Hello,
On 9/12/19 8:35 AM, Ezequiel Garcia wrote:
> On Thu, 2019-09-12 at 14:52 +0900, Tomasz Figa wrote:
>> On Thu, Sep 12, 2019 at 4:49 AM Nicolas Dufresne
>> wrote:
>>> Le mercredi 11 septembre 2019 à 09:27 +0100, Ezequiel Garcia a écrit :
On Mon, 2019-09-09 at 16:07 +0900, Tomasz Figa w
;>>> Attendees for this session:
>>>>>>
>>>>>> Kieran Bingham
>>>>
>>>> Unfortunately I can no longer attend ELCE.
>>>>
>>>> (My second baby will be a bit too new for an extended stay away from home)
>>>
--help-all option was not displaying options from --help-subdev.
Add missing subdev_usage() in usage_all() to fix it.
Signed-off-by: Helen Koike
---
utils/v4l2-ctl/v4l2-ctl.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/utils/v4l2-ctl/v4l2-ctl.cpp b/utils/v4l2-ctl/v4l2-ctl.cpp
index
+Hans +Shuah
Hi Guilherme and Danilo,
Thank you for the patch, please see my comments below.
On 9/9/19 1:08 AM, Guilherme Alcarde Gallo wrote:
> Add support for the scaler subdevice to respond VIDIOC_G_SELECTION and
> VIDIOC_S_SELECTION ioctls with the following targets:
> V4L2_SEL_TGT_COMPOSE_B
8:30 (tentative, might change) to 12:00 (we have to vacate the room at that
>> time).
>>
>> Confirmed attendees for this session:
>>
>> Boris Brezillon
>> Alexandre Courbot
>> Nicolas Dufresne
>> Tomasz Figa
>> Ezequiel Garcia
>> Daniel G
Hi Dafna,
On 10/1/19 1:50 PM, Dafna Hirschfeld wrote:
> since NULL value for vimc entity pointer indicates
> that entity creation failed and this is tested, the
> pointers should be initialized to NULL.
Nice catch :)
>
> Signed-off-by: Dafna Hirschfeld
> ---
> drivers/media/platform/vimc/vimc
tration also frees vsen.
>
> Signed-off-by: Dafna Hirschfeld
Acked-by: Helen Koike
> ---
> drivers/media/platform/vimc/vimc-sensor.c | 20 ++--
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/media/platform/vimc/vimc-sensor.c
>
Hi Dafna,
Thanks for your patch
On 10/1/19 1:50 PM, Dafna Hirschfeld wrote:
> according to the docs, this function must be called during
> the cleanup phase after unregistering the entity.
>
> Signed-off-by: Dafna Hirschfeld
Acked-by: Helen Koike
I just have on
On 10/1/19 2:25 PM, Andrzej Pietrasiewicz wrote:
> Hi Dafna, hi Helen,
>
> W dniu 01.10.2019 o 19:19, Helen Koike pisze:
>> Hi Dafna,
>>
>> On 10/1/19 1:50 PM, Dafna Hirschfeld wrote:
>>> since NULL value for vimc entity pointer indicates
>>> that e
Hi Dafna,
Thanks for your patch, just some comments below.
On 10/1/19 2:07 PM, Dafna Hirschfeld wrote:
> since the pads array is of known small size, there is no reason to
> allocate it separately. Instead, it is embedded in the entity struct.
> This also conforms to the media controller doc:
> '
On 10/3/19 7:44 AM, Dafna Hirschfeld wrote:
> since NULL value for vimc entity pointer indicates
> that entity creation failed and this is tested, the
> pointers should be initialized to NULL.
>
> Signed-off-by: Dafna Hirschfeld
Acked-by: Helen Koike
> ---
> driver
ng like:
"media: vimc: remove unnecessary var when adding entities"
It makes clear what you are doing and where, what do you think?
With this:
Acked-by: Helen Koike
> ---
> drivers/media/platform/vimc/vimc-core.c | 6 ++
> 1 file changed, 2 insertions(+), 4 deletions(
unregisters the subdevice
> and then frees vsen, this cause double free since the release
> callback that follows subdevice unregistration also frees vsen.
>
> Signed-off-by: Dafna Hirschfeld
> Acked-by: Helen Koike
> ---
> drivers/media/platform/vimc/vimc-sensor.c | 20 +
On 10/3/19 7:44 AM, Dafna Hirschfeld wrote:
> since this function only calls v4l2_device_unregister_subdev,
> it is pointless.
>
> Signed-off-by: Dafna Hirschfeld
Acked-by: Helen Koike
> ---
> drivers/media/platform/vimc/vimc-common.c | 5 -
> drivers/med
; Signed-off-by: Wei Yongjun
Acked-by: Helen Koike
Thank you
Helen
> ---
> drivers/media/platform/vimc/vimc-core.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/vimc/vimc-core.c
> b/drivers/media/platform/vimc/vimc-co
t;> The second session deals with libcamera and is on Wednesday morning
>> from 9:00 to 13:00.
>>
>> Attendees for this session:
>>
>> Nicolas Dufresne
>> Tomasz Figa
>> Ezequiel Garcia
>> Dafna Hirschfeld
>
> I beliebe Dafna and I s
Hi Shuah,
On 7/2/19 10:44 PM, shuah wrote:
> On 5/23/19 9:07 AM, shuah wrote:
>> Hi Hans and Helen,
>>
>> vimc streaming fails on Linux 5.2-rc1
>>
>> vimc: format doesn't match in link Scaler->RGB/YUV Capture
>>
>> You can reproduce this easily with v4l2-ctl
>>
>> Streaming works fine on Linux 5.1
Hi Niklas,
Thanks for the patch (and sorry for my late reply).
On 5/17/19 10:07 PM, Niklas Söderlund wrote:
> A sensor which is running is already part of a pipeline and trying to
> start a new pipeline is not possible. This prevents two capture devices
> connected to the same sensor from running
On 7/25/19 3:41 PM, Mauro Carvalho Chehab wrote:
> Em Fri, 26 Jul 2019 01:29:58 +0800
> Chen-Yu Tsai escreveu:
>
>> On Fri, Jul 26, 2019 at 1:06 AM Ezequiel Garcia
>> wrote:
>>>
>>> On Thu, 2019-07-25 at 12:57 -0300, Mauro Carvalho Chehab wrote:
Em Mon, 15 Jul 2019 18:23:16 -0300
Hi Dafna,
Thanks for the patch. Just small comments below.
On 8/29/19 8:00 AM, Dafna Hirschfeld wrote:
> Userspace can disable links and create pipelines that
> do not start with a source entity. Trying to stream
> from such a pipeline should fail with -EPIPE
> currently this is not handled and c
Hi Hans,
Thank you for your review. I just have a question for this one.
On 2017-05-08 08:53 AM, Hans Verkuil wrote:
On 04/08/2017 12:37 AM, Helen Koike wrote:
Allow user space to change the image format as the frame size, the
pixel format, colorspace, quantization, field YCbCr encoding
and
colorspace, ycbcr_enc, quantization and xfer_func must match across the
link.
Check if they match in v4l2_subdev_link_validate_default unless they are
set as _DEFAULT.
Signed-off-by: Helen Koike
---
Hi,
I think we should validate colorimetry as having different colorimetry
across a link
All links will be checked in the same way. Adding a helper function for
that
Signed-off-by: Helen Koike
---
Changes in v3:
[media] vimc: common: Add vimc_link_validate
- this is a new patch in the series
Changes in v2: None
---
drivers/media/platform/vimc/vimc-capture.c | 78
default parameters for quantization, colorspace ...
- add more dev_dbg
Helen Koike (11):
[media] vimc: sen: Integrate the tpg on the sensor
[media] vimc: Move common code from the core
[media] vimc: common: Add vimc_ent_sd_* helper
[media] vimc: common: Add vimc_pipeline_s_stream helper
Implement scaler and integrated with the core
Signed-off-by: Helen Koike
---
Changes in v3:
[media] vimc: sca: Add scaler
- Declare frame_size as a local variable
- s_stream(sd, 1): return 0 if stream is already enabled
- s_stream(sd, 0): return 0 if stream is already
Implement the debayer filter and integrate it with the core
Signed-off-by: Helen Koike
---
Changes in v3:
[media] vimc: deb: Add debayer filter
- Declare frame_size as a local variable
- s_stream(sd, 1): return 0 if stream is already enabled
- s_stream(sd, 0): return 0
_device in the system.
It also facilitates other implementations of different nodes without
touching the core code and remove the need of a header file for each
type of node.
Signed-off-by: Helen Koike
---
Changes in v3:
[media] vimc: Subdevices as modules
- This is a new patch in the serie
the capture node, thus saving intermediate memory buffers
and process time, allowing a higher frame rate.
Signed-off-by: Helen Koike
---
Changes in v3:
[media] vimc: Optimize frame generation through the pipe
- This is a new patch in the series
Changes in v2: None
---
drivers/media
Allow user space to change the image format as the frame size, the
media bus pixel format, colorspace, quantization, field YCbCr encoding
and the transfer function
Signed-off-by: Helen Koike
---
Changes in v3:
[media] vimc: sen: Support several image formats
- remove support for
Allow user space to change the image format as the frame size, the
pixel format, colorspace, quantization, field YCbCr encoding
and the transfer function
Signed-off-by: Helen Koike
---
Changes in v3:
[media] vimc: cap: Support several image formats
- use *_DEFAULT macros for
Remove helper functions from vimc-core and add it in vimc-common to
clean up the core.
Signed-off-by: Helen Koike
---
Changes in v3:
[media] vimc: Move common code from the core
- This is a new patch in the series
Changes in v2: None
---
drivers/media/platform/vimc/Makefile
Initialize the test pattern generator on the sensor
Generate a colored bar image instead of a grey one
Signed-off-by: Helen Koike
---
Changes in v3:
[media] vimc: sen: Integrate the tpg on the sensor
- Declare frame_size as a local variable
- Set tpg frame format before
Move the vimc_cap_pipeline_s_stream from the vimc-cap.c to vimc-common.c
as this core will be reused by other subdevices to activate the stream
in their directly connected nodes
Signed-off-by: Helen Koike
---
Changes in v3:
[media] vimc: Add vimc_pipeline_s_stream in the core
- add it
As all the subdevices in the topology will be initialized in the same
way, to avoid code repetition the vimc_ent_sd_{register, unregister}
helper functions were created
Signed-off-by: Helen Koike
---
Changes in v3:
[media] vimc: Add vimc_ent_sd_* helper functions
- add it in vimc
ping
On 2017-04-10 07:53 PM, Helen Koike wrote:
Hi,
Continuing the discussion about the API of the vimc driver, I made some
changes
based on the previous comments, please see below and let me know your
opinion about it.
Helen
/***
Configfs considerations
I forgot to mention that this patch series is also available here
https://github.com/helen-fornazier/opw-staging/tree/z/sent/vimc/vpu/v3
On 2017-06-02 11:58 PM, Helen Koike wrote:
This patch series improves the current video processing units in vimc
(by adding more controls to the sensor and
On 2017-06-02 11:58 PM, Helen Koike wrote:
Add a parameter called vsen_tpg, if true then vimc will work as before:
frames will be generated in the sensor nodes then propagated through the
pipe and processed by each node until a capture node is reached.
If vsen_tpg is false, then the frame is
Hi All,
Just reviving this discussion
On 2017-04-07 06:53 AM, Laurent Pinchart wrote:
Hi Hans,
On Friday 07 Apr 2017 11:46:48 Hans Verkuil wrote:
On 04/04/2017 03:22 PM, Sakari Ailus wrote:
On Mon, Apr 03, 2017 at 12:11:54PM -0300, Helen Koike wrote:
On 2017-03-31 06:57 AM, Mauro Carvalho
Hi Sakari,
Thanks for replying
On 2017-05-31 03:31 AM, Sakari Ailus wrote:
Hi Helen,
On Tue, May 30, 2017 at 04:08:08PM -0300, Helen Koike wrote:
colorspace, ycbcr_enc, quantization and xfer_func must match across the
link.
Check if they match in v4l2_subdev_link_validate_default unless
Hi
On 2017-06-08 08:41 AM, Mauro Carvalho Chehab wrote:
Em Tue, 6 Jun 2017 19:15:34 -0300
Helen Koike escreveu:
Hi Sakari,
Thanks for replying
On 2017-05-31 03:31 AM, Sakari Ailus wrote:
Hi Helen,
On Tue, May 30, 2017 at 04:08:08PM -0300, Helen Koike wrote:
colorspace, ycbcr_enc
colorspace, ycbcr_enc, quantization and xfer_func must match
across the link.
Check if they match in v4l2_subdev_link_validate_default
unless they are set as _DEFAULT.
Signed-off-by: Helen Koike
---
Hi,
As discussed previously, I added a warn message instead of returning
error to give drivers
Hi Hans,
Thanks for your review, just a question below
On 2017-06-12 06:50 AM, Hans Verkuil wrote:
On 06/03/2017 04:58 AM, Helen Koike wrote:
All links will be checked in the same way. Adding a helper function for
that
Signed-off-by: Helen Koike
---
Changes in v3:
[media] vimc: common
Hi Hans,
Thank you for your review
On 2017-06-12 07:03 AM, Hans Verkuil wrote:
On 06/03/2017 04:58 AM, Helen Koike wrote:
Add a parameter called vsen_tpg, if true then vimc will work as before:
frames will be generated in the sensor nodes then propagated through the
pipe and processed by each
Hi Hans,
Thank you for your review. Please check my comments below
On 2017-06-12 07:37 AM, Hans Verkuil wrote:
On 06/03/2017 04:58 AM, Helen Koike wrote:
Change the core structure for adding subdevices in the topology.
Instead of calling the specific create function for each subdevice,
inject
Hi Hans,
On 2017-06-13 03:49 AM, Hans Verkuil wrote:
On 06/12/2017 10:35 PM, Helen Koike wrote:
Hi Hans,
Thank you for your review. Please check my comments below
On 2017-06-12 07:37 AM, Hans Verkuil wrote:
On 06/03/2017 04:58 AM, Helen Koike wrote:
+static struct component_match
- remove vsd struct
- add IS_SRC and IS_SINK macros
- add sca_mult as a parameter of the module
- check set_fmt default parameters for quantization, colorspace ...
- add more dev_dbg
Helen Koike (11):
[media] vimc: sen: Integrate the tpg on the sensor
[m
Allow user space to change the image format as the frame size, the
media bus pixel format, colorspace, quantization, field YCbCr encoding
and the transfer function
Signed-off-by: Helen Koike
---
Changes in v4:
[media] vimc: sen: Support several image formats
- use
_device in the system.
It also facilitates other implementations of different nodes without
touching the core code and remove the need of a header file for each
type of node.
Signed-off-by: Helen Koike
---
Changes in v4:
[media] vimc: Subdevices as modules
- Rebase without [media] vimc
Allow user space to change the image format as the frame size, the
pixel format, colorspace, quantization, field YCbCr encoding
and the transfer function
Signed-off-by: Helen Koike
---
Changes in v4:
[media] vimc: cap: Support several image formats
- add vimc_colorimetry_clamp macro
Colorimetry value will always be checked in the same way. Adding a
helper macro for that
Signed-off-by: Helen Koike
---
Changes in v4:
[media] vimc: common: Add vimc_colorimetry_clamp
- this is a new patch in the series
Changes in v3: None
Changes in v2: None
---
drivers/media
Implement the debayer filter and integrate it with the core
Signed-off-by: Helen Koike
---
Changes in v4:
[media] vimc: deb: Add debayer filter
- Rebase without [media] vimc: Optimize frame generation through
pipe
- use vimc_colorimetry_clamp
- replace
Implement scaler and integrated with the core
Signed-off-by: Helen Koike
---
Changes in v4:
[media] vimc: sca: Add scaler
- use vimc_colorimetry_clamp
- replace V4L2_COLORSPACE_SRGB by V4L2_COLORSPACE_DEFAULT in the
default format struct
- use struct
All links will be checked in the same way. Adding a helper function for
that
Signed-off-by: Helen Koike
---
Changes in v4:
[media] vimc: common: Add vimc_link_validate
- remove vimc_fmt_pix_to_mbus(), replaced by
v4l2_fill_mbus_format()
- remove EXPORT_SYMBOL
As all the subdevices in the topology will be initialized in the same
way, to avoid code repetition the vimc_ent_sd_{register, unregister}
helper functions were created
Signed-off-by: Helen Koike
---
Changes in v4: None
Changes in v3:
[media] vimc: common: Add vimc_ent_sd_* helper
Move the vimc_cap_pipeline_s_stream from the vimc-cap.c to vimc-common.c
as this core will be reused by other subdevices to activate the stream
in their directly connected nodes
Signed-off-by: Helen Koike
---
Changes in v4: None
Changes in v3:
[media] vimc: Add vimc_pipeline_s_stream in the
Initialize the test pattern generator on the sensor
Generate a colored bar image instead of a grey one
Signed-off-by: Helen Koike
---
Changes in v4: None
Changes in v3:
[media] vimc: sen: Integrate the tpg on the sensor
- Declare frame_size as a local variable
- Set tpg frame
Remove helper functions from vimc-core and add it in vimc-common to
clean up the core.
Signed-off-by: Helen Koike
---
Changes in v4: None
Changes in v3:
[media] vimc: Move common code from the core
- This is a new patch in the series
Changes in v2: None
---
drivers/media/platform
-by: Helen Koike
---
Changes in v2::
- replace the type by capability
- erase V4L2_INPUT_TYPE_DEFAULT
- also consider output
- plug helpers in the ops automatically so drivers doesn't need
to set it by hand
- update docs
- commit messag
return EBUSY when trying to set the format while stream is on
- remove vsd struct
- add IS_SRC and IS_SINK macros
- add sca_mult as a parameter of the module
- check set_fmt default parameters for quantization, colorspace ...
- add more dev_dbg
Helen Ko
As all the subdevices in the topology will be initialized in the same
way, to avoid code repetition the vimc_ent_sd_{register, unregister}
helper functions were created
Signed-off-by: Helen Koike
---
Changes in v5: None
Changes in v4: None
Changes in v3:
[media] vimc: common: Add vimc_ent_sd_
Declare vimc_sen_video_ops as static, remove warning from sparse tool
Signed-off-by: Helen Koike
---
Changes in v5:
[media] vimc: sen: Declare vimc_sen_video_ops as static
- This is a new patch in the series
Changes in v4: None
Changes in v3: None
Changes in v2: None
---
drivers
Implement scaler and integrated with the core
Signed-off-by: Helen Koike
---
Changes in v5:
[media] vimc: sca: Add scaler
- declare vimc_sca_video_ops as static, remove sparse warning
Changes in v4:
[media] vimc: sca: Add scaler
- use vimc_colorimetry_clamp
- replace
Implement the debayer filter and integrate it with the core
Signed-off-by: Helen Koike
---
Changes in v5:
[media] vimc: deb: Add debayer filter
- delare vimc_deb_video_ops as static, remove sparse warning
Changes in v4:
[media] vimc: deb: Add debayer filter
- Rebase without
_device in the system.
It also facilitates other implementations of different nodes without
touching the core code and remove the need of a header file for each
type of node.
Signed-off-by: Helen Koike
---
Changes in v5:
[media] vimc: Subdevices as modules
- Fix vimc_add_subdevs in rollback
All links will be checked in the same way. Adding a helper function for
that
Signed-off-by: Helen Koike
---
Changes in v5: None
Changes in v4:
[media] vimc: common: Add vimc_link_validate
- remove vimc_fmt_pix_to_mbus(), replaced by
v4l2_fill_mbus_format()
- remove
Remove helper functions from vimc-core and add it in vimc-common to
clean up the core.
Signed-off-by: Helen Koike
---
Changes in v5: None
Changes in v4: None
Changes in v3:
[media] vimc: Move common code from the core
- This is a new patch in the series
Changes in v2: None
Allow user space to change the image format as the frame size, the
pixel format, colorspace, quantization, field YCbCr encoding
and the transfer function
Signed-off-by: Helen Koike
---
Changes in v5: None
Changes in v4:
[media] vimc: cap: Support several image formats
- add
Initialize the test pattern generator on the sensor
Generate a colored bar image instead of a grey one
Signed-off-by: Helen Koike
---
Changes in v5: None
Changes in v4: None
Changes in v3:
[media] vimc: sen: Integrate the tpg on the sensor
- Declare frame_size as a local variable
Colorimetry value will always be checked in the same way. Adding a
helper macro for that
Signed-off-by: Helen Koike
---
Changes in v5: None
Changes in v4:
[media] vimc: common: Add vimc_colorimetry_clamp
- this is a new patch in the series
Changes in v3: None
Changes in v2: None
Allow user space to change the image format as the frame size, the
media bus pixel format, colorspace, quantization, field YCbCr encoding
and the transfer function
Signed-off-by: Helen Koike
---
Changes in v5: None
Changes in v4:
[media] vimc: sen: Support several image formats
- use
Move the vimc_cap_pipeline_s_stream from the vimc-cap.c to vimc-common.c
as this core will be reused by other subdevices to activate the stream
in their directly connected nodes
Signed-off-by: Helen Koike
---
Changes in v5: None
Changes in v4: None
Changes in v3:
[media] vimc: Add
Hi Hans,
Thanks for reviewing this
On 2017-06-19 08:15 AM, Hans Verkuil wrote:
On 06/14/2017 06:50 AM, Helen Koike wrote:
Add V4L2_CAP_IO_MC to be used in struct v4l2_capability to indicate that
input and output are controlled by the Media Controller instead of V4L2
API.
When this flag is set
ms good to me.
Reviewed-by: Helen Koike
---
drivers/media/platform/vimc/vimc-capture.c | 15 ---
drivers/media/platform/vimc/vimc-debayer.c | 15 ---
drivers/media/platform/vimc/vimc-scaler.c | 15 ---
drivers/media/platform/vimc/vimc-sens
Hi Laurent,
On 2017-01-10 04:54 PM, Laurent Pinchart wrote:
Hi Helen,
(CC'ing Sakari as there's a question specifically for him)
Thank you for the patch, and so sorry for the late review.
On Sunday 04 Sep 2016 17:02:18 Helen Koike wrote:
From: Helen Fornazier
First version of t
Hi
On 01/04/2016 15:22, Mauro Carvalho Chehab wrote:
Hi Helen,
This is just a quick look on it. See below.
Em Fri, 1 Apr 2016 14:18:13 -0300
Helen Mae Koike Fornazier escreveu:
The test pattern generator will be used by other drivers as the virtual
media controller (vimc)
Signed-off-by: He
Hi Hans,
On 2017-03-10 10:08 AM, Hans Verkuil wrote:
Hi Helen,
On 11/01/17 02:30, Helen Koike wrote:
>
> Thank you for the review, I'll update the patch accordingly and re-submit it.
>
> Helen
Do you know when you have a v7 ready?
Thanks for your interest. I don't
Hi Sakari,
Thanks for your review, I have some questions below:
On 2017-01-25 11:03 AM, Sakari Ailus wrote:
Hi Helen,
My apologies for the long review time!
Please see my comments below.
On Sun, Sep 04, 2016 at 05:02:18PM -0300, Helen Koike wrote:
From: Helen Fornazier
First version of
First version of the Virtual Media Controller.
Add a simple version of the core of the driver, the capture and
sensor nodes in the topology, generating a grey image in a hardcoded
format.
Signed-off-by: Helen Koike
---
Patch based in media/master tree, and available here:
https://github.com
On 2017-03-25 02:11 PM, Helen Koike wrote:
First version of the Virtual Media Controller.
Add a simple version of the core of the driver, the capture and
sensor nodes in the topology, generating a grey image in a hardcoded
format.
Signed-off-by: Helen Koike
---
Patch based in media/master
First version of the Virtual Media Controller.
Add a simple version of the core of the driver, the capture and
sensor nodes in the topology, generating a grey image in a hardcoded
format.
Signed-off-by: Helen Koike
---
Patch based in media/master tree, and available here:
https://github.com
Hi Sakari,
On 2017-03-26 10:31 AM, Sakari Ailus wrote:
Hi Helen,
...
+static int vimc_cap_enum_input(struct file *file, void *priv,
+ struct v4l2_input *i)
+{
+ /* We only have one input */
+ if (i->index > 0)
+ return -EINVAL;
+
+ i
Add V4L2_INPUT_TYPE_DEFAULT and helpers functions for input ioctls to be
used when no inputs are available in the device
Signed-off-by: Helen Koike
---
drivers/media/v4l2-core/v4l2-ioctl.c | 27 +++
include/media/v4l2-ioctl.h | 26
add documentation for V4L2_INPUT_TYPE_DEFAULT
Signed-off-by: Helen Koike
---
Documentation/media/uapi/v4l/vidioc-enuminput.rst | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/media/uapi/v4l/vidioc-enuminput.rst
b/Documentation/media/uapi/v4l/vidioc-enuminput.rst
index
Hi Laurent,
Thanks for reviewing
On 2017-03-30 04:56 PM, Laurent Pinchart wrote:
Hi Helen,
Thank you for the patch.
On Thursday 30 Mar 2017 13:02:17 Helen Koike wrote:
Add V4L2_INPUT_TYPE_DEFAULT and helpers functions for input ioctls to be
used when no inputs are available in the device
On 2017-03-30 11:39 PM, Helen Koike wrote:
Hi Laurent,
Thanks for reviewing
On 2017-03-30 04:56 PM, Laurent Pinchart wrote:
Hi Helen,
Thank you for the patch.
On Thursday 30 Mar 2017 13:02:17 Helen Koike wrote:
Add V4L2_INPUT_TYPE_DEFAULT and helpers functions for input ioctls to be
used
Hi,
On 2017-03-31 06:57 AM, Mauro Carvalho Chehab wrote:
Em Fri, 31 Mar 2017 10:29:04 +0200
Hans Verkuil escreveu:
On 30/03/17 18:02, Helen Koike wrote:
Add V4L2_INPUT_TYPE_DEFAULT and helpers functions for input ioctls to be
used when no inputs are available in the device
Signed-off-by
First version of the Virtual Media Controller.
Add a simple version of the core of the driver, the capture and
sensor nodes in the topology, generating a grey image in a hardcoded
format.
Signed-off-by: Helen Koike
---
Patch based in media/master tree, and available here:
https://github.com
Hi,
There are two points below that I'll change in v10. I'll wait for your
comments in the rest of the code so I can send all the requested changes
in v10
On 2017-04-03 07:16 PM, Helen Koike wrote:
First version of the Virtual Media Controller.
Add a simple version of the core of
Fix kernel Oops NULL pointer deference
Call dev_dbg_obj only after checking if gobj->mdev is not NULL
Signed-off-by: Helen Koike
---
drivers/media/media-entity.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/media-entity.c b/drivers/media/media-entit
Fix kernel Oops NULL pointer deference
Call dev_dbg_obj only after checking if gobj->mdev is not NULL
Signed-off-by: Helen Koike
---
drivers/media/media-entity.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/media-entity.c b/drivers/media/media-entit
Hi Sakari,
On 2017-04-07 04:40 AM, Sakari Ailus wrote:
Hi Helen,
On Thu, Apr 06, 2017 at 04:32:00PM -0300, Helen Koike wrote:
Fix kernel Oops NULL pointer deference
Call dev_dbg_obj only after checking if gobj->mdev is not NULL
Signed-off-by: Helen Koike
---
drivers/media/media-entit
First version of the Virtual Media Controller.
Add a simple version of the core of the driver, the capture and
sensor nodes in the topology, generating a grey image in a hardcoded
format.
Signed-off-by: Helen Koike
Reviewed-by: Hans Verkuil
---
Patch based in media/master tree, and available
Move the vimc_cap_pipeline_s_stream from the vimc-cap.c to vimc-core.c
as this core will be reused by other subdevices to activate the stream
in their directly connected nodes
Signed-off-by: Helen Koike
---
Changes in v2:
[media] vimc: Add vimc_pipeline_s_stream in the core
- Use
Initialize the test pattern generator on the sensor
Generate a colored bar image instead of a grey one
Signed-off-by: Helen Koike
---
Changes in v2:
[media] vimc: sen: Integrate the tpg on the sensor
- Fix include location
- Select V4L2_TPG in Kconfig
- configure tpg on
Allow user space to change the image format as the frame size, the
media bus pixel format, colorspace, quantization, field YCbCr encoding
and the transfer function
Signed-off-by: Helen Koike
---
Changes in v2:
[media] vimc: sen: Support several image formats
- this is a new commit in
As all the subdevices in the topology will be initialized in the same
way, to avoid code repetition the vimc_ent_sd_{register, unregister}
helper functions were created
Signed-off-by: Helen Koike
---
Changes in v2:
[media] vimc: Add vimc_ent_sd_* helper functions
- Comments in
heck pad types on create
- return EBUSY when trying to set the format while stream is on
- remove vsd struct
- add IS_SRC and IS_SINK macros
- add sca_mult as a parameter of the module
- check set_fmt default parameters for quantization, colorspace ...
- add more
Implement scaler and integrated with the core
Signed-off-by: Helen Koike
---
Changes in v2:
[media] vimc: sca: Add scaler
- Add function MEDIA_ENT_F_IO_V4L
- remove v4l2_dev and dev
- s/sink_mbus_fmt/sink_fmt
- remove BUG_ON, remove redundant if else, rewrite
Implement the debayer filter and integrate it with the core
Signed-off-by: Helen Koike
---
Changes in v2:
[media] vimc: deb: Add debayer filter
- Using MEDIA_ENT_F_ATV_DECODER in function
- remove v4l2_dev and dev from vimc_deb_device struct
- src fmt propagates from
Allow user space to change the image format as the frame size, the
pixel format, colorspace, quantization, field YCbCr encoding
and the transfer function
Signed-off-by: Helen Koike
---
Changes in v2:
[media] vimc: cap: Support several image formats
- this is a new commit in the serie
1 - 100 of 168 matches
Mail list logo
