Implement the debayer filter and integrate it with the core
Signed-off-by: Helen Koike
---
Changes in v5:
[media] vimc: deb: Add debayer filter
- delare vimc_deb_video_ops as static, remove sparse warning
Changes in v4:
[media] vimc: deb: Add debayer filter
- Rebase without
_device in the system.
It also facilitates other implementations of different nodes without
touching the core code and remove the need of a header file for each
type of node.
Signed-off-by: Helen Koike
---
Changes in v5:
[media] vimc: Subdevices as modules
- Fix vimc_add_subdevs in rollback
All links will be checked in the same way. Adding a helper function for
that
Signed-off-by: Helen Koike
---
Changes in v5: None
Changes in v4:
[media] vimc: common: Add vimc_link_validate
- remove vimc_fmt_pix_to_mbus(), replaced by
v4l2_fill_mbus_format()
- remove
Remove helper functions from vimc-core and add it in vimc-common to
clean up the core.
Signed-off-by: Helen Koike
---
Changes in v5: None
Changes in v4: None
Changes in v3:
[media] vimc: Move common code from the core
- This is a new patch in the series
Changes in v2: None
Allow user space to change the image format as the frame size, the
pixel format, colorspace, quantization, field YCbCr encoding
and the transfer function
Signed-off-by: Helen Koike
---
Changes in v5: None
Changes in v4:
[media] vimc: cap: Support several image formats
- add
Initialize the test pattern generator on the sensor
Generate a colored bar image instead of a grey one
Signed-off-by: Helen Koike
---
Changes in v5: None
Changes in v4: None
Changes in v3:
[media] vimc: sen: Integrate the tpg on the sensor
- Declare frame_size as a local variable
Colorimetry value will always be checked in the same way. Adding a
helper macro for that
Signed-off-by: Helen Koike
---
Changes in v5: None
Changes in v4:
[media] vimc: common: Add vimc_colorimetry_clamp
- this is a new patch in the series
Changes in v3: None
Changes in v2: None
Allow user space to change the image format as the frame size, the
media bus pixel format, colorspace, quantization, field YCbCr encoding
and the transfer function
Signed-off-by: Helen Koike
---
Changes in v5: None
Changes in v4:
[media] vimc: sen: Support several image formats
- use
Move the vimc_cap_pipeline_s_stream from the vimc-cap.c to vimc-common.c
as this core will be reused by other subdevices to activate the stream
in their directly connected nodes
Signed-off-by: Helen Koike
---
Changes in v5: None
Changes in v4: None
Changes in v3:
[media] vimc: Add
Hi Hans,
Thanks for reviewing this
On 2017-06-19 08:15 AM, Hans Verkuil wrote:
On 06/14/2017 06:50 AM, Helen Koike wrote:
Add V4L2_CAP_IO_MC to be used in struct v4l2_capability to indicate that
input and output are controlled by the Media Controller instead of V4L2
API.
When this flag is set
ms good to me.
Reviewed-by: Helen Koike
---
drivers/media/platform/vimc/vimc-capture.c | 15 ---
drivers/media/platform/vimc/vimc-debayer.c | 15 ---
drivers/media/platform/vimc/vimc-scaler.c | 15 ---
drivers/media/platform/vimc/vimc-sens
Hi Hans,
Thanks for the patch
On 02/02/2018 11:00 AM, Hans Verkuil wrote:
The sensor subdev didn't handle control events. Add support for this.
Found with v4l2-compliance.
Signed-off-by: Hans Verkuil
Acked-by: Helen Koike
---
diff --git a/drivers/media/platform/vimc/vimc-common
ons are also called directly from
drivers, so I don't want to change the error code there.
Right, I see, thanks for the patch
Found with vimc and v4l2-compliance.
Signed-off-by: Hans Verkuil
Acked-by: Helen Koike
---
diff --git a/drivers/media/v4l2-core/v4l2-subdev.c
b/drivers/media/v
Hi Hans,
On 02/07/2018 03:06 PM, Hans Verkuil wrote:
Instead of calling everything a MEDIA_ENT_F_ATV_DECODER, pick the
correct functions for these blocks.
Nice, thanks for the patch
Signed-off-by: Hans Verkuil
Acked-by: Helen Koike
---
diff --git a/drivers/media/platform/vimc/vimc
Hi Laurent,
On 2017-01-10 04:54 PM, Laurent Pinchart wrote:
Hi Helen,
(CC'ing Sakari as there's a question specifically for him)
Thank you for the patch, and so sorry for the late review.
On Sunday 04 Sep 2016 17:02:18 Helen Koike wrote:
From: Helen Fornazier
First version of t
Hi Hans,
On 2017-03-10 10:08 AM, Hans Verkuil wrote:
Hi Helen,
On 11/01/17 02:30, Helen Koike wrote:
>
> Thank you for the review, I'll update the patch accordingly and re-submit it.
>
> Helen
Do you know when you have a v7 ready?
Thanks for your interest. I don't
Hi Sakari,
Thanks for your review, I have some questions below:
On 2017-01-25 11:03 AM, Sakari Ailus wrote:
Hi Helen,
My apologies for the long review time!
Please see my comments below.
On Sun, Sep 04, 2016 at 05:02:18PM -0300, Helen Koike wrote:
From: Helen Fornazier
First version of
First version of the Virtual Media Controller.
Add a simple version of the core of the driver, the capture and
sensor nodes in the topology, generating a grey image in a hardcoded
format.
Signed-off-by: Helen Koike
---
Patch based in media/master tree, and available here:
https://github.com
On 2017-03-25 02:11 PM, Helen Koike wrote:
First version of the Virtual Media Controller.
Add a simple version of the core of the driver, the capture and
sensor nodes in the topology, generating a grey image in a hardcoded
format.
Signed-off-by: Helen Koike
---
Patch based in media/master
First version of the Virtual Media Controller.
Add a simple version of the core of the driver, the capture and
sensor nodes in the topology, generating a grey image in a hardcoded
format.
Signed-off-by: Helen Koike
---
Patch based in media/master tree, and available here:
https://github.com
Hi Sakari,
On 2017-03-26 10:31 AM, Sakari Ailus wrote:
Hi Helen,
...
+static int vimc_cap_enum_input(struct file *file, void *priv,
+ struct v4l2_input *i)
+{
+ /* We only have one input */
+ if (i->index > 0)
+ return -EINVAL;
+
+ i
Add V4L2_INPUT_TYPE_DEFAULT and helpers functions for input ioctls to be
used when no inputs are available in the device
Signed-off-by: Helen Koike
---
drivers/media/v4l2-core/v4l2-ioctl.c | 27 +++
include/media/v4l2-ioctl.h | 26
add documentation for V4L2_INPUT_TYPE_DEFAULT
Signed-off-by: Helen Koike
---
Documentation/media/uapi/v4l/vidioc-enuminput.rst | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/media/uapi/v4l/vidioc-enuminput.rst
b/Documentation/media/uapi/v4l/vidioc-enuminput.rst
index
Hi Laurent,
Thanks for reviewing
On 2017-03-30 04:56 PM, Laurent Pinchart wrote:
Hi Helen,
Thank you for the patch.
On Thursday 30 Mar 2017 13:02:17 Helen Koike wrote:
Add V4L2_INPUT_TYPE_DEFAULT and helpers functions for input ioctls to be
used when no inputs are available in the device
On 2017-03-30 11:39 PM, Helen Koike wrote:
Hi Laurent,
Thanks for reviewing
On 2017-03-30 04:56 PM, Laurent Pinchart wrote:
Hi Helen,
Thank you for the patch.
On Thursday 30 Mar 2017 13:02:17 Helen Koike wrote:
Add V4L2_INPUT_TYPE_DEFAULT and helpers functions for input ioctls to be
used
Hi,
On 2017-03-31 06:57 AM, Mauro Carvalho Chehab wrote:
Em Fri, 31 Mar 2017 10:29:04 +0200
Hans Verkuil escreveu:
On 30/03/17 18:02, Helen Koike wrote:
Add V4L2_INPUT_TYPE_DEFAULT and helpers functions for input ioctls to be
used when no inputs are available in the device
Signed-off-by
First version of the Virtual Media Controller.
Add a simple version of the core of the driver, the capture and
sensor nodes in the topology, generating a grey image in a hardcoded
format.
Signed-off-by: Helen Koike
---
Patch based in media/master tree, and available here:
https://github.com
Hi,
There are two points below that I'll change in v10. I'll wait for your
comments in the rest of the code so I can send all the requested changes
in v10
On 2017-04-03 07:16 PM, Helen Koike wrote:
First version of the Virtual Media Controller.
Add a simple version of the core of
Fix kernel Oops NULL pointer deference
Call dev_dbg_obj only after checking if gobj->mdev is not NULL
Signed-off-by: Helen Koike
---
drivers/media/media-entity.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/media-entity.c b/drivers/media/media-entit
Fix kernel Oops NULL pointer deference
Call dev_dbg_obj only after checking if gobj->mdev is not NULL
Signed-off-by: Helen Koike
---
drivers/media/media-entity.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/media-entity.c b/drivers/media/media-entit
Hi Sakari,
On 2017-04-07 04:40 AM, Sakari Ailus wrote:
Hi Helen,
On Thu, Apr 06, 2017 at 04:32:00PM -0300, Helen Koike wrote:
Fix kernel Oops NULL pointer deference
Call dev_dbg_obj only after checking if gobj->mdev is not NULL
Signed-off-by: Helen Koike
---
drivers/media/media-entit
First version of the Virtual Media Controller.
Add a simple version of the core of the driver, the capture and
sensor nodes in the topology, generating a grey image in a hardcoded
format.
Signed-off-by: Helen Koike
Reviewed-by: Hans Verkuil
---
Patch based in media/master tree, and available
Move the vimc_cap_pipeline_s_stream from the vimc-cap.c to vimc-core.c
as this core will be reused by other subdevices to activate the stream
in their directly connected nodes
Signed-off-by: Helen Koike
---
Changes in v2:
[media] vimc: Add vimc_pipeline_s_stream in the core
- Use
Initialize the test pattern generator on the sensor
Generate a colored bar image instead of a grey one
Signed-off-by: Helen Koike
---
Changes in v2:
[media] vimc: sen: Integrate the tpg on the sensor
- Fix include location
- Select V4L2_TPG in Kconfig
- configure tpg on
Allow user space to change the image format as the frame size, the
media bus pixel format, colorspace, quantization, field YCbCr encoding
and the transfer function
Signed-off-by: Helen Koike
---
Changes in v2:
[media] vimc: sen: Support several image formats
- this is a new commit in
As all the subdevices in the topology will be initialized in the same
way, to avoid code repetition the vimc_ent_sd_{register, unregister}
helper functions were created
Signed-off-by: Helen Koike
---
Changes in v2:
[media] vimc: Add vimc_ent_sd_* helper functions
- Comments in
heck pad types on create
- return EBUSY when trying to set the format while stream is on
- remove vsd struct
- add IS_SRC and IS_SINK macros
- add sca_mult as a parameter of the module
- check set_fmt default parameters for quantization, colorspace ...
- add more
Implement scaler and integrated with the core
Signed-off-by: Helen Koike
---
Changes in v2:
[media] vimc: sca: Add scaler
- Add function MEDIA_ENT_F_IO_V4L
- remove v4l2_dev and dev
- s/sink_mbus_fmt/sink_fmt
- remove BUG_ON, remove redundant if else, rewrite
Implement the debayer filter and integrate it with the core
Signed-off-by: Helen Koike
---
Changes in v2:
[media] vimc: deb: Add debayer filter
- Using MEDIA_ENT_F_ATV_DECODER in function
- remove v4l2_dev and dev from vimc_deb_device struct
- src fmt propagates from
Allow user space to change the image format as the frame size, the
pixel format, colorspace, quantization, field YCbCr encoding
and the transfer function
Signed-off-by: Helen Koike
---
Changes in v2:
[media] vimc: cap: Support several image formats
- this is a new commit in the serie
Hi Hans,
Thanks for your patch and sorry for my late reply.
Please see my comments and questions below
On 2017-07-28 07:23 AM, Hans Verkuil wrote:
> Add support for the test_pattern control and the h/vflip controls.
>
> This makes it possible to switch to more interesting test patterns and to
>
Hi Hans,
Thanks for your review.
On 2017-07-28 10:39 AM, Hans Verkuil wrote:
> Hi Helen,
>
> Finally after way too long I found some time to review this. See my comments
> below.
>
> On 04/11/2017 12:53 AM, Helen Koike wrote:
>>
>> Hi,
>>
>> Continuin
i >= 0)
> platform_device_unregister(vimc->subdevs[i]);
>
> - return ERR_PTR(-ENOMEM);
> + return match;
> }
>
> component_match_add(&vimc->pdev.dev, &match, vimc_comp_compare,
>
>
>
Nice catch, thanks, looks good to me
Acked-by: Helen Koike
Hi,
Continuing the discussion about the API of the vimc driver, I made some
changes
based on the previous comments, please see below and let me know your
opinion about it.
Helen
/***
Configfs considerations:
/
Informal definitions:
subsyst
Hi,
On 2017-04-12 08:00 AM, Milan Čížek wrote:
How to remove your product from my kernel? I tried make rmmod
rminstall but this message stills in my syslog.
Sorry for question, I'm linux newbie.
[ 15.753993] WARNING: You are using an experimental version of the
media stack.
As
Hi Hans,
Thank you for your review. I just have a question for this one.
On 2017-05-08 08:53 AM, Hans Verkuil wrote:
On 04/08/2017 12:37 AM, Helen Koike wrote:
Allow user space to change the image format as the frame size, the
pixel format, colorspace, quantization, field YCbCr encoding
and
colorspace, ycbcr_enc, quantization and xfer_func must match across the
link.
Check if they match in v4l2_subdev_link_validate_default unless they are
set as _DEFAULT.
Signed-off-by: Helen Koike
---
Hi,
I think we should validate colorimetry as having different colorimetry
across a link
All links will be checked in the same way. Adding a helper function for
that
Signed-off-by: Helen Koike
---
Changes in v3:
[media] vimc: common: Add vimc_link_validate
- this is a new patch in the series
Changes in v2: None
---
drivers/media/platform/vimc/vimc-capture.c | 78
default parameters for quantization, colorspace ...
- add more dev_dbg
Helen Koike (11):
[media] vimc: sen: Integrate the tpg on the sensor
[media] vimc: Move common code from the core
[media] vimc: common: Add vimc_ent_sd_* helper
[media] vimc: common: Add vimc_pipeline_s_stream helper
Implement scaler and integrated with the core
Signed-off-by: Helen Koike
---
Changes in v3:
[media] vimc: sca: Add scaler
- Declare frame_size as a local variable
- s_stream(sd, 1): return 0 if stream is already enabled
- s_stream(sd, 0): return 0 if stream is already
Implement the debayer filter and integrate it with the core
Signed-off-by: Helen Koike
---
Changes in v3:
[media] vimc: deb: Add debayer filter
- Declare frame_size as a local variable
- s_stream(sd, 1): return 0 if stream is already enabled
- s_stream(sd, 0): return 0
_device in the system.
It also facilitates other implementations of different nodes without
touching the core code and remove the need of a header file for each
type of node.
Signed-off-by: Helen Koike
---
Changes in v3:
[media] vimc: Subdevices as modules
- This is a new patch in the serie
the capture node, thus saving intermediate memory buffers
and process time, allowing a higher frame rate.
Signed-off-by: Helen Koike
---
Changes in v3:
[media] vimc: Optimize frame generation through the pipe
- This is a new patch in the series
Changes in v2: None
---
drivers/media
Allow user space to change the image format as the frame size, the
media bus pixel format, colorspace, quantization, field YCbCr encoding
and the transfer function
Signed-off-by: Helen Koike
---
Changes in v3:
[media] vimc: sen: Support several image formats
- remove support for
Allow user space to change the image format as the frame size, the
pixel format, colorspace, quantization, field YCbCr encoding
and the transfer function
Signed-off-by: Helen Koike
---
Changes in v3:
[media] vimc: cap: Support several image formats
- use *_DEFAULT macros for
Remove helper functions from vimc-core and add it in vimc-common to
clean up the core.
Signed-off-by: Helen Koike
---
Changes in v3:
[media] vimc: Move common code from the core
- This is a new patch in the series
Changes in v2: None
---
drivers/media/platform/vimc/Makefile
Initialize the test pattern generator on the sensor
Generate a colored bar image instead of a grey one
Signed-off-by: Helen Koike
---
Changes in v3:
[media] vimc: sen: Integrate the tpg on the sensor
- Declare frame_size as a local variable
- Set tpg frame format before
Move the vimc_cap_pipeline_s_stream from the vimc-cap.c to vimc-common.c
as this core will be reused by other subdevices to activate the stream
in their directly connected nodes
Signed-off-by: Helen Koike
---
Changes in v3:
[media] vimc: Add vimc_pipeline_s_stream in the core
- add it
As all the subdevices in the topology will be initialized in the same
way, to avoid code repetition the vimc_ent_sd_{register, unregister}
helper functions were created
Signed-off-by: Helen Koike
---
Changes in v3:
[media] vimc: Add vimc_ent_sd_* helper functions
- add it in vimc
ping
On 2017-04-10 07:53 PM, Helen Koike wrote:
Hi,
Continuing the discussion about the API of the vimc driver, I made some
changes
based on the previous comments, please see below and let me know your
opinion about it.
Helen
/***
Configfs considerations
I forgot to mention that this patch series is also available here
https://github.com/helen-fornazier/opw-staging/tree/z/sent/vimc/vpu/v3
On 2017-06-02 11:58 PM, Helen Koike wrote:
This patch series improves the current video processing units in vimc
(by adding more controls to the sensor and
Hi Hans,
On 2017-11-06 08:19 AM, Hans Verkuil wrote:
> Hi Helen,
>
> On 09/27/2017 08:30 PM, Helen Koike wrote:
>> Hi Hans,
>>
>> Thanks for your patch and sorry for my late reply.
>
> Sorry for my late reply to your reply :-)
>
>> Please see my commen
In case of failure, print "q.create_bufs(node, 1, &fmt) != EINVAL" instead
of "ret != EINVAL"
Signed-off-by: Helen Koike
---
Hello,
I was wondering, why the q.create_bufs is expected to should return EINVAL in
this test? The height and size are set to half of the
If *nplanes is not zero, it should use the requested size if valid
Signed-off-by: Helen Koike
---
drivers/media/usb/stk1160/stk1160-v4l.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/usb/stk1160/stk1160-v4l.c
b/drivers/media/usb/stk1160/stk1160-v4l.c
index 77131fd
Hi Jeremy,
On 24-05-2016 21:00, Jeremy Gebben wrote:
Helen,
I am more of a v4l2 newb than a reviewer, but I got your driver working
on a qemu arm64 system. Using it to play with mediactl -p was
a good way to get started.
I did have 2 minor include path problems. Maybe they come in implicitly
o
From: Helen Fornazier
First version of the Virtual Media Controller.
Add a simple version of the core of the driver, the capture and
sensor nodes in the topology, generating a grey image in a hardcoded
format.
Signed-off-by: Helen Fornazier
---
Changes since v3: fix rmmod crash and built-in co
Hi Hans
On 01-07-2016 09:39, Hans Verkuil wrote:
Hi Helen,
Better late than never, but I finally have time for a review, mostly with a eye
for V4L2 issues.
Thank you for your review, I'll incorporate your suggestions in v5.
I am also preparing a patch series that integrates the tpg and have
From: Helen Fornazier
First version of the Virtual Media Controller.
Add a simple version of the core of the driver, the capture and
sensor nodes in the topology, generating a grey image in a hardcoded
format.
Signed-off-by: Helen Koike
---
Patch based in media/master tree, and available
101 - 168 of 168 matches
Mail list logo