[PATCH] solo6x10: Approximate frame intervals with non-standard denominator

Instead of falling back to 1/25 (PAL) or 1/30 (NTSC). Signed-off-by: Ismael Luceno ismael.luc...@corp.bluecherry.net # Please enter the commit message for your changes. Lines starting # with '#' will be ignored, and an empty message aborts the commit. # On branch media # Changes to be committed

[PATCH] solo6x10: Update the encoder mode on VIDIOC_S_FMT

Signed-off-by: Ismael Luceno ismael.luc...@corp.bluecherry.net --- drivers/staging/media/solo6x10/solo6x10-v4l2-enc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/solo6x10/solo6x10-v4l2-enc.c b/drivers/staging/media/solo6x10/solo6x10-v4l2-enc.c index 6147bb2

[PATCH] solo6x10: Fix pixelformat accepted/reported by the encoder

The 6010 produces MPEG-4 part 2, while 6110 produces H.264. Signed-off-by: Ismael Luceno ismael.luc...@corp.bluecherry.net --- drivers/staging/media/solo6x10/solo6x10-v4l2-enc.c | 43 -- 1 file changed, 32 insertions(+), 11 deletions(-) diff --git a/drivers/staging/media

Re: [RFC] Motion Detection API

On Fri, 12 Apr 2013 17:36:16 +0200 Hans Verkuil hverk...@xs4all.nl wrote: This RFC looks at adding support for motion detection to V4L2. This is the main missing piece that prevents the go7007 and solo6x10 drivers from being moved into mainline from the staging directory. ... Comment?

[PATCH v2] solo6x10: Approximate frame intervals with non-standard denominator

Instead of falling back to 1/25 (PAL) or 1/30 (NTSC). Signed-off-by: Ismael Luceno ismael.luc...@corp.bluecherry.net --- drivers/staging/media/solo6x10/solo6x10-v4l2-enc.c | 38 +- 1 file changed, 15 insertions(+), 23 deletions(-) diff --git a/drivers/staging/media/solo6x10

[PATCH] Reimplement SAA712x setup routine

Signed-off-by: Ismael Luceno ismael.luc...@corp.bluecherry.net --- drivers/staging/media/solo6x10/solo6x10-tw28.c | 112 +++-- 1 file changed, 66 insertions(+), 46 deletions(-) diff --git a/drivers/staging/media/solo6x10/solo6x10-tw28.c b/drivers/staging/media/solo6x10

Re: [PATCH 5/6] staging/media/solo6x10: use module_pci_driver macro

pci_register_driver(solo_pci_driver); -} - -static void __exit solo_module_exit(void) -{ - pci_unregister_driver(solo_pci_driver); -} - -module_init(solo_module_init); -module_exit(solo_module_exit); +module_pci_driver(solo_pci_driver); Acked-by: Ismael Luceno ismael.luc

Re: [PATCH 10/10] staging: solo6x10: Avoid extern declaration by reworking module parameter

On Thu, Jun 21, 2012 at 4:52 PM, Ezequiel Garcia elezegar...@gmail.com wrote: This patch moves video_nr module parameter to core.c and then passes that parameter as an argument to functions that need it. This way we avoid the extern declaration and parameter dependencies are better exposed.

Re: [PATCH 10/10] staging: solo6x10: Avoid extern declaration by reworking module parameter

On Thu, 19 Jul 2012 10:25:09 -0300 Ezequiel Garcia elezegar...@gmail.com wrote: On Wed, Jul 18, 2012 at 7:26 PM, Ismael Luceno ismael.luc...@gmail.com wrote: On Thu, Jun 21, 2012 at 4:52 PM, Ezequiel Garcia elezegar...@gmail.com wrote: This patch moves video_nr module parameter to core.c

Re: [PATCH 10/10] staging: solo6x10: Avoid extern declaration by reworking module parameter

On Thu, 19 Jul 2012 21:48:33 +0200 Hans Verkuil hverk...@xs4all.nl wrote: On Thu July 19 2012 20:41:11 Ismael Luceno wrote: On Thu, 19 Jul 2012 10:25:09 -0300 Ezequiel Garcia elezegar...@gmail.com wrote: On Wed, Jul 18, 2012 at 7:26 PM, Ismael Luceno ismael.luc...@gmail.com wrote

[PATCH 1/2] au0828: Add USB ID used by many dongles

Tested with Yfeng 680 ATV dongle. Signed-off-by: Ismael Luceno ismael.luc...@gmail.com --- drivers/media/video/au0828/au0828-cards.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/video/au0828/au0828-cards.c b/drivers/media/video/au0828/au0828-cards.c index 1c6015a

[PATCH 2/2] au0828: Move under dvb

Signed-off-by: Ismael Luceno ismael.luc...@gmail.com --- drivers/media/dvb/Kconfig |1 + drivers/media/dvb/Makefile |1 + drivers/media/{video = dvb}/au0828/Kconfig|0 drivers/media/{video = dvb}/au0828/Makefile |0

Re: [PATCH 2/2] au0828: Move under dvb

On Fri, 11 May 2012 08:04:59 -0400 Devin Heitmueller dheitmuel...@kernellabs.com wrote: ... What is the motivation for moving these files? Well, the device was on the wrong Kconfig section, and while thinking about changing that, I just thought to move it under DVB. The au0828 is a hybrid

[PATCH] au0828: Add USB ID used by many dongles

Tested with Yfeng 680 ATV dongle. Signed-off-by: Ismael Luceno ismael.luc...@gmail.com --- drivers/media/video/au0828/au0828-cards.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/video/au0828/au0828-cards.c b/drivers/media/video/au0828/au0828-cards.c index 1c6015a

[PATCH] au0828: Move the Kconfig knob under V4L_USB_DRIVERS

This driver is for USB devices, but was incorrectly listed under V4L_PCI_DRIVERS. Signed-off-by: Ismael Luceno ismael.luc...@gmail.com --- drivers/media/video/Kconfig |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/video/Kconfig b/drivers/media/video

Re: [PATCH] SOLO6x10: Fix video headers on certain hardware.

Acked-by: Ismael Luceno ismael.luc...@corp.bluecherry.net ... signature.asc Description: PGP signature

Re: [PATCH] SOLO6x10: Fix video encoding on big-endian systems.

On Thu, 12 Sep 2013 14:28:07 +0200 khal...@piap.pl (Krzysztof Hałasa) wrote: Signed-off-by: Krzysztof Hałasa khal...@piap.pl Acked-by: Ismael Luceno ismael.luc...@corp.bluecherry.net ... signature.asc Description: PGP signature

Re: [PATCH] SOLO6x10: Remove unused #define SOLO_DEFAULT_GOP

On Thu, 12 Sep 2013 14:26:46 +0200 khal...@piap.pl (Krzysztof Hałasa) wrote: Signed-off-by: Krzysztof Hałasa khal...@piap.pl Acked-by: Ismael Luceno ismael.luc...@corp.bluecherry.net ... signature.asc Description: PGP signature

Re: [PATCH] SOLO6x10: Fix video frame type (I/P/B).

On Mon, 07 Oct 2013 13:33:55 +0200 khal...@piap.pl (Krzysztof Hałasa) wrote: Signed-off-by: Krzysztof Hałasa khal...@piap.pl Acked-by: Ismael Luceno ismael.luc...@corp.bluecherry.net ... signature.asc Description: PGP signature

Re: [PATCH] SOLO6x10: don't do DMA from stack in solo_dma_vin_region().

On Thu, 12 Sep 2013 14:25:36 +0200 khal...@piap.pl (Krzysztof Hałasa) wrote: Signed-off-by: Krzysztof Hałasa khal...@piap.pl Acked-by: Ismael Luceno ismael.luc...@corp.bluecherry.net ... signature.asc Description: PGP signature

Re: [PATCH 4/4] media/solo6x10: Changes on the vb2-dma-sg API

On Fri, 19 Jul 2013 09:58:49 +0200 Ricardo Ribalda Delgado ricardo.riba...@gmail.com wrote: The struct vb2_dma_sg_desc has been replaced with the generic sg_table to describe the location of the video buffers. Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com Acked-by: Ismael

[PATCH] solo6x10: Maintainer change

Signed-off-by: Ismael Luceno ismael.luc...@corp.bluecherry.net --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 3b95564..eb277c9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7315,8 +7315,8 @@ S:Odd Fixes F

[PATCH] solo6x10: Update TODO (maintainer change)

Signed-off-by: Ismael Luceno ismael.luc...@corp.bluecherry.net --- drivers/staging/media/solo6x10/TODO | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/solo6x10/TODO b/drivers/staging/media/solo6x10/TODO index 539f739..8ae814b 100644 --- a/drivers

Re: [RFC PATCH 00/20] solo6x10: V4L2 compliancy fixes and major overhaul

On Sun, 3 Mar 2013 00:45:16 +0100 Hans Verkuil hverk...@xs4all.nl wrote: 3) What is the meaning of this snippet of code in v4l2-enc.c? if (pix-priv) solo_enc-type = SOLO_ENC_TYPE_EXT; I've commented it out since it is completely undocumented and no driver should

[PATCH v2] solo6x10: Update TODO (maintainer change)

Signed-off-by: Ismael Luceno ismael.luc...@corp.bluecherry.net --- drivers/staging/media/solo6x10/TODO | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/solo6x10/TODO b/drivers/staging/media/solo6x10/TODO index 539f739..d09dd03 100644 --- a/drivers

[PATCH] gspca_gl860: Clean up idxdata structs

Signed-off-by: Ismael Luceno ismael.luc...@gmail.com --- drivers/media/usb/gspca/gl860/gl860-mi2020.c | 464 --- 1 file changed, 268 insertions(+), 196 deletions(-) diff --git a/drivers/media/usb/gspca/gl860/gl860-mi2020.c b/drivers/media/usb/gspca/gl860/gl860-mi2020.c

[PATCH] solo6x10: Reduce OSD writes to the minimum necessary

Signed-off-by: Ismael Luceno ismael.luc...@corp.bluecherry.net --- drivers/staging/media/solo6x10/solo6x10-enc.c | 31 ++- drivers/staging/media/solo6x10/solo6x10-offsets.h | 2 ++ 2 files changed, 16 insertions(+), 17 deletions(-) diff --git a/drivers/staging/media

[PATCH] solo6x10: Kconfig: Add supported card list to the SOLO6X10 knob

Signed-off-by: Ismael Luceno ismael.luc...@corp.bluecherry.net --- drivers/staging/media/solo6x10/Kconfig | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/solo6x10/Kconfig b/drivers/staging/media/solo6x10/Kconfig index 9a4296c..6a1906f 100644

Re: [PATCH] staging: solo6x10: fix for sparse warning message

, 0x05, 0x08, 0x07, Signed-off-by: Ismael Luceno ismael.luc...@corp.bluecherry.net signature.asc Description: PGP signature

Re: [PATCH 1/2] solo6x10: expose encoder quantization setting as V4L2 control

, SOLO_DEFAULT_QP); v4l2_ctrl_new_custom(hdl, solo_motion_threshold_ctrl, NULL); v4l2_ctrl_new_custom(hdl, solo_motion_enable_ctrl, NULL); v4l2_ctrl_new_custom(hdl, solo_osd_text_ctrl, NULL); Signed-off-by: Ismael Luceno ismael.luc...@corp.bluecherry.net signature.asc Description: PGP signature

Re: [PATCH 2/2] solo6x10: update GOP size, QP immediately

); + solo_reg_write(solo_dev, SOLO_VE_CH_QP_E(solo_enc-ch), solo_enc-qp); return 0; case V4L2_CID_MOTION_THRESHOLD: solo_enc-motion_thresh = ctrl-val; Signed-off-by: Ismael Luceno ismael.luc...@corp.bluecherry.net signature.asc Description: PGP signature

Re: [PATCH] [media] staging/solo6x10: SOLO6X10 should select BITREVERSE

FONT_SUPPORT select FONT_8x16 select VIDEOBUF2_DMA_SG Signed-off-by: Ismael Luceno ismael.luc...@corp.bluecherry.net signature.asc Description: PGP signature

Re: [PATCH] Update MAINTAINERS for solo6x10

100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8787,7 +8787,9 @@ S: Maintained F: drivers/leds/leds-net48xx.c SOFTLOGIC 6x10 MPEG CODEC -M: Ismael Luceno ismael.luc...@corp.bluecherry.net +M: Bluecherry Maintainers maintain...@bluecherrydvr.com +M: Andrey Utkin andrey.ut

Re: SOLO6x10: fix a race in IRQ handler.

) solo_g723_isr(solo_dev); - /* Clear all interrupts handled */ - solo_reg_write(solo_dev, SOLO_IRQ_STAT, status); - return IRQ_HANDLED; } Signed-off-by: Ismael Luceno ismael.luc...@corp.bluecherry.net pgpM1nfzSn1Y5.pgp Description: OpenPGP digital signature

Re: [RFC] solo6x10 freeze, even with Oct 31's linux-next... any ideas or help?

On Tue, 11 Nov 2014 19:05:37 +0100 Hans Verkuil hverk...@xs4all.nl wrote: On 11/11/2014 06:46 PM, Andrey Utkin wrote: At Bluecherry, we have issues with servers which have 3 solo6110 cards (and cards have up to 16 analog video cameras connected to them, and being actively read). This is a

Re: [RFC] solo6x10 freeze, even with Oct 31's linux-next... any ideas or help?

On Sat, 15 Nov 2014 21:42:05 +0100 khal...@piap.pl (Krzysztof Hałasa) wrote: Andrey Utkin andrey.ut...@corp.bluecherry.net writes: In upstream there's no more module parameter for video standard (NTSC/PAL). But there's VIDIOC_S_STD handling procedure. But it turns out not to work

[PATCH] solo6x10: Maintainers update

Adding Andrey Utkin, and I'll be using my personal email address from now on. Signed-off-by: Ismael Luceno ismael.luc...@corp.bluecherry.net --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 0ff630d..b4ba217 100644

[PATCH 1/3] solo6x10: s/unsigned char/u8/

Signed-off-by: Ismael Luceno ism...@iodev.co.uk --- drivers/media/pci/solo6x10/solo6x10-enc.c | 6 +++--- drivers/media/pci/solo6x10/solo6x10-g723.c | 4 ++-- drivers/media/pci/solo6x10/solo6x10-jpeg.h | 4 ++-- drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c | 18

[PATCH 3/3] solo6x10: Fix solo_eeprom_read retval type

Signed-off-by: Ismael Luceno ism...@iodev.co.uk --- drivers/media/pci/solo6x10/solo6x10-eeprom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/solo6x10/solo6x10-eeprom.c b/drivers/media/pci/solo6x10/solo6x10-eeprom.c index da25ce4..8e81186 100644

[PATCH 2/3] solo6x10: Fix eeprom_* functions buffer's type

Signed-off-by: Ismael Luceno ism...@iodev.co.uk --- drivers/media/pci/solo6x10/solo6x10-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/pci/solo6x10/solo6x10-core.c b/drivers/media/pci/solo6x10/solo6x10-core.c index 8cbe6b4..570d119 100644

[PATCH] solo6x10: s/uint8_t/u8/

Signed-off-by: Ismael Luceno ism...@iodev.co.uk --- drivers/media/pci/solo6x10/solo6x10-tw28.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/pci/solo6x10/solo6x10-tw28.c b/drivers/media/pci/solo6x10/solo6x10-tw28.c index edd0781..0632d3f 100644

[PATCH] MAINTAINERS: Update solo6x10 entry

Re-add Ismael Luceno as co-maintainer (with personal email address). Signed-off-by: Ismael Luceno ism...@iodev.co.uk --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index ddb9ac8..b012411 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8892,6 +8892,7

Re: [PATCH] media: pci: solo6x10: solo6x10-enc.c: Remove unused function

On Fri, 16 Jan 2015 11:55:15 +0100 Hans Verkuil hverk...@xs4all.nl wrote: (resent with correct email address for Ismael) Ismael, Andrey, Can you take a look at this? Shouldn't solo_s_jpeg_qp() be hooked up to something? The feature was never implemented, so yes, and we should keep it

Re: [PATCH] SOLO6x10: Fix G.723 minimum audio period count.

in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Signed-off-by: Ismael Luceno ism...@iodev.co.uk -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org

Re: [PATCH] SOLO6x10: unmap registers only after free_irq().

-by: Ismael Luceno ism...@iodev.co.uk -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: A few SOLO6x10 patches.

On Mon, 08 Jun 2015 15:30:17 +0200 khal...@piap.pl (Krzysztof Hałasa) wrote: ... (nobody using SOLO with audio?) Probably not, the audio quality is pretty bad. -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] SOLO6x10: Remove dead code.

); - if (pdev-irq) - free_irq(pdev-irq, solo_dev); + free_irq(pdev-irq, solo_dev); pci_iounmap(pdev, solo_dev-reg_base); } Signed-off-by: Ismael Luceno ism...@iodev.co.uk -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH] SOLO6x10: remove unneeded register locking and barriers.

); - writel(data, solo_dev-reg_base + reg); - wmb(); - pci_read_config_word(solo_dev-pdev, PCI_STATUS, val); - rmb(); - - spin_unlock_irqrestore(solo_dev-reg_io_lock, flags); } static inline void solo_irq_on(struct solo_dev *dev, u32 mask) Signed-off-by: Ismael

Re: solo6x10: all interrupts for all cards handled by CPU0, no balancing - why?

On Fri, 30 Jan 2015 00:29:13 +0200 Andrey Utkin andrey.krieger.ut...@gmail.com wrote: The host was rebooted and got back online. Without irqbalance daemon, all solo6x10 interrupts are still on CPU0. See https://gist.github.com/krieger-od/d1686243c67fbe3e14a5 Any ideas are strongly appreciated.

[PATCH 2/2] solo6x10: Simplify solo_enum_ext_input

Additionally, now it specifies which channels it's showing. Signed-off-by: Ismael Luceno <ism...@iodev.co.uk> --- drivers/media/pci/solo6x10/solo6x10-v4l2.c | 27 +-- 1 file changed, 9 insertions(+), 18 deletions(-) diff --git a/drivers/media/pci/solo6x10/solo6x10-

[PATCH 1/2] solo6x10: Set FRAME_BUF_SIZE to 200KB

Such frame size is met in practice. Also report oversized frames. Based on patches by Andrey Utkin <andrey.ut...@corp.bluecherry.net>. Signed-off-by: Ismael Luceno <ism...@iodev.co.uk> --- drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c | 7 +-- 1 file changed, 5 insertions(+),

Re: [PATCH 2/2] solo6x10: Simplify solo_enum_ext_input

On 04/Mai/2016 10:02, Hans Verkuil wrote: > Hi Ismael, > > On 04/30/2016 05:17 AM, Ismael Luceno wrote: > > Additionally, now it specifies which channels it's showing. > > > > Signed-off-by: Ismael Luceno <ism...@iodev.co.uk> > > --- > > dr

Re: [PATCH v2 1/2] solo6x10: Set FRAME_BUF_SIZE to 200KB

On 05/Mai/2016 00:14, Andrey Utkin wrote: > On Wed, May 04, 2016 at 01:21:20PM -0300, Ismael Luceno wrote: > > From: Andrey Utkin <andrey.ut...@corp.bluecherry.net> > > > > Such frame size is met in practice. Also report oversized frames. > > > > [isma

Re: [PATCH 1/2] solo6x10: Set FRAME_BUF_SIZE to 200KB

On 04/May/2016 17:22, Andrey Utkin wrote: > On Wed, May 4, 2016 at 5:04 PM, Hans Verkuil wrote: > > BTW, looking at the MAINTAINERS file I see two email addresses for Andrey, > > neither of which is the fastmail.com address this email came from. > > Now I'm replying from

Re: [PATCH 1/2] solo6x10: Set FRAME_BUF_SIZE to 200KB

On 04/May/2016 16:34, Andrey Utkin wrote: > On Sat, Apr 30, 2016 at 12:17:08AM -0300, Ismael Luceno wrote: > > Such frame size is met in practice. Also report oversized frames. > > > > Based on patches by Andrey Utkin <andrey.ut...@corp.bluecherry.net>. > > If

[PATCH v2 2/2] solo6x10: Simplify solo_enum_ext_input

Additionally, now it specifies which channels it's showing. Signed-off-by: Ismael Luceno <ism...@iodev.co.uk> --- drivers/media/pci/solo6x10/solo6x10-v4l2.c | 34 ++ 1 file changed, 16 insertions(+), 18 deletions(-) diff --git a/drivers/media/pci/solo6x10/so

[PATCH v2 1/2] solo6x10: Set FRAME_BUF_SIZE to 200KB

From: Andrey Utkin <andrey.ut...@corp.bluecherry.net> Such frame size is met in practice. Also report oversized frames. [ismael: Reworked warning and commit message] Signed-off-by: Ismael Luceno <ism...@iodev.co.uk> --- drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c | 7 +-- 1

Re: [PATCH 0505/1285] Replace numeric parameter like 0444 with macro

On 02/Ago/2016 19:18, Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the > corresponding macro, > and that using

Re: [PATCH] [media] solo6x10: release vb2 buffers in solo_stop_streaming()

On 08/Mar/2017 21:59, Andrey Utkin wrote: > Signed-off-by: Andrey Utkin > Signed-off-by: Andrey Utkin > > Please welcome Anton who is now in charge of solo6x10 and tw5864 support > and development in Bluecherry company, I have sent

Re: [PATCH v2] [media] solo6x10: release vb2 buffers in solo_stop_streaming()

+ while (!list_empty(_dev->vidq_active)) { > + struct solo_vb2_buf *buf = list_entry( > + solo_dev->vidq_active.next, > + struct solo_vb2_buf, list); > + > + list_del(>list); > + vb2_buffer

Re: [PATCH] [media] solo6x10: make const array saa7128_regs_ntsc static

const int reg_start = 0x26; > - const u8 saa7128_regs_ntsc[] = { > + static const u8 saa7128_regs_ntsc[] = { > /* :0x26 */ > 0x0d, 0x00, > /* :0x28 */ Signed-off-by: Ismael Luceno <ism...@iodev.co.uk>

Re: [PATCH] [media] solo6x10: export hardware GPIO pins 8:31 to gpiolib interface

h > index 3f8da5e8c430..3a1893ae2dad 100644 > --- a/drivers/media/pci/solo6x10/solo6x10.h > +++ b/drivers/media/pci/solo6x10/solo6x10.h > @@ -31,6 +31,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -199,6 +200,10 @@ struct solo_dev { > u32 irq_mask; > u32 motion_mask; > struct v4l2_device v4l2_dev; > +#ifdef CONFIG_GPIOLIB > + /* GPIO */ > + struct gpio_chipgpio_dev; > +#endif > > /* tw28xx accounting */ > u8 tw2865, tw2864, tw2815; > -- > 2.13.0 > Signed-off-by: Ismael Luceno <ism...@iodev.co.uk>

Re: [PATCH] [media] solo6x10: hide unused variable

gpio.c > +++ b/drivers/media/pci/solo6x10/solo6x10-gpio.c > @@ -162,7 +162,9 @@ static void solo_gpiochip_set(struct gpio_chip *chip, > > int solo_gpio_init(struct solo_dev *solo_dev) > { > +#ifdef CONFIG_GPIOLIB > int ret; > +#endif > > solo_gpio_config(solo_dev); > #ifdef CONFIG_GPIOLIB > -- > 2.9.0 > Signed-off-by: Ismael Luceno <ism...@iodev.co.uk>

Re: [PATCH 2/2] [media] solo6x10: make snd_kcontrol_new const

CTL_ELEM_IFACE_MIXER, > .name = "Capture Volume", > .info = snd_solo_capture_volume_info, > -- > 1.9.1 > Signed-off-by: Ismael Luceno <ism...@iodev.co.uk> signature.asc Description: PGP signature

Re: [PATCH v2] [media] pci: make video_device const

0644 > --- a/drivers/media/pci/tw68/tw68-video.c > +++ b/drivers/media/pci/tw68/tw68-video.c > @@ -916,7 +916,7 @@ static int vidioc_s_register(struct file *file, void > *priv, > #endif > }; > > -static struct video_device tw68_video_template = { > +static const struct video_device tw68_video_template = { > .name = "tw68_video", > .fops = _fops, > .ioctl_ops = _ioctl_ops, > -- > 1.9.1 Signed-off-by: Ismael Luceno <ism...@iodev.co.uk>

Re: [PATCH 3/5] [media] solo6x10: make video_device const

gt; .fops = _v4l2_fops, > .ioctl_ops = _v4l2_ioctl_ops, > -- > 1.9.1 > Signed-off-by: Ismael Luceno <ism...@iodev.co.uk>

Re: [PATCH 3/8] [media] solo6x10: use ktime_get_ts64() for time sync

; + diff = (s32)ts.tv_sec - (s32)sec; > diff = (diff * 100) > - + ((long)(ts.tv_nsec / NSEC_PER_USEC) - (long)usec); > + + ((s32)(ts.tv_nsec / NSEC_PER_USEC) - (s32)usec); > > if (diff > 1000 || diff < -1000) { > solo_set_time(solo_dev); > -- > 2.9.0 > Signed-off-by: Ismael Luceno <ism...@iodev.co.uk> signature.asc Description: PGP signature