[PATCH/RFC v4 07/11] media-ctl: libv4l2subdev: add VYUY8_2X8 mbus code

2014-11-21 Thread Jacek Anaszewski
The VYUY8_2X8 media bus format is the only one supported by the S5C73M3 camera sensor, that is a part of the media device on the Exynos4412-trats2 board. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park --- utils/media-ctl/libv4l2subdev.c |1 + 1 file changed, 1 insertion(+) diff

Re: [PATCH 6/6] media/platform: fix querycap

2014-11-25 Thread Jacek Anaszewski
ready slated for removal, so it's time to do so. Signed-off-by: Hans Verkuil Cc: Lad, Prabhakar Cc: Kamil Debski Cc: Jacek Anaszewski Acked-by: Jacek Anaszewski Best Regards, Jacek Anaszewski --- drivers/media/platform/davinci/vpbe_display.c | 1 - drivers/media/platfo

Re: [PATCH/RFC v4 01/11] mediactl: Introduce v4l2_subdev structure

2014-11-25 Thread Jacek Anaszewski
Hi Sakari, On 11/25/2014 12:36 PM, Sakari Ailus wrote: Hi Jacek, Thank you for the updated patchset. On Fri, Nov 21, 2014 at 05:14:30PM +0100, Jacek Anaszewski wrote: Add struct v4l2_subdev as a representation of the v4l2 sub-device related to a media entity. Add sd property, the pointer to

[PATCH/RFC v8 13/14] of: Add Skyworks Solutions, Inc. vendor prefix

2014-11-28 Thread Jacek Anaszewski
Use "skyworks" as the vendor prefix for the Skyworks Solutions, Inc. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala Cc: --- .../devicetree/bindings/vendor-prefixes.txt|1 + 1 fi

[PATCH/RFC v8 14/14] DT: Add documentation for the Skyworks AAT1290

2014-11-28 Thread Jacek Anaszewski
This patch adds device tree binding documentation for 1.5A Step-Up Current Regulator for Flash LEDs. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala Cc

[PATCH/RFC v8 12/14] leds: Add driver for AAT1290 current regulator

2014-11-28 Thread Jacek Anaszewski
This patch adds a driver for the 1.5A Step-Up Current Regulator for Flash LEDs. The device is programmed through a Skyworks proprietary AS2Cwire serial digital interface. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie --- drivers/leds/Kconfig

[PATCH/RFC v8 09/14] mfd: max77693: adjust max77693_led_platform_data

2014-11-28 Thread Jacek Anaszewski
Add "label" array for Device Tree strings with the name of a LED device and make flash_timeout a two element array, for caching the sub-led related flash timeout. Signed-off-by: Jacek Anaszewski Signed-off-by: Andrzej Hajda Acked-by: Kyungmin Park Cc: Lee Jones Cc: SangYoung Son

[PATCH/RFC v8 10/14] leds: Add support for max77693 mfd flash cell

2014-11-28 Thread Jacek Anaszewski
leds can be triggered externally or by software. Signed-off-by: Jacek Anaszewski Signed-off-by: Andrzej Hajda Acked-by: Kyungmin Park Cc: Lee Jones Cc: Bryan Wu Cc: Richard Purdie Cc: SangYoung Son Cc: Samuel Ortiz --- drivers/leds/Kconfig | 10 + drivers/leds/Makefile|1

[PATCH/RFC v8 11/14] DT: Add documentation for the mfd Maxim max77693

2014-11-28 Thread Jacek Anaszewski
This patch adds device tree binding documentation for the flash cell of the Maxim max77693 multifunctional device. Signed-off-by: Jacek Anaszewski Signed-off-by: Andrzej Hajda Acked-by: Kyungmin Park Cc: Lee Jones Cc: SangYoung Son Cc: Samuel Ortiz Cc: Bryan Wu Cc: Richard Purdie Cc: Rob

[PATCH/RFC v8 08/14] DT: Add documentation for exynos4-is 'flashes' property

2014-11-28 Thread Jacek Anaszewski
This patch adds a description of 'flashes' property to the samsung-fimc.txt. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Sylwester Nawrocki Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala Cc: --- .../devicetree/bindings/med

[PATCH/RFC v8 07/14] exynos4-is: Add support for v4l2-flash subdevs

2014-11-28 Thread Jacek Anaszewski
This patch adds suppport for external v4l2-flash devices. The support includes parsing "flashes" Device Tree property and asynchronous subdevice registration. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Sylwester Nawrocki --- drivers/media/platform/exynos4-is/m

[PATCH/RFC v8 04/14] v4l2-async: change custom.match callback argument type

2014-11-28 Thread Jacek Anaszewski
It is useful to have an access to the async sub-device being matched, not only to the related struct device. Change match callback argument from struct device to struct v4l2_subdev. It will allow e.g. for matching a sub-device by its "name" property. Signed-off-by: Jacek Anaszewski

[PATCH/RFC v8 05/14] v4l2-ctrls: Add V4L2_CID_FLASH_SYNC_STROBE control

2014-11-28 Thread Jacek Anaszewski
Add V4L2_CID_FLASH_SYNC_STROBE control for determining whether a flash device strobe has to be synchronized with other flash leds controller by the same device. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Sakari Ailus Cc: Hans Verkuil --- Documentation/DocBook/media/v4l

[PATCH/RFC v8 06/14] media: Add registration helpers for V4L2 flash sub-devices

2014-11-28 Thread Jacek Anaszewski
ll be used. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Sakari Ailus Cc: Hans Verkuil --- drivers/media/v4l2-core/Kconfig | 11 + drivers/media/v4l2-core/Makefile |2 + drivers/media/v4l2-core/v4l2-flash.c | 516 ++ include/media

[PATCH/RFC v8 03/14] Documentation: leds: Add description of v4l2-flash sub-device

2014-11-28 Thread Jacek Anaszewski
This patch extends LED Flash class documention by the description of interactions with v4l2-flash sub-device. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie --- Documentation/leds/leds-class-flash.txt | 13 + 1 file changed, 13

[PATCH/RFC v8 02/14] Documentation: leds: Add description of LED Flash class extension

2014-11-28 Thread Jacek Anaszewski
The documentation being added contains overall description of the LED Flash Class and the related sysfs attributes. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie --- Documentation/leds/leds-class-flash.txt | 48 +++ 1

[PATCH/RFC v8 00/14] LED / flash API integration

2014-11-28 Thread Jacek Anaszewski
op in v4l2-flash. LED subsystem should be strobe provider agnostic. Thanks, Jacek Anaszewski [1] https://lkml.org/lkml/2014/7/11/914 Jacek Anaszewski (14): leds: Add LED Flash class extension to the LED subsystem Documentation: leds: Add description of LED Flash class extension

[PATCH/RFC v8 01/14] leds: Add LED Flash class extension to the LED subsystem

2014-11-28 Thread Jacek Anaszewski
design assumes that V4L2 sub-device can take of the LED class device control and communicate with it through the kernel internal interface. When V4L2 Flash sub-device file is opened, the LED class device sysfs interface is made unavailable. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc

Re: [PATCH/RFC v7 2/3] leds: Add LED Flash Class wrapper to LED subsystem

2014-11-28 Thread Jacek Anaszewski
; You could use the rounddown() macro. I.e. rounddown(v - s->min, s->step) + s->min; I took this code snippet from v4l2-ctrls.c. It allows for aligning the control value to the nearest step - top or bottom, whereas rounddown only to the bottom one. Best Regards, Jacek Anaszewski --

Re: [PATCH/RFC v8 08/14] DT: Add documentation for exynos4-is 'flashes' property

2014-11-28 Thread Jacek Anaszewski
On 11/28/2014 12:14 PM, Mark Rutland wrote: On Fri, Nov 28, 2014 at 09:18:00AM +, Jacek Anaszewski wrote: This patch adds a description of 'flashes' property to the samsung-fimc.txt. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Sylwester Nawrocki Cc: Rob H

[PATCH] s5p-jpeg: Fix possible NULL pointer dereference in s_fmt

2014-11-28 Thread Jacek Anaszewski
Some formats are not supported in encoding or decoding mode for given type of buffer (e.g. V4L2_PIX_FMT_JPEG is supported on output buffer only while in decoding mode). Make S_FMT failing if not suitable format is found. Signed-off-by: Jacek Anaszewski --- drivers/media/platform/s5p-jpeg/jpeg

Re: [PATCH/RFC v4 11/11] Add a libv4l plugin for Exynos4 camera

2014-11-28 Thread Jacek Anaszewski
Hi Sakari, Thanks for the review. On 11/27/2014 09:41 AM, Sakari Ailus wrote: Hi Jacek, On Fri, Nov 21, 2014 at 05:14:40PM +0100, Jacek Anaszewski wrote: The plugin provides support for the media device on Exynos4 SoC. It performs single plane <-> multi plane API conversion, video pi

Re: [PATCH/RFC v8 08/14] DT: Add documentation for exynos4-is 'flashes' property

2014-11-28 Thread Jacek Anaszewski
On 11/28/2014 01:30 PM, Mark Rutland wrote: On Fri, Nov 28, 2014 at 12:09:14PM +, Jacek Anaszewski wrote: On 11/28/2014 12:14 PM, Mark Rutland wrote: On Fri, Nov 28, 2014 at 09:18:00AM +, Jacek Anaszewski wrote: This patch adds a description of 'flashes' property to t

Re: [PATCH/RFC v8 04/14] v4l2-async: change custom.match callback argument type

2014-12-01 Thread Jacek Anaszewski
Hi Laurent, On 11/29/2014 05:38 PM, Laurent Pinchart wrote: Hi Jacek, Thank you for the patch. On Friday 28 November 2014 10:17:56 Jacek Anaszewski wrote: It is useful to have an access to the async sub-device being matched, not only to the related struct device. Change match callback

Re: [PATCH/RFC v4 05/11] mediactl: Add media device graph helpers

2014-12-01 Thread Jacek Anaszewski
Hi Sakari, Thanks for a review. On 11/28/2014 06:06 PM, Sakari Ailus wrote: Hi Jacek, On Fri, Nov 21, 2014 at 05:14:34PM +0100, Jacek Anaszewski wrote: Add new graph helpers useful for video pipeline discovering. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park --- utils/media

Re: [PATCH/RFC v8 02/14] Documentation: leds: Add description of LED Flash class extension

2014-12-01 Thread Jacek Anaszewski
to add new fault modes in future... Faults are cleared by reading the attribute. I will add this note. There can be more than one fault at a time. I think that the bitmask is a flexible solution. I don't see any troubles related to adding new fault modes in the future, do you? Best Regards, J

Re: [PATCH/RFC v8 12/14] leds: Add driver for AAT1290 current regulator

2014-12-01 Thread Jacek Anaszewski
Hi Pavel, Thanks for a review. On 11/29/2014 08:05 PM, Pavel Machek wrote: Hi! @@ -0,0 +1,472 @@ +/* + * LED Flash class driver for the AAT1290 + * 1.5A Step-Up Current Regulator for Flash LEDs + * + * Copyright (C) 2014, Samsung Electronics Co., Ltd. + * Author: Jacek

Re: [PATCH/RFC v8 09/14] mfd: max77693: adjust max77693_led_platform_data

2014-12-01 Thread Jacek Anaszewski
Hi Lee, Thanks for the review. On 12/01/2014 12:34 PM, Lee Jones wrote: On Fri, 28 Nov 2014, Jacek Anaszewski wrote: Add "label" array for Device Tree strings with the name of a LED device and make flash_timeout a two element array, for caching the sub-led related fla

Re: [PATCH/RFC v8 11/14] DT: Add documentation for the mfd Maxim max77693

2014-12-01 Thread Jacek Anaszewski
y noise in the binding. Best Regards, Jacek Anaszewski -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH/RFC v8 11/14] DT: Add documentation for the mfd Maxim max77693

2014-12-01 Thread Jacek Anaszewski
Hi Pavel, On 12/01/2014 02:02 PM, Pavel Machek wrote: Hi! Is this one needed? Just ommit child note if it is not there. It is needed because you can have one led connected two both outputs. This allows to describe such a design. Ok. +- maxim,trigger-type : Array of trigger types in order

Re: [PATCH/RFC v8 02/14] Documentation: leds: Add description of LED Flash class extension

2014-12-01 Thread Jacek Anaszewski
des are generic and map directly to the V4L2 Flash error codes. Best Regards, Jacek Anaszewski -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH/RFC v4 05/11] mediactl: Add media device graph helpers

2014-12-01 Thread Jacek Anaszewski
Hi Sakari, On 12/01/2014 01:30 PM, Sakari Ailus wrote: Hi Jacek, Jacek Anaszewski wrote: ... +int media_get_busy_pads_by_entity(struct media_device *media, +struct media_entity *entity, +unsigned int type, +struct media_pad **busy_pads

Re: [PATCH/RFC v8 06/14] media: Add registration helpers for V4L2 flash sub-devices

2014-12-01 Thread Jacek Anaszewski
On 11/28/2014 10:17 AM, Jacek Anaszewski wrote: This patch adds helper functions for registering/unregistering LED Flash class devices as V4L2 sub-devices. The functions should be called from the LED subsystem device driver. In case the support for V4L2 Flash sub-devices is disabled in the

[PATCH/RFC v9 18/19] leds: max77693: add support for V4L2 Flash sub-device

2014-12-03 Thread Jacek Anaszewski
Add support for V4L2 Flash sub-device to the max77693 LED Flash class driver. The support allows for V4L2 Flash sub-device to take the control of the LED Flash class device. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie Cc: Sakari Ailus --- drivers

[PATCH/RFC v9 19/19] leds: aat1290: add support for V4L2 Flash sub-device

2014-12-03 Thread Jacek Anaszewski
Add support for V4L2 Flash sub-device to the aat1290 LED Flash class driver. The support allows for V4L2 Flash sub-device to take the control of the LED Flash class device. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie Cc: Sakari Ailus --- drivers

[PATCH/RFC v9 17/19] DT: Add documentation for exynos4-is 'flashes' property

2014-12-03 Thread Jacek Anaszewski
This patch adds a description of 'flashes' property to the samsung-fimc.txt. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Sylwester Nawrocki Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala Cc: --- .../devicetree/bindings/med

[PATCH/RFC v9 04/19] mfd: max77693: adjust max77693_led_platform_data

2014-12-03 Thread Jacek Anaszewski
Add "label" array for Device Tree strings with the name of a LED device and make flash_timeout a two element array, for caching the sub-led related flash timeout. Added is also an array for caching pointers to the sub-nodes representing sub-leds. Signed-off-by: Jacek Anaszewski

[PATCH/RFC v9 11/19] v4l2-async: change custom.match callback argument type

2014-12-03 Thread Jacek Anaszewski
It is useful to have an access to the async sub-device being matched, not only to the related struct device. Change match callback argument from struct device to struct v4l2_subdev. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Guennadi Liakhovetski Cc: Laurent Pinchart Cc: Hans

[PATCH/RFC v9 09/19] of: Add Skyworks Solutions, Inc. vendor prefix

2014-12-03 Thread Jacek Anaszewski
Use "skyworks" as the vendor prefix for the Skyworks Solutions, Inc. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala Cc: --- .../devicetree/bindings/vendor-prefixes.txt|1 + 1 fi

[PATCH/RFC v9 06/19] DT: Add documentation for the mfd Maxim max77693

2014-12-03 Thread Jacek Anaszewski
This patch adds device tree binding documentation for the flash cell of the Maxim max77693 multifunctional device. Signed-off-by: Jacek Anaszewski Signed-off-by: Andrzej Hajda Acked-by: Kyungmin Park Cc: Lee Jones Cc: Chanwoo Choi Cc: Bryan Wu Cc: Richard Purdie Cc: Rob Herring Cc: Pawel

[PATCH/RFC v9 03/19] mfd: max77693: Modify flash cell name identifiers

2014-12-03 Thread Jacek Anaszewski
Change flash cell identifiers from max77693-flash to max77693-led to avoid confusion with NOR/NAND Flash. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Chanwoo Choi Cc: Lee Jones --- drivers/mfd/max77693.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH/RFC v9 14/19] media: Add registration helpers for V4L2 flash sub-devices

2014-12-03 Thread Jacek Anaszewski
ll be used. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Sakari Ailus Cc: Hans Verkuil --- drivers/media/v4l2-core/Kconfig | 11 + drivers/media/v4l2-core/Makefile |2 + drivers/media/v4l2-core/v4l2-flash.c | 546 ++ include/media

[PATCH/RFC v9 15/19] Documentation: leds: Add description of v4l2-flash sub-device

2014-12-03 Thread Jacek Anaszewski
This patch extends LED Flash class documention by the description of interactions with v4l2-flash sub-device. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Acked-by: Sakari Ailus Cc: Bryan Wu Cc: Richard Purdie --- Documentation/leds/leds-class-flash.txt | 13 + 1

[PATCH/RFC v9 07/19] dt-binding: mfd: max77693: Add DT binding related macros

2014-12-03 Thread Jacek Anaszewski
Add macros for max77693 led part related binding. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Lee Jones Cc: Chanwoo Choi --- include/dt-bindings/mfd/max77693.h | 38 1 file changed, 38 insertions(+) create mode 100644 include/dt

[PATCH/RFC v9 16/19] exynos4-is: Add support for v4l2-flash subdevs

2014-12-03 Thread Jacek Anaszewski
This patch adds suppport for external v4l2-flash devices. The support includes parsing camera-flash DT property and asynchronous subdevice registration. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Sylwester Nawrocki --- drivers/media/platform/exynos4-is/media-dev.c | 42

[PATCH/RFC v9 13/19] v4l2-ctrls: Add V4L2_CID_FLASH_SYNC_STROBE control

2014-12-03 Thread Jacek Anaszewski
Add V4L2_CID_FLASH_SYNC_STROBE control for determining whether a flash device strobe has to be synchronized with other flash leds controller by the same device. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Sakari Ailus Cc: Hans Verkuil --- Documentation/DocBook/media/v4l

[PATCH/RFC v9 10/19] DT: Add documentation for the Skyworks AAT1290

2014-12-03 Thread Jacek Anaszewski
This patch adds device tree binding documentation for 1.5A Step-Up Current Regulator for Flash LEDs. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala Cc

[PATCH/RFC v9 05/19] leds: Add support for max77693 mfd flash cell

2014-12-03 Thread Jacek Anaszewski
This patch adds led-flash support to Maxim max77693 chipset. A device can be exposed to user space through LED subsystem sysfs interface. Device supports up to two leds which can work in flash and torch mode. The leds can be triggered externally or by software. Signed-off-by: Jacek Anaszewski

[PATCH/RFC v9 08/19] leds: Add driver for AAT1290 current regulator

2014-12-03 Thread Jacek Anaszewski
This patch adds a driver for the 1.5A Step-Up Current Regulator for Flash LEDs. The device is programmed through a Skyworks proprietary AS2Cwire serial digital interface. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie --- drivers/leds/Kconfig

[PATCH/RFC v9 12/19] v4l2-async: add V4L2_ASYNC_MATCH_CUSTOM_OF matching type

2014-12-03 Thread Jacek Anaszewski
V4L2_ASYNC_MATCH_CUSTOM_OF matching type to declare this type of matching. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Guennadi Liakhovetski Cc: Laurent Pinchart Cc: Hans Verkuil --- drivers/media/v4l2-core/v4l2-async.c | 106 ++ include/media

[PATCH/RFC v9 02/19] Documentation: leds: Add description of LED Flash class extension

2014-12-03 Thread Jacek Anaszewski
The documentation being added contains overall description of the LED Flash Class and the related sysfs attributes. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie --- Documentation/leds/leds-class-flash.txt | 50 +++ 1

[PATCH/RFC v9 00/19] LED / flash API integration

2014-12-03 Thread Jacek Anaszewski
facilities from the LED Flash Class and provided external_strobe_set op in v4l2-flash. LED subsystem should be strobe provider agnostic. Thanks, Jacek Anaszewski Jacek Anaszewski (19): leds: Add LED Flash class extension to the LED subsystem Documentation: leds: Add description of LED

[PATCH/RFC v9 01/19] leds: Add LED Flash class extension to the LED subsystem

2014-12-03 Thread Jacek Anaszewski
design assumes that V4L2 sub-device can take of the LED class device control and communicate with it through the kernel internal interface. When V4L2 Flash sub-device file is opened, the LED class device sysfs interface is made unavailable. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc

Re: [PATCH/RFC v9 01/19] leds: Add LED Flash class extension to the LED subsystem

2014-12-04 Thread Jacek Anaszewski
Hi Sakari, Thanks for the review. On 12/03/2014 05:50 PM, Sakari Ailus wrote: Hi Jacek, Thanks for the update. A few comments below. On Wed, Dec 03, 2014 at 05:06:36PM +0100, Jacek Anaszewski wrote: Some LED devices support two operation modes - torch and flash. This patch provides support

Re: [PATCH/RFC v9 02/19] Documentation: leds: Add description of LED Flash class extension

2014-12-04 Thread Jacek Anaszewski
Hi Sakari, Thanks for the review. On 12/03/2014 06:08 PM, Sakari Ailus wrote: Hi Jacek, On Wed, Dec 03, 2014 at 05:06:37PM +0100, Jacek Anaszewski wrote: The documentation being added contains overall description of the LED Flash Class and the related sysfs attributes. Signed-off-by: Jacek

Re: [PATCH/RFC v9 05/19] leds: Add support for max77693 mfd flash cell

2014-12-04 Thread Jacek Anaszewski
Hi Sakari, Thanks for the review. On 12/04/2014 10:39 AM, Sakari Ailus wrote: Hi Jacek, On Wed, Dec 03, 2014 at 05:06:40PM +0100, Jacek Anaszewski wrote: This patch adds led-flash support to Maxim max77693 chipset. A device can be exposed to user space through LED subsystem sysfs interface

Re: [PATCH/RFC v9 06/19] DT: Add documentation for the mfd Maxim max77693

2014-12-04 Thread Jacek Anaszewski
Hi Sakari, Thanks for the review. On 12/04/2014 11:07 AM, Sakari Ailus wrote: Hi Jacek, On Wed, Dec 03, 2014 at 05:06:41PM +0100, Jacek Anaszewski wrote: This patch adds device tree binding documentation for the flash cell of the Maxim max77693 multifunctional device. Signed-off-by: Jacek

Re: [PATCH/RFC v9 06/19] DT: Add documentation for the mfd Maxim max77693

2014-12-08 Thread Jacek Anaszewski
Hi Pavel, On 12/04/2014 05:12 PM, Pavel Machek wrote: Hi! +- maxim,boost-mode : + In boost mode the device can produce up to 1.2A of total current + on both outputs. The maximum current on each output is reduced + to 625mA then. If there are two child led nodes defined then b

Re: [PATCH/RFC v8 02/14] Documentation: leds: Add description of LED Flash class extension

2014-12-08 Thread Jacek Anaszewski
have to be different than for the devices which don't clear faults on readout. In case of devices which use writing to clear error code - I'd do that after reading flash_fault attribute, in the same callback. Best Regards, Jacek Anaszewski -- To unsubscribe from this list: send the lin

Re: [PATCH/RFC v8 01/14] leds: Add LED Flash class extension to the LED subsystem

2014-12-08 Thread Jacek Anaszewski
On 12/05/2014 08:27 PM, Bryan Wu wrote: On Fri, Nov 28, 2014 at 1:17 AM, Jacek Anaszewski wrote: Some LED devices support two operation modes - torch and flash. This patch provides support for flash LED devices in the LED subsystem by introducing new sysfs attributes and kernel internal

Re: [PATCH/RFC v8 02/14] Documentation: leds: Add description of LED Flash class extension

2014-12-09 Thread Jacek Anaszewski
Hi Pavel, On 12/08/2014 09:18 PM, Pavel Machek wrote: On Mon 2014-12-08 17:55:20, Jacek Anaszewski wrote: On 12/06/2014 01:43 PM, Pavel Machek wrote: The format of a sysfs attribute should be concise. The error codes are generic and map directly to the V4L2 Flash error codes. Actually

Re: [PATCH/RFC v9 04/19] mfd: max77693: adjust max77693_led_platform_data

2014-12-09 Thread Jacek Anaszewski
On 12/09/2014 09:50 AM, Lee Jones wrote: On Wed, 03 Dec 2014, Jacek Anaszewski wrote: Add "label" array for Device Tree strings with the name of a LED device and make flash_timeout a two element array, for caching the sub-led related flash timeout. Added is also an array for cachin

Re: [PATCH/RFC v9 03/19] mfd: max77693: Modify flash cell name identifiers

2014-12-09 Thread Jacek Anaszewski
On 12/09/2014 09:52 AM, Lee Jones wrote: On Wed, 03 Dec 2014, Jacek Anaszewski wrote: Change flash cell identifiers from max77693-flash to max77693-led to avoid confusion with NOR/NAND Flash. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Chanwoo Choi Cc: Lee Jones

Re: [PATCH/RFC v9 04/19] mfd: max77693: adjust max77693_led_platform_data

2014-12-09 Thread Jacek Anaszewski
On 12/09/2014 11:04 AM, Lee Jones wrote: On Tue, 09 Dec 2014, Jacek Anaszewski wrote: On 12/09/2014 09:50 AM, Lee Jones wrote: On Wed, 03 Dec 2014, Jacek Anaszewski wrote: Add "label" array for Device Tree strings with the name of a LED device and make flash_timeout a two element

Re: [PATCH/RFC v9 01/19] leds: Add LED Flash class extension to the LED subsystem

2014-12-09 Thread Jacek Anaszewski
Hi Sakari, On 12/09/2014 01:36 PM, Sakari Ailus wrote: Hi Jacek, On Thu, Dec 04, 2014 at 10:29:10AM +0100, Jacek Anaszewski wrote: ... +static struct attribute *led_flash_strobe_attrs[] = { + &dev_attr_flash_strobe.attr, + NULL, +}; + +static struct attri

Re: [PATCH/RFC v9 02/19] Documentation: leds: Add description of LED Flash class extension

2014-12-09 Thread Jacek Anaszewski
7;device-prefix'? Best Regards, Jacek Anaszewski -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH/RFC v9 04/19] mfd: max77693: adjust max77693_led_platform_data

2014-12-09 Thread Jacek Anaszewski
On 12/09/2014 02:50 PM, Lee Jones wrote: On Tue, 09 Dec 2014, Jacek Anaszewski wrote: On 12/09/2014 11:04 AM, Lee Jones wrote: On Tue, 09 Dec 2014, Jacek Anaszewski wrote: On 12/09/2014 09:50 AM, Lee Jones wrote: On Wed, 03 Dec 2014, Jacek Anaszewski wrote: Add "label" array

Re: [PATCH/RFC v9 06/19] DT: Add documentation for the mfd Maxim max77693

2014-12-09 Thread Jacek Anaszewski
Hi Sakari, On 12/09/2014 03:09 PM, Sakari Ailus wrote: Hi Jacek, On Thu, Dec 04, 2014 at 12:40:48PM +0100, Jacek Anaszewski wrote: + the flash/torch. +- maxim,trigger : Array of flags indicating which trigger can activate given led + in order: fled1, fled2

Re: [PATCH/RFC v9 06/19] DT: Add documentation for the mfd Maxim max77693

2014-12-10 Thread Jacek Anaszewski
Hi Sakari, On 12/04/2014 12:40 PM, Jacek Anaszewski wrote: On 12/04/2014 11:07 AM, Sakari Ailus wrote: Hi Jacek, On Wed, Dec 03, 2014 at 05:06:41PM +0100, Jacek Anaszewski wrote: This patch adds device tree binding documentation for the flash cell of the Maxim max77693 multifunctional

Re: [PATCH/RFC v9 04/19] mfd: max77693: adjust max77693_led_platform_data

2014-12-10 Thread Jacek Anaszewski
On 12/09/2014 03:41 PM, Lee Jones wrote: On Tue, 09 Dec 2014, Jacek Anaszewski wrote: On 12/09/2014 02:50 PM, Lee Jones wrote: On Tue, 09 Dec 2014, Jacek Anaszewski wrote: On 12/09/2014 11:04 AM, Lee Jones wrote: On Tue, 09 Dec 2014, Jacek Anaszewski wrote: On 12/09/2014 09:50 AM, Lee

Re: [PATCH/RFC v9 06/19] DT: Add documentation for the mfd Maxim max77693

2014-12-10 Thread Jacek Anaszewski
... }; }; Feel free to propose better name for the property, I guess we need to avoid "maxim,current-sources" due to ambiguity of the word "current". For me this sounds reasonable. Moreover we will avoid the need for address-cells and size-cells properti

Re: [PATCH/RFC v8 02/14] Documentation: leds: Add description of LED Flash class extension

2014-12-10 Thread Jacek Anaszewski
On 12/09/2014 04:50 PM, Pavel Machek wrote: On Tue 2014-12-09 09:54:06, Jacek Anaszewski wrote: Hi Pavel, On 12/08/2014 09:18 PM, Pavel Machek wrote: On Mon 2014-12-08 17:55:20, Jacek Anaszewski wrote: On 12/06/2014 01:43 PM, Pavel Machek wrote: The format of a sysfs attribute should be

Re: [PATCH/RFC v9 05/19] leds: Add support for max77693 mfd flash cell

2014-12-11 Thread Jacek Anaszewski
Hi Sakari, On 12/09/2014 02:11 PM, Sakari Ailus wrote: Hi Jacek, On Thu, Dec 04, 2014 at 12:06:59PM +0100, Jacek Anaszewski wrote: Hi Sakari, Thanks for the review. You're welcome! :-) On 12/04/2014 10:39 AM, Sakari Ailus wrote: Hi Jacek, On Wed, Dec 03, 2014 at 05:06:40PM +0100,

Re: [PATCH/RFC v9 08/19] leds: Add driver for AAT1290 current regulator

2014-12-11 Thread Jacek Anaszewski
Hi Sakari, Thanks for the review. On 12/11/2014 03:16 PM, Sakari Ailus wrote: Hi Jacek, On Wed, Dec 03, 2014 at 05:06:43PM +0100, Jacek Anaszewski wrote: This patch adds a driver for the 1.5A Step-Up Current Regulator for Flash LEDs. The device is programmed through a Skyworks proprietary

Re: [PATCH] [media] s5p-jpeg: Adding Exynos7 Jpeg variant support

2014-12-17 Thread Jacek Anaszewski
efine EXYNOS4_ENC_FMT_GRAY (0 << EXYNOS4_ENC_FMT_SHIFT) #define EXYNOS4_ENC_FMT_YUV_444 (1 << EXYNOS4_ENC_FMT_SHIFT) #define EXYNOS4_ENC_FMT_YUV_422 (2 << EXYNOS4_ENC_FMT_SHIFT) @@ -303,8 +308,10 @@ #define EXYN

[PATCH/RFC v6 1/2] media: Add registration helpers for V4L2 flash

2014-09-22 Thread Jacek Anaszewski
used. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Sakari Ailus Cc: Hans Verkuil Cc: Bryan Wu Cc: Richard Purdie --- drivers/media/v4l2-core/Kconfig | 11 + drivers/media/v4l2-core/Makefile |2 + drivers/media/v4l2-core/v4l2-flash.c |

[PATCH/RFC v6 2/2] exynos4-is: Add support for v4l2-flash subdevs

2014-09-22 Thread Jacek Anaszewski
This patch adds suppport for external v4l2-flash devices. The support includes parsing camera-flash DT property and asynchronous subdevice registration. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Sylwester Nawrocki --- drivers/media/platform/exynos4-is/media-dev.c | 36

[PATCH/RFC v6 1/3] leds: implement sysfs interface locking mechanism

2014-09-22 Thread Jacek Anaszewski
of led_sysfs_is_disabled function. Such a design allows for providing immediate feedback to the user space on whether the LED Flash Class device is available or is under V4L2 Flash sub-device control. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie

[PATCH/RFC v6 2/3] leds: add API for setting torch brightness

2014-09-22 Thread Jacek Anaszewski
vices, whereas triggers will still call brightness op in both cases. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie --- drivers/leds/led-class.c |9 +++-- drivers/leds/led-core.c | 14 ++ include/linux/leds.h |

[PATCH/RFC v6 0/3] LED / flash API integration - LED Flash Class

2014-09-22 Thread Jacek Anaszewski
: - removed flash manager framework - its implementation needs further thorough discussion. - removed external strobe facilities from the LED Flash Class and provided external_strobe_set op in v4l2-flash. LED subsystem should be strobe provider agnostic. Thanks, Jacek Anaszewski [1] https

[PATCH/RFC v6 0/2] LED / flash API integration - V4L2 Flash

2014-09-22 Thread Jacek Anaszewski
: - removed flash manager framework - its implementation needs further thorough discussion. - removed external strobe facilities from the LED Flash Class and provided external_strobe_set op in v4l2-flash. LED subsystem should be strobe provider agnostic. Thanks, Jacek Anaszewski [1] https

[PATCH/RFC v6 3/3] leds: Add LED Flash Class wrapper to LED subsystem

2014-09-22 Thread Jacek Anaszewski
sub-device can take of the LED class device control and communicate with it through the kernel internal interface. When V4L2 Flash sub-device file is opened, the LED class device sysfs interface is made unavailable. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc

[PATCH/RFC v6 2/2] leds: Add driver for AAT1290 current regulator

2014-09-22 Thread Jacek Anaszewski
This patch adds a driver for the 1.5A Step-Up Current Regulator for Flash LEDs. The device is programmed through a Skyworks' proprietary AS2Cwire serial digital interface. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie --- drivers/leds/Kc

[PATCH/RFC v6 1/2] leds: Add support for max77693 mfd flash cell

2014-09-22 Thread Jacek Anaszewski
be triggered externally or by software. Signed-off-by: Jacek Anaszewski Signed-off-by: Andrzej Hajda Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie Cc: SangYoung Son Cc: Samuel Ortiz --- drivers/leds/Kconfig |9 + drivers/leds/Makefile|1 + drivers/leds

[PATCH/RFC v6 0/6] LED / flash API integration - Documentation

2014-09-22 Thread Jacek Anaszewski
: - removed flash manager framework - its implementation needs further thorough discussion. - removed external strobe facilities from the LED Flash Class and provided external_strobe_set op in v4l2-flash. LED subsystem should be strobe provider agnostic. Thanks, Jacek Anaszewski [1] https

[PATCH/RFC v6 0/2] LED / flash API integration - LED Flash Class drivers

2014-09-22 Thread Jacek Anaszewski
: - removed flash manager framework - its implementation needs further thorough discussion. - removed external strobe facilities from the LED Flash Class and provided external_strobe_set op in v4l2-flash. LED subsystem should be strobe provider agnostic. Thanks, Jacek Anaszewski [1] https

[PATCH/RFC v6 1/6] Documentation: leds: Add description of LED Flash Class extension

2014-09-22 Thread Jacek Anaszewski
The documentation being added contains overall description of the LED Flash Class and the related sysfs attributes. There are also chapters devoted specifically to the Flash Manager feature. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Bryan Wu Cc: Richard Purdie

[PATCH/RFC v6 2/6] DT: leds: Add flash led devices related properties

2014-09-22 Thread Jacek Anaszewski
Addition of a LED Flash Class extension entails the need for flash led specific device tree properties. The properties being added are: iout-torch, iout-flash, iout-indicator and flash-timeout. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Stephen Warren Cc: Grant Likely Cc: Rob

[PATCH/RFC v6 4/6] DT: Add documentation for the mfd Maxim max77693

2014-09-22 Thread Jacek Anaszewski
This patch adds device tree binding documentation for the flash cell of the Maxim max77693 multifunctional device. Signed-off-by: Jacek Anaszewski Signed-off-by: Andrzej Hajda Acked-by: Kyungmin Park Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala

[PATCH/RFC v6 6/6] DT: Add documentation for the Skyworks AAT1290

2014-09-22 Thread Jacek Anaszewski
This patch adds device tree binding documentation for 1.5A Step-Up Current Regulator for Flash LEDs. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala --- .../devicetree/bindings/leds/leds-aat1290.txt

[PATCH/RFC v6 5/6] of: Add Skyworks Solutions, Inc. vendor prefix

2014-09-22 Thread Jacek Anaszewski
Use "skyworks" as the vendor prefix for the Skyworks Solutions, Inc. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala --- .../devicetree/bindings/vendor-prefixes.txt|1 + 1 file

[PATCH/RFC v6 3/6] DT: Add documentation for exynos4-is 'flashes' property

2014-09-22 Thread Jacek Anaszewski
This patch adds a description of 'flashes' property to the samsung-fimc.txt. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala --- .../devicetree/bindings/media/samsung-fimc.txt |5 +++

[PATCH/RFC 1/1] Add a libv4l plugin for Exynos4 camera

2014-10-08 Thread Jacek Anaszewski
particular sub-device. The plugin performs single plane <-> multi plane API conversion, video pipeline linking and takes care of automatic data format negotiation for the whole pipeline, after intercepting VIDIOC_S_FMT or VIDIOC_TRY_FMT ioctls. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Pa

[PATCH 2/3] exynos4-is: Add support for asynchronous sub-devices power on

2014-10-08 Thread Jacek Anaszewski
From: Sylwester Nawrocki Schedule sub-devices power up in separate thread to speed up video device open and to allow some ioctls, like VIDIOC_REQBUFS to be run in parallel. We synchronize with completion of the power up sequence before starting streaming on subdevices, as they require to be powe

[PATCH/RFC 0/1] Libv4l: Add a plugin for the Exynos4 camera

2014-10-08 Thread Jacek Anaszewski
't be normally required but format negotiation error is reported by gstreamer without it. I am investigating the issue. Thanks, Jacek Anaszewski [1] http://www.spinics.net/lists/dri-devel/msg66494.html Jacek Anaszewski (1): Add a libv4l plugin for Exynos4 camera configure.ac

[PATCH 3/3] exynos4-is: Open shouldn't fail when sensor entity is not linked

2014-10-08 Thread Jacek Anaszewski
o the moment when streamon callback is called. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park --- drivers/media/platform/exynos4-is/media-dev.c | 45 ++--- 1 file changed, 41 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/exynos4-is/media-dev.c b/dr

[PATCH 1/3] async: Add async_domain_init_exclusive() helper

2014-10-08 Thread Jacek Anaszewski
From: Sylwester Nawrocki Add a helper to allow initialization of struct async_domain at runtime. Signed-off-by: Sylwester Nawrocki Acked-by: Kyungmin Park --- include/linux/async.h |6 ++ 1 file changed, 6 insertions(+) diff --git a/include/linux/async.h b/include/linux/async.h index

Re: [PATCH/RFC 1/1] Add a libv4l plugin for Exynos4 camera

2014-10-08 Thread Jacek Anaszewski
Hi Hans, On 10/08/2014 02:42 PM, Hans de Goede wrote: Hi, On 10/08/2014 10:46 AM, Jacek Anaszewski wrote: The plugin provides support for the media device on Exynos4 SoC. Added is also a media device configuration file parser. The media configuration file is used for conveying information

Re: [PATCH/RFC 1/1] Add a libv4l plugin for Exynos4 camera

2014-10-09 Thread Jacek Anaszewski
On 10/08/2014 05:49 PM, Antonio Ospite wrote: On Wed, 08 Oct 2014 15:22:43 +0200 Jacek Anaszewski wrote: Hi Hans, On 10/08/2014 02:42 PM, Hans de Goede wrote: Hi, On 10/08/2014 10:46 AM, Jacek Anaszewski wrote: The plugin provides support for the media device on Exynos4 SoC. Added is also

Re: [PATCH/RFC 1/1] Add a libv4l plugin for Exynos4 camera

2014-10-10 Thread Jacek Anaszewski
Hi, On 10/09/2014 10:20 AM, Hans de Goede wrote: Hi, On 10/08/2014 03:22 PM, Jacek Anaszewski wrote: Hi Hans, On 10/08/2014 02:42 PM, Hans de Goede wrote: +} + +/* refresh device topology data after linking */ +release_entities(mdev); + +ret = get_device_topology(mdev

<    2   3   4   5   6   7   8   >