Re: [PATCH v3 0/4] AS3645A fixes

2017-09-22 Thread Jacek Anaszewski
bindings to a release? I've dropped the patches related to LED naming and > label property as the discusion appears to continue on that. No problem. One question - isn't patch 3/4 missing? Best regards, Jacek Anaszewski > Thanks. > > > since v2: > > - Drop patches rela

Re: [RESEND PATCH v2 4/6] dt: bindings: as3645a: Improve label documentation, DT example

2017-09-22 Thread Jacek Anaszewski
On 09/20/2017 10:53 PM, Rob Herring wrote: > On Tue, Sep 19, 2017 at 11:01:02PM +0200, Jacek Anaszewski wrote: >> Hi Pavel, >> >> On 09/18/2017 10:54 PM, Pavel Machek wrote: >>> On Mon 2017-09-18 17:49:23, Sakari Ailus wrote: >>>> Hi Pavel, >>>>

Re: [PATCH v3 0/4] AS3645A fixes

2017-09-23 Thread Jacek Anaszewski
Hi Sakari, On 09/22/2017 11:25 PM, Sakari Ailus wrote: > Hi Jacek, > > (Fixed DT list address.) > > Jacek Anaszewski wrote: >> Hi Sakari, >> >> On 09/22/2017 11:32 AM, Sakari Ailus wrote: >>> Hi Jacek and others, >>> >>> Here are a

Re: [RESEND PATCH v2 4/6] dt: bindings: as3645a: Improve label documentation, DT example

2017-09-23 Thread Jacek Anaszewski
On 09/22/2017 11:07 PM, Jacek Anaszewski wrote: > On 09/20/2017 10:53 PM, Rob Herring wrote: >> On Tue, Sep 19, 2017 at 11:01:02PM +0200, Jacek Anaszewski wrote: >>> Hi Pavel, >>> >>> On 09/18/2017 10:54 PM, Pavel Machek wrote: >>>> On Mon 2017-09

Re: [PATCH 0/3] AS3645A fixes

2017-09-08 Thread Jacek Anaszewski
--- > arch/arm/boot/dts/omap3-n950-n9.dtsi | 10 +--- > drivers/leds/leds-as3645a.c| 28 > +++--- > 3 files changed, 50 insertions(+), 16 deletions(-) > Acked-by: Jacek Anaszewski <jacek.anaszew...@gmail.com> -- Best regards, Jacek Anaszewski

Re: [PATCH v9 18/24] as3645a: Switch to fwnode property API

2017-09-09 Thread Jacek Anaszewski
linux-leds list on cc when touching areas related to LED/flash devices? Thanks in advance. Best regards, Jacek Anaszewski On 09/08/2017 03:18 PM, Sakari Ailus wrote: > Switch the as3645a from OF to the fwnode property API. Also add ACPI > support. > > Signed-off-by: Sakari Ailu

Re: as3645a flash userland interface

2017-09-12 Thread Jacek Anaszewski
is. LED class device name pattern is well defined to devicename:colour:function (see Documentation/leds/leds-class.txt, "LED Device Naming" section). In this case "flash" in place of the "function" segment makes the things clear enough I suppose. -- Best regards, Jacek Anaszewski

Re: [PATCH v9 18/24] as3645a: Switch to fwnode property API

2017-09-11 Thread Jacek Anaszewski
Hi Sakari, On 09/09/2017 11:36 PM, Sakari Ailus wrote: > Hi Jacek, > > On Sat, Sep 09, 2017 at 09:06:41PM +0200, Jacek Anaszewski wrote: >> Hi Sakari, >> >> I've come across this patch only by a chance. I believe that merging >> leds-as3645a.c pa

Re: [PATCH v2.1 2/3] leds: as3645a: Add LED flash class driver

2017-08-21 Thread Jacek Anaszewski
Hi Sakari, On 08/21/2017 03:53 PM, Sakari Ailus wrote: > Hi Jacek, > > Jacek Anaszewski wrote: >> Hi Sakari, >> >> Thanks for the update. >> I've noticed that you added node labels to the child device nodes >> in [0]: >> >> "a

Re: [PATCH v2.1 2/3] leds: as3645a: Add LED flash class driver

2017-08-20 Thread Jacek Anaszewski
nst the approach I proposed in the previous review?: snprintf(names->flash, sizeof(names->flash), AS_NAME":%s", node->name); Best regards, Jacek Anaszewski On 08/19/2017 11:42 PM, Sakari Ailus wrote: > From: Sakari Ailus <sakari.ai...@iki.fi> > &g

Re: [PATCH v2.1 2/3] leds: as3645a: Add LED flash class driver

2017-08-20 Thread Jacek Anaszewski
Forgot to add a link to the referenced patch: [0] http://www.spinics.net/lists/devicetree/msg191273.html On 08/20/2017 12:09 PM, Jacek Anaszewski wrote: > Hi Sakari, > > Thanks for the update. > I've noticed that you added node labels to the child device nodes > in [0]: >

Re: [RESEND PATCH v2 4/6] dt: bindings: as3645a: Improve label documentation, DT example

2017-11-18 Thread Jacek Anaszewski
our' DT property as a solution? Best regards, Jacek Anaszewski On 09/23/2017 11:12 PM, Jacek Anaszewski wrote: > On 09/22/2017 11:07 PM, Jacek Anaszewski wrote: >> On 09/20/2017 10:53 PM, Rob Herring wrote: >>> On Tue, Sep 19, 2017 at 11:01:02PM +0200, Jacek Anaszewski wrote: >&g

Re: [PATCH] media: s5p-jpeg: don't return a value on a void function

2018-04-20 Thread Jacek Anaszewski
EXYNOS3250_JPGINTST); > } > > unsigned int exynos3250_jpeg_operating(void __iomem *regs) > Reviewed-by: Jacek Anaszewski <jacek.anaszew...@gmail.com> -- Best regards, Jacek Anaszewski

<    3   4   5   6   7   8