[Q] media: V4L2 compressed frames and s_fmt.

7; the maximum buffer size to store a compressed frame. However, it does not mention anything special about width and height. Does it make sense setting width and height for h.264/mpeg4 formats? [1] http://v4l2spec.bytesex.org/spec/c2030.htm#V4L2-PIX-FORMAT -- Javier Martin Vista Silicon S.L. CDTUC

Re: [Q] media: V4L2 compressed frames and s_fmt.

Hi Kamil, Sakari, thank you for your replies. On 15 March 2012 14:19, Kamil Debski wrote: > Hi Javier, Sakari, > >> From: Sakari Ailus [mailto:sakari.ai...@iki.fi] >> Sent: 15 March 2012 12:04 >> >> Hi Javier, >> >> (Cc Kamil.) >> >> On Wed,

[Q] ov7670: green line in VGA resolution

://kernel.ubuntu.com/git?p=bradf/backup.ubuntu-maverick/.git;a=commitdiff;h=e4182762eaf3c80b2f5c8d1d373409d7c2843579;hp=e770cc1e35a3f11cffd1f38f52060e3e38b4fbf7 But I don't know how these values can be extrapolated to the VGA case. Has anybody found the same issue? Regards. -- Javier Martin

Re: [Q] ov7670: green line in VGA resolution

Hi Jonathan, thank you for your attention. On 19 March 2012 18:44, Jonathan Corbet wrote: > On Mon, 19 Mar 2012 17:27:06 +0100 > javier Martin wrote: > >> I suspect the problem is related to the fact that this sensor has an >> array of 656 x 488 pixels but only 640

[PATCH] media: i.MX2: eMMa-PrP: Allow userptr IO mode.

Userptr can be very useful if this device is requested to use video buffers allocated by another processing device. So that buffers don't need to be copied. Signed-off-by: Javier Martin --- drivers/media/video/mx2_emmaprp.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)

[Q] What sensor does s5K6aa driver support?

as a replacement? Regards. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a me

[PATCH 0/3] media: tvp5150: Fix mbus format to UYUV instead of YUYV.

[PATCH 1/3] media: tvp5150: Fix mbus format. [PATCH 2/3] media: mx2_camera: Fix mbus format handling. [PATCH 3/3] i.MX27: visstrim_m10: Remove use of MX2_CAMERA_SWAP16. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org Mo

[PATCH 1/3] media: tvp5150: Fix mbus format.

According to p.14 fig 3-3 of the datasheet (SLES098A) this decoder transmits data in UYVY format. Signed-off-by: Javier Martin --- drivers/media/video/tvp5150.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/video/tvp5150.c b/drivers/media/video

[PATCH 2/3] media: mx2_camera: Fix mbus format handling.

Remove MX2_CAMERA_SWAP16 and MX2_CAMERA_PACK_DIR_MSB flags so that the driver can negotiate with the attached sensor whether the mbus format needs convertion from UYUV to YUYV or not. Signed-off-by: Javier Martin --- arch/arm/plat-mxc/include/mach/mx2_cam.h |2 - drivers/media/video

[PATCH 3/3] i.MX27: visstrim_m10: Remove use of MX2_CAMERA_SWAP16.

Signed-off-by: Javier Martin --- arch/arm/mach-imx/mach-imx27_visstrim_m10.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-imx/mach-imx27_visstrim_m10.c b/arch/arm/mach-imx/mach-imx27_visstrim_m10.c index 3128cfe..4db00c6 100644 --- a/arch/arm/mach-imx

Re: [PATCH 3/3] i.MX27: visstrim_m10: Remove use of MX2_CAMERA_SWAP16.

On 26 March 2012 14:10, Baruch Siach wrote: > Hi Javier, > > On Mon, Mar 26, 2012 at 01:20:04PM +0200, Javier Martin wrote: >> >> Signed-off-by: Javier Martin >> --- >>  arch/arm/mach-imx/mach-imx27_visstrim_m10.c |    2 +- >>  1 files changed, 1 insertion

[PATCH v2 0/3] media: tvp5150: Fix mbus format to UYUV instead of YUYV.

Changes since v2: - Swap order of patches 3 and 4 to make the series bisectable. [PATCH v2 1/3] media: tvp5150: Fix mbus format. [PATCH v2 2/3] i.MX27: visstrim_m10: Remove use of MX2_CAMERA_SWAP16. [PATCH v2 3/3] media: mx2_camera: Fix mbus format handling. -- To unsubscribe from this list: send

[PATCH v2 1/3] media: tvp5150: Fix mbus format.

According to p.14 fig 3-3 of the datasheet (SLES098A) this decoder transmits data in UYVY format. Signed-off-by: Javier Martin --- drivers/media/video/tvp5150.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/video/tvp5150.c b/drivers/media/video

[PATCH v2 2/3] i.MX27: visstrim_m10: Remove use of MX2_CAMERA_SWAP16.

Signed-off-by: Javier Martin --- arch/arm/mach-imx/mach-imx27_visstrim_m10.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-imx/mach-imx27_visstrim_m10.c b/arch/arm/mach-imx/mach-imx27_visstrim_m10.c index 3128cfe..4db00c6 100644 --- a/arch/arm/mach-imx

[PATCH v2 3/3] media: mx2_camera: Fix mbus format handling.

Remove MX2_CAMERA_SWAP16 and MX2_CAMERA_PACK_DIR_MSB flags so that the driver can negotiate with the attached sensor whether the mbus format needs convertion from UYUV to YUYV or not. Signed-off-by: Javier Martin --- arch/arm/plat-mxc/include/mach/mx2_cam.h |2 - drivers/media/video

Re: [v7] media: coda: Add driver for Coda video codec.

erent chips later is as straightforward as possible. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe from this list: send the line "unsubscribe linux-media&

Vacations.

. [PATCH 2/4] media: mx2_camera: Mark i.MX25 support as BROKEN. [PATCH 3/4] Schedule removal of i.MX25 support in mx2_camera.c [PATCH v2] media: mx2_camera: Fix clock handling for i.MX27. For Sascha: [PATCH v2] Visstrim SM10: Use mo_version to decide board video mode. Regards. -- Javier Martin

Re: [v7] media: coda: Add driver for Coda video codec.

.linuxtv.org/media_tree.git/commitdiff/186b250a07253770717f41eee911b8c5467be04e?hp=6d8c4529f8058b4e8c902fe689786877f2224060 > > Still, how did you test this v4l2 device? Using V4L2 API in a mem2mem basis, i.e. the driver has one output and one capture interface that must be configured independen

Re: [PATCH] media: mx2_camera: Remove MX2_CAMERA_SWAP16 and MX2_CAMERA_PACK_DIR_MSB flags.

Hi, On 30 July 2012 17:33, Guennadi Liakhovetski wrote: > Hi Javier > > On Mon, 30 Jul 2012, javier Martin wrote: > >> Hi, >> thank you for yor ACKs. >> >> On 20 July 2012 13:31, Guennadi Liakhovetski wrote: >> > On Thu, 12 Jul 2012, Javier Martin w

[PATCH v3] media: mx2_camera: Don't modify non volatile parameters in try_fmt.

Signed-off-by: Javier Martin --- Changes since v2: - Add Signed-off-by line. --- drivers/media/video/mx2_camera.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/video/mx2_camera.c b/drivers/media/video/mx2_camera.c index 2a33bcb..88dcae6 100644 --- a

Re: [PATCH] media: coda: remove duplicated call of fh_to_ctx in vidioc_s_fmt_vid_out

riv), f); > + ret = vidioc_s_fmt(ctx, f); > if (ret) > ctx->colorspace = f->fmt.pix.colorspace; > > -- > 1.7.9.5 > > Good catch. Acked-by: Javier Martin -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/

Re: [PATCH] coda: Add V4L2_CAP_VIDEO_M2M capability flag

On 22 August 2012 23:00, Sylwester Nawrocki wrote: > New mem-to-mem video drivers should use V4L2_CAP_VIDEO_M2M capability, rather > than ORed V4L2_CAP_VIDEO_CAPTURE and V4L2_CAP_VIDEO_OUTPUT flags, as outlined > in commit a1367f1b260d29e9b9fb20d8e2f39f1e74fa6c3b. > > Cc: Javier M

Re: [PATCH] m2m-deinterlace: Add V4L2_CAP_VIDEO_M2M capability flag

On 22 August 2012 23:00, Sylwester Nawrocki wrote: > New mem-to-mem video drivers should use V4L2_CAP_VIDEO_M2M capability, rather > than ORed V4L2_CAP_VIDEO_CAPTURE and V4L2_CAP_VIDEO_OUTPUT flags, as outlined > in commit a1367f1b260d29e9b9fb20d8e2f39f1e74fa6c3b. > > Cc: Javier M

Re: [PATCH 05/10] coda: Remove unneeded struct vb2_queue clear on queue_init()

On 23 August 2012 15:08, Ezequiel Garcia wrote: > queue_init() is always called by v4l2_m2m_ctx_init(), which allocates > a context struct v4l2_m2m_ctx with kzalloc. > Therefore, there is no need to clear vb2_queue src/dst structs. > > Cc: Javier Martin > Signed-off-b

Re: [PATCH 07/10] mem2mem-emmaprp: Remove unneeded struct vb2_queue clear on queue_init()

On 23 August 2012 15:08, Ezequiel Garcia wrote: > queue_init() is always called by v4l2_m2m_ctx_init(), which allocates > a context struct v4l2_m2m_ctx with kzalloc. > Therefore, there is no need to clear vb2_queue src/dst structs. > > Cc: Javier Martin > Signed-off-b

Re: [PATCH 03/12] coda: fix IRAM/AXI handling for i.MX53

CODA_FMOPARAM_SLICENUM_MASK 0x0f > +#define CODA7_CMD_ENC_SEQ_SEARCH_BASE 0x1b8 > +#define CODA7_CMD_ENC_SEQ_SEARCH_SIZE 0x1bc > #define CODA_CMD_ENC_SEQ_RC_QP_MAX 0x1c8 >

Re: [PATCH 04/12] media: coda: allocate internal framebuffers separately from v4l2 buffers

ext_dst_buf(ctx->m2m_ctx); > + src_buf = v4l2_m2m_src_buf_remove(ctx->m2m_ctx); > + dst_buf = v4l2_m2m_dst_buf_remove(ctx->m2m_ctx); > > /* Get results from the coda */ > coda_read(dev, CODA_RET_ENC_PIC_TYPE); > @@ -1501,23 +1548,7 @@ static irqre

Re: [PATCH 04/12] media: coda: allocate internal framebuffers separately from v4l2 buffers

On 28 August 2012 09:50, javier Martin wrote: > Hi Phillip, > I see you are trying a cleaner approach for reference and reconstructed > frames. > > On 24 August 2012 18:17, Philipp Zabel wrote: >> Some codecs running on CODA need internal framebuffers for reference and &g

Re: [PATCH 0/12] Initial i.MX5/CODA7 support for the CODA driver

++- > drivers/media/video/coda.c | 367 > ++ > drivers/media/video/coda.h | 21 +--- > 6 files changed, 305

Re: [PATCH 03/12] coda: fix IRAM/AXI handling for i.MX53

On 28 August 2012 10:24, Philipp Zabel wrote: > Hi Javier, > > thank you for the comments, > > Am Montag, den 27.08.2012, 10:59 +0200 schrieb javier Martin: >> Hi Philipp, >> thank you for your patch. Please, find some comments below. >> >> On 24

Re: [PATCH 04/12] media: coda: allocate internal framebuffers separately from v4l2 buffers

On 28 August 2012 10:40, Philipp Zabel wrote: > Hi Javier, > > Am Dienstag, den 28.08.2012, 09:50 +0200 schrieb javier Martin: >> Hi Phillip, >> I see you are trying a cleaner approach for reference and reconstructed >> frames. >> > -#define CO

Re: [PATCH 0/12] Initial i.MX5/CODA7 support for the CODA driver

code2[i] << 16) | bit_code2[i + 1]); fwrite(&data, sizeof(data), 1, f); } fclose(f); } On 28 August 2012 12:17, Gaëtan Carlier wrote: > Hi Javier, > > On 08/28/2012 10:10 AM, javier Martin wrote: >> >> Hi Philipp, >> in order to give you my ACK I need that pa

Re: [PATCH v3 03/16] media: coda: fix IRAM/AXI handling for i.MX53

_QP_MAX 0x1c8 > #defineCODA_QPMAX_OFFSET 0 > #defineCODA_QPMAX_MASK 0x3f > @@ -189,8 +196,14 @@ > #define CODA_RET_ENC_PIC_FLAG 0x1d0 > > /* Set F

Re: [PATCH v3 04/16] media: coda: allocate internal framebuffers separately from v4l2 buffers

_buf_remove(ctx->m2m_ctx); > > /* Get results from the coda */ > coda_read(dev, CODA_RET_ENC_PIC_TYPE); > @@ -1494,23 +1541,7 @@ static irqreturn_t coda_irq_handler(int irq, void > *data) > dst_buf->v4l2_buf.flags &= ~V4L2_BUF_FLAG_KEYFRA

Re: [PATCH v3 07/16] media: coda: stop all queues in case of lockup

IRMWARE_VERNUM(CODA_DX6, 2, 2, 5), > CODA_FIRMWARE_VERNUM(CODA_7541, 13, 4, 29), > @@ -1836,6 +1856,7 @@ static int __devinit coda_probe(struct platform_device > *pdev) > > spin_lock_init(&dev->irqlock); > INIT_LIST_HEAD(&dev->instances); >

Re: [PATCH v3 07/16] media: coda: stop all queues in case of lockup

_FIRMWARE_VERNUM(CODA_DX6, 2, 2, 5), > CODA_FIRMWARE_VERNUM(CODA_7541, 13, 4, 29), > @@ -1836,6 +1856,7 @@ static int __devinit coda_probe(struct platform_device > *pdev) > > spin_lock_init(&dev->irqlock); > INIT_LIST_HEAD(&dev->instances)

Re: [PATCH v3] media: mx2_camera: Don't modify non volatile parameters in try_fmt.

Hi, Guennadi,did you pick this one? Regards. On 20 August 2012 11:49, Javier Martin wrote: > Signed-off-by: Javier Martin > --- > Changes since v2: > - Add Signed-off-by line. > > --- > drivers/media/video/mx2_camera.c |5 +++-- > 1 file changed, 3 insertions(+),

Re: [PATCH v3] media: mx2_camera: Don't modify non volatile parameters in try_fmt.

On 5 September 2012 10:29, Guennadi Liakhovetski wrote: > On Wed, 5 Sep 2012, Guennadi Liakhovetski wrote: > >> Hi Javier >> >> On Mon, 3 Sep 2012, javier Martin wrote: >> >> > Hi, >> > Guennadi,did you pick this one? >> >> Wanted t

Re: [PATCH v4 01/16] media: coda: firmware loading for 64-bit AXI bus width

; + /* Copy the whole firmware image to the code buffer */ > + memcpy(dev->codebuf.vaddr, fw->data, fw->size); > + release_firmware(fw); > + > + ret = coda_hw_init(dev); > if (ret) { > v4l2_err(&dev->v4l2_dev, "HW initialization failed\n"); > return; > -- > 1.7.10.4 > Tested-by: Javier Martin http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 02/16] media: coda: add i.MX53 / CODA7541 platform support

EVICE_TABLE(platform, coda_platform_ids); > #ifdef CONFIG_OF > static const struct of_device_id coda_dt_ids[] = { > { .compatible = "fsl,imx27-vpu", .data = > &coda_platform_ids[CODA_IMX27] }, > + { .compatible = "fsl,imx53-vpu", .data = &coda_devdata[CODA_IMX53] }, > { /* sentinel */ } > }; > MODULE_DEVICE_TABLE(of, coda_dt_ids); > -- > 1.7.10.4 > Tested-by: Javier Martin http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 03/16] media: coda: fix IRAM/AXI handling for i.MX53

0x1c8 > #defineCODA_QPMAX_OFFSET 0 > #defineCODA_QPMAX_MASK 0x3f > @@ -189,8 +196,14 @@ > #define CODA_RET_ENC_PIC_FLAG 0x1d0 > > /* Set Frame Buffer */ > -#define CODA_CMD_SET_FRAME_BUF_NUM 0x180 > -#define CODA_CMD_SET_FRAME_BUF_STRIDE 0x184 > +#define CODA_CMD_SET_FRAME_BUF_NUM 0x180 > +#define CODA_CMD_SET_FRAME_BUF_STRIDE 0x184 > +#define CODA7_CMD_SET_FRAME_AXI_BIT_ADDR 0x190 > +#define CODA7_CMD_SET_FRAME_AXI_IPACDC_ADDR0x194 > +#define CODA7_CMD_SET_FRAME_AXI_DBKY_ADDR 0x198 > +#define CODA7_CMD_SET_FRAME_AXI_DBKC_ADDR 0x19c > +#define CODA7_CMD_SET_FRAME_AXI_OVL_ADDR 0x1a0 > +#define CODA7_CMD_SET_FRAME_SOURCE_BUF_STRIDE 0x1a8 > > /* Encoder Header */ > #define CODA_CMD_ENC_HEADER_CODE 0x180 > -- > 1.7.10.4 > Tested-by: Javier Martin http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 04/16] media: coda: allocate internal framebuffers separately from v4l2 buffers

uf = v4l2_m2m_dst_buf_remove(ctx->m2m_ctx); > > /* Get results from the coda */ > coda_read(dev, CODA_RET_ENC_PIC_TYPE); > @@ -1493,23 +1540,7 @@ static irqreturn_t coda_irq_handler(int irq, void > *data) > dst_buf->v4l2_buf.flags &= ~V4L2_BUF_FLAG_KEYFRAME; > } > > - /* Free previous reference picture if available */ > - if (ctx->reference) { > - v4l2_m2m_buf_done(ctx->reference, VB2_BUF_STATE_DONE); > - ctx->reference = NULL; > - } > - > - /* > -* For the last frame of the gop we don't need to save > -* a reference picture. > -*/ > - v4l2_m2m_dst_buf_remove(ctx->m2m_ctx); > - tmp_buf = v4l2_m2m_src_buf_remove(ctx->m2m_ctx); > - if (ctx->gopcounter == 0) > - v4l2_m2m_buf_done(src_buf, VB2_BUF_STATE_DONE); > - else > - ctx->reference = tmp_buf; > - > + v4l2_m2m_buf_done(src_buf, VB2_BUF_STATE_DONE); > v4l2_m2m_buf_done(dst_buf, VB2_BUF_STATE_DONE); > > ctx->gopcounter--; > -- > 1.7.10.4 > Reviewed-by: Javier Martin Tested-by: Javier Martin http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 05/16] media: coda: ignore coda busy status in coda_job_ready

)) { > - v4l2_dbg(1, coda_debug, &ctx->dev->v4l2_dev, > -"not ready: coda is still busy.\n"); > - return 0; > - } > - > v4l2_dbg(1, coda_debug, &ctx->dev->v4l2_dev, > "job ready\n"); > return 1; > -- > 1.7.10.4 > Tested-by: Javier Martin http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 06/16] media: coda: keep track of active instances

x->idx, &dev->instance_mask); > kfree(ctx); > > return 0; > @@ -1822,6 +1834,7 @@ static int __devinit coda_probe(struct platform_device > *pdev) > } > > spin_lock_init(&dev->irqlock); > + INIT_LIST_HEAD(&dev->instances); > > dev->plat_dev = pdev; > dev->clk_per = devm_clk_get(&pdev->dev, "per"); > -- > 1.7.10.4 > Tested-by: Javier Martin http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 07/16] media: coda: stop all queues in case of lockup

+ mutex_unlock(&dev->dev_mutex); > +} > + > static u32 coda_supported_firmwares[] = { > CODA_FIRMWARE_VERNUM(CODA_DX6, 2, 2, 5), > CODA_FIRMWARE_VERNUM(CODA_7541, 13, 4, 29), > @@ -1835,6 +1860,7 @@ static int __devinit coda_probe(struct platform_device > *pdev) > > spin_lock_init(&dev->irqlock); > INIT_LIST_HEAD(&dev->instances); > + INIT_DELAYED_WORK(&dev->timeout, coda_timeout); > > dev->plat_dev = pdev; > dev->clk_per = devm_clk_get(&pdev->dev, "per"); > -- > 1.7.10.4 > Tested-by: Javier Martin http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 08/16] media: coda: enable user pointer support

MMAP; > + dst_vq->io_modes = VB2_MMAP | VB2_USERPTR; > dst_vq->drv_priv = ctx; > dst_vq->buf_struct_size = sizeof(struct v4l2_m2m_buffer); > dst_vq->ops = &coda_qops; > -- > 1.7.10.4 > Acked-by: Javier Martin http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 09/16] media: coda: wait for picture run completion in start/stop_streaming

ion_done(&dev->done)) > + return; > + > + complete(&dev->done); > + > v4l2_err(&dev->v4l2_dev, "CODA PIC_RUN timeout, stopping all > streams\n"); > > mutex_lock(&dev->dev_mutex); > @@ -1861,6 +1883,8 @@ static int __devinit coda_probe(struct platform_device > *pdev) > spin_lock_init(&dev->irqlock); > INIT_LIST_HEAD(&dev->instances); > INIT_DELAYED_WORK(&dev->timeout, coda_timeout); > + init_completion(&dev->done); > + complete(&dev->done); > > dev->plat_dev = pdev; > dev->clk_per = devm_clk_get(&pdev->dev, "per"); > -- > 1.7.10.4 > Tested-by: Javier Martin http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 10/16] media: coda: fix sizeimage setting in try_fmt

peg-4 */ > - q_data->sizeimage = CODA_MAX_FRAME_SIZE; > - } > + q_data->sizeimage = f->fmt.pix.sizeimage; > > v4l2_dbg(1, coda_debug, &ctx->dev->v4l2_dev, > "Setting format for type %d, wxh: %dx%d, fmt: %d\n", > -- > 1.7.10.4 > Tested-by: Javier Martin http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 11/16] media: coda: add horizontal / vertical flipping support

ROT_270(0x3 > << 0) > +#defineCODA_MIR_NONE (0x0 > << 2) > +#defineCODA_MIR_VER (0x1 > << 2) > +#defineCODA_MIR_HOR(0x2 > << 2) > +#defineCODA_MIR_VER_HOR(0x3 > << 2) > #define CODA_CMD_ENC_PIC_OPTION0x194 > #define CODA_CMD_ENC_PIC_BB_START 0x198 > #define CODA_CMD_ENC_PIC_BB_SIZE 0x19c > -- > 1.7.10.4 > Tested-by: Javier Martin http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 12/16] media: coda: add byte size slice limit control

ossible values for this ctrl and that won't work. > v4l2_ctrl_new_std(&ctx->ctrls, &coda_ctrl_ops, > V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MAX_MB, 1, 0x3fff, 1, 1); > + v4l2_ctrl_new_std(&ctx->ctrls, &coda_ctrl_ops, > + V4L

Re: [PATCH v4 16/16] media: coda: support >1024 px height on CODA7, set max frame size to 1080p

ICHEIGHT_MASK 0x3ff > +#defineCODA7_PICHEIGHT_MASK 0x > #define CODA_CMD_ENC_SEQ_SRC_F_RATE0x194 > #define CODA_CMD_ENC_SEQ_MP4_PARA 0x198 > #defineCODA_MP4PAR

Re: [PATCH v5 12/13] media: coda: add byte size slice limit control

Hi Philipp, it now works properly. On 12 September 2012 17:02, Philipp Zabel wrote: > Signed-off-by: Philipp Zabel > --- > Changes since v4: > - Fix menu_skip_mask for V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MODE v4l2_ctrl. Tested-by: Javier Martin > --- > drivers/media/plat

Re: [PATCH v5 13/13] media: coda: set up buffers to be sized as negotiated with s_fmt

ected buffer size to the maximum > resolution), and userspace queues buffers of smaller size - > corresponding to the negotiated dimensions - were queued. > Explicitly setting sizeimage to the value negotiated via s_fmt > fixes the issue. > > Signed-off-by: Philipp Zabel

Re: [PATCH v5 0/13] Initial i.MX5/CODA7 support for the CODA driver

/media/platform/Kconfig |3 +- > drivers/media/platform/coda.c | 422 > +--- > drivers/media/platform/coda.h | 30 ++- > 3 files changed, 337 insertions(+), 118 deletions(-) > -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de

Re: [PATCH v5 0/13] Initial i.MX5/CODA7 support for the CODA driver

://patchwork.kernel.org/patch/1367011/ https://patchwork.kernel.org/patch/1363331/ https://patchwork.kernel.org/patch/1352551/ Regards. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe

Improving ov7670 sensor driver.

nobody else has addressed it either. Please, correct me if I am wrong:http://patchwork.linuxtv.org/patch/8860/ 7.- Add V4L2_CID_POWER_LINE_FREQUENCY ctrl. Why? Because the platform will be used in several countries. How? As long as point 1 is solved this is quite trivial. The reason of this e-mail

Re: Improving ov7670 sensor driver.

Hi Hans, thank you for your response. On 13 September 2012 12:07, Hans Verkuil wrote: > On Thu 13 September 2012 11:48:17 javier Martin wrote: >> Hi, >> our new i.MX27 based platform (Visstrim-SM20) uses an ov7675 sensor >> attached to the CSI interface. Apparently,

Re: Improving ov7670 sensor driver.

On 13 September 2012 13:00, Hans Verkuil wrote: > On Thu 13 September 2012 12:47:53 javier Martin wrote: >> Hi Hans, >> thank you for your response. >> >> On 13 September 2012 12:07, Hans Verkuil wrote: >> > On Thu 13 September 2012 11:48:17 javier Martin w

Re: [PATCH v5 0/13] Initial i.MX5/CODA7 support for the CODA driver

Hi Philipp, On 13 September 2012 13:24, Philipp Zabel wrote: > Am Donnerstag, den 13.09.2012, 09:51 +0200 schrieb javier Martin: >> If you want to speed up the process and you have you could send a pull >> request to Mauro. > > Should I include the four patches below in the

Re: Improving ov7670 sensor driver.

s. > > Em 13-09-2012 06:48, javier Martin escreveu: >> Hi, >> our new i.MX27 based platform (Visstrim-SM20) uses an ov7675 sensor >> attached to the CSI interface. Apparently, this sensor is fully >> compatible with the old ov7670. For this reason, it seems rather

Alignment problems: arm_memblock_steal() + dma_declare_coherent_memory()

nment requirements. Regards. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a me

Re: [PATCH 27/34] media: mx2_camera: use managed functions to clean up code

1ce2e10b1a ]--- Kernel panic - not syncing: Attempted to kill init! exitcode=0x000b -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe from this list: send the

Re: [PATCH 26/34] media: mx2_camera: remove dead code in mx2_camera_add_device

g dead since commit 2c9ba37 ([media] >> V4L: mx2_camera: remove unsupported i.MX27 DMA mode, make EMMA >> mandatory). It should have been removed together with the commit. >> Remove it now. >> >> Signed-off-by: Shawn Guo >> Cc: Guennadi Liakhovetski >> Cc

Re: [PATCH 28/34] media: mx2_camera: remove mach/hardware.h inclusion

>> platform_device *pdev) >> goto exit; >> } >> >> + pcdev->devtype = pdev->id_entry->driver_data; >> + switch (pcdev->devtype) { >> + case IMX25_CAMERA: >> + pcdev->reg_csisr = CSISR_IMX25; >>

Re: [PATCH 27/34] media: mx2_camera: use managed functions to clean up code

Hi Shawn, On 18 September 2012 09:43, Shawn Guo wrote: > On Mon, Sep 17, 2012 at 03:36:07PM +0200, javier Martin wrote: >> This patch breaks the driver: >> > Javier, > > Can you please apply the following change to see if it fixes the > problem? > > Shawn >

Re: [PATCH 28/34] media: mx2_camera: remove mach/hardware.h inclusion

On 17 September 2012 15:59, Guennadi Liakhovetski wrote: > On Mon, 17 Sep 2012, javier Martin wrote: > >> Hi Shawn, >> >> On 17 September 2012 11:21, Guennadi Liakhovetski >> wrote: >> > On Mon, 17 Sep 2012, Shawn Guo wrote: >> > >> >>

Re: [GIT PULL v2] Initial i.MX5/CODA7 support for the CODA driver

nts.gmane.org/gmane.linux.drivers.video-input-infrastructure/53627 The pull request is a way to tell Mauro this is ready to be merged in his linux-media tree and making things easier for him. Regards. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 390

Re: [GIT PULL v2] Initial i.MX5/CODA7 support for the CODA driver

On 20 September 2012 10:03, Richard Zhao wrote: > On Thu, Sep 20, 2012 at 09:10:46AM +0200, javier Martin wrote: >> Hi Richard, >> >> On 20 September 2012 05:32, Richard Zhao wrote: >> > why is it a request-pull? >> >> After 5 version of Philipp's

[PATCH 0/5] media: ov7670: driver cleanup and support for ov7674.

The following series includes all the changes discussed in [1] that don't affect either bridge drivers that use ov7670 or soc-camera framework For this reason they are considered non controversial and sent separately. At least 1 more series will follow in order to implement all features described i

[PATCH 1/5] media: ov7670: add support for ov7675.

ov7675 and ov7670 share the same registers but there is no way to distinguish them at runtime. However, they require different tweaks to achieve the desired resolution. For this reason this patch adds a new ov7675 entry to the ov7670_id table. Signed-off-by: Javier Martin --- drivers/media/i2c

[PATCH 2/5] media: ov7670: make try_fmt() consistent with 'min_height' and 'min_width'.

'min_height' and 'min_width' are variables that allow to specify the minimum resolution that the sensor will achieve. This patch make v4l2 fmt callbacks consider this parameters in order to return valid data to user space. Signed-off-by: Javier Martin --- drivers/media

[PATCH 4/5] media: ov7670: add possibility to bypass pll for ov7675.

Signed-off-by: Javier Martin --- drivers/media/i2c/ov7670.c | 24 ++-- include/media/ov7670.h |1 + 2 files changed, 23 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/ov7670.c b/drivers/media/i2c/ov7670.c index 175fbfc..54fb535 100644 --- a/drivers

[PATCH 3/5] media: ov7670: calculate framerate properly for ov7675.

will be used for ov7675 only. Signed-off-by: Javier Martin --- drivers/media/i2c/ov7670.c | 122 ++-- 1 file changed, 105 insertions(+), 17 deletions(-) diff --git a/drivers/media/i2c/ov7670.c b/drivers/media/i2c/ov7670.c index 627fe5f..175fbfc 100644

[PATCH 5/5] media: ov7670: Add possibility to disable pixclk during hblank.

Signed-off-by: Javier Martin --- drivers/media/i2c/ov7670.c |8 include/media/ov7670.h |1 + 2 files changed, 9 insertions(+) diff --git a/drivers/media/i2c/ov7670.c b/drivers/media/i2c/ov7670.c index 54fb535..f7e4341 100644 --- a/drivers/media/i2c/ov7670.c +++ b/drivers

Re: [PATCH 0/5] media: ov7670: driver cleanup and support for ov7674.

On 26 September 2012 11:47, Javier Martin wrote: > The following series includes all the changes discussed in [1] that > don't affect either bridge drivers that use ov7670 or soc-camera framework > For this reason they are considered non controversial and sent separately. > At le

Re: [PATCH 1/5] media: ov7670: add support for ov7675.

Hi Jonathan, thank you for your time. On 26 September 2012 18:40, Jonathan Corbet wrote: > This is going to have to be quick, sorry... > > On Wed, 26 Sep 2012 11:47:53 +0200 > Javier Martin wrote: > >> +static struct ov7670_win_size ov7670_win_sizes[2][4] = { >> +

Re: [PATCH 2/5] media: ov7670: make try_fmt() consistent with 'min_height' and 'min_width'.

On 26 September 2012 18:42, Jonathan Corbet wrote: > On Wed, 26 Sep 2012 11:47:54 +0200 > Javier Martin wrote: > >> 'min_height' and 'min_width' are variables that allow to specify the minimum >> resolution that the sensor will achieve. This patch

Re: [PATCH 3/5] media: ov7670: calculate framerate properly for ov7675.

On 26 September 2012 18:50, Jonathan Corbet wrote: > On Wed, 26 Sep 2012 11:47:55 +0200 > Javier Martin wrote: > >> According to the datasheet ov7675 uses a formula to achieve >> the desired framerate that is different from the operations >> done in the current code.

Re: [PATCH 4/5] media: ov7670: add possibility to bypass pll for ov7675.

On 26 September 2012 18:52, Jonathan Corbet wrote: > On Wed, 26 Sep 2012 11:47:56 +0200 > Javier Martin wrote: > >> >> Signed-off-by: Javier Martin > > This one needs a changelog - what does bypassing the PLL do and why might > you want to do it? Otherwise: A

Re: [PATCH 5/5] media: ov7670: Add possibility to disable pixclk during hblank.

On 26 September 2012 18:52, Jonathan Corbet wrote: > On Wed, 26 Sep 2012 11:47:57 +0200 > Javier Martin wrote: > >> Signed-off-by: Javier Martin >> --- >> drivers/media/i2c/ov7670.c |8 >> include/media/ov7670.h |1 + >> 2 files chan

[PATCH v2 0/5] media: ov7670: driver cleanup and support for ov7674.

The following series includes all the changes discussed in [1] that don't affect either bridge drivers that use ov7670 or soc-camera framework For this reason they are considered non controversial and sent separately. At least 1 more series will follow in order to implement all features described i

[PATCH v2 1/5] media: ov7670: add support for ov7675.

ov7675 and ov7670 share the same registers but there is no way to distinguish them at runtime. However, they require different tweaks to achieve the desired resolution. For this reason this patch adds a new ov7675 entry to the ov7670_id table. Signed-off-by: Javier Martin --- Changes since v1

[PATCH v2 3/5] media: ov7670: calculate framerate properly for ov7675.

will be used for ov7675 only. Signed-off-by: Javier Martin --- Changes since v1: - Create separate functions for frame rate control. --- drivers/media/i2c/ov7670.c | 136 ++-- 1 file changed, 118 insertions(+), 18 deletions(-) diff --git a/drivers/media

[PATCH v2 2/5] media: ov7670: make try_fmt() consistent with 'min_height' and 'min_width'.

'min_height' and 'min_width' are variables that allow to specify the minimum resolution that the sensor will achieve. This patch make v4l2 fmt callbacks consider this parameters in order to return valid data to user space. Acked-by: Jonathan Corbet Signed-off-by: Javier

[PATCH v2 4/5] media: ov7670: add possibility to bypass pll for ov7675.

For a frame rate of 30 fps a pixclk of 24MHz is needed. For those cases where the ov7670 has a clean 24MHz input (xvclk) the PLL can be bypassed. This will result in a value of clkrc of 1, which means that in practice pixclk = xvclk (input clock) Acked-by: Jonathan Corbet Signed-off-by: Javier

[PATCH v2 5/5] media: ov7670: Add possibility to disable pixclk during hblank.

Some bridge drivers captures pixels during blanking periods if pixclk is enabled. In order to avoid capturing bogus data we need to disable pixclk in the sensor during those blanking periods. Acked-by: Jonathan Corbet Signed-off-by: Javier Martin --- Changes since v1: - Added changelog

[PATCH 0/3] ov7670: migrate this sensor and its users to ctrl framework.

The following series migrate ov7670 sensor and current users to ctrl framework as discussed in [1]. This has been tested against mx2_camera soc-camera bridge, so tests or acks will be required from people using cam-core and via-camera out there. This will have to be applied on top of my previous

[PATCH 2/3] mcam-core: implement the control framework.

Signed-off-by: Hans Verkuil Signed-off-by: Javier Martin --- drivers/media/platform/marvell-ccic/mcam-core.c | 54 --- drivers/media/platform/marvell-ccic/mcam-core.h |2 + 2 files changed, 11 insertions(+), 45 deletions(-) diff --git a/drivers/media/platform/marvell

[PATCH 3/3] via-camera: implement the control framework.

And added a missing kfree to clean up the via_camera struct. Signed-off-by: Hans Verkuil Signed-off-by: Javier Martin --- drivers/media/platform/via-camera.c | 60 --- 1 file changed, 14 insertions(+), 46 deletions(-) diff --git a/drivers/media/platform/via

[PATCH 1/3] ov7670: use the control framework

Signed-off-by: Hans Verkuil Signed-off-by: Javier Martin --- drivers/media/i2c/ov7670.c | 295 +--- 1 file changed, 115 insertions(+), 180 deletions(-) diff --git a/drivers/media/i2c/ov7670.c b/drivers/media/i2c/ov7670.c index 9d7a92e..eead1b4 100644

Re: [PATCH 1/3] ov7670: use the control framework

Hi Hans, On 28 September 2012 10:23, Hans Verkuil wrote: > On Fri September 28 2012 09:48:01 Javier Martin wrote: >> static const struct v4l2_subdev_core_ops ov7670_core_ops = { >> .g_chip_ident = ov7670_g_chip_ident, >> - .g_ctrl = ov7670_g_ctrl, >> -

[PATCH v2 0/4] ov7670: migrate this sensor and its users to ctrl framework.

The following series migrate ov7670 sensor and current users to ctrl framework as discussed in [1]. This has been tested against mx2_camera soc-camera bridge, so tests or acks will be required from people using cam-core and via-camera out there. This will have to be applied on top of my previous

[PATCH v2 1/4] ov7670: use the control framework

Signed-off-by: Hans Verkuil Signed-off-by: Javier Martin --- Changes since v1: - Use v4l2_ctrl_auto_cluster() for auto_gain and auto_exp. --- drivers/media/i2c/ov7670.c | 310 1 file changed, 112 insertions(+), 198 deletions(-) diff --git a

[PATCH v2 2/4] mcam-core: implement the control framework.

Signed-off-by: Hans Verkuil Signed-off-by: Javier Martin --- drivers/media/platform/marvell-ccic/mcam-core.c | 54 --- drivers/media/platform/marvell-ccic/mcam-core.h |2 + 2 files changed, 11 insertions(+), 45 deletions(-) diff --git a/drivers/media/platform/marvell

[PATCH v2 3/4] via-camera: implement the control framework.

And added a missing kfree to clean up the via_camera struct. Signed-off-by: Hans Verkuil Signed-off-by: Javier Martin --- drivers/media/platform/via-camera.c | 60 --- 1 file changed, 14 insertions(+), 46 deletions(-) diff --git a/drivers/media/platform/via

[PATCH v2 4/4] ov7670: remove legacy ctrl callbacks.

via-camera and mcam-core were the only bridge drivers that used ov7670. Since now they have been moved to use the ctrl framework, the old legacy callbacks in the ov7670 can be removed. Signed-off-by: Javier Martin --- drivers/media/i2c/ov7670.c |7 --- 1 file changed, 7 deletions

Re: [PATCH v2 1/4] ov7670: use the control framework

Hi Hans, On 28 September 2012 13:05, Hans Verkuil wrote: > On Fri September 28 2012 12:50:55 Javier Martin wrote: >> Signed-off-by: Hans Verkuil >> Signed-off-by: Javier Martin >> --- >> Changes since v1: >> - Use v4l2_ctrl_auto_cluster() for auto_gain an

[PATCH v3 0/4] ov7670: migrate this sensor and its users to ctrl framework.

The following series migrate ov7670 sensor and current users to ctrl framework as discussed in [1]. This has been tested against mx2_camera soc-camera bridge, so tests or acks will be required from people using cam-core and via-camera out there. This will have to be applied on top of my previous

[PATCH v3 1/4] ov7670: use the control framework

Reviewed-by: Hans Verkuil Signed-off-by: Javier Martin --- Changes since v2: - Do not use 'cur.val' to get gain value. --- drivers/media/i2c/ov7670.c | 310 1 file changed, 112 insertions(+), 198 deletions(-) diff --git a/drivers/media/

[PATCH v3 4/4] ov7670: remove legacy ctrl callbacks.

via-camera and mcam-core were the only bridge drivers that used ov7670. Since now they have been moved to use the ctrl framework, the old legacy callbacks in the ov7670 can be removed. Reviewed-by: Hans Verkuil Signed-off-by: Javier Martin --- drivers/media/i2c/ov7670.c |7 --- 1 file

<    1   2   3   4   5   >