[PATCH v3 3/4] via-camera: implement the control framework.

2012-09-28 Thread Javier Martin
And added a missing kfree to clean up the via_camera struct. Reviewed-by: Hans Verkuil Signed-off-by: Hans Verkuil Signed-off-by: Javier Martin --- drivers/media/platform/via-camera.c | 60 --- 1 file changed, 14 insertions(+), 46 deletions(-) diff --git a

[PATCH v3 2/4] mcam-core: implement the control framework.

2012-09-28 Thread Javier Martin
Reviewed-by: Hans Verkuil Signed-off-by: Hans Verkuil Signed-off-by: Javier Martin --- drivers/media/platform/marvell-ccic/mcam-core.c | 54 --- drivers/media/platform/marvell-ccic/mcam-core.h |2 + 2 files changed, 11 insertions(+), 45 deletions(-) diff --git a

Re: [PATCH 1/5] media: ov7670: add support for ov7675.

2012-10-08 Thread javier Martin
On 6 October 2012 17:19, Mauro Carvalho Chehab wrote: > Em Thu, 27 Sep 2012 08:58:33 +0200 > javier Martin escreveu: > >> Hi Jonathan, >> thank you for your time. >> >> On 26 September 2012 18:40, Jonathan Corbet wrote: >> > This is going to have to b

Re: [PATCH 2/2] [media]: mx2_camera: Fix regression caused by clock conversion

2012-10-08 Thread javier Martin
s currently working in our Visstrim M10 platform without this patch and I need to test it to confirm whether it breaks something or not. Regards. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60

Re: [PATCH v2 2/2] [media]: mx2_camera: Fix regression caused by clock conversion

2012-10-09 Thread javier Martin
out it. Look: soc-camera-pdrv soc-camera-pdrv.0: Probing soc-camera-pdrv.0 mx2-camera mx2-camera.0: Camera driver attached to camera 0 ov7670 0-0021: chip found @ 0x42 (imx-i2c) [..] mx2-camera mx2-camera.0: Camera driver detached from camera 0 mx2-camera mx2-camera.0: MX2 Camera (CSI) driver probed, clock frequency: 6650

Re: [PATCH v2 2/2] [media]: mx2_camera: Fix regression caused by clock conversion

2012-10-09 Thread javier Martin
clk_emma_ipg); >> clk_disable_unprepare(pcdev->clk_emma_ahb); >> } >> +exit_csi_per: >> + clk_disable_unprepare(pcdev->clk_csi_per); >> +exit_csi_ahb: >> + clk_disable_unprepare(pcdev->clk_csi_ahb); >> exit: >>

Re: [PATCH 1/2] ARM: clk-imx27: Add missing clock for mx2-camera

2012-10-09 Thread javier Martin
lkdev(clk[usb_div], "per", "fsl-usb2-udc"); > clk_register_clkdev(clk[usb_ipg_gate], "ipg", "fsl-usb2-udc"); > clk_register_clkdev(clk[usb_ahb_gate], "ahb", "fsl-usb2-udc"); > -- > 1.7.9.5 > > Tested-by:

Re: [PATCH] [media] coda: Do not use __cancel_delayed_work()

2012-10-09 Thread javier Martin
instead and get >> rid of >> the following warning: >> >> drivers/media/platform/coda.c:1543: warning: '__cancel_delayed_work' is >> deprecated (declared at include/linux/workqueue.h:437) >> >> Signed-off-by: Fabio Estevam > > Ac

Re: [PATCH v3 2/2] [media]: mx2_camera: Fix regression caused by clock conversion

2012-10-24 Thread javier Martin
y find it in clk-imx25.c. Does this >> mean, that this your patch is for i.MX25? But you're saying it's for >> i.MX27. Confused... > > I provide this mx27 clock in the first patch of the series: > http://patchwork.linuxtv.org/patch/14915/ Yes, I made the same mistake.

Re: [PATCH v2 0/5] media: ov7670: driver cleanup and support for ov7674.

2012-10-25 Thread javier Martin
Hi Mauro, do you have any problems with this series? Regards. On 29 September 2012 21:20, Jonathan Corbet wrote: > On Thu, 27 Sep 2012 17:38:20 +0200 > Javier Martin wrote: > >> The following series includes all the changes discussed in [1] that >> don't affect eith

Re: [PATCH v3 0/4] ov7670: migrate this sensor and its users to ctrl framework.

2012-10-25 Thread javier Martin
Hi Mauro, Jon, any more issues related with this series? Regards. On 29 September 2012 21:25, Jonathan Corbet wrote: > On Fri, 28 Sep 2012 13:26:39 +0200 > Javier Martin wrote: > >> The following series migrate ov7670 sensor and current users to ctrl >> framework >>

Re: [PATCH v2 0/5] media: ov7670: driver cleanup and support for ov7674.

2012-10-26 Thread javier Martin
Hi Mauro, On 25 October 2012 18:18, Mauro Carvalho Chehab wrote: > Em Thu, 25 Oct 2012 15:24:49 +0200 > javier Martin escreveu: > >> Hi Mauro, >> do you have any problems with this series? > > It didn't apply here, maybe due to its dependency from your > pre

Re: [PATCH v3 0/4] ov7670: migrate this sensor and its users to ctrl framework.

2012-10-26 Thread javier Martin
Hi Mauro, On 25 October 2012 17:50, Mauro Carvalho Chehab wrote: > Hi Javier, > > Em Thu, 25 Oct 2012 15:27:08 +0200 > javier Martin escreveu: > >> Hi Mauro, Jon, >> any more issues related with this series? > > Patch doesn't apply anymore: > > pat

[PATCH] media: coda: Fix H.264 header alignment.

2012-10-29 Thread javier . martin
From: Javier Martin Length of H.264 headers is variable and thus it might not be aligned for the coda to append the encoded frame. This causes the first frame to overwrite part of the H.264 PPS. In order to solve that, a filler NAL must be added between the headers and the first frame to

[PATCH v2] media: coda: Fix H.264 header alignment.

2012-10-29 Thread javier . martin
From: Javier Martin Length of H.264 headers is variable and thus it might not be aligned for the coda to append the encoded frame. This causes the first frame to overwrite part of the H.264 PPS. In order to solve that, a filler NAL must be added between the headers and the first frame to

[PULL] video_visstrim staging/ov7670_for_v3.7

2012-10-29 Thread Javier Martin
egacy ctrl callbacks. (2012-09-28 13:18:23 +0200) -------- Javier Martin (9): media: ov7670: add support for ov7675. media: ov7670: make try_fmt() consistent with 'min_height' and 'min_width'. media: ov7670

[PATCH 0/4] media: mx2_camera: Remove i.mx25 and clean up.

2012-10-30 Thread Javier Martin
[PATCH 1/4] media: mx2_camera: Remove i.mx25 support. [PATCH 2/4] media: mx2_camera: Add image size HW limits. [PATCH 3/4] media: mx2_camera: Remove 'buf_cleanup' callback. [PATCH 4/4] media: mx2_camera: Remove buffer states. -- To unsubscribe from this list: send the line "unsubscribe linux-media"

[PATCH 1/4] media: mx2_camera: Remove i.mx25 support.

2012-10-30 Thread Javier Martin
i.MX25 support has been broken for several releases now and nobody seems to care about it. Signed-off-by: Javier Martin --- drivers/media/platform/soc_camera/mx2_camera.c | 405 ++-- 1 file changed, 100 insertions(+), 305 deletions(-) diff --git a/drivers/media/platform

[PATCH 2/4] media: mx2_camera: Add image size HW limits.

2012-10-30 Thread Javier Martin
The CSI has some constraints regarding image with. This patch makes sure those requirements are met in try_fmt(). Signed-off-by: Javier Martin --- drivers/media/platform/soc_camera/mx2_camera.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform

[PATCH 3/4] media: mx2_camera: Remove 'buf_cleanup' callback.

2012-10-30 Thread Javier Martin
All necessary tasks to end the streaming properly are already implemented in mx2_stop_streaming() and nothing remains to be done in this callback. Furthermore, it only included debug messages so it can be removed. Signed-off-by: Javier Martin --- drivers/media/platform/soc_camera/mx2_camera.c

[PATCH 4/4] media: mx2_camera: Remove buffer states.

2012-10-30 Thread Javier Martin
After removing i.mx25 support and buf_cleanup() callback, buffer states are not used in the code any longer. Signed-off-by: Javier Martin --- drivers/media/platform/soc_camera/mx2_camera.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/media/platform/soc_camera

Re: [PATCH 1/4] media: mx2_camera: Remove i.mx25 support.

2012-10-30 Thread javier Martin
Hi Guennadi, Fabio, On 30 October 2012 13:29, Guennadi Liakhovetski wrote: > On Tue, 30 Oct 2012, Fabio Estevam wrote: > >> Javier, >> >> On Tue, Oct 30, 2012 at 10:16 AM, Javier Martin >> wrote: >> > i.MX25 support has been broken for several releases >

[PATCH v2 0/4] media: mx2_camera: Remove i.mx25 and clean up.

2012-10-30 Thread Javier Martin
Changes since v1: - Remove i.MX25 support in the Kconfig file too in patch 1. [PATCH v2 1/4] media: mx2_camera: Remove i.mx25 support. [PATCH v2 2/4] media: mx2_camera: Add image size HW limits. [PATCH v2 3/4] media: mx2_camera: Remove 'buf_cleanup' callback. [PATCH v2 4/4] media: mx2_camera: Rem

[PATCH v2 1/4] media: mx2_camera: Remove i.mx25 support.

2012-10-30 Thread Javier Martin
i.MX25 support has been broken for several releases now and nobody seems to care about it. Signed-off-by: Javier Martin --- drivers/media/platform/soc_camera/Kconfig |7 +- drivers/media/platform/soc_camera/mx2_camera.c | 405 ++-- 2 files changed, 103 insertions

[PATCH v2 2/4] media: mx2_camera: Add image size HW limits.

2012-10-30 Thread Javier Martin
The CSI has some constraints regarding image with. This patch makes sure those requirements are met in try_fmt(). Signed-off-by: Javier Martin --- drivers/media/platform/soc_camera/mx2_camera.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform

[PATCH v2 3/4] media: mx2_camera: Remove 'buf_cleanup' callback.

2012-10-30 Thread Javier Martin
All necessary tasks to end the streaming properly are already implemented in mx2_stop_streaming() and nothing remains to be done in this callback. Furthermore, it only included debug messages so it can be removed. Signed-off-by: Javier Martin --- drivers/media/platform/soc_camera/mx2_camera.c

[PATCH v2 4/4] media: mx2_camera: Remove buffer states.

2012-10-30 Thread Javier Martin
After removing i.mx25 support and buf_cleanup() callback, buffer states are not used in the code any longer. Signed-off-by: Javier Martin --- drivers/media/platform/soc_camera/mx2_camera.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/media/platform/soc_camera

[PATCH] media: m2m-deinterlace: Do not set debugging flag to true.

2012-10-30 Thread Javier Martin
Default value should be 'debugging disabled'. Signed-off-by: Javier Martin --- drivers/media/platform/m2m-deinterlace.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/m2m-deinterlace.c b/drivers/media/platform/m2m-deinterlace.c ind

Re: [PATCH 1/4] media: mx2_camera: Remove i.mx25 support.

2012-10-30 Thread javier Martin
On 30 October 2012 15:57, Guennadi Liakhovetski wrote: > On Tue, 30 Oct 2012, javier Martin wrote: > >> Hi Guennadi, Fabio, >> >> On 30 October 2012 13:29, Guennadi Liakhovetski >> wrote: >> > On Tue, 30 Oct 2012, Fabio Estevam wrote: >> > >>

[PATCH] media: ov7670: Allow 32x maximum gain for yuv422.

2012-10-30 Thread Javier Martin
4x gain ceiling is not enough to capture a decent image in conditions of total darkness and only a LED light source. Allow a maximum gain of 32x instead. This doesn't have any drawback since the image quality in 'normal' light conditions is the same. Signed-off-by: Javier Marti

[PATCH 1/2] ARM: i.MX27: Add platform support for IRAM.

2012-11-05 Thread Javier Martin
Add support for IRAM to i.MX27 non-DT platforms using iram_init() function. Signed-off-by: Javier Martin --- arch/arm/mach-imx/mm-imx27.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/mach-imx/mm-imx27.c b/arch/arm/mach-imx/mm-imx27.c index e7e24af..fd2416d 100644 --- a

[PATCH 2/2] media: coda: Use iram_alloc() for codadx6 too.

2012-11-05 Thread Javier Martin
Use this helper function instead of hardcoding the physical address of the IRAM in the i.MX27. Signed-off-by: Javier Martin --- drivers/media/video/Kconfig |2 +- drivers/media/video/coda.c | 18 ++ 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers

Re: [PATCH 1/2] ARM: i.MX27: Add platform support for IRAM.

2012-11-22 Thread javier Martin
On 16 November 2012 13:48, Sascha Hauer wrote: > On Mon, Nov 05, 2012 at 04:59:44PM +0100, Javier Martin wrote: >> Add support for IRAM to i.MX27 non-DT platforms using >> iram_init() function. >> >> Signed-off-by: Javier Martin >> --- >> arch/arm/ma

Re: [PULL] soc-camera for 3.3

2012-01-02 Thread javier Martin
ontroller conversion, so, that > will have to wait at least until 3.4. > > Interestingly, Javier Martin has fixed field_count handling in mx2_camera, > but, apparently, it also has to be fixed in other soc-camera drivers. So, > a patch for that might follow later in the 3.3 cycle. >

[PATCH] media i.MX27 camera: properly detect frame loss.

2012-01-02 Thread Javier Martin
As V4L2 specification states, frame_count must also regard lost frames so that the user can handle that case properly. This patch adds a mechanism to increment the frame counter even when a video buffer is not available and a discard buffer is used. Signed-off-by: Javier Martin --- drivers

Re: [PATCH v4 0/2] Add support form eMMa-PrP in i.MX2 chips as a mem2mem device.

2012-01-02 Thread javier Martin
Hi, do you have any more concerns or comments on this patch? I can't find it in media_tree. Has it been merged somewhere else? Thank you. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.

Re: MEM2MEM devices: how to handle sequence number?

2012-01-02 Thread javier Martin
video source. Is that OK? -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a me

Re: [PATCH] media: vb2: vmalloc-based allocator user pointer handling

2012-01-02 Thread javier Martin
Hi, what is the status of this patch? Did you finally merge it in any tree? I am willing to extend it so that it can support pfn mappings as soon as it's ready. Thank you. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cant

Re: [PATCH] media: tvp5150: Add mbus_fmt callbacks.

2012-01-02 Thread javier Martin
Hi Mauro, any more comments on this? Will you please merge the last version which includes the fixes you requested? Thank you. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com

Re: MEM2MEM devices: how to handle sequence number?

2012-01-02 Thread javier Martin
. But this would break your rule that sequence number introduced at the output queue has to be ignored by the driver. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe

[PATCH 1/2] media: vb2: support userptr for PFN mappings.

2012-01-02 Thread Javier Martin
Some video devices need to use contiguous memory which is not backed by pages as it happens with vmalloc. This patch provides userptr handling for those devices. Signed-off-by: Javier Martin --- drivers/media/video/videobuf2-vmalloc.c | 66 +++--- 1 files changed, 42

[PATCH 2/2] uvcvideo: Allow userptr IO mode.

2012-01-02 Thread Javier Martin
Userptr can be very useful if a UVC camera is requested to use video buffers allocated by another processing device. So that buffers don't need to be copied. Signed-off-by: Javier Martin --- drivers/media/video/uvc/uvc_queue.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

Re: [PATCH v4 0/2] Add support form eMMa-PrP in i.MX2 chips as a mem2mem device.

2012-01-02 Thread javier Martin
On 2 January 2012 22:12, Sylwester Nawrocki wrote: > Hi Javier, > > On 01/02/2012 10:31 AM, javier Martin wrote: >> Hi, >> do you have any more concerns or comments on this patch? >> I can't find it in media_tree. Has it been merged somewhere else? > > If yo

Re: [PATCH 1/2] media: vb2: support userptr for PFN mappings.

2012-01-02 Thread javier Martin
Hi Laurent, thank you for your review. On 2 January 2012 20:00, Laurent Pinchart wrote: > Hi Javier, > > Thanks for the patch. > > On Monday 02 January 2012 15:12:22 Javier Martin wrote: >> Some video devices need to use contiguous memory >> which is not backed

Re: [PATCH v4 0/2] Add support form eMMa-PrP in i.MX2 chips as a mem2mem device.

2012-01-03 Thread javier Martin
Added Mauro to CC. On 3 January 2012 08:43, javier Martin wrote: > On 2 January 2012 22:12, Sylwester Nawrocki wrote: >> Hi Javier, >> >> On 01/02/2012 10:31 AM, javier Martin wrote: >>> Hi, >>> do you have any more concerns or comments on this patch? &g

[PATCH 1/2 v2] media: vb2: support userptr for PFN mappings.

2012-01-03 Thread Javier Martin
Some video devices need to use contiguous memory which is not backed by pages as it happens with vmalloc. This patch provides userptr handling for those devices. --- Changes since v1: - Use vb2_get_contig_userptr() which provides page locking and contiguous memory check. Signed-off-by: Javier

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2012-01-03 Thread javier Martin
ssigns a value of its own: http://lxr.linux.no/#linux+v3.1.6/drivers/media/video/soc_camera.c#L1006 How am I suppose to pass that information to the tvp5150 then? Thank you. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spa

[PATCH 1/2 v3] media: vb2: support userptr for PFN mappings.

2012-01-04 Thread Javier Martin
Some video devices need to use contiguous memory which is not backed by pages as it happens with vmalloc. This patch provides userptr handling for those devices. --- Changes since v2: - Do not grab mm->mmap_sem. Signed-off-by: Javier Martin --- drivers/media/video/videobuf2-vmalloc.c |

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2012-01-04 Thread javier Martin
Hi Guennadi. Thanks for your help. On 3 January 2012 16:05, Guennadi Liakhovetski wrote: > Hi Javier > > On Tue, 3 Jan 2012, javier Martin wrote: > >> Guennadi, >> probably you could answer me some question: >> >> as we agreed I'm trying to implement EN

[PATCH 1/2 v4] media: vb2: support userptr for PFN mappings.

2012-01-04 Thread Javier Martin
Some video devices need to use contiguous memory which is not backed by pages as it happens with vmalloc. This patch provides userptr handling for those devices. --- Changes since v3: - Remove vma_res variable. Signed-off-by: Javier Martin --- drivers/media/video/videobuf2-vmalloc.c | 70

[PATCH v2] media: tvp5150: Add mbus_fmt callbacks.

2012-01-05 Thread Javier Martin
These callbacks allow a host video driver to poll video formats supported by tvp5150. --- Changes since v1: Fix standard handling in tvp5150_mbus_fmt() --- drivers/media/video/tvp5150.c | 67 + 1 files changed, 67 insertions(+), 0 deletions(-) diff --gi

Re: [PATCH 1/2 v4] media: vb2: support userptr for PFN mappings.

2012-01-09 Thread javier Martin
Hi Marek, On 9 January 2012 11:14, Marek Szyprowski wrote: > Hello, > > On Wednesday, January 04, 2012 5:19 PM Javier Martin wrote: > >> Some video devices need to use contiguous memory >> which is not backed by pages as it happens with >> vmalloc. This patch

Re: [PATCH] media i.MX27 camera: properly detect frame loss.

2012-01-09 Thread javier Martin
Hi Guennadi, this is the patch I mentioned that fixes sequence count so that it complies with v4l2 API. Will you please merge? Thank you. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista

Re: [PATCH] media i.MX27 camera: properly detect frame loss.

2012-01-11 Thread javier Martin
Hi Guennadi, thank you for your review. On 10 January 2012 12:00, Guennadi Liakhovetski wrote: > Hi Javier > > On Mon, 2 Jan 2012, Javier Martin wrote: > >> As V4L2 specification states, frame_count must also >> regard lost frames so that the user can handle that >

[PATCH v2] media i.MX27 camera: properly detect frame loss.

2012-01-11 Thread Javier Martin
"frame_count" to -1 instead of using "firstirq" variable. Signed-off-by: Javier Martin --- drivers/media/video/mx2_camera.c | 45 - 1 files changed, 24 insertions(+), 21 deletions(-) diff --git a/drivers/media/video/mx2_camera.c b/drivers/medi

Re: [PATCH 2/2] uvcvideo: Allow userptr IO mode.

2012-01-12 Thread javier Martin
Hi Laurent, FYI Marek has already merged 1/2 into his vb2-fixes branch. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe from this list: send the line

[GIT PATCHES FOR 3.3] mx2 emma-prp mem2mem driver

2012-01-13 Thread Javier Martin
Hi Mauro, The following changes since commit 240ab508aa9fb7a294b0ecb563b19ead000b2463: Mauro Carvalho Chehab (1): [media] [PATCH] don't reset the delivery system on DTV_CLEAR are available in the git repository at: git://github.com/jmartinc/video_visstrim.git for_v3.3 Javier M

[PATCH 0/4] media i.MX27 camera: fix buffer handling and videobuf2 support.

2012-01-20 Thread Javier Martin
The way video buffer handling is programmed for i.MX27 leads to buffers being written when they are not ready. It can be easily checked enabling DEBUG features of the driver. This series migrate the driver to videobuf2 and provide an additional discard queue to make sure all the events are han

[PATCH 1/4] media i.MX27 camera: migrate driver to videobuf2

2012-01-20 Thread Javier Martin
Signed-off-by: Javier Martin --- drivers/media/video/mx2_camera.c | 277 ++ 1 files changed, 128 insertions(+), 149 deletions(-) diff --git a/drivers/media/video/mx2_camera.c b/drivers/media/video/mx2_camera.c index 68038e7..290ac9d 100644 --- a/drivers

[PATCH 2/4] media i.MX27 camera: add start_stream and stop_stream callbacks.

2012-01-20 Thread Javier Martin
Add "start_stream" and "stop_stream" callback in order to enable and disable the eMMa-PrP properly and save CPU usage avoiding IRQs when the device is not streaming. Signed-off-by: Javier Martin --- drivers/media/video/mx2_camera.c | 107 +++

[PATCH 3/4] media i.MX27 camera: improve discard buffer handling.

2012-01-20 Thread Javier Martin
ted. A new "discard" queue and two discard buffers have been added to make them flow trough the pipeline of queues and thus provide suitable event ordering. Signed-off-by: Javier Martin --- drivers/media/video/mx2_camera.c | 215 +- 1 files changed, 1

[PATCH 4/4] media i.MX27 camera: handle overflows properly.

2012-01-20 Thread Javier Martin
Signed-off-by: Javier Martin --- drivers/media/video/mx2_camera.c | 23 +-- 1 files changed, 9 insertions(+), 14 deletions(-) diff --git a/drivers/media/video/mx2_camera.c b/drivers/media/video/mx2_camera.c index e0c5dd4..cdc614f 100644 --- a/drivers/media/video

Re: [PATCH v2] media i.MX27 camera: properly detect frame loss.

2012-01-23 Thread javier Martin
ries is accepted and then merge both at the same time. What do you think? -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe from this list: send the line "u

Re: [PATCH v2] media i.MX27 camera: properly detect frame loss.

2012-01-23 Thread javier Martin
too tight on schedule. I'll see ifI can swallow it that way or maybe > merge myself :-) If you, Sascha, or someone else comes up with some requests or fixes to the new series I don't mind to rebase it so you can just ignore this patch, since I would have to sent a v2 version of the seri

Re: [PATCH 1/4] media i.MX27 camera: migrate driver to videobuf2

2012-01-25 Thread javier Martin
(vb->state == VIDEOBUF_QUEUED) { >> -             list_del(&vb->queue); >> -             vb->state = VIDEOBUF_ERROR; >> -     } else if (cpu_is_mx25() && vb->state == VIDEOBUF_ACTIVE) { >> +     if (buf->state == MX2_STATE_QUEUED || buf->state =

Re: [PATCH 2/4] media i.MX27 camera: add start_stream and stop_stream callbacks.

2012-01-25 Thread javier Martin
Hi Guennadi, On 25 January 2012 11:26, Guennadi Liakhovetski wrote: > As discussed before, please, merge this patch with > > "media i.MX27 camera: properly detect frame loss." Yes. You can drop that patch already. > One more cosmetic note: > > On Fri, 20 Jan 2012, J

Re: [PATCH 3/4] media i.MX27 camera: improve discard buffer handling.

2012-01-26 Thread javier Martin
Hi Guennadi, On 25 January 2012 13:12, Guennadi Liakhovetski wrote: > On Fri, 20 Jan 2012, Javier Martin wrote: > >> The way discard buffer was previously handled lead >> to possible races that made a buffer that was not >> yet ready to be overwritten by new video

Re: [PATCH 4/4] media i.MX27 camera: handle overflows properly.

2012-01-26 Thread javier Martin
Hi Guennadi, On 25 January 2012 13:17, Guennadi Liakhovetski wrote: > On Fri, 20 Jan 2012, Javier Martin wrote: > >> >> Signed-off-by: Javier Martin >> --- >>  drivers/media/video/mx2_camera.c |   23 +-- >>  1 files changed, 9 insertions(

[PATCH v2 1/4] media i.MX27 camera: migrate driver to videobuf2

2012-01-26 Thread Javier Martin
Signed-off-by: Javier Martin --- Changes since v1: - mx27 code doesn't use states. - number of states reduced to the ones used by mx25. - Fix incorrect if which broke mx25 support. - Minor fixes. --- drivers/media/video/mx2_camera.c | 298 -- 1

[PATCH v2 2/4] media i.MX27 camera: add start_stream and stop_stream callbacks.

2012-01-26 Thread Javier Martin
Add "start_stream" and "stop_stream" callback in order to enable and disable the eMMa-PrP properly and save CPU usage avoiding IRQs when the device is not streaming. This also makes the driver return 0 as the sequence number of the first frame. Signed-off-by: Javier Marti

[PATCH v2 3/4] media i.MX27 camera: improve discard buffer handling.

2012-01-26 Thread Javier Martin
ted. A new "discard" queue and two discard buffers have been added to make them flow trough the pipeline of queues and thus provide suitable event ordering. Signed-off-by: Javier Martin --- Changes since v1: - Don't allocate discard buffer on every set_fmt. --- driv

[PATCH v2 4/4] media i.MX27 camera: handle overflows properly.

2012-01-26 Thread Javier Martin
Signed-off-by: Javier Martin --- Changes since v1: - Make ifs in irq callback mutually exclusive. - Add new argument to mx27_camera_frame_done_emma() to handle errors. --- drivers/media/video/mx2_camera.c | 38 -- 1 files changed, 16 insertions(+), 22

Re: [PATCH v2 1/4] media i.MX27 camera: migrate driver to videobuf2

2012-01-30 Thread javier Martin
of this patch fixing what you've pointed out. Regards. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe from this list: send the line "unsubscribe linux

Re: [PATCH v2 2/4] media i.MX27 camera: add start_stream and stop_stream callbacks.

2012-01-30 Thread javier Martin
Hi, On 27 January 2012 16:53, Guennadi Liakhovetski wrote: > On Thu, 26 Jan 2012, Javier Martin wrote: > >> Add "start_stream" and "stop_stream" callback in order to enable >> and disable the eMMa-PrP properly and save CPU usage avoiding >> IRQs when

Re: [PATCH 3/4] media i.MX27 camera: improve discard buffer handling.

2012-01-30 Thread javier Martin
Hi Guennadi, On 27 January 2012 19:02, Guennadi Liakhovetski wrote: > (removing bar...@tkos.co.il - it bounces) > > On Thu, 26 Jan 2012, javier Martin wrote: > >> Hi Guennadi, >> >> On 25 January 2012 13:12, Guennadi Liakhovetski >> wrote: >>

Re: [PATCH v2 3/4] media i.MX27 camera: improve discard buffer handling.

2012-01-30 Thread javier Martin
On 27 January 2012 19:13, Guennadi Liakhovetski wrote: > On Thu, 26 Jan 2012, Javier Martin wrote: > >> The way discard buffer was previously handled lead >> to possible races that made a buffer that was not >> yet ready to be overwritten by new video data. This >&g

Re: [PATCH v2 4/4] media i.MX27 camera: handle overflows properly.

2012-01-30 Thread javier Martin
On 27 January 2012 19:16, Guennadi Liakhovetski wrote: > (removed bar...@tkos.co.il - it bounces) > > On Thu, 26 Jan 2012, Javier Martin wrote: > >> >> Signed-off-by: Javier Martin >> --- >>  Changes since v1: >>  - Make ifs in irq callback mut

[PATCH v3 1/4] media i.MX27 camera: migrate driver to videobuf2

2012-01-30 Thread Javier Martin
Signed-off-by: Javier Martin --- Changes since v2: - Return ENOTTY for VIDIOC_CREATE_BUFS - Check buffer size properly. - Do not remove unfixed FIXME. - Remove mx25 queued buffers from the queue list at release. --- drivers/media/video/mx2_camera.c | 289

[PATCH v3 2/4] media i.MX27 camera: add start_stream and stop_stream callbacks.

2012-01-30 Thread Javier Martin
Add "start_stream" and "stop_stream" callback in order to enable and disable the eMMa-PrP properly and save CPU usage avoiding IRQs when the device is not streaming. This also makes the driver return 0 as the sequence number of the first frame. Signed-off-by: Javier

[PATCH v3 3/4] media i.MX27 camera: improve discard buffer handling.

2012-01-30 Thread Javier Martin
ted. A new "discard" queue and two discard buffers have been added to make them flow trough the pipeline of queues and thus provide suitable event ordering. Signed-off-by: Javier Martin --- Changes since v2: - Remove BUG_ON when active list is empty. - Replace empty list checks with warni

[PATCH v3 4/4] media i.MX27 camera: handle overflows properly.

2012-01-30 Thread Javier Martin
Signed-off-by: Javier Martin --- Changes since v2: - Use true and false for bool variables. --- drivers/media/video/mx2_camera.c | 38 -- 1 files changed, 16 insertions(+), 22 deletions(-) diff --git a/drivers/media/video/mx2_camera.c b/drivers/media

[PATCH 1/2] media: tvp5150: Add cropping support.

2012-01-31 Thread Javier Martin
Signed-off-by: Javier Martin --- drivers/media/video/tvp5150.c | 127 +++-- 1 files changed, 122 insertions(+), 5 deletions(-) diff --git a/drivers/media/video/tvp5150.c b/drivers/media/video/tvp5150.c index c58c8d5..b1476f6 100644 --- a/drivers/media/video

[PATCH 2/2] media: tvp5150: support g_mbus_fmt callback.

2012-01-31 Thread Javier Martin
Signed-off-by: Javier Martin --- drivers/media/video/tvp5150.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/tvp5150.c b/drivers/media/video/tvp5150.c index b1476f6..e292c46 100644 --- a/drivers/media/video/tvp5150.c +++ b/drivers/media/video

Re: OV2640 and iMX25PDK - help needed

2012-02-02 Thread javier Martin
0? visstrim_m10 is connected to a tvp5150 but it uses the same interface as a CMOS sensor. Let me find some time to send a patch that I have pending in my queue. Then it can be used by Gonzalo as a reference. Regards. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de

[dmaengine] [Q] jiffies value does not increase in dma_sync_wait()

2012-02-03 Thread javier Martin
introduced a couple of printk() to check why this timeout is not triggered and I've found that the value of jiffies does not increase between loop iterations (i. e. it's like time didn't advance). Does anyobody know what reasons could make jiffies not being updated? Regards. -- Javier

Re: [dmaengine] [Q] jiffies value does not increase in dma_sync_wait()

2012-02-03 Thread javier Martin
Hi Russell, On 3 February 2012 10:10, Russell King - ARM Linux wrote: > On Fri, Feb 03, 2012 at 09:37:48AM +0100, javier Martin wrote: >> I've introduced a couple of printk() to check why this timeout is not >> triggered and I've found that the value of jiffies does not

Re: [dmaengine] [Q] jiffies value does not increase in dma_sync_wait()

2012-02-03 Thread javier Martin
On 3 February 2012 10:24, Russell King - ARM Linux wrote: > On Fri, Feb 03, 2012 at 10:22:00AM +0100, javier Martin wrote: >> Hi Russell, >> >> On 3 February 2012 10:10, Russell King - ARM Linux >> wrote: >> > On Fri, Feb 03, 2012 at 09:37:48AM +0100, javier M

Re: videobuf2 porting

2012-02-06 Thread javier Martin
If the driver you are trying to port supports old videobuf framework this patch might be useful for you: http://patchwork.linuxtv.org/patch/9719/ -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vi

Re: [PATCH v3 3/4] media i.MX27 camera: improve discard buffer handling.

2012-02-07 Thread javier Martin
Hi Guennadi, thank you for your attention. On 6 February 2012 19:33, Guennadi Liakhovetski wrote: > Hi Javier > > Thanks for the update! Let's see, whether this one can be improved a bit > more. > > On Mon, 30 Jan 2012, Javier Martin wrote: > >> The way discard bu

Re: [PATCH v3 3/4] media i.MX27 camera: improve discard buffer handling.

2012-02-07 Thread javier Martin
On 7 February 2012 09:22, Guennadi Liakhovetski wrote: > Hi Javier > > On Tue, 7 Feb 2012, javier Martin wrote: > > [snip] > >> Guennadi, before I send v4: >> Do you agree with the other patches 1, 2 and 4? > > Yes, this time I haven't found anything thei

[PATCH v4 3/4] media i.MX27 camera: improve discard buffer handling.

2012-02-07 Thread Javier Martin
ted. A new "discard" queue and two discard buffers have been added to make them flow trough the pipeline of queues and thus provide suitable event ordering. Signed-off-by: Javier Martin --- - Add proper locking to avoid races between IRQ and stop callbacks. - If a list is unexpectedly em

Re: [PATCH v4 3/4] media i.MX27 camera: improve discard buffer handling.

2012-02-09 Thread javier Martin
Hi Guennadi, I understand you are probably quite busy right now but it would be great if you could ack this patch. The sooner you merge it the sooner I will start working on the cleanup series. I've got some time on my hands now. Thank you. On 7 February 2012 11:14, Javier Martin wrote:

Re: [PATCH v4 3/4] media i.MX27 camera: improve discard buffer handling.

2012-02-10 Thread javier Martin
Hi Guennadi, On 9 February 2012 23:36, Guennadi Liakhovetski wrote: > Hi Javier > > On Thu, 9 Feb 2012, javier Martin wrote: > >> Hi Guennadi, >> I understand you are probably quite busy right now but it would be >> great if you could ack this patch. The sooner you

[PATCH 0/6] media: i.MX27 camera: Clean up series.

2012-02-13 Thread Javier Martin
Hi Guennadi, This is the clean up series I promised to send this week. This has to be applied on top of my previous patches. These are already discussed issues so I don't think you have any concerns with them. While I wait for your confirmation, I'm going to prepare a new patch in order to provid

[PATCH 1/6] media: i.MX27 camera: Remove goto from mx2_videobuf_queue().

2012-02-13 Thread Javier Martin
Signed-off-by: Javier Martin --- drivers/media/video/mx2_camera.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/media/video/mx2_camera.c b/drivers/media/video/mx2_camera.c index e70d26f..1f046a3 100644 --- a/drivers/media/video/mx2_camera.c +++ b/drivers

[PATCH 2/6] media: i.MX27 camera: Use list_first_entry() whenever possible.

2012-02-13 Thread Javier Martin
Signed-off-by: Javier Martin --- drivers/media/video/mx2_camera.c | 28 +--- 1 files changed, 13 insertions(+), 15 deletions(-) diff --git a/drivers/media/video/mx2_camera.c b/drivers/media/video/mx2_camera.c index 1f046a3..13be305 100644 --- a/drivers/media/video

[PATCH 4/6] media: i.MX27 camera: return IRQ_NONE if no IRQ status bit is set.

2012-02-13 Thread Javier Martin
If active_bufs() list is empty and no IRQ status bit is set we are probably dealing with a share IRQ. Return IRQ_NONE in this case. Signed-off-by: Javier Martin --- drivers/media/video/mx2_camera.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/media

[PATCH 3/6] media: i.MX27 camera: Use spin_lock() inside the IRQ handler.

2012-02-13 Thread Javier Martin
We don't need to use spin_lock_irqsave() since there are not any other IRQs that can race with this ISR. Signed-off-by: Javier Martin --- drivers/media/video/mx2_camera.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/media/video/mx2_camera.c b/dr

[PATCH 5/6] media: i.MX27 camera: fix compilation warning.

2012-02-13 Thread Javier Martin
Signed-off-by: Javier Martin --- drivers/media/video/mx2_camera.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/media/video/mx2_camera.c b/drivers/media/video/mx2_camera.c index d9028f1..8ccdb4a 100644 --- a/drivers/media/video/mx2_camera.c

[PATCH 6/6] media: i.MX27 camera: more efficient discard buffer handling.

2012-02-13 Thread Javier Martin
Some elements of 'mx2_buffer' are grouped together in another auxiliary structure. This way we don't need to have unused 'vb2_buffer' structures for both discard buffers. Signed-off-by: Javier Martin --- drivers/media/video/mx2_camera.c | 77 ++

<    1   2   3   4   5   >