Re: [PATCH v5 3/3] [media] s5p-mfc: Check and set 'v4l2_pix_format:field' field in try_fmt

2017-02-22 Thread Nicolas Dufresne
Le mercredi 22 février 2017 à 10:10 -0300, Thibault Saunier a écrit : > Hello, > > On 02/22/2017 06:29 AM, Andrzej Hajda wrote: > > On 21.02.2017 20:20, Thibault Saunier wrote: > > > It is required by the standard that the field order is set by the > > > driver. > > > > > > Signed-off-by: Thibaul

Re: [PATCH v5 1/3] [media] exynos-gsc: Use user configured colorspace if provided

2017-02-22 Thread Nicolas Dufresne
Le mercredi 22 février 2017 à 15:57 -0300, Thibault Saunier a écrit : > On 02/22/2017 03:06 PM, Hans Verkuil wrote: > > > > On 02/22/2017 05:05 AM, Thibault Saunier wrote: > > > Hello, > > > > > > > > > On 02/21/2017 11:19 PM, Hans Verkuil wrote: > > > > On 02/21/2017 11:20 AM, Thibault Saunier

Re: [PATCH v6 2/2] [media] s5p-mfc: Handle 'v4l2_pix_format:field' in try_fmt and g_fmt

2017-03-01 Thread Nicolas Dufresne
Le mercredi 01 mars 2017 à 14:12 +0100, Andrzej Hajda a écrit : > On 01.03.2017 12:51, Thibault Saunier wrote: > > It is required by the standard that the field order is set by the > > driver, default to NONE in case any is provided, but we can > > basically > > accept any value provided by the use

Re: [PATCH v6 2/2] [media] s5p-mfc: Handle 'v4l2_pix_format:field' in try_fmt and g_fmt

2017-03-01 Thread Nicolas Dufresne
Le mercredi 01 mars 2017 à 14:12 +0100, Andrzej Hajda a écrit : > - on output side you have encoded bytestream - you cannot say about > interlacing in such case, so the only valid value is NONE, > - on capture side you have decoded frames, and in this case it > depends > on the device and driver ca

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-14 Thread Nicolas Dufresne
Le lundi 13 mars 2017 à 10:45 +, Russell King - ARM Linux a écrit : > On Mon, Mar 13, 2017 at 11:02:34AM +0100, Hans Verkuil wrote: > > On 03/11/2017 07:14 PM, Steve Longerbeam wrote: > > > The event must be user visible, otherwise the user has no indication > > > the error, and can't correct i

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

2017-03-14 Thread Nicolas Dufresne
Le mardi 14 mars 2017 à 15:47 +0100, Benjamin Gaignard a écrit : > Should we use /devi/ion/$heap instead of /dev/ion_$heap ? > I think it would be easier for user to look into one directory rather > then in whole /dev to find the heaps > > > is that we don't have to worry about a limit of 32 possi

Re: media / v4l2-mc: wishlist for complex cameras (was Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline)

2017-03-15 Thread Nicolas Dufresne
Le mercredi 15 mars 2017 à 11:50 +0100, Philippe De Muyter a écrit : > > I would say: camorama, xawtv3, zbar, google talk, skype. If it runs > > with those, it will likely run with any other application. > > > > I would like to add the 'v4l2src' plugin of gstreamer, and on the > imx6 its While i

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-18 Thread Nicolas Dufresne
Le samedi 18 mars 2017 à 20:43 +, Russell King - ARM Linux a écrit : > On Sat, Mar 18, 2017 at 12:58:27PM -0700, Steve Longerbeam wrote: > > Can you share your gstreamer pipeline? For now, until > > VIDIOC_ENUM_FRAMESIZES is implemented, try a pipeline that > > does not attempt to specify a fra

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Nicolas Dufresne
Le dimanche 19 mars 2017 à 09:55 +, Russell King - ARM Linux a écrit : > 2) would it also make sense to allow gstreamer's v4l2src to try > setting >    a these parameters, and only fail if it's unable to set it?  IOW, > if >    I use: > > gst-launch-1.0 v4l2src device=/dev/video10 ! \ >   

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Nicolas Dufresne
Le dimanche 19 mars 2017 à 14:21 +, Russell King - ARM Linux a écrit : > > Can it be a point of failure? > > There's a good reason why I dumped a full debug log using > GST_DEBUG=*:9, > analysed it for the cause of the failure, and tried several different > pipelines, including the standard ba

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Nicolas Dufresne
Le dimanche 19 mars 2017 à 00:54 +, Russell King - ARM Linux a écrit : > > > > In practice, I have the impression there is a fair reason why > > framerate > > enumeration isn't implemented (considering there is only 1 valid > > rate). > > That's actually completely incorrect. > > With the ca

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-22 Thread Nicolas Dufresne
Le mardi 21 mars 2017 à 11:36 +, Russell King - ARM Linux a écrit : >     warn: v4l2-test-formats.cpp(1187): S_PARM is > supported for buftype 2, but not ENUM_FRAMEINTERVALS >     warn: v4l2-test-formats.cpp(1194): S_PARM is > supported but doesn't report V4L2_CAP_TIMEPE

Re: [PATCH v7 5/9] media: venus: vdec: add video decoder files

2017-03-24 Thread Nicolas Dufresne
Le vendredi 24 mars 2017 à 15:41 +0100, Hans Verkuil a écrit : > > +static const struct venus_format vdec_formats[] = { > > + { > > + .pixfmt = V4L2_PIX_FMT_NV12, > > + .num_planes = 1, > > + .type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE, > > Just curious: is N

Re: [PATCH v7 5/9] media: venus: vdec: add video decoder files

2017-03-26 Thread Nicolas Dufresne
Le dimanche 26 mars 2017 à 00:30 +0200, Stanimir Varbanov a écrit : > > > +vb->planes[0].data_offset = data_offset; > > > +vb->timestamp = timestamp_us * NSEC_PER_USEC; > > > +vbuf->sequence = inst->sequence++; > > > > timestamp and sequence are only set for CAP

Re: [PATCH v7 5/9] media: venus: vdec: add video decoder files

2017-03-27 Thread Nicolas Dufresne
Le lundi 27 mars 2017 à 10:45 +0200, Hans Verkuil a écrit : > > > timestamp and sequence are only set for CAPTURE, not OUTPUT. Is > > > that correct? > > > > Correct. I can add sequence for the OUTPUT queue too, but I have no > > idea how that sequence is used by userspace. > > You set V4L2_BUF_F

Re: Memory freeing when dmabuf fds are exported with VIDIOC_EXPBUF

2017-10-03 Thread Nicolas Dufresne
I'd like to revive this discussion. Le lundi 01 août 2016 à 12:56 +0200, Hans Verkuil a écrit : > > > > Hans, Marek, any opinion on this ? > > What is the use-case for this? What you are doing here is to either free all > existing buffers or reallocate buffers. We can decide to rely on refcounti

Re: platform: coda: how to use firmware-imx binary releases? / how to use VDOA on imx6?

2017-10-05 Thread Nicolas Dufresne
Le jeudi 05 octobre 2017 à 13:54 +0200, Martin Kepplinger a écrit : > > This message is most likely just a result of the VDOA not supporting > > the > > selected capture format. In vdoa_context_configure, you can see that > > the > > VDOA only writes YUYV or NV12. > > ok. I'll have to look into

Re: [PATCH 2/2] media: venus: venc: fix bytesused v4l2_plane field

2017-10-09 Thread Nicolas Dufresne
fers only. > > Signed-off-by: Stanimir Varbanov Tested-by: Nicolas Dufresne > --- > drivers/media/platform/qcom/venus/venc.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/platform/qcom/venus/venc.c > b/drivers/media/p

Re: [PATCH] media: vb2: unify calling of set_page_dirty_lock

2017-10-10 Thread Nicolas Dufresne
Le mardi 29 août 2017 à 14:26 +0300, Stanimir Varbanov a écrit : > Currently videobuf2-dma-sg checks for dma direction for > every single page and videobuf2-dc lacks any dma direction > checks and calls set_page_dirty_lock unconditionally. > > Thus unify and align the invocations of set_page_dirty

Re: [PATCH v3 1/2] staging: Introduce NVIDIA Tegra20 video decoder driver

2017-10-11 Thread Nicolas Dufresne
Le mercredi 11 octobre 2017 à 23:08 +0300, Dmitry Osipenko a écrit : > diff --git a/drivers/staging/tegra-vde/TODO b/drivers/staging/tegra- > vde/TODO > new file mode 100644 > index ..e98bbc7b3c19 > --- /dev/null > +++ b/drivers/staging/tegra-vde/TODO > @@ -0,0 +1,5 @@ > +TODO: > +

Re: [PATCH] venus: reimplement decoder stop command

2017-10-13 Thread Nicolas Dufresne
his is last > decoded buffer with data. > > Signed-off-by: Stanimir Varbanov Tested-By: Nicolas Dufresne > --- > drivers/media/platform/qcom/venus/core.h| 2 -- > drivers/media/platform/qcom/venus/helpers.c | 7 -- > drivers/media/platform/qcom/venus/hfi.c |

Re: [PATCH] media: vb2: unify calling of set_page_dirty_lock

2017-10-15 Thread Nicolas Dufresne
Le dimanche 15 octobre 2017 à 23:40 +0300, Sakari Ailus a écrit : > Hi Nicolas, > > On Tue, Oct 10, 2017 at 11:40:10AM -0400, Nicolas Dufresne wrote: > > Le mardi 29 août 2017 à 14:26 +0300, Stanimir Varbanov a écrit : > > > Currently videobuf2-dma-sg checks for dma d

Re: [PATCH] media: vb2: unify calling of set_page_dirty_lock

2017-10-17 Thread Nicolas Dufresne
Le mardi 17 octobre 2017 à 13:14 +0300, Sakari Ailus a écrit : > On Sun, Oct 15, 2017 at 07:09:24PM -0400, Nicolas Dufresne wrote: > > Le dimanche 15 octobre 2017 à 23:40 +0300, Sakari Ailus a écrit : > > > Hi Nicolas, > > > > > > On Tue, Oct 10, 2017 at 11:4

Re: [PATCH v2 2/6] [media] rockchip/rga: v4l2 m2m support

2017-07-17 Thread Nicolas Dufresne
Le lundi 17 juillet 2017 à 05:37 +0300, Laurent Pinchart a écrit : > Hi Nicolas, > > On Saturday 15 Jul 2017 12:49:13 Personnel wrote: > > You might want to fix your mailer to use your name :-) > > > Le samedi 15 juillet 2017 à 12:42 +0300, Laurent Pinchart a écrit : > > > On Saturday 15 Jul 201

Re: [PATCH v3] [media] v4l2: Add support for go2001 PCI codec driver

2017-07-25 Thread Nicolas Dufresne
Le mardi 25 juillet 2017 à 19:40 +0200, Thierry Escande a écrit : > This patch adds support for the go2001 PCI codec driver. This > hardware > is present on ChromeOS based devices like the Acer ChromeBox and > Acer/LG > ChromeBase 24 devices. This chipset comes on a mini PCI-E card with > Google as

Re: DRM Format Modifiers in v4l2

2017-08-28 Thread Nicolas Dufresne
Le jeudi 24 août 2017 à 13:26 +0100, Brian Starkey a écrit : > > What I mean was: an application can use the modifier to give buffers from > > one device to another without needing to understand it. > > > > But a generic video capture application that processes the video itself > > cannot be expec

Re: [PATCH 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor

2017-08-28 Thread Nicolas Dufresne
Le lundi 28 août 2017 à 08:15 -0700, Soren Brinkmann a écrit : > From: Leon Luo > > The imx274 is a Sony CMOS image sensor that has 1/2.5 image size. > It supports up to 3840x2160 (4K) 60fps, 1080p 120fps. The interface > is 4-lane MIPI running at 1.44Gbps each. > > This driver has been tested o

Re: DRM Format Modifiers in v4l2

2017-08-31 Thread Nicolas Dufresne
Le jeudi 31 août 2017 à 17:28 +0300, Laurent Pinchart a écrit : > > e.g. if I have two devices which support MODIFIER_FOO, I could attempt > > to share a buffer between them which uses MODIFIER_FOO without > > necessarily knowing exactly what it is/does. > > Userspace could certainly set modifiers

Re: [PATCH v3 01/15] [media] v4l: Document explicit synchronization behaviour

2017-09-07 Thread Nicolas Dufresne
Le jeudi 07 septembre 2017 à 15:42 -0300, Gustavo Padovan a écrit : > From: Gustavo Padovan > > Add section to VIDIOC_QBUF about it > > v2: > - mention that fences are files (Hans) > - rework for the new API > > Signed-off-by: Gustavo Padovan > --- > Documentation/media/uapi/v4l/v

Re: support autofocus / autogain in libv4l2

2017-04-25 Thread Nicolas Dufresne
Le mardi 25 avril 2017 à 10:08 +0200, Pali Rohár a écrit : > On Tuesday 25 April 2017 10:05:38 Pavel Machek wrote: > > > > It would be nice if more than one application could be > > > > accessing the > > > > camera at the same time... (I.e. something graphical running > > > > preview > > > > then u

Re: support autofocus / autogain in libv4l2

2017-04-25 Thread Nicolas Dufresne
Le mardi 25 avril 2017 à 10:05 +0200, Pavel Machek a écrit : > Well, fd's are hard, because application can do fork() and now > interesting stuff happens. Threads are tricky, because now you have > locking etc. > > libv4l2 is designed to be LD_PRELOADED. That is not really feasible > with "complex

Re: support autofocus / autogain in libv4l2

2017-04-25 Thread Nicolas Dufresne
Le mardi 25 avril 2017 à 13:30 +0200, Pali Rohár a écrit : > Pinos (renamed from PulseVideo) > > https://blogs.gnome.org/uraeus/2015/06/30/introducing-pulse-video/ > https://cgit.freedesktop.org/~wtay/pinos/ > > But from git history it looks like it is probably dead now... This is also incorrect

Re: [RFC 0/4] Exynos DRM: add Picture Processor extension

2017-04-26 Thread Nicolas Dufresne
Le mercredi 26 avril 2017 à 01:21 +0300, Sakari Ailus a écrit : > Hi Marek, > > On Thu, Apr 20, 2017 at 01:23:09PM +0200, Marek Szyprowski wrote: > > Hi Laurent, > > > > On 2017-04-20 12:25, Laurent Pinchart wrote: > > > Hi Marek, > > > > > > (CC'ing Sakari Ailus) > > > > > > Thank you for the

Re: [RFC 0/4] Exynos DRM: add Picture Processor extension

2017-04-26 Thread Nicolas Dufresne
Le mercredi 26 avril 2017 à 18:52 +0200, Tobias Jakobi a écrit : > Hello again, > > > Nicolas Dufresne wrote: > > Le mercredi 26 avril 2017 à 01:21 +0300, Sakari Ailus a écrit : > > > Hi Marek, > > > > > > On Thu, Apr 20, 2017 at 01:23:09PM +020

Re: [RFC 0/4] Exynos DRM: add Picture Processor extension

2017-04-26 Thread Nicolas Dufresne
Le mercredi 26 avril 2017 à 21:31 +0200, Tobias Jakobi a écrit : > I'm pretty sure you have misread Marek's description of the patchset. > The picture processor API should replaced/deprecate the IPP API that is > currently implemented in the Exynos DRM. > > In particular this affects the following

Re: [PATCH v2 3/3] libv4l-codecparsers: add GStreamer mpeg2 parser

2017-05-01 Thread Nicolas Dufresne
Le vendredi 28 avril 2017 à 17:02 +0200, Hugues Fruchet a écrit : > Add the mpeg2 codecparser backend glue which will > call the GStreamer parsing functions. > > Signed-off-by: Hugues Fruchet > --- >  configure.ac|  21 ++ >  lib/libv4l-codecparsers/Makefile.am 

Re: [PATCH v2] media: s5p-mfc: Add support for V4L2_MEMORY_DMABUF type

2017-11-03 Thread Nicolas Dufresne
Le vendredi 03 novembre 2017 à 09:11 +0100, Marek Szyprowski a écrit : > MFC driver supports only MMAP operation mode mainly due to the hardware > restrictions of the addresses of the DMA buffers (MFC v5 hardware can > access buffers only in 128MiB memory region starting from the base address > of

[PATCH] uvc: Add D3DFMT_L8 support

2017-11-03 Thread Nicolas Dufresne
Microsoft HoloLense UVC sensor uses D3DFMT instead of FOURCC when exposing formats. This add support for D3DFMT_L8 as exposed from the Acer Windows Mixed Reality Headset. Signed-off-by: Nicolas Dufresne --- drivers/media/usb/uvc/uvc_driver.c | 5 + drivers/media/usb/uvc/uvcvideo.h | 5

Re: [PATCH v2] media: s5p-mfc: Add support for V4L2_MEMORY_DMABUF type

2017-11-06 Thread Nicolas Dufresne
Le lundi 06 novembre 2017 à 10:28 +0100, Marek Szyprowski a écrit : > Hi Nicolas, > > On 2017-11-03 14:45, Nicolas Dufresne wrote: > > Le vendredi 03 novembre 2017 à 09:11 +0100, Marek Szyprowski a écrit : > > > MFC driver supports only MMAP operation mode ma

[PATCH v2] uvc: Add D3DFMT_L8 support

2017-11-06 Thread Nicolas Dufresne
Microsoft HoloLense UVC sensor uses D3DFMT instead of FOURCC when exposing formats. This adds support for D3DFMT_L8 as exposed from the Acer Windows Mixed Reality Headset. Signed-off-by: Nicolas Dufresne --- drivers/media/usb/uvc/uvc_driver.c | 5 + drivers/media/usb/uvc/uvcvideo.h | 5

Re: [linux-sunxi] Cedrus driver

2017-11-16 Thread Nicolas Dufresne
Le jeudi 16 novembre 2017 à 12:02 +0100, Maxime Ripard a écrit : > Assuming that the request API is in, we'd need to: > - Finish the MPEG4 support > - Work on more useful codecs (H264 comes to my mind) For which we will have to review the tables and make sure they match the spec (the easy part

Re: [Patch v6 05/12] [media] videodev2.h: Add v4l2 definition for HEVC

2017-12-08 Thread Nicolas Dufresne
Le vendredi 08 décembre 2017 à 14:38 +0530, Smitha T Murthy a écrit : > Add V4L2 definition for HEVC compressed format > > Signed-off-by: Smitha T Murthy > Reviewed-by: Andrzej Hajda > Reviewed-by: Stanimir Varbanov > Acked-by: Hans Verkuil > --- > include/uapi/linux/videodev2.h | 1 + > 1 fi

Re: [PATCH v4 3/5] staging: Introduce NVIDIA Tegra video decoder driver

2017-12-10 Thread Nicolas Dufresne
Le dimanche 10 décembre 2017 à 21:56 +0300, Dmitry Osipenko a écrit : > > I've CC-ed Maxime and Giulio as well: they are looking into adding support > > for > > the stateless allwinner codec based on this code as well. There may well be > > opportunities for you to work together, esp. on the users

Re: Kernel Oopses from v4l_enum_fmt

2017-12-13 Thread Nicolas Dufresne
Le mercredi 13 décembre 2017 à 22:33 +0100, Oleksandr Ostrenko a écrit : > Dear all, > > There is an issue in v4l_enum_fmt leading to kernel panic under > certain > circumstance. It happens while I try to capture video from my TV > tuner. > > When I connect this USB TV tuner (WinTV HVR-1900) it

Re: gstreamer: v4l2videodec plugin

2016-05-01 Thread Nicolas Dufresne
Le jeudi 28 avril 2016 à 14:33 +0300, Stanimir Varbanov a écrit : > So I'm wondering is that intensional? > > Depending on the answer I should make the same in the Gallium dri2 in > dri2_from_dma_bufs(). It's DRI format that are confusing. In GStreamer DRI_FORMAT_GR88 would be named RG88 (if it e

Re: [RFC 08/22] videodev2.h: Add request field to v4l2_pix_format_mplane

2016-05-06 Thread Nicolas Dufresne
Le vendredi 06 mai 2016 à 13:53 +0300, Sakari Ailus a écrit : > From: Laurent Pinchart > > Let userspace specify a request ID when getting or setting formats. > The > support is limited to the multi-planar API at the moment, extending > it > to the single-planar API is possible if needed. > > Fr

Re: [RESEND PATCH] [media] s5p-mfc: don't close instance after free OUTPUT buffers

2016-05-06 Thread Nicolas Dufresne
Thanks for re-submitting. See inline two typos to fix in teh comment. cheers, Nicolas Le vendredi 06 mai 2016 à 18:11 -0400, Javier Martinez Canillas a écrit : > From: ayaka > > User-space applications can use the VIDIOC_REQBUFS ioctl to determine if a > memory mapped, user pointer or DMABUF ba

Re: [RESEND PATCH] [media] s5p-mfc: don't close instance after free OUTPUT buffers

2016-05-09 Thread Nicolas Dufresne
ssue, only free the buffers on VIDIOC_REQBUFS(0) but > don't > close the MFC instance to allow future VIDIOC_REQBUFS(n) calls to > succeed. > > Signed-off-by: ayaka > [javier: Rewrote changelog to explain the problem more detailed] > Signed-off-by: Javier Martinez Canillas I j

Re: [PATCH] Revert "[media] videobuf2-v4l2: Verify planes array in buffer dequeueing"

2016-05-11 Thread Nicolas Dufresne
Le mercredi 11 mai 2016 à 13:27 -0300, Mauro Carvalho Chehab a écrit : > This patch causes a Kernel panic when called on a DVB driver. > > This reverts commit 2c1f6951a8a82e6de0d82b1158b5e493fc6c54ab. Seems rather tricky, since this commit fixed a possible (user induced) buffer overflow according

Re: gstreamer: v4l2videodec plugin

2016-05-14 Thread Nicolas Dufresne
Le vendredi 13 mai 2016 à 11:45 +0300, Stanimir Varbanov a écrit : > yes, of course :) > > Just FYI, I applied the WIP patches on my side and I'm very happy to > report that they just works. So If you need some testing on qcom > video > accelerator just ping me. > > One thing which bothers me is

Re: gstreamer: v4l2videodec plugin

2016-05-15 Thread Nicolas Dufresne
Le vendredi 13 mai 2016 à 11:45 +0300, Stanimir Varbanov a écrit : > One thing which bothers me is how the extra-controls property > working, > i.e. I failed to change the h264 profile for example with below > construct: > > extra-controls="controls,h264_profile=4;" Yes, and profile should be neg

Re: gstreamer: v4l2videodec plugin

2016-05-19 Thread Nicolas Dufresne
Le jeudi 19 mai 2016 à 15:25 +0200, Philipp Zabel a écrit : > Is there any reason not to update the MFC driver to use G_SELECTION? > The > g_crop implementation could be kept for backwards compatibility. Videobuf2 already provide this backward compatible implementation, so there is no reason not t

Re: [PATCH 00/38] i.MX5/6 Video Capture

2016-06-16 Thread Nicolas Dufresne
Le jeudi 16 juin 2016 à 10:02 -0700, Steve Longerbeam a écrit : > I found the cause at least in my case. After enabling dynamic debug in > videobuf2-dma-contig.c, "v4l2-ctl -d/dev/video0 --stream-user=8" gives > me > > [  468.826046] user data must be aligned to 64 bytes > > > > But even gettin

Re: [PATCH 00/38] i.MX5/6 Video Capture

2016-06-16 Thread Nicolas Dufresne
Le jeudi 16 juin 2016 à 10:02 -0700, Steve Longerbeam a écrit : > I found the cause at least in my case. After enabling dynamic debug in > videobuf2-dma-contig.c, "v4l2-ctl -d/dev/video0 --stream-user=8" gives > me > > [  468.826046] user data must be aligned to 64 bytes > > > > But even gettin

Re: [RFC PATCH] media: s5p-mfc - remove vidioc_g_crop

2016-07-03 Thread Nicolas Dufresne
Le dimanche 03 juillet 2016 à 11:43 +0200, Hans Verkuil a écrit : > Hi Nicolas, > > On 07/02/2016 10:29 PM, Nicolas Dufresne wrote: > > > > Le 30 juin 2016 5:35 PM, "Shuah Khan" > <mailto:shua...@osg.samsung.com>> a écrit : > > > > >

Re: Still images and v4l2?

2016-10-28 Thread Nicolas Dufresne
Le vendredi 28 octobre 2016 à 14:14 +0200, Michael Haardt a écrit : > I am currently developing a new image v4l2 sensor driver to acquire > sequences of still images and wonder how to interface that to the > v4l2 API. > > Currently, cameras are assumed to deliver an endless stream of images > afte

Re: [RFC] V4L2 unified low-level decoder API

2016-11-04 Thread Nicolas Dufresne
Le vendredi 04 novembre 2016 à 14:55 +0100, Hugues FRUCHET a écrit : > >> > >> I can help on H264 on a code review basis based on the functional H264 > >> setup I have in-house and codec knowledge, but I cannot provide > >> implementation in a reasonable timeframe, same for VP8. > >> > >> > >> > >>

Re: [PATCH v3 4/9] media: venus: vdec: add video decoder files

2016-11-23 Thread Nicolas Dufresne
Le lundi 21 novembre 2016 à 18:09 +0200, Stanimir Varbanov a écrit : > >> Meanwhile I have found bigger obstacle - I cannot run multiple > instances > >> simultaneously. By m2m design it can execute only one job (m2m > context) > >> at a time per m2m device. Can you confirm that my observation is >

Re: [PATCH v2 0/3] support of v4l2 encoder for STMicroelectronics SOC

2016-07-11 Thread Nicolas Dufresne
Le lundi 11 juillet 2016 à 17:14 +0200, Jean-Christophe Trotin a écrit : > version 2: > - List of pixel formats supported by the encoder reduced to NV12 and > NV21 > - x86_64 compilation warnings corrected > - V4L2 compliance successfully passed with this version (see report > below) > - All remark

Re: [PATCH v2 2/3] [media] hva: multi-format video encoder V4L2 driver

2016-07-11 Thread Nicolas Dufresne
Le lundi 11 juillet 2016 à 17:14 +0200, Jean-Christophe Trotin a écrit : > This patch adds V4L2 HVA (Hardware Video Accelerator) video encoder > driver for STMicroelectronics SoC. It uses the V4L2 mem2mem framework. > > This patch only contains the core parts of the driver: > - the V4L2 interface

Re: [PATCH v3 3/9] DocBook/v4l: Add compressed video formats used on MT8173 codec driver

2016-07-12 Thread Nicolas Dufresne
Le mardi 12 juillet 2016 à 16:16 +0800, Wu-Cheng Li (李務誠) a écrit : > Decoder hardware produces MT21 (compressed). Image processor can > convert it to a format that can be input of display driver. Tiffany. > When do you plan to upstream image processor (mtk-mdp)? > > > > It can be as input format f

Re: [PATCH v3 3/9] DocBook/v4l: Add compressed video formats used on MT8173 codec driver

2016-07-12 Thread Nicolas Dufresne
Le mardi 12 juillet 2016 à 15:08 -0400, Nicolas Dufresne a écrit : > Le mardi 12 juillet 2016 à 16:16 +0800, Wu-Cheng Li (李務誠) a écrit : > > Decoder hardware produces MT21 (compressed). Image processor can > > convert it to a format that can be input of display driver. > > Tif

Re: [PATCH 2/2] [media] s5p-g2d: Replace old driver with DRM version

2016-07-13 Thread Nicolas Dufresne
Le mardi 12 juillet 2016 à 20:02 -0300, Mauro Carvalho Chehab a écrit : > I suspect that you'll be applying this one via DRM tree, so: > > Em Tue, 24 May 2016 15:28:13 +0200 > Krzysztof Kozlowski escreveu: > > > Remove the old non-DRM driver because it is now entirely supported > by > > exynos_d

Re: [PATCH v3 3/9] DocBook/v4l: Add compressed video formats used on MT8173 codec driver

2016-07-13 Thread Nicolas Dufresne
Le mercredi 13 juillet 2016 à 10:00 +0800, tiffany lin a écrit : > Hi Nicolas, > > On Tue, 2016-07-12 at 15:14 -0400, Nicolas Dufresne wrote: > > Le mardi 12 juillet 2016 à 15:08 -0400, Nicolas Dufresne a écrit : > > > Le mardi 12 juillet 2016 à 16:16 +0800, W

Re: [RFT PATCH v2] [media] exynos4-is: Fix fimc_is_parse_sensor_config() nodes handling

2016-07-15 Thread Nicolas Dufresne
. So the reference count is incremented but > > not > > decremented for the endpoint and port nodes. > > > > Fix this by having separate pointers for each node looked up. > > > > Signed-off-by: Javier Martinez Canillas > > > > Any comments about this patch

Re: [RFT PATCH v2] [media] exynos4-is: Fix fimc_is_parse_sensor_config() nodes handling

2016-07-15 Thread Nicolas Dufresne
Le vendredi 15 juillet 2016 à 12:53 -0400, Nicolas Dufresne a écrit : > Le jeudi 21 avril 2016 à 09:21 -0400, Javier Martinez Canillas a > écrit : > > Hello Sylwester, > > > > On 03/23/2016 08:41 PM, Javier Martinez Canillas wrote: > > > The same struct device_

Re: [PATCH] [media] vb2: map dmabuf for planes on driver queue instead of vidioc_qbuf

2016-07-18 Thread Nicolas Dufresne
(not yet merged) implementing fallback at QBuf. Failing asynchronously would leave userspace with absolutely no way to handle the case of incompatible DMA-Buf. Regards, Nicolas p.s. I'll be away for the rest of the summer, see you in September. > > Regards, > > Hans >

Re: v4l2 api: supported resolution negotiation

2015-10-04 Thread Nicolas Dufresne
Le dimanche 04 octobre 2015 à 21:49 +0300, Sakari Ailus a écrit : > I think the GStreamer > v4lsrc tries very small and very large values. The driver will clamp > them to > a supported values which are passed to the application from the > IOCTL. In GStreamer we try ENUM_FRAMESIZE, and when no supp

Re: [PATCH 4/4] v4l2-mem2mem: allow reqbufs(0) with "in use" MMAP buffers

2015-11-02 Thread Nicolas Dufresne
Le mardi 08 avril 2014 à 12:51 +0200, Marek Szyprowski a écrit : > Hello, > > On 2014-04-07 16:41, Kamil Debski wrote: > > Pawel, Marek, > > > > Before taking this to my tree I wanted to get an ACK from one of > > the > > videobuf2 maintainers. Could you spare a moment to look through > > this >

Re: v4l2 kernel module debugging methods

2015-12-05 Thread Nicolas Dufresne
Le dimanche 06 décembre 2015 à 00:00 +0200, Ran Shalit a écrit : > Hello, > > I would like to ask a general question regarding methods to debug a > v4l2 device driver. > Since I assume that the kernel driver will probably won't work in > first try after coding everything inside the device driver..

Re: v4l2 kernel module debugging methods

2015-12-10 Thread Nicolas Dufresne
Le jeudi 10 décembre 2015 à 23:46 +0200, Ran Shalit a écrit : > Thank you for the comment. > As someone expreinced with v4l2 device driver, do you recommened > using > debugging technique such as qemu (or kgdb) or do you rather use plain > printing ? I never used that, printing I used. You should

Re: problem with coda when running qt-gstreamer and video reaches its end (resending in plain text)

2015-12-16 Thread Nicolas Dufresne
Le mercredi 16 décembre 2015 à 15:49 +0100, Philipp Zabel a écrit : > > # [ 1382.828875] coda 204.vpu: CODA PIC_RUN timeout > > # [ 1383.938704] coda 204.vpu: CODA PIC_RUN timeout > >  > > The video is stopped but I can see last frame on the screen although in  > > qt application it should

VIVID bug in BGRA and ARGB

2015-12-17 Thread Nicolas Dufresne
Hi Hans, while testing over color formats VIVID produce, I found that BGRA and ARGB the alpha component is always 0, which leads to black frames when composed (when the background is black of course). Is that a bug, or intended ? cheers, Nicolas signature.asc Description: This is a digitally sig

Re: imx53 IPU support on 4.0.4

2015-05-21 Thread Nicolas Dufresne
Le mercredi 20 mai 2015 à 21:55 +0100, Russell King - ARM Linux a écrit : > The way kernel development works is that patches are sent to mailing > lists for review. Kernel developers review the patches and provide > comments back. The comments are discussed and actioned, and a new > set of patch

Re: [RFC] V4L2 codecs in user space

2015-06-08 Thread Nicolas Dufresne
Le lundi 08 juin 2015 à 13:42 +0900, Damian Hobson-Garcia a écrit : > Also, if this method is not recommended, should there be a 1-2 line > disclaimer on the "V4L2_Userspace_Library" wiki page that mentions > this? I think you may have got that wrong. The V4L2 userspace library is not implementin

[PATCH 0/5] s5p-fimc: Misc fixes

2014-03-25 Thread Nicolas Dufresne
This patch series fixes several bugs found in the s5p-fimc driver. These bugs relate to bad parameters in the formats definition and short size of image buffers. Nicolas Dufresne (5): s5p-fimc: Reuse calculated sizes s5p-fimc: Iterate for each memory plane s5p-fimc: Align imagesize to row

[PATCH 1/5] s5p-fimc: Changed RGB32 to BGR32

2014-03-25 Thread Nicolas Dufresne
Testing showed that HW produces BGR32 rather then RGB32 as exposed in the driver. The documentation seems to state the pixels are stored in little endian order. Signed-off-by: Nicolas Dufresne --- drivers/media/platform/exynos4-is/fimc-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 2/5] s5p-fimc: Fix YUV422P depth

2014-03-25 Thread Nicolas Dufresne
All YUV 422 has 16bit per pixels. Signed-off-by: Nicolas Dufresne --- drivers/media/platform/exynos4-is/fimc-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/exynos4-is/fimc-core.c b/drivers/media/platform/exynos4-is/fimc-core.c index bfb80fb

[PATCH 3/5] s5p-fimc: Align imagesize to row size for tiled formats

2014-03-25 Thread Nicolas Dufresne
-off-by: Nicolas Dufresne --- drivers/media/platform/exynos4-is/fimc-core.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/exynos4-is/fimc-core.c b/drivers/media/platform/exynos4-is/fimc-core.c index 2e70fab..0e94412 100644 --- a/drivers

[PATCH 5/5] s5p-fimc: Reuse calculated sizes

2014-03-25 Thread Nicolas Dufresne
This formula did not take into account the required tiled alignement for NV12MT format. As this was already computed an stored in payload array initially, reuse that value. Signed-off-by: Nicolas Dufresne --- drivers/media/platform/exynos4-is/fimc-m2m.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 1/5] s5p-fimc: Changed RGB32 to BGR32

2014-03-25 Thread Nicolas Dufresne
Testing showed that HW produces BGR32 rather then RGB32 as exposed in the driver. The documentation seems to state the pixels are stored in little endian order. Signed-off-by: Nicolas Dufresne --- drivers/media/platform/exynos4-is/fimc-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 4/5] s5p-fimc: Iterate for each memory plane

2014-03-25 Thread Nicolas Dufresne
Depth and payload is defined per memory plane. It's better to iterate using number of memory planes. This was not causing much issue since the rest of the arrays involved where intialized to zero. Signed-off-by: Nicolas Dufresne --- drivers/media/platform/exynos4-is/fimc-core.c | 2 +- dr

[PATCH 2/5] s5p-fimc: Fix YUV422P depth

2014-03-25 Thread Nicolas Dufresne
All YUV 422 has 16bit per pixels. Signed-off-by: Nicolas Dufresne --- drivers/media/platform/exynos4-is/fimc-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/exynos4-is/fimc-core.c b/drivers/media/platform/exynos4-is/fimc-core.c index bfb80fb

Re: [PATCH 3/5] s5p-fimc: Align imagesize to row size for tiled formats

2014-03-26 Thread Nicolas Dufresne
Le mardi 25 mars 2014 à 16:51 -0400, Nicolas Dufresne a écrit : > For tiled format, we need to allocated a multiple of the row size. A > good example is for 1280x720, wich get adjusted to 1280x736. In tiles, > this mean Y plane is 20x23 and UV plane 20x12. Because of the rounding, >

[PATCH 3/5] s5p-fimc: Roundup imagesize to row size for tiled formats

2014-03-26 Thread Nicolas Dufresne
-off-by: Nicolas Dufresne --- drivers/media/platform/exynos4-is/fimc-core.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/exynos4-is/fimc-core.c b/drivers/media/platform/exynos4-is/fimc-core.c index 2e70fab..7ea15ef 100644 --- a/drivers

Re: [PATCH 0/5] s5p-fimc: Misc fixes

2014-04-01 Thread Nicolas Dufresne
Any comment/input ? Le mardi 25 mars 2014 à 16:45 -0400, Nicolas Dufresne a écrit : > This patch series fixes several bugs found in the s5p-fimc driver. These > bugs relate to bad parameters in the formats definition and short size > of image buffers. > > Nicolas Dufresne (5

Re: [PATCH 1/5] s5p-fimc: Changed RGB32 to BGR32

2014-04-01 Thread Nicolas Dufresne
Le mardi 01 avril 2014 à 16:34 +0200, Sylwester Nawrocki a écrit : > It should be "BGRA, 32 bpp", I can fix it when applying, if > you won't send next version of this patch until then. Good catch, I'll let you fix when applying. thanks, Nicolas signature.asc Description: This is a digitall

[PATCH] vb2: Update buffer state flags after __vb2_dqbuf

2014-04-16 Thread Nicolas Dufresne
. Signed-off-by: Nicolas Dufresne --- drivers/media/v4l2-core/videobuf2-core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c index f9059bb..ac5026a 100644 --- a/drivers/media/v4l2-core

Poll and empty queues

2014-06-02 Thread Nicolas Dufresne
Hi everyone, Recently in GStreamer we notice that we where not handling the POLLERR flag at all. Though we found that what the code do, and what the doc says is slightly ambiguous. "When the application did not call VIDIOC_QBUF or VIDIOC_STREAMON yet the poll() function succeeds,

Re: Poll and empty queues

2014-06-03 Thread Nicolas Dufresne
Le mardi 03 juin 2014 à 08:38 +0200, Hans Verkuil a écrit : > Hi Nicholas, > > On 06/02/2014 09:47 PM, Nicolas Dufresne wrote: > > Hi everyone, > > > > Recently in GStreamer we notice that we where not handling the POLLERR > > flag at all. Though we found that w

Re: Poll and empty queues

2014-06-03 Thread Nicolas Dufresne
Le mardi 03 juin 2014 à 18:11 +0200, Laurent Pinchart a écrit : > Hi Nicolas, > > On Tuesday 03 June 2014 10:37:50 Nicolas Dufresne wrote: > > Le mardi 03 juin 2014 à 08:38 +0200, Hans Verkuil a écrit : > > > On 06/02/2014 09:47 PM, Nicolas Dufresne wr

Re: V4l2 state transition

2014-12-08 Thread Nicolas Dufresne
Le 2014-12-08 00:19, Bin Chen a écrit : Can anyone comment is following state transition diagram for V4l2 user space program make sense? Do you see any issues if we were to enforce this constraint? I think you should request some buffers before streamon. If in capture, you should also queue the

Re: V4l2 state transition

2014-12-08 Thread Nicolas Dufresne
Le 2014-12-08 09:29, Nicolas Dufresne a écrit : Le 2014-12-08 00:19, Bin Chen a écrit : Can anyone comment is following state transition diagram for V4l2 user space program make sense? Do you see any issues if we were to enforce this constraint? I think you should request some buffers before

LibV4L2 and CREATE_BUFS issues

2014-12-10 Thread Nicolas Dufresne
Hi, we recently fixed our CREATE_BUFS support in GStreamer master. It works nicely with UVC drivers. The problem is that libv4l2 isn't aware of it, and endup taking terribly decision the least quickly lead to crash. I'm not sure what that right approach. It seems non-trivial to support it, at lea

Re: coda: not generating EOS event

2014-12-11 Thread Nicolas Dufresne
Le jeudi 11 décembre 2014 à 11:00 -0200, Fabio Estevam a écrit : > Hi, > > I am running Gstreamer 1.4.4 with on a imx6q-sabresd board and I am > able to decode a video through the coda driver. > > The pipeline I use is: > gst-launch-1.0 filesrc > location=/home/H264_test1_Talkinghead_mp4_480x360.

Re: LibV4L2 and CREATE_BUFS issues

2014-12-13 Thread Nicolas Dufresne
Le 2014-12-13 05:41, Hans de Goede a écrit : I think making CREATE_BUFS fail when doing conversion is probably best, note that gstreamer should be able to tell which formats will lead to doing conversion, and that it can try to avoid those. Those format indeed have a flag. The problem is for

Re: LibV4L2 and CREATE_BUFS issues

2014-12-14 Thread Nicolas Dufresne
Le 2014-12-14 04:49, Hans de Goede a écrit : Ah yes I see, so I assume that if libv4l where to return a failure for CREATE_BUFS when conversion is used, that gstreamer will then fallback to a regular REQUEST_BUFS call ? Then that indeed seems the best solution, can you submit patch for this ?

Re: LibV4L2 and CREATE_BUFS issues

2014-12-15 Thread Nicolas Dufresne
Le 2014-12-15 10:58, Hans de Goede a écrit : Hi, Hmm, is that jpeg overflow still there with my recent (aprok 2-3 weeks ago) fix for this? I'll need to check, might have been my fault too, since I was trying to reallocate the frames segment to implement support for CREATE_BUFS, without prop

[PATCH 0/3] Various fixes for s5p-mfc driver

2014-12-15 Thread Nicolas Dufresne
the control properties was preventing it. There was basically no way other then setting a large delay value to get the frames in display order. Nicolas Dufresne (3): s5p-mfc-v6+: Use display_delay_enable CID s5p-mfc-dec: Don't use encoder stop command media-doc: Fix MFC display delay co

[PATCH 2/3] s5p-mfc-dec: Don't use encoder stop command

2014-12-15 Thread Nicolas Dufresne
The decoder should handle V4L2_DEC_CMD_STOP to trigger drain, but it currently expecting V4L2_ENC_CMD_STOP. Signed-off-by: Nicolas Dufresne --- drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/s5p-mfc

<    1   2   3   4   >