Re: [PATCH RFC] media: OF: add field-active and sync-on-green endpoint properties

2013-05-16 Thread Prabhakar Lad
Hi Sylwester, On Thu, May 16, 2013 at 4:13 PM, Sylwester Nawrocki wrote: > Hi, > > > On 05/16/2013 06:53 AM, Prabhakar Lad wrote: >>>> [Snip] >> May be we rename "field-active" to "fid-pol" ? > > > I guess we failed to clearly descr

Re: [PATCH RFC] media: OF: add field-active and sync-on-green endpoint properties

2013-05-16 Thread Prabhakar Lad
e V4L2_MBUS_FIELD_EVEN_LOW (1<< 11) >> +#define V4L2_MBUS_FIELD_ACTIVE (1<< 12) >> +#define V4L2_MBUS_SOG (1<< 13) > > > How about V4L2_MBUS_SYNC_ON_GREEN ? > OK makes it more readable. Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/6] ARM: davinci: dm365 evm: remove init_enable from ths7303 pdata

2013-05-16 Thread Prabhakar Lad
Hi Laurent, On Wed, May 15, 2013 at 5:41 PM, Prabhakar Lad wrote: > Hi Laurent, > > Thanks for the review. > > On Wed, May 15, 2013 at 5:35 PM, Laurent Pinchart > wrote: >> Hi Prabhakar, >> >> Thank you for the patch. >> >> On Wednesday 15 May

Re: [PATCH v3] media: i2c: tvp514x: add OF support

2013-05-16 Thread Prabhakar Lad
ity = 1; >> + >> + if (flags & V4L2_MBUS_PCLK_SAMPLE_RISING) >> + pdata->clk_polarity = 1; >> + > > As well as here. Maybe a > > done: > of_node_put(endpoint); > return pdata; > > with a goto done in the

Re: [PATCH v3] media: i2c: tvp514x: add OF support

2013-05-16 Thread Prabhakar Lad
Hi Laurent, On Thu, May 16, 2013 at 6:20 PM, Laurent Pinchart wrote: > Hi Prabhakar, > > On Thursday 16 May 2013 18:13:38 Prabhakar Lad wrote: >> On Thu, May 16, 2013 at 5:40 PM, Laurent Pinchart wrote: >> > Hi Prabhakar, >> >> [Snip] >> >> &g

Re: [PATCH 1/6] media: i2c: ths7303: remove init_enable option from pdata

2013-05-16 Thread Prabhakar Lad
pdata->init_enable; >> - >> - mask = state->stream_on ? 0xff : 0xf8; >> + mask = 0xf8; > > You can assign mask in declaration. It'd be nice to have a human-readable > name for the mask, too. > This function gets removed in the preceding patch of this series

Re: [PATCH 1/7] media: davinci: vpif: remove unwanted header includes

2013-05-16 Thread Prabhakar Lad
izes the kernel headers > internal includes then the driver might break. As a general rule of good > practice you should include headers for all the APIs you use. > OK, do you want me too drop the similar patches from this series ? Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH RFC v2] media: OF: add sync-on-green endpoint property

2013-05-21 Thread Prabhakar Lad
end non RFC version of it ? Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/4] media: remove duplicate check for EPERM

2013-05-21 Thread Prabhakar Lad
gister > media: dvb-frontends: remove duplicate checks for EPERM in > dbg_g/s_register > media: usb: remove duplicate checks for EPERM in vidioc_g/s_register > media: pci: remove duplicate checks for EPERM > Gentle ping.. Regards, --Prabhakar Lad -- To unsubscribe from this li

Re: [PATCH 0/6] media: i2c: ths7303 feature enhancement and cleanup

2013-05-23 Thread Prabhakar Lad
have that I can take in the first four patches and I can take the > final two patches once the async support is merged. > Ok I'll do it today. Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/6] ARM: davinci: dm365 evm: remove init_enable from ths7303 pdata

2013-05-23 Thread Prabhakar Lad
Hi Sekhar, On Wed, May 15, 2013 at 5:27 PM, Lad Prabhakar wrote: > From: Lad, Prabhakar > > remove init_enable from ths7303 pdata as it is no longer exists. > Can you please ack this patch, as this patch is intended to go via media tree. Regards, --Prabhakar Lad -- To unsubscri

Re: [PATCH] [media] vpif_display: fix error return code in vpif_probe()

2013-05-23 Thread Prabhakar Lad
Hi Hans, On Mon, May 13, 2013 at 11:34 AM, Prabhakar Lad wrote: > Hi Wei, > > Thanks for the patch. > > On Mon, May 13, 2013 at 11:27 AM, Wei Yongjun wrote: >> From: Wei Yongjun >> >> Fix to return -ENODEV in the subdevice register error handling >> case

Re: [PATCH] drivers/staging: davinci: vpfe: fix dependency for building the driver

2013-05-23 Thread Prabhakar Lad
to take this patch for 3.10 as a fix ? or for v3.11 ? Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/7] media: davinci: vpif trivial cleanup

2013-05-23 Thread Prabhakar Lad
the code. >> >> This patch series applies on 3.10.rc1 and is tested on OMAP-L138. > > Can you repost this taken into account Laurent's comments regarding the > unwanted header includes? > Yes I plan to do this weekend. Regards, --Prabhakar Lad -- To unsubscribe from t

Re: [PATCH 3/5] media: i2c: tvp7002: rearrange header inclusion alphabetically

2013-05-23 Thread Prabhakar Lad
gt; headers. > OK > I would just drop this patch. I've merged the first two patches of > this patch series, the last two I can't merge as long as the async > code isn't in yet. > Thanks. yes the last two depend on v4l-async patches. Regards, --Prabhakar Lad -- To

Re: [v3] media: davinci: kconfig: fix incorrect selects

2013-05-23 Thread Prabhakar Lad
Hi Hans, On Thu, May 23, 2013 at 3:53 PM, Hans Verkuil wrote: > On Mon 13 May 2013 12:41:26 Prabhakar Lad wrote: >> Hi Paul, >> >> On Mon, May 13, 2013 at 3:35 PM, Paul Bolle wrote: >> > Prabhakar, >> > >> > On Mon, 2013-05-13 at 15:27 +

Re: [PATCH RFC v2] media: OF: add sync-on-green endpoint property

2013-05-25 Thread Prabhakar Lad
could perhaps define > 'component-sync' or similar property that would enumerate all possible > synchronisation methods. We might as well use separate boolean properties, > but I'm a bit concerned about the increasing number of properties that need > to be parsed for each

Re: [PATCH RFC v2] media: OF: add sync-on-green endpoint property

2013-05-25 Thread Prabhakar Lad
Hi Sylwester, On Sat, May 25, 2013 at 7:41 PM, Sylwester Nawrocki wrote: > Hi, > > > On 05/25/2013 11:17 AM, Prabhakar Lad wrote: >>> >>> From looking at Figure 8 "TVP7002 Application Example" in the TVP7002's >>> > datasheet >>&

[PATCH v2 0/5] media: davinci: vpif trivial cleanup

2013-05-25 Thread Prabhakar Lad
From: Lad, Prabhakar This patch series cleans the VPIF driver, uses devm_* api wherever required and uses module_platform_driver() to simplify the code. This patch series applies on http://git.linuxtv.org/hverkuil/media_tree.git/ shortlog/refs/heads/for-v3.11 and is tested on OMAP-L138. Changes

[PATCH v2 1/5] media: davinci: vpif: remove unwanted header mach/hardware.h and sort the includes alphabetically

2013-05-25 Thread Prabhakar Lad
From: Lad, Prabhakar This patch removes unwanted header include of mach/hardware.h and along side sorts the header inclusion alphabetically. Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpif.c | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a

[PATCH v2 2/5] media: davinci: vpif: Convert to devm_* api

2013-05-25 Thread Prabhakar Lad
From: Lad, Prabhakar Use devm_ioremap_resource instead of reques_mem_region()/ioremap(). This ensures more consistent error values and simplifies error paths. Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpif.c | 27 --- 1 files changed, 4 insertio

[PATCH v2 3/5] media: davinci: vpif: remove unnecessary braces around defines

2013-05-25 Thread Prabhakar Lad
From: Lad, Prabhakar Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpif.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/davinci/vpif.c b/drivers/media/platform/davinci/vpif.c index 164c1b7..d9269c9 100644 --- a/drivers

[PATCH v2 4/5] media: davinci: vpif_capture: Convert to devm_* api

2013-05-25 Thread Prabhakar Lad
From: Lad, Prabhakar use devm_request_irq() instead of request_irq(). This ensures more consistent error values and simplifies error paths. use module_platform_driver to simplify the code. Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpif_capture.c | 73 +

[PATCH v2 5/5] media: davinci: vpif_display: Convert to devm_* api

2013-05-25 Thread Prabhakar Lad
From: Lad, Prabhakar use devm_request_irq() instead of request_irq(). This ensures more consistent error values and simplifies error paths. use module_platform_driver to simplify the code. Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpif_display.c | 61 +

[PATCH v2 4/4] media: i2c: ths7303: make the pdata as a constant pointer

2013-05-25 Thread Prabhakar Lad
From: Lad, Prabhakar generally the pdata needs to be a constant pointer in the device state structure. This patch makes the pdata as a constant pointer and alongside returns -EINVAL when pdata is NULL. Signed-off-by: Lad, Prabhakar Cc: Hans Verkuil Cc: Laurent Pinchart Cc: Mauro Carvalho Cheh

[PATCH v2 3/4] media: i2c: ths7303: remove unnecessary function ths7303_setup()

2013-05-25 Thread Prabhakar Lad
From: Lad, Prabhakar the ths7303_setup() was doing the same thing as ths7303_setval() except that ths7303_setval() sets it to some particular mode. This patch removes ths7303_setup() function and calls ths7303_setval() in the probe setting the device to 480I_576I filter mode in the probe. Signed

[PATCH v2 0/4] media: i2c: ths7303 cleanup

2013-05-25 Thread Prabhakar Lad
From: Lad, Prabhakar Trivial cleanup of the driver. Changes for v2: 1: Dropped the asynchronous probing and, OF support patches will be handling them independently because of dependencies. 2: Arranged the patches logically so that git bisect succeeds. Lad, Prabhakar (4): ARM: davinci:

[PATCH v2 1/4] ARM: davinci: dm365 evm: remove init_enable from ths7303 pdata

2013-05-25 Thread Prabhakar Lad
From: Lad, Prabhakar remove init_enable from ths7303 pdata as it is being dropped from ths7303_platform_data. Signed-off-by: Lad, Prabhakar Cc: Sekhar Nori Cc: Hans Verkuil Cc: Laurent Pinchart Cc: Mauro Carvalho Chehab Cc: linux-ker...@vger.kernel.org Cc: davinci-linux-open-sou...@linux.da

[PATCH v2 2/4] media: i2c: ths7303: remove init_enable option from pdata

2013-05-25 Thread Prabhakar Lad
From: Lad, Prabhakar This patch removes init_enable option from pdata, the init_enable was intended that the device should start streaming video immediately but ideally the bridge drivers should call s_stream explicitly for such devices to start video. Signed-off-by: Lad, Prabhakar Cc: Hans Ver

Re: [PATCH v2 1/4] ARM: davinci: dm365 evm: remove init_enable from ths7303 pdata

2013-05-25 Thread Prabhakar Lad
Hi Sekhar, On Sat, May 25, 2013 at 11:09 PM, Prabhakar Lad wrote: > From: Lad, Prabhakar > > remove init_enable from ths7303 pdata as it is being dropped > from ths7303_platform_data. > Can you please ack this patch as I intend to take this patch via media tree. Regards, --Prab

[PATCH v3 0/9] media: davinci: vpif trivial cleanup

2013-05-26 Thread Prabhakar Lad
From: Lad, Prabhakar This patch series cleans the VPIF driver, uses devm_* api wherever required and uses module_platform_driver() to simplify the code. This patch series applies on http://git.linuxtv.org/hverkuil/media_tree.git/ shortlog/refs/heads/for-v3.11 and is tested on OMAP-L138. Changes

[PATCH v3 1/9] media: davinci: vpif: remove unwanted header mach/hardware.h and sort the includes alphabetically

2013-05-26 Thread Prabhakar Lad
From: Lad, Prabhakar This patch removes unwanted header include of mach/hardware.h and along side sorts the header inclusion alphabetically. Signed-off-by: Lad, Prabhakar Acked-by: Laurent Pinchart --- drivers/media/platform/davinci/vpif.c | 10 -- 1 files changed, 4 insertions(+),

[PATCH v3 2/9] media: davinci: vpif: Convert to devm_* api

2013-05-26 Thread Prabhakar Lad
From: Lad, Prabhakar Use devm_ioremap_resource instead of reques_mem_region()/ioremap(). This ensures more consistent error values and simplifies error paths. Signed-off-by: Lad, Prabhakar Acked-by: Laurent Pinchart --- drivers/media/platform/davinci/vpif.c | 27 ---

[PATCH v3 5/9] media: davinci: vpif_capture: use module_platform_driver()

2013-05-26 Thread Prabhakar Lad
From: Lad, Prabhakar This patch uses module_platform_driver() to simplify the code. Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpif_capture.c | 28 + 1 files changed, 1 insertions(+), 27 deletions(-) diff --git a/drivers/media/platform/davinci/v

[PATCH v3 8/9] media: davinci: vpif_display: use module_platform_driver()

2013-05-26 Thread Prabhakar Lad
From: Lad, Prabhakar This patch uses module_platform_driver() to simplify the code. Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpif_display.c | 18 +- 1 files changed, 1 insertions(+), 17 deletions(-) diff --git a/drivers/media/platform/davinci/vpif_dis

[PATCH v3 9/9] media: davinci: vpif_display: Convert to devm_* api

2013-05-26 Thread Prabhakar Lad
From: Lad, Prabhakar use devm_request_irq() instead of request_irq(). This ensures more consistent error values and simplifies error paths. Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpif_display.c | 35 ++-- 1 files changed, 9 insertions(+), 26 dele

[PATCH v3 3/9] media: davinci: vpif: remove unnecessary braces around defines

2013-05-26 Thread Prabhakar Lad
From: Lad, Prabhakar This patch removes unnecessary braces around defines. Signed-off-by: Lad, Prabhakar Acked-by: Laurent Pinchart --- drivers/media/platform/davinci/vpif.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/davinci/vpif.c

[PATCH v3 4/9] media: davinci: vpif_capture: move the freeing of irq and global variables to remove()

2013-05-26 Thread Prabhakar Lad
From: Lad, Prabhakar Ideally the freeing of irq's and the global variables needs to be done in the remove() rather than module_exit(), this patch moves the freeing up of irq's and freeing the memory allocated to channel objects to remove() callback of struct platform_driver. Signed-off-by: Lad,

[PATCH v3 6/9] media: davinci: vpif_capture: Convert to devm_* api

2013-05-26 Thread Prabhakar Lad
From: Lad, Prabhakar use devm_request_irq() instead of request_irq(). This ensures more consistent error values and simplifies error paths. Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpif_capture.c | 38 - 1 files changed, 12 insertions(+), 26 de

[PATCH v3 7/9] media: davinci: vpif_display: move the freeing of irq and global variables to remove()

2013-05-26 Thread Prabhakar Lad
From: Lad, Prabhakar Ideally the freeing of irq's and the global variables needs to be done in the remove() rather than module_exit(), this patch moves the freeing up of irq's and freeing the memory allocated to channel objects to remove() callback of struct platform_driver. Signed-off-by: Lad,

[PATCH v4] media: i2c: tvp514x: add OF support

2013-05-26 Thread Prabhakar Lad
From: Lad, Prabhakar add OF support for the tvp514x driver. Signed-off-by: Lad, Prabhakar Cc: Hans Verkuil Cc: Laurent Pinchart Cc: Mauro Carvalho Chehab Cc: Guennadi Liakhovetski Cc: Sylwester Nawrocki Cc: Sakari Ailus Cc: Grant Likely Cc: Rob Herring Cc: Rob Landley Cc: devicetree-di

Re: [PATCH v4] media: i2c: tvp514x: add OF support

2013-05-26 Thread Prabhakar Lad
Hi All, On Sun, May 26, 2013 at 6:10 PM, Prabhakar Lad wrote: > From: Lad, Prabhakar > > add OF support for the tvp514x driver. > > Signed-off-by: Lad, Prabhakar > Cc: Hans Verkuil > Cc: Laurent Pinchart > Cc: Mauro Carvalho Chehab > Cc: Guennadi Liakhovetski >

[PATCH] media: i2c: mt9p031: add OF support

2013-05-26 Thread Prabhakar Lad
From: Lad, Prabhakar add OF support for the mt9p031 sensor driver. Alongside this patch sorts the header inclusion alphabetically. Signed-off-by: Lad, Prabhakar Cc: Hans Verkuil Cc: Laurent Pinchart Cc: Mauro Carvalho Chehab Cc: Guennadi Liakhovetski Cc: Sylwester Nawrocki Cc: Sakari Ailus

[PATCH v5] media: i2c: tvp514x: add OF support

2013-05-26 Thread Prabhakar Lad
From: Lad, Prabhakar add OF support for the tvp514x driver. Signed-off-by: Lad, Prabhakar Cc: Hans Verkuil Cc: Laurent Pinchart Cc: Mauro Carvalho Chehab Cc: Guennadi Liakhovetski Cc: Sylwester Nawrocki Cc: Sakari Ailus Cc: Grant Likely Cc: Rob Herring Cc: Rob Landley Cc: devicetree-di

[PATCH] media: i2c: ths7303: add OF support

2013-05-26 Thread Prabhakar Lad
From: Lad, Prabhakar add OF support for the ths7303 driver. Signed-off-by: Lad, Prabhakar Cc: Hans Verkuil Cc: Laurent Pinchart Cc: Mauro Carvalho Chehab Cc: Guennadi Liakhovetski Cc: Sylwester Nawrocki Cc: Sakari Ailus Cc: Grant Likely Cc: Rob Herring Cc: Rob Landley Cc: devicetree-di

Re: [PATCH] media: i2c: mt9p031: add OF support

2013-05-28 Thread Prabhakar Lad
Hi Laurent, On Wed, May 29, 2013 at 9:01 AM, Laurent Pinchart wrote: > Hi Prabhakar, > > Thanks for the patch. > > On Sunday 26 May 2013 18:38:54 Prabhakar Lad wrote: >> From: Lad, Prabhakar >> >> add OF support for the mt9p031 sensor driver. >> Alongsid

Re: [PATCH v3 4/9] media: davinci: vpif_capture: move the freeing of irq and global variables to remove()

2013-05-28 Thread Prabhakar Lad
Hi Laurent, Thanks for the review. On Wed, May 29, 2013 at 8:02 AM, Laurent Pinchart wrote: > Hi Prabhakar, > > Thanks for the patch. > > On Sunday 26 May 2013 17:30:07 Prabhakar Lad wrote: >> From: Lad, Prabhakar >> >> Ideally the freeing of irq's and th

Re: [PATCH v3 9/9] media: davinci: vpif_display: Convert to devm_* api

2013-05-28 Thread Prabhakar Lad
Hi Laurent, On Wed, May 29, 2013 at 9:08 AM, Laurent Pinchart wrote: > On Sunday 26 May 2013 17:30:12 Prabhakar Lad wrote: >> From: Lad, Prabhakar >> >> use devm_request_irq() instead of request_irq(). This ensures >> more consistent error values and simplifies error

Re: [PATCH v5] media: i2c: tvp514x: add OF support

2013-05-28 Thread Prabhakar Lad
Hi Laurent, On Wed, May 29, 2013 at 6:52 AM, Laurent Pinchart wrote: > Hi Prabhakar, > > Thanks for the patch. > > On Sunday 26 May 2013 18:49:46 Prabhakar Lad wrote: >> From: Lad, Prabhakar >> >> add OF support for the tvp514x driver. >> >> Signe

Re: [RFC PATCH 07/14] tvp514x: fix querystd

2013-05-30 Thread Prabhakar Lad
rabhakar Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCHv1 02/38] v4l2: remove g_chip_ident from bridge drivers where it is easy to do so.

2013-05-30 Thread Prabhakar Lad
Cc: Andrey Smirnov > --- > drivers/media/platform/davinci/vpif_capture.c | 66 > > drivers/media/platform/davinci/vpif_display.c | 66 > ---- for the above, Acked-by: Lad, Prabhakar Regards, --Prabhakar Lad -- To unsubscribe from t

Re: [PATCHv1 28/38] vpbe_display: drop g/s_register ioctls.

2013-05-30 Thread Prabhakar Lad
Hi Hans, Thanks for the patch. On Wed, May 29, 2013 at 4:30 PM, Hans Verkuil wrote: > From: Hans Verkuil > > These are no longer needed: register access to subdevices no longer needs > the bridge driver to forward them. > > Signed-off-by: Hans Verkuil > Cc: Prabhaka

Re: [PATCHv1 34/38] media/i2c: fill in missing reg->size fields.

2013-05-30 Thread Prabhakar Lad
Hi Hans, Thanks for the patch. On Wed, May 29, 2013 at 4:30 PM, Hans Verkuil wrote: > From: Hans Verkuil > > Signed-off-by: Hans Verkuil > Cc: Prabhakar Lad > Cc: Guennadi Liakhovetski > --- > drivers/media/i2c/tvp7002.c|1 + For the above, Ack

Re: [PATCHv1 18/38] media/i2c: remove g_chip_ident op.

2013-05-30 Thread Prabhakar Lad
Hi Hans, Thanks for the patch. On Wed, May 29, 2013 at 4:29 PM, Hans Verkuil wrote: > From: Hans Verkuil > > This is no longer needed since the core now handles this through > DBG_G_CHIP_INFO. > > Signed-off-by: Hans Verkuil > Cc: Laurent Pinchart > Cc: Prabhakar Lad

Re: [PATCH v2 1/4] ARM: davinci: dm365 evm: remove init_enable from ths7303 pdata

2013-05-31 Thread Prabhakar Lad
Hi Sekhar, On Sat, May 25, 2013 at 11:13 PM, Prabhakar Lad wrote: > Hi Sekhar, > > On Sat, May 25, 2013 at 11:09 PM, Prabhakar Lad > wrote: >> From: Lad, Prabhakar >> >> remove init_enable from ths7303 pdata as it is being dropped >> from ths7303_platfor

[PATCH 0/2] media: i2c: add suppport for ths8200 encoder.

2013-06-03 Thread Prabhakar Lad
From: Lad, Prabhakar The first patch of the series adds support for the THS8200 encoder The full datasheets are available from TI website[1]. The second patch of the series adds supports for v4l-async subdevice probing. [1] http://www.ti.com/product/ths8200 Hans Verkuil (1): media: i2c: ths82

[PATCH 1/2] media: i2c: ths8200: driver for TI video encoder.

2013-06-03 Thread Prabhakar Lad
From: Hans Verkuil The full datasheets are available from TI website:- http://www.ti.com/product/ths8200 Note:- This patch adds support only for progressive format as of now. Signed-off-by: Hans Verkuil Signed-off-by: Mats Randgaard Signed-off-by: Martin Bugge Signed-off-by: Lad, Prabhakar

[PATCH 2/2] media: i2c: ths8200: add support v4l-async

2013-06-03 Thread Prabhakar Lad
From: Lad, Prabhakar This patch supports ths8200 driver for v4l-async subdevice probing. Signed-off-by: Lad, Prabhakar --- drivers/media/i2c/ths8200.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/drivers/media/i2c/ths8200.c b/drivers/media/i2c/ths8200.c ind

[PATCH v6] media: i2c: tvp514x: add OF support

2013-06-04 Thread Prabhakar Lad
From: Lad, Prabhakar add OF support for the tvp514x driver. Signed-off-by: Lad, Prabhakar Acked-by: Laurent Pinchart Cc: Hans Verkuil Cc: Mauro Carvalho Chehab Cc: Guennadi Liakhovetski Cc: Sylwester Nawrocki Cc: Sakari Ailus Cc: Grant Likely Cc: Rob Herring Cc: Rob Landley Cc: devicet

Re: [PATCH v2 1/4] ARM: davinci: dm365 evm: remove init_enable from ths7303 pdata

2013-06-06 Thread Prabhakar Lad
Hi Sekhar, On Thu, Jun 6, 2013 at 10:06 AM, Sekhar Nori wrote: > On 5/25/2013 11:09 PM, Prabhakar Lad wrote: >> From: Lad, Prabhakar >> >> remove init_enable from ths7303 pdata as it is being dropped >> from ths7303_platform_data. >> >> Signed-off-by: La

Re: [PATCH v2 0/4] media: i2c: ths7303 cleanup

2013-06-06 Thread Prabhakar Lad
Hi Hans, On Sun, May 26, 2013 at 6:50 AM, Laurent Pinchart wrote: > On Saturday 25 May 2013 23:09:32 Prabhakar Lad wrote: >> From: Lad, Prabhakar >> >> Trivial cleanup of the driver. >> >> Changes for v2: >> 1: Dropped the asynchronous probing and, OF >

Re: [PATCH v2 0/4] media: i2c: ths7303 cleanup

2013-06-08 Thread Prabhakar Lad
Hi Hans, On Fri, Jun 7, 2013 at 2:10 PM, Hans Verkuil wrote: > On Thu June 6 2013 12:05:38 Prabhakar Lad wrote: >> Hi Hans, >> >> On Sun, May 26, 2013 at 6:50 AM, Laurent Pinchart >> wrote: >> > On Saturday 25 May 2013 23:09:32 Prabhakar L

Re: [RFC PATCH 2/2] davinci_vpfe: Clean up media entity after unregistering subdev

2013-06-11 Thread Prabhakar Lad
d, Prabhakar Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v10 15/21] V4L2: add a device pointer to struct v4l2_subdev

2013-06-12 Thread Prabhakar Lad
ff-by: Guennadi Liakhovetski Acked-by: Lad, Prabhakar Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v10 16/21] V4L2: support asynchronous subdevice registration

2013-06-12 Thread Prabhakar Lad
tion callbacks, > that will be called upon various related events. > > Signed-off-by: Guennadi Liakhovetski Acked-by: Lad, Prabhakar Tested-by: Lad, Prabhakar Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a me

Re: [REVIEWv2 PATCH 01/12] v4l2-device: check if already unregistered.

2013-06-12 Thread Prabhakar Lad
that already happened and just return if that was > the case. > > Also refure to register a v4l2_device if both the dev and name fields are s/refure/refuse Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a messa

[PATCH] media: i2c: ths7303: remove unused member driver_data

2013-06-15 Thread Prabhakar Lad
From: "Lad, Prabhakar" This patch removes the driver_data member from ths7303_state structure. The driver_data member was intended to differentiate between ths7303 and ths7353 chip and get the g_chip_ident, But as of now g_chip_ident is obsolete, so there is no need of driver_data. Signed-off-by

Re: [PATCH] media: i2c: ths7303: remove unused member driver_data

2013-06-15 Thread Prabhakar Lad
Hi Laurent, On Sun, Jun 16, 2013 at 5:21 AM, Laurent Pinchart wrote: > Hi Prabhakar, > > Thanks for the patch. > > On Saturday 15 June 2013 22:04:10 Prabhakar Lad wrote: >> From: "Lad, Prabhakar" >> >> This patch removes the driver_data member from

Re: [PATCH] [media] tvp514x: Fix init seqeunce

2013-06-16 Thread Prabhakar Lad
edia/i2c/tvp514x.c: In function 'tvp514x_probe': drivers/media/i2c/tvp514x.c:1092: warning: assignment makes pointer from integer without a cast With the above fixed you can add my, Acked-by: Lad, Prabhakar Tested-by: Lad, Prabhakar Regards, --Prabhakar Lad -- To unsubscribe from this list:

Re: [PATCH v11 16/21] V4L2: support asynchronous subdevice registration

2013-06-16 Thread Prabhakar Lad
ks, > that will be called upon various related events. > > Signed-off-by: Guennadi Liakhovetski Acked-by: Lad, Prabhakar Tested-by: Lad, Prabhakar Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to

Re: [PATCH v11 15/21] V4L2: add a device pointer to struct v4l2_subdev

2013-06-16 Thread Prabhakar Lad
e I2C and SPI cases. > > Signed-off-by: Guennadi Liakhovetski Acked-by: Lad, Prabhakar Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC PATCH 2/2] davinci_vpfe: Clean up media entity after unregistering subdev

2013-06-17 Thread Prabhakar Lad
Hi Sylwester, On Mon, Jun 17, 2013 at 2:46 AM, Sylwester Nawrocki wrote: > Hi, > > > On 06/12/2013 06:44 AM, Prabhakar Lad wrote: >> >> On Tue, Jun 11, 2013 at 4:20 PM, Sakari Ailus wrote: >>> >>> media_entity_cleanup() frees

[PATCH v4 00/11] media: davinci: vpif driver cleanup

2013-06-17 Thread Prabhakar Lad
From: "Lad, Prabhakar" This patch series cleans the VPIF driver, uses devm_* api wherever required and uses module_platform_driver() to simplify the code. This patch series applies on http://git.linuxtv.org/hverkuil/media_tree.git/ shortlog/refs/heads/for-v3.11 and is tested on OMAP-L138 EVM. C

[PATCH v4 09/11] media: davinci: vpif_display: use module_platform_driver()

2013-06-17 Thread Prabhakar Lad
From: "Lad, Prabhakar" This patch uses module_platform_driver() to simplify the code. Signed-off-by: Lad, Prabhakar Acked-by: Laurent Pinchart --- drivers/media/platform/davinci/vpif_display.c | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/drivers/med

[PATCH v4 02/11] media: davinci: vpif: Convert to devm_* api

2013-06-17 Thread Prabhakar Lad
From: "Lad, Prabhakar" Use devm_ioremap_resource instead of reques_mem_region()/ioremap(). This ensures more consistent error values and simplifies error paths. Signed-off-by: Lad, Prabhakar Acked-by: Laurent Pinchart --- drivers/media/platform/davinci/vpif.c | 27 --

[PATCH v4 10/11] media: davinci: vpif_display: Convert to devm_* api

2013-06-17 Thread Prabhakar Lad
From: "Lad, Prabhakar" use devm_request_irq() instead of request_irq(). This ensures more consistent error values and simplifies error paths. Signed-off-by: Lad, Prabhakar Acked-by: Laurent Pinchart --- drivers/media/platform/davinci/vpif_display.c | 35 +++-- 1 file cha

[PATCH v4 08/11] media: davinci: vpif_display: move the freeing of irq and global variables to remove()

2013-06-17 Thread Prabhakar Lad
From: "Lad, Prabhakar" Ideally the freeing of irq's and the global variables needs to be done in the remove() rather than module_exit(), this patch moves the freeing up of irq's and freeing the memory allocated to channel objects to remove() callback of struct platform_driver. Signed-off-by: Lad

[PATCH v4 03/11] media: davinci: vpif: remove unnecessary braces around defines

2013-06-17 Thread Prabhakar Lad
From: "Lad, Prabhakar" This patch removes unnecessary braces around defines. Signed-off-by: Lad, Prabhakar Acked-by: Laurent Pinchart --- drivers/media/platform/davinci/vpif.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/davinci/vpif.c

[PATCH v4 11/11] media: davinci: vpif_display: remove unnecessary loop for IRQ resource

2013-06-17 Thread Prabhakar Lad
From: "Lad, Prabhakar" For vpif display driver each IRQ resource contains a single IRQ so drop the second loop. Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpif_display.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/medi

[PATCH v4 06/11] media: davinci: vpif_capture: Convert to devm_* api

2013-06-17 Thread Prabhakar Lad
From: "Lad, Prabhakar" use devm_request_irq() instead of request_irq(). This ensures more consistent error values and simplifies error paths. Signed-off-by: Lad, Prabhakar Acked-by: Laurent Pinchart --- drivers/media/platform/davinci/vpif_capture.c | 36 + 1 file cha

[PATCH v4 07/11] media: davinci: vpif_capture: remove unnecessary loop for IRQ resource

2013-06-17 Thread Prabhakar Lad
From: "Lad, Prabhakar" For vpif capture driver each IRQ resource contains a single IRQ so drop the second loop. Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpif_capture.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/media

[PATCH v4 05/11] media: davinci: vpif_capture: use module_platform_driver()

2013-06-17 Thread Prabhakar Lad
From: "Lad, Prabhakar" This patch uses module_platform_driver() to simplify the code. Signed-off-by: Lad, Prabhakar Acked-by: Laurent Pinchart --- drivers/media/platform/davinci/vpif_capture.c | 28 + 1 file changed, 1 insertion(+), 27 deletions(-) diff --git a/driv

[PATCH v4 04/11] media: davinci: vpif_capture: move the freeing of irq and global variables to remove()

2013-06-17 Thread Prabhakar Lad
From: "Lad, Prabhakar" Ideally the freeing of irq's and the global variables needs to be done in the remove() rather than module_exit(), this patch moves the freeing up of irq's and freeing the memory allocated to channel objects to remove() callback of struct platform_driver. Signed-off-by: Lad

[PATCH v4 01/11] media: davinci: vpif: remove unwanted header mach/hardware.h and sort the includes alphabetically

2013-06-17 Thread Prabhakar Lad
From: "Lad, Prabhakar" This patch removes unwanted header include of mach/hardware.h and along side sorts the header inclusion alphabetically. Signed-off-by: Lad, Prabhakar Acked-by: Laurent Pinchart --- drivers/media/platform/davinci/vpif.c | 10 -- 1 file changed, 4 insertions(+),

Re: [PATCH v11 14/21] V4L2: add temporary clock helpers

2013-06-17 Thread Prabhakar Lad
dopting the clock API, should switch to using it. Eventually > this temporary API should be removed. > > Signed-off-by: Guennadi Liakhovetski Acked-by: Lad, Prabhakar Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-media&

Re: [PATCH] V4L2: add documentation for V4L2 clock helpers and asynchronous probing

2013-06-17 Thread Prabhakar Lad
Hi Guennadi, Thanks for the patch. On Mon, Jun 17, 2013 at 11:34 AM, Guennadi Liakhovetski wrote: > Add documentation for the V4L2 clock and V4L2 asynchronous probing APIs > to v4l2-framework.txt. > > Signed-off-by: Guennadi Liakhovetski Reviewed-by: Lad, Prabhakar Regards, --P

Re: [REVIEW PATCH 3/3] omap_vout: fix compiler warning

2013-06-20 Thread Prabhakar Lad
^ > > Signed-off-by: Hans Verkuil > Cc: Laurent Pinchart > Cc: Prabhakar Lad Acked-by: Lad, Prabhakar Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] [media] tvp514x: Fix init seqeunce

2013-06-21 Thread Prabhakar Lad
Hi Lars-Peter, On Sun, Jun 16, 2013 at 3:41 PM, Prabhakar Lad wrote: > Hi Lars-Peter, > > Thanks for the patch. > > On Sat, Jun 15, 2013 at 8:04 PM, Lars-Peter Clausen wrote: >> client->driver->id_table will always point to the first entry in the device >> id

Re: [GIT PULL FOR v3.11] Conversions to v4l-async

2013-06-21 Thread Prabhakar Lad
l-async > These patches needs to be reworked on.These patches were based on earlier version of v4l-async, the v4l-async got changed in last version due to which there is a little bit of rework which I'll work on them today and repost. Mauro, please don’t pull these patches. Regards, --

[PATCH 0/2] media: i2c: ths8200: Feature enhancement

2013-06-22 Thread Prabhakar Lad
From: "Lad, Prabhakar" The first patch of the series adds supports for asynchronous subdev registration for ths8200 driver, and the second patch of the series adds OF support the driver. Lad, Prabhakar (2): media: i2c: ths8200: support asynchronous probing media: i2c: ths8200: add OF support

[PATCH 1/2] media: i2c: ths8200: support asynchronous probing

2013-06-22 Thread Prabhakar Lad
From: "Lad, Prabhakar" This patch supports both synchronous and asynchronous ths8200 subdevice probing. Signed-off-by: Lad, Prabhakar --- drivers/media/i2c/ths8200.c |9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/ths8200.c b/drivers/media/i2c/t

[PATCH 2/2] media: i2c: ths8200: add OF support

2013-06-22 Thread Prabhakar Lad
From: "Lad, Prabhakar" add OF support for the ths8200 driver. Signed-off-by: Lad, Prabhakar --- .../devicetree/bindings/media/i2c/ths8200.txt | 19 +++ drivers/media/i2c/ths8200.c|9 + 2 files changed, 28 insertions(+) create mode 100

[PATCH] media: i2c: adv7343: add support for asynchronous probing

2013-06-22 Thread Prabhakar Lad
From: "Lad, Prabhakar" Both synchronous and asynchronous adv7343 subdevice probing is supported by this patch. Signed-off-by: Lad, Prabhakar Cc: Guennadi Liakhovetski Cc: Laurent Pinchart Cc: Hans Verkuil Cc: Sakari Ailus Cc: Mauro Carvalho Chehab --- drivers/media/i2c/adv7343.c | 15 ++

[PATCH] media: i2c: tvp514x: add support for asynchronous probing

2013-06-22 Thread Prabhakar Lad
From: "Lad, Prabhakar" Both synchronous and asynchronous tvp514x subdevice probing is supported by this patch. Signed-off-by: Prabhakar Lad Cc: Guennadi Liakhovetski Cc: Laurent Pinchart Cc: Hans Verkuil Cc: Sakari Ailus Cc: Mauro Carvalho Chehab --- drivers/media/i2c/tvp514

[PATCH RFC v3] media: OF: add video sync endpoint property

2013-06-22 Thread Prabhakar Lad
From: "Lad, Prabhakar" This patch adds video sync properties as part of endpoint properties and also support to parse them in the parser. Signed-off-by: Lad, Prabhakar Cc: Hans Verkuil Cc: Laurent Pinchart Cc: Mauro Carvalho Chehab Cc: Guennadi Liakhovetski Cc: Sylwester Nawrocki Cc: Sakar

[PATCH v2 0/2] media: i2c: tvp7002: feature enhancement

2013-06-22 Thread Prabhakar Lad
From: "Lad, Prabhakar" The first patch of the series add support for asynchronous probing and the second patch adds OF support to tvp7002 driver. Lad, Prabhakar (2): media: i2c: tvp7002: add support for asynchronous probing media: i2c: tvp7002: add OF support .../devicetree/bindings/media/

[PATCH v2 1/2] media: i2c: tvp7002: add support for asynchronous probing

2013-06-22 Thread Prabhakar Lad
From: "Lad, Prabhakar" Both synchronous and asynchronous tvp7002 subdevice probing is supported by this patch. Signed-off-by: Lad, Prabhakar Cc: Hans Verkuil Cc: Laurent Pinchart Cc: Mauro Carvalho Chehab Cc: Guennadi Liakhovetski Cc: Sylwester Nawrocki Cc: Sakari Ailus Cc: linux-ker...@v

[PATCH v2 2/2] media: i2c: tvp7002: add OF support

2013-06-22 Thread Prabhakar Lad
From: "Lad, Prabhakar" add OF support for the tvp7002 driver. Signed-off-by: Lad, Prabhakar Cc: Hans Verkuil Cc: Laurent Pinchart Cc: Mauro Carvalho Chehab Cc: Guennadi Liakhovetski Cc: Sylwester Nawrocki Cc: Sakari Ailus Cc: Grant Likely Cc: Rob Herring Cc: Rob Landley Cc: devicetree-

Re: [PATCH] media: i2c: tvp514x: add support for asynchronous probing

2013-06-23 Thread Prabhakar Lad
Hi Guennadi, Thanks for the review. On Sun, Jun 23, 2013 at 8:49 PM, Guennadi Liakhovetski wrote: > On Sat, 22 Jun 2013, Prabhakar Lad wrote: > >> From: "Lad, Prabhakar" >> >> Both synchronous and asynchronous tvp514x subdevice probing is supported by

Re: [PATCH v2] [media] tvp514x: Fix init seqeunce

2013-06-23 Thread Prabhakar Lad
o get the right init > sequence. > > Signed-off-by: Lars-Peter Clausen Acked-by: Lad, Prabhakar Tested-by: Lad, Prabhakar Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.

<    1   2   3   4   5   6   7   >