Re: [PATCHv7 7/9] FMTx: si4713: Add files to handle si4713 i2c device

2009-06-16 Thread Eero Nurkkala
On Tue, 2009-06-16 at 13:22 +0200, ext Hans Verkuil wrote: On Tuesday 16 June 2009 13:06:09 Eduardo Valentin wrote: On Sun, Jun 14, 2009 at 02:31:55PM +0200, ext Hans Verkuil wrote: + if (rval 0) + goto exit; + + /* TODO: How to set frequency to measure

Re: [PATCHv7 7/9] FMTx: si4713: Add files to handle si4713 i2c device

2009-06-16 Thread Eero Nurkkala
On Tue, 2009-06-16 at 13:50 +0200, Valentin Eduardo (Nokia-D/Helsinki) wrote: Yes, sorry I've made some really bad phrasing. It is Strength. It is a feature to measure Received Signal Strength Indication (RSSI). As mentioned by Eero, it's not a good idea to transmit any on freq which the

Re: [PATCH 0/2] V4L: Add BCM2048 radio driver

2009-05-19 Thread Eero Nurkkala
On Tue, 2009-05-12 at 09:10 +0200, ext Hans Verkuil wrote: On Tuesday 12 May 2009 09:03:42 Eero Nurkkala wrote: On Tue, 2009-05-12 at 08:51 +0200, ext Hans Verkuil wrote: I recommend that you move the RDS decoder code into an rds library in the v4l2-apps directory of the v4l-dvb tree

Re: [PATCH v2 4/7] FMTx: si4713: Add files to handle si4713 i2c device

2009-05-12 Thread Eero Nurkkala
On Tue, 2009-05-12 at 08:22 +0300, Eero Nurkkala wrote: + /* Australia */ + { + .channel_spacing= 20, + .bottom_frequency = 8750, + .top_frequency = 10800, + .preemphasis= 1

Re: [PATCH 0/2] V4L: Add BCM2048 radio driver

2009-05-12 Thread Eero Nurkkala
On Tue, 2009-05-12 at 08:51 +0200, ext Hans Verkuil wrote: I recommend that you move the RDS decoder code into an rds library in the v4l2-apps directory of the v4l-dvb tree. As you say, the rds decoder implementation does not belong in the driver, but it would be very nice to have it as a

[PATCH 2/2] V4L: Add BCM2048 radio driver Makefile and Kconfig dependencies

2009-05-11 Thread ext-eero . nurkkala
From: Eero Nurkkala ext-eero.nurkk...@nokia.com This adds the Makefile and Kconfig entries for the BCM2048 radio chip. Signed-off-by: Eero Nurkkala ext-eero.nurkk...@nokia.com --- drivers/media/radio/Kconfig | 10 ++ drivers/media/radio/Makefile |1 + 2 files changed, 11

[PATCH 0/2] V4L: Add BCM2048 radio driver

2009-05-11 Thread ext-eero . nurkkala
From: Eero Nurkkala ext-eero.nurkk...@nokia.com This patchset adds the BCM2048 radio driver code. BCM2048 is radio is integrated in the BCM2048 chipset that contains the Bluetooth also. There's quite some sysfs entries introduced here; But only a very few of them is meant to be used besides

Re: [PATCH v2 1/7] v4l2: video device: Add V4L2_CTRL_CLASS_FMTX controls

2009-05-11 Thread Eero Nurkkala
On Mon, 2009-05-11 at 11:31 +0200, Valentin Eduardo (Nokia-D/Helsinki) wrote: +enum v4l2_fmtx_preemphasis { + V4L2_FMTX_PREEMPHASIS_75_uS = 0, + V4L2_FMTX_PREEMPHASIS_50_uS = 1, + V4L2_FMTX_PREEMPHASIS_DISABLED = 2, +}; Hello there, Would it make

Re: [PATCH v2 4/7] FMTx: si4713: Add files to handle si4713 i2c device

2009-05-11 Thread Eero Nurkkala
On Mon, 2009-05-11 at 11:31 +0200, Valentin Eduardo (Nokia-D/Helsinki) wrote: +/* + * Values for region specific configurations + * (spacing, bottom and top frequencies, preemphasis) + */ +static struct region_info region_configs[] = { + /* USA */ + { +

Re: [PATCH v2 4/7] FMTx: si4713: Add files to handle si4713 i2c device

2009-05-11 Thread Eero Nurkkala
On Tue, 2009-05-12 at 08:15 +0300, Eero Nurkkala wrote: On Mon, 2009-05-11 at 11:31 +0200, Valentin Eduardo (Nokia-D/Helsinki) wrote: +/* + * Values for region specific configurations + * (spacing, bottom and top frequencies, preemphasis) + */ +static struct region_info region_configs