Re: [RFC PATCH] media: uvc: *HACK* workaround uvc unregister device

2014-10-07 Thread Michael Grzeschik
Hi Laurent, this was probably one hack comment to much, so it did not get much attention. :) It is possible that this patch is not fully a workaround. But I am not aware how much this could break along the way. Thanks, Michael On Thu, Oct 02, 2014 at 06:09:47PM +0200, Michael Grzeschik wrote

[RFC PATCH] media: uvc: *HACK* workaround uvc unregister device *HACK*

2014-10-02 Thread Michael Grzeschik
Currently the uvc_driver is not cleaning up its child devices if a device is still in use. It leads to orphaned devices which are not sitting on any interface. They get cleaned up on uvc_delete which will be called on uvc_remove after the userspace application is closing the stream. When

Re: [PATCH v2 2/3] usb: gadget/uvc: also handle v4l2 ioctl ENUM_FMT

2014-08-25 Thread Michael Grzeschik
and the linux-media mailing list) On Friday 08 August 2014 17:38:58 Michael Grzeschik wrote: This patch adds ENUM_FMT as possible ioctl to the uvc v4l2 device. That makes userspace applications with a generic IOCTL calling convention make also use of it. Signed-off-by: Michael Grzeschik

Re: [PATCH 2/2] usb: gadget: f_uvc: Move to video_ioctl2

2014-08-20 Thread Michael Grzeschik
On Mon, Aug 18, 2014 at 11:16:36PM +0200, Laurent Pinchart wrote: Hi Hans, On Monday 18 August 2014 18:24:26 Hans Verkuil wrote: On 08/18/2014 05:06 PM, Laurent Pinchart wrote: Simplify ioctl handling by using video_ioctl2. Are you able to test this on actual hardware? And if so, can

Re: [PATCH v4 4/5] mt9m111: rewrite set_pixfmt

2011-07-22 Thread Michael Grzeschik
Hi Guennadi, On Sun, Jul 17, 2011 at 07:09:42PM +0200, Guennadi Liakhovetski wrote: On Tue, 12 Jul 2011, Michael Grzeschik wrote: added new bit offset defines, more supported BE colour formats and also support BGR565 swapped pixel formats removed pixfmt helper functions and option

[PATCH v2] mt9m111: move lastpage to struct mt9m111 for multi instances

2011-07-19 Thread Michael Grzeschik
Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- v1 - v2: added initial value -1 for lastpage drivers/media/video/mt9m111.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/media/video/mt9m111.c b/drivers/media/video/mt9m111.c index a357aa8

[PATCH 2/5] mt9m111: fix missing return value check mt9m111_reg_clear

2011-07-12 Thread Michael Grzeschik
Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- drivers/media/video/mt9m111.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/mt9m111.c b/drivers/media/video/mt9m111.c index f10dcf0..e08b46c 100644 --- a/drivers/media/video/mt9m111.c

[PATCH 1/5] mt9m111: set inital return values to zero

2011-07-12 Thread Michael Grzeschik
Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- drivers/media/video/mt9m111.c | 32 1 files changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/media/video/mt9m111.c b/drivers/media/video/mt9m111.c index ebebed9..f10dcf0 100644

[PATCH 5/5] mt9m111: make use of testpattern

2011-07-12 Thread Michael Grzeschik
Signed-off-by: Philipp Wiesner p.wies...@phytec.de Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- Changes v1 - v2 * removed ifdef DEBUG drivers/media/video/mt9m111.c | 57 + 1 files changed, 57 insertions(+), 0 deletions(-) diff

[PATCH v4 4/5] mt9m111: rewrite set_pixfmt

2011-07-12 Thread Michael Grzeschik
registers, but it is more convenient and faster (saves one rw cycle). Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de Signed-off-by: Philipp Wiesner p.wies...@phytec.de --- Changes v1 - v2 * removed unrelated OPMODE handling in this function Changes v2 - v3 * squashed

Re: [PATCH v2 10/11] mt9m111: rewrite set_pixfmt

2010-10-25 Thread Michael Grzeschik
On Sat, Oct 02, 2010 at 10:03:55AM +0200, Guennadi Liakhovetski wrote: Michael, any insight? long time ago... For the YUV and RGB formats, tested and acked. For the bayer, I don't use it. With row switch, that gives back: byte offset: 0 1 2 3 B G B G

[PATCH v3] mt9m111: rewrite set_pixfmt

2010-10-25 Thread Michael Grzeschik
registers, but it is more convenient and faster (saves one rw cycle). Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de Signed-off-by: Philipp Wiesner p.wies...@phytec.de --- Changes v1 - v2 * removed unrelated OPMODE handling in this function Changes v2 - v3 * squashed

Re: [PATCH v2 10/11] mt9m111: rewrite set_pixfmt

2010-08-31 Thread Michael Grzeschik
Hi Robert and Guennadi On Sun, Aug 29, 2010 at 09:17:00PM +0200, Robert Jarzmik wrote: Guennadi Liakhovetski g.liakhovet...@gmx.de writes: Robert, I'll need your ack / tested by on this one too. It actually changes behaviour, for example, it sets MT9M111_OUTFMT_FLIP_BAYER_ROW in the

Re: [PATCH v2 00/11] MT9M111/MT9M131

2010-08-31 Thread Michael Grzeschik
Hi, On Sun, Aug 29, 2010 at 09:20:06PM +0200, Robert Jarzmik wrote: Guennadi Liakhovetski g.liakhovet...@gmx.de writes: On Tue, 17 Aug 2010, Michael Grzeschik wrote: Hi Robert, Guennadi, after the messed up previous patchseries, this v2 series is left without any feedback

Re: [PATCH 04/11] mt9m111: added new bit offset defines

2010-08-27 Thread Michael Grzeschik
On Fri, Aug 27, 2010 at 05:11:18PM +0200, Guennadi Liakhovetski wrote: On Tue, 3 Aug 2010, Michael Grzeschik wrote: Signed-off-by: Philipp Wiesner p.wies...@phytec.de Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de I don't see these being used in any of your patches... Yes

Re: [PATCH 04/11] mt9m111: added new bit offset defines

2010-08-27 Thread Michael Grzeschik
On Fri, Aug 27, 2010 at 06:30:28PM +0200, Guennadi Liakhovetski wrote: On Fri, 27 Aug 2010, Michael Grzeschik wrote: On Fri, Aug 27, 2010 at 05:11:18PM +0200, Guennadi Liakhovetski wrote: On Tue, 3 Aug 2010, Michael Grzeschik wrote: Signed-off-by: Philipp Wiesner p.wies

[PATCH] mx3fb and ipu_idmac cleanups

2010-08-24 Thread Michael Grzeschik
From: Juergen Beisert j.beis...@pengutronix.de Signed-off-by: Juergen Beisert j...@pengutronix.de Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- drivers/dma/ipu/ipu_idmac.c |2 +- drivers/video/mx3fb.c |6 +++--- 2 files changed, 4 insertions(+), 4 deletions

Re: [PATCH v2 00/11] MT9M111/MT9M131

2010-08-17 Thread Michael Grzeschik
Hi Robert, Guennadi, after the messed up previous patchseries, this v2 series is left without any feedback. Hopefully not forgotten. :-) Btw: The first two patches are already applied. Thanks, Michael On Tue, Aug 03, 2010 at 12:57:38PM +0200, Michael Grzeschik wrote: Hey everyone, here

Re: [PATCH 1/5] mx2_camera: change to register and probe

2010-08-11 Thread Michael Grzeschik
Hey Guennadi, On Tue, Aug 10, 2010 at 09:08:11PM +0200, Guennadi Liakhovetski wrote: On Tue, 10 Aug 2010, Michael Grzeschik wrote: Hi Guennadi, On Thu, Aug 05, 2010 at 10:17:11PM +0200, Guennadi Liakhovetski wrote: On Tue, 3 Aug 2010, Michael Grzeschik wrote: change

[PATCH v2] mx2_camera: remove emma limitation for RGB565

2010-08-09 Thread Michael Grzeschik
X-Uptime: 16:20:11 up 37 days, 5:31, 61 users, load average: 0.68, 0.32, 0.30 In the current source status the emma has no limitation for any PIXFMT since the data is parsed raw and unprocessed into the memory. Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- v1 - v2

[PATCH v2][RESEND] mx2_camera: remove emma limitation for RGB565

2010-08-09 Thread Michael Grzeschik
In the current source status the emma has no limitation for any PIXFMT since the data is parsed raw and unprocessed into the memory. Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- v1 - v2 Changed Comment in emma_buf_init as recommended drivers/media/video/mx2_camera.c

Re: [PATCH 1/5] mx2_camera: change to register and probe

2010-08-04 Thread Michael Grzeschik
On Wed, Aug 04, 2010 at 10:24:50AM +0200, Guennadi Liakhovetski wrote: On Wed, 4 Aug 2010, Sascha Hauer wrote: On Wed, Aug 04, 2010 at 01:01:34AM +0200, Guennadi Liakhovetski wrote: On Tue, 3 Aug 2010, Michael Grzeschik wrote: On Tue, Aug 03, 2010 at 08:22:13PM +0200, Guennadi

Re: [PATCH 2/5] mx2_camera: remove emma limitation for RGB565

2010-08-04 Thread Michael Grzeschik
On Wed, Aug 04, 2010 at 11:55:39AM +0200, Guennadi Liakhovetski wrote: On Tue, 3 Aug 2010, Michael Grzeschik wrote: In the current source status the emma has no limitation for any PIXFMT since the data is parsed raw and unprocessed into the memory. I'd like some explanation for this one

[PATCH 3/5] mx2_camera: fix for list bufnum in frame_done_emma

2010-08-03 Thread Michael Grzeschik
The emma uses bufnum 1 and 0. This patch tells the bufqueue to change the next buffer to the next one and not the current one. Otherwise the BUG_ON above will trigger everytime. Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- drivers/media/video/mx2_camera.c |2 +- 1 files

[PATCH 1/5] mx2_camera: change to register and probe

2010-08-03 Thread Michael Grzeschik
change this driver back to register and probe, since some platforms first have to initialize an already registered power regulator to switch on the camera. Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- drivers/media/video/mx2_camera.c |4 +++- 1 files changed, 3 insertions

[PATCH 4/5] mx2_camera: add rising edge for pixclock

2010-08-03 Thread Michael Grzeschik
Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- drivers/media/video/mx2_camera.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/mx2_camera.c b/drivers/media/video/mx2_camera.c index cf9a604..7f27492 100644 --- a/drivers/media/video

[PATCH 2/5] mx2_camera: remove emma limitation for RGB565

2010-08-03 Thread Michael Grzeschik
In the current source status the emma has no limitation for any PIXFMT since the data is parsed raw and unprocessed into the memory. Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- drivers/media/video/mx2_camera.c |8 1 files changed, 0 insertions(+), 8 deletions

[PATCH 5/5] mx2_camera: add informative camera clock frequency printout

2010-08-03 Thread Michael Grzeschik
ported mx27_camera to 2.6.33.2 Signed-off-by: Teresa Gamez t.ga...@phytec.de Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- drivers/media/video/mx2_camera.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/mx2_camera.c b/drivers/media

[PATCH 0/5] mx2_camera changes and corrections

2010-08-03 Thread Michael Grzeschik
Hi everybody, this patchseries include little changes, which are necessary for the mx2_camera driver to work properly on i.MX27 baseboards, especially an issue with the emma. Thanks, Michael Michael Grzeschik (5): mx2_camera: change to register and probe mx2_camera: remove emma limitation

[PATCH v2 00/11] MT9M111/MT9M131

2010-08-03 Thread Michael Grzeschik
, until i figured out that the code is mostly needed for the softcropping feature of the camera. But first things first, here are my changes: Michael Grzeschik (9): mt9m111: init chip after read CHIP_VERSION mt9m111: register cleanup hex to dec bitoffset mt9m111: added new bit offset defines

[PATCH 05/11] mt9m111: changed MIN_DARK_COLS to MT9M131 spec count

2010-08-03 Thread Michael Grzeschik
Signed-off-by: Philipp Wiesner p.wies...@phytec.de Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- drivers/media/video/mt9m111.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/mt9m111.c b/drivers/media/video/mt9m111.c index 1b21522

[PATCH 04/11] mt9m111: added new bit offset defines

2010-08-03 Thread Michael Grzeschik
Signed-off-by: Philipp Wiesner p.wies...@phytec.de Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- drivers/media/video/mt9m111.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/mt9m111.c b/drivers/media/video/mt9m111.c index

[PATCH 08/11] mt9m111: added reg_mask function

2010-08-03 Thread Michael Grzeschik
reg_mask is basically the same as clearing setting registers, but it is more convenient and faster (saves one rw cycle). Signed-off-by: Philipp Wiesner p.wies...@phytec.de Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- drivers/media/video/mt9m111.c | 11 +++ 1 files

[PATCH 07/11] mt9m111: added current colorspace at g_fmt

2010-08-03 Thread Michael Grzeschik
Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- drivers/media/video/mt9m111.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/mt9m111.c b/drivers/media/video/mt9m111.c index 89c3f89..48c63bc 100644 --- a/drivers/media/video/mt9m111.c

[PATCH 09/11] v4l2-mediabus: Add pixelcodes for BGR565 formats

2010-08-03 Thread Michael Grzeschik
From: Sascha Hauer s.ha...@pengutronix.de Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- include/media/v4l2-mediabus.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/media/v4l2-mediabus.h b/include/media/v4l2-mediabus.h index 0dbe02a..d0b7340 100644 ---

[PATCH 06/11] mt9m111: cropcap and s_crop check if type is VIDEO_CAPTURE

2010-08-03 Thread Michael Grzeschik
Signed-off-by: Philipp Wiesner p.wies...@phytec.de Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- This one is a merge of: [PATCH 09/20] mt9m111: cropcap check if type is CAPTURE [PATCH 13/20] mt9m111: s_crop check for VIDEO_CAPTURE type drivers/media/video/mt9m111.c |7

[PATCH 02/11] mt9m111: init chip after read CHIP_VERSION

2010-08-03 Thread Michael Grzeschik
Moved mt9m111_init after the chip version detection passage: I don't like the idea of writing on a device we haven't identified yet. Signed-off-by: Philipp Wiesner p.wies...@phytec.de Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- drivers/media/video/mt9m111.c |6 ++ 1

Re: [PATCH 1/5] mx2_camera: change to register and probe

2010-08-03 Thread Michael Grzeschik
On Tue, Aug 03, 2010 at 08:22:13PM +0200, Guennadi Liakhovetski wrote: On Tue, 3 Aug 2010, Michael Grzeschik wrote: change this driver back to register and probe, since some platforms first have to initialize an already registered power regulator to switch on the camera. Sorry, don't

Re: [PATCH 00/20] MT9M111/MT9M131

2010-08-02 Thread Michael Grzeschik
Hey Guennadi, Robert sorry for that lack of information to those patches. I also just have been slicing one big patch into several canonical and tried to get rid of most tofu. You see the result in that patchseries. But since some big changes i could not figure out correctly, i left them in the

[PATCH 01/20] mt9m111: Added indication that MT9M131 is supported by this driver

2010-07-30 Thread Michael Grzeschik
From: Philipp Wiesner p.wies...@phytec.de Added this info to Kconfig and mt9m111.c, some comment cleanup, replaced 'mt9m11x'-statements by clarifications or driver name. Driver is fully compatible to mt9m131 which has only additional functions compared to mt9m111. Those aren't used anyway at the

[PATCH 03/20] mt9m111: register cleanup hex to dec bitoffset

2010-07-30 Thread Michael Grzeschik
Signed-off-by: Philipp Wiesner p.wies...@phytec.de Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- drivers/media/video/mt9m111.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/media/video/mt9m111.c b/drivers/media/video/mt9m111.c

[PATCH 00/20] MT9M111/MT9M131

2010-07-30 Thread Michael Grzeschik
restructuring. It has been tested as functional. Comments on this are very welcome. Michael Grzeschik (19): mt9m111: init chip after read CHIP_VERSION mt9m111: register cleanup hex to dec bitoffset mt9m111: added new bit offset defines mt9m111: added default row/col/width/height values

[PATCH 07/20] mt9m111: changed MIN_DARK_COLS to MT9M131 spec count

2010-07-30 Thread Michael Grzeschik
Signed-off-by: Philipp Wiesner p.wies...@phytec.de Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- drivers/media/video/mt9m111.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/mt9m111.c b/drivers/media/video/mt9m111.c index 2080615

[PATCH 08/20] mt9m111: cropcap use defined default rect properties in defrect

2010-07-30 Thread Michael Grzeschik
Signed-off-by: Philipp Wiesner p.wies...@phytec.de Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- drivers/media/video/mt9m111.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/mt9m111.c b/drivers/media/video/mt9m111.c index f024cc5

[PATCH 13/20] mt9m111: s_crop check for VIDEO_CAPTURE type

2010-07-30 Thread Michael Grzeschik
Signed-off-by: Philipp Wiesner p.wies...@phytec.de Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- drivers/media/video/mt9m111.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/mt9m111.c b/drivers/media/video/mt9m111.c index 2758a97

[PATCH 10/20] mt9m111: rewrite make_rect for positioning in debug

2010-07-30 Thread Michael Grzeschik
If DEBUG is defined it is possible to set upper left corner Signed-off-by: Philipp Wiesner p.wies...@phytec.de Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- drivers/media/video/mt9m111.c | 31 +++ 1 files changed, 23 insertions(+), 8 deletions

[PATCH 20/20] mt9m111: s_fmt make use of try_fmt

2010-07-30 Thread Michael Grzeschik
Signed-off-by: Philipp Wiesner p.wies...@phytec.de Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- drivers/media/video/mt9m111.c | 60 +++-- 1 files changed, 28 insertions(+), 32 deletions(-) diff --git a/drivers/media/video/mt9m111.c b

[PATCH 14/20] mt9m111: added reg_mask function

2010-07-30 Thread Michael Grzeschik
reg_mask is basically the same as clearing setting registers, but it is more convenient and faster (saves one rw cycle). Signed-off-by: Philipp Wiesner p.wies...@phytec.de Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- drivers/media/video/mt9m111.c | 11 +++ 1 files

[PATCH 16/20] mt9m111: added more supported BE colour formats

2010-07-30 Thread Michael Grzeschik
Signed-off-by: Philipp Wiesner p.wies...@phytec.de Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- drivers/media/video/mt9m111.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/mt9m111.c b/drivers/media/video/mt9m111.c index 11a68b6

[PATCH 15/20] mt9m111: rewrite setup_rect, added soft_crop for smooth panning

2010-07-30 Thread Michael Grzeschik
-soft_crop: enables the use of the sensors cropping abilities instead of using real roi. This is needed to make use of the 'pan' registers for smooth panning. Signed-off-by: Philipp Wiesner p.wies...@phytec.de Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- drivers/media/video

[PATCH 17/20] mt9m111: rewrite set_pixfmt

2010-07-30 Thread Michael Grzeschik
removed pixfmt helper functions and option flags setting the configuration register directly in set_pixfmt Signed-off-by: Philipp Wiesner p.wies...@phytec.de Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- drivers/media/video/mt9m111.c | 142

[PATCH 19/20] mt9m111: try_fmt rewrite to use preset values

2010-07-30 Thread Michael Grzeschik
make use of the format.rect boundery values Signed-off-by: Philipp Wiesner p.wies...@phytec.de Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- drivers/media/video/mt9m111.c | 41 +++-- 1 files changed, 19 insertions(+), 22 deletions(-) diff

[PATCH 18/20] mt9m111: make use of testpattern in debug mode

2010-07-30 Thread Michael Grzeschik
Signed-off-by: Philipp Wiesner p.wies...@phytec.de Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- drivers/media/video/mt9m111.c | 63 + 1 files changed, 63 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/mt9m111.c b

[PATCH 05/20] mt9m111: added default row/col/width/height values

2010-07-30 Thread Michael Grzeschik
Signed-off-by: Philipp Wiesner p.wies...@phytec.de Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- drivers/media/video/mt9m111.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/mt9m111.c b/drivers/media/video/mt9m111.c index aeb2241

[PATCH 06/20] mt9m111: changed MAX_{HEIGHT,WIDTH} values to silicon pixelcount

2010-07-30 Thread Michael Grzeschik
Signed-off-by: Philipp Wiesner p.wies...@phytec.de Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- drivers/media/video/mt9m111.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/video/mt9m111.c b/drivers/media/video/mt9m111.c index 5f0c55e