Re: [PATCH v2 0/4] media: soc_camera: ov9640: switch driver to v4l2_async

2018-09-14 Thread Petr Cvek
Dne 14.9.2018 v 14:59 Sakari Ailus napsal(a): > Hi Petr, > > On Wed, Aug 15, 2018 at 03:30:23PM +0200, petrcve...@gmail.com wrote: >> From: Petr Cvek >> >> This patch series transfer the ov9640 driver from the soc_camera subsystem >> into a standalone v4l2 d

Re: [PATCH v2 1/4] media: soc_camera: ov9640: move ov9640 out of soc_camera

2018-09-14 Thread Petr Cvek
Dne 14.9.2018 v 14:59 Sakari Ailus napsal(a): > Hi Petr, > > Thanks for the patchset, and my apologies for reviewing it so late! > > I'm commenting this one but feel free to add patches to address the > comments. > Hi and thanks for the review. I would like to have this patch set to be as much

Re: [PATCH v2 1/4] media: soc_camera: ov9640: move ov9640 out of soc_camera

2018-08-16 Thread Petr Cvek
Dne 16.8.2018 v 12:23 jacopo mondi napsal(a): > Hi Petr, > > On Wed, Aug 15, 2018 at 03:35:39PM +0200, Petr Cvek wrote: >> BTW from the v1 discussion: >> >> Dne 10.8.2018 v 09:32 jacopo mondi napsal(a): >>> When I've been recently doing the same for ov772x a

Re: [BUG, RFC] media: Wrong module gets acquired

2018-08-15 Thread Petr Cvek
Dne 14.8.2018 v 15:03 Mauro Carvalho Chehab napsal(a): > Em Tue, 14 Aug 2018 11:35:01 +0300 > Sakari Ailus escreveu: > >> Hi Pert, >> >> On Mon, Aug 13, 2018 at 06:33:12PM +0200, petrcve...@gmail.com wrote: >>> From: Petr Cvek >>> >

Re: [PATCH v2 1/4] media: soc_camera: ov9640: move ov9640 out of soc_camera

2018-08-15 Thread Petr Cvek
BTW from the v1 discussion: Dne 10.8.2018 v 09:32 jacopo mondi napsal(a): > When I've been recently doing the same for ov772x and other sensor > driver I've been suggested to first copy the driver into > drivers/media/i2c/ and leave the original soc_camera one there, so > they can be bulk removed

Re: [BUG, RFC] media: Wrong module gets acquired

2018-08-14 Thread Petr Cvek
Dne 14.8.2018 v 10:35 Sakari Ailus napsal(a): > Hi Pert, > Hello, thanks for answering > On Mon, Aug 13, 2018 at 06:33:12PM +0200, petrcve...@gmail.com wrote: >> From: Petr Cvek >> >> When transferring a media sensor driver from the soc_camera I've found >&

Re: [PATCH v1 4/5] [media] i2c: drop soc_camera code from ov9640 and switch to v4l2_async

2018-08-12 Thread Petr Cvek
Dne 10.8.2018 v 09:51 jacopo mondi napsal(a): > Hi Petr, > > On Thu, Aug 09, 2018 at 03:39:48AM +0200, petrcve...@gmail.com wrote: >> From: Petr Cvek >> >> This patch removes the dependency on an obsoleted soc_camera from ov9640 >> driver and changes the c

Re: [RFC] [PATCH 0/4] [media] pxa_camera: Fixing bugs and missing colorformats

2017-05-13 Thread Petr Cvek
Dne 13.5.2017 v 08:40 Petr Cvek napsal(a): > The second problem seems to be a same problem. When playing/encoding the data > from the sensor (with or without previous fix) and calling (probably) > anything on v4l2 the drivers stops in a same way. I discovered it by trying

Re: [RFC] [PATCH 0/4] [media] pxa_camera: Fixing bugs and missing colorformats

2017-05-13 Thread Petr Cvek
Dne 2.5.2017 v 16:57 Robert Jarzmik napsal(a): > Petr Cvek <petr.c...@tul.cz> writes: > >> Dne 1.5.2017 v 06:20 Petr Cvek napsal(a): >>> This patchset is just a grouping of a few bugfixes I've found during >>> the ov9640 sensor support re-adding. >> >

Re: [PATCH 2/4] [media] pxa_camera: Fix incorrect test in the image size generation

2017-05-04 Thread Petr Cvek
Dne 2.5.2017 v 16:43 Robert Jarzmik napsal(a): > Petr Cvek <petr.c...@tul.cz> writes: > >> During the transfer from the soc_camera a test in pxa_mbus_image_size() >> got removed. Without it any PXA_MBUS_LAYOUT_PACKED format causes either >> the return of a wrong val

Re: [PATCH 4/4] [media] pxa_camera: Fix a call with an uninitialized device pointer

2017-05-04 Thread Petr Cvek
Dne 2.5.2017 v 16:53 Robert Jarzmik napsal(a): > Petr Cvek <petr.c...@tul.cz> writes: > >> In 'commit 295ab497d6357 ("[media] media: platform: pxa_camera: make >> printk consistent")' a pointer to the device structure in >> mclk_get_divisor() was changed

Re: [PATCH 2/4] [media] pxa_camera: Fix incorrect test in the image size generation

2017-05-02 Thread Petr Cvek
Dne 2.5.2017 v 16:43 Robert Jarzmik napsal(a): > Petr Cvek <petr.c...@tul.cz> writes: > >> During the transfer from the soc_camera a test in pxa_mbus_image_size() >> got removed. Without it any PXA_MBUS_LAYOUT_PACKED format causes either >> the return of a wrong val

Re: [PATCH] [media] pxa_camera: fix module remove codepath for v4l2 clock

2017-04-30 Thread Petr Cvek
Dne 28.4.2017 v 08:31 Robert Jarzmik napsal(a): > Petr Cvek <petr.c...@tul.cz> writes: > >> I will post some other bugfixes (and feature adding) for pxa_camera soon. Do >> you wish to be CC'd? >> >> P.S. Who is the the maintainer of pxa_camera BTW? St

Re: [RFC] [PATCH 0/4] [media] pxa_camera: Fixing bugs and missing colorformats

2017-04-30 Thread Petr Cvek
Dne 1.5.2017 v 06:20 Petr Cvek napsal(a): > This patchset is just a grouping of a few bugfixes I've found during > the ov9640 sensor support re-adding. P.S. I've manually calculated every format variant for the image size calculation functions, but still these functions are not too

[PATCH 4/4] [media] pxa_camera: Fix a call with an uninitialized device pointer

2017-04-30 Thread Petr Cvek
it happens in v4l2_device_register() at the end of the probe. The dev_warn and dev_dbg caused a line in the log: (NULL device *): Limiting master clock to 2600 Fix this by using an initialized pointer from the platform_device (as before the old patch). Signed-off-by: Petr Cvek <pet

[PATCH 3/4] [media] pxa_camera: Add (un)subscribe_event ioctl

2017-04-30 Thread Petr Cvek
The v4l2-compliance complains about nonexistent vidioc_subscribe_event and vidioc_unsubscribe_event calls. Add them to fix the complaints. Signed-off-by: Petr Cvek <petr.c...@tul.cz> --- drivers/media/platform/pxa_camera.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers

[PATCH 2/4] [media] pxa_camera: Fix incorrect test in the image size generation

2017-04-30 Thread Petr Cvek
). This was observed in an error from the ffmpeg (for some of the YUYV subvariants). This patch re-adds the same test as in soc_camera version. Signed-off-by: Petr Cvek <petr.c...@tul.cz> --- drivers/media/platform/pxa_camera.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/pl

[PATCH 1/4] [media] pxa_camera: Add remaining Bayer 8 formats

2017-04-30 Thread Petr Cvek
This patch adds Bayer 8 GBRG and RGGB support and move GRBG definition close to BGGR (so all Bayer 8 variants are together). No other changes are needed as the driver handles them as RAW data stream. The RGGB variant was tested in a modified OV9640 driver. Signed-off-by: Petr Cvek <pet

[PATCH 0/4] [media] pxa_camera: Fixing bugs and missing colorformats

2017-04-30 Thread Petr Cvek
clock Petr Cvek (4): [media] pxa_camera: Add remaining Bayer 8 formats [media] pxa_camera: Fix incorrect test in the image size generation [media] pxa_camera: Add (un)subscribe_event ioctl [media] pxa_camera: Fix a call with an uninitialized device pointer drivers/media/platform

Re: [PATCH] [media] pxa_camera: fix module remove codepath for v4l2 clock

2017-04-27 Thread Petr Cvek
Dne 27.4.2017 v 21:20 Robert Jarzmik napsal(a): > Petr Cvek <petr.c...@tul.cz> writes: > >> The conversion from soc_camera omitted a correct handling of the clock >> gating for a sensor. When the pxa_camera driver module was removed it >> tried to unregister clk, but

[PATCH] [media] pxa_camera: fix module remove codepath for v4l2 clock

2017-04-24 Thread Petr Cvek
bound sensor the clock is still present. The codepath is practically a copy from the old soc_camera. The bug was tested with a pxa_camera+ov9640 combination during the conversion of the ov9640 from the soc_camera. Signed-off-by: Petr Cvek <petr.c...@tul.cz> --- drivers/media/platform/pxa_ca

Re: [PATCH v2 09/21] ARM: pxa: magician: Add OV9640 camera support

2015-08-21 Thread Petr Cvek
Dne 21.8.2015 v 19:36 Robert Jarzmik napsal(a): I shrunk a bit the mailing list. Arnd Bergmann a...@arndb.de writes: On Friday 21 August 2015 00:39:30 Petr Cvek wrote: Dne 20.8.2015 v 22:26 Arnd Bergmann napsal(a): On Thursday 20 August 2015 21:48:20 Robert Jarzmik wrote: Petr Cvek