Re: [PATCHv3 1/1] Add ir-rcmm-driver

2018-12-07 Thread Sean Young
Hi Patrick, On Fri, Dec 07, 2018 at 10:57:21AM +0100, Patrick LERDA wrote: > Add support for RCMM infrared remote controls. > > Signed-off-by: Patrick Lerda Other than the Signed-off-by this looks exactly like the v2 version; did you see my other comments on the v2 patch? Thanks Sean > ---

[GIT PULL FOR v4.21] Two DVB patches

2018-12-06 Thread Sean Young
Hi Mauro, Two small dvb fixes which would be nice to have in 4.21. Thanks, Sean The following changes since commit 3c28b91380dd1183347d32d87d820818031ebecf: media: stkwebcam: Bugfix for wrong return values (2018-12-05 14:10:48 -0500) are available in the Git repository at:

Re: [PATCH] [PATCHv2] Add ir-rcmm-driver

2018-12-06 Thread Sean Young
On Wed, Dec 05, 2018 at 01:29:33AM +0100, patrick9...@free.fr wrote: > From: Patrick LERDA > We need a Signed-off-by: here. https://www.kernel.org/doc/html/v4.12/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin > --- > drivers/media/rc/Kconfig |

Re: [PATCH] Add ir-rcmm-driver

2018-12-04 Thread Sean Young
On Tue, Dec 04, 2018 at 09:20:25PM +0100, patrick9...@free.fr wrote: > From: Patrick LERDA > > --- > drivers/media/rc/Kconfig | 10 ++ > drivers/media/rc/Makefile | 1 + > drivers/media/rc/ir-rcmm-decoder.c | 185 + >

[GIT PULL FOR v4.21] more dvb fixes

2018-12-04 Thread Sean Young
): media: usb: dvb-usb: remove old friio driver Malcolm Priestley (2): media: lmedm04: Move usb buffer to lme2510_state. media: lmedm04: use dvb_usbv2_generic_rw_locked Nikita Gerasimov (1): media: rtl28xxu: add support for Sony CXD2837ER slave demod Sean Young (1): media

Re: [PATCH 3/4] media: lmedm04: Move interrupt buffer to priv buffer.

2018-12-04 Thread Sean Young
On Thu, Nov 29, 2018 at 10:30:15PM +, Malcolm Priestley wrote: > Interrupt is always present throught life time of > there is no dma element move this buffer to private > area of driver. > > Signed-off-by: Malcolm Priestley > --- > drivers/media/usb/dvb-usb-v2/lmedm04.c | 26

Re: [PATCH 1/4] media: lmedm04: Add missing usb_free_urb to free, interrupt urb

2018-12-04 Thread Sean Young
On Thu, Nov 29, 2018 at 10:29:31PM +, Malcolm Priestley wrote: > The interrupt urb is killed but never freed add the function > > Cc: sta...@vger.kernel.org > Signed-off-by: Malcolm Priestley > --- > drivers/media/usb/dvb-usb-v2/lmedm04.c | 1 + > 1 file changed, 1 insertion(+) > > diff

Re: Astrometa DVB-T2 2018 update

2018-11-29 Thread Sean Young
On Mon, Nov 05, 2018 at 07:12:52PM +, Bob Goddard wrote: > Enable Sony CXD2837ER slave demon on the Astrometa DVB-T2, known as the 2018 > update. > > Originally based on the patch by kapitanf at > https://github.com/torvalds/linux/pull/567, it was not quite right. This is > more correct,

[GIT PULL FOR v4.21] dvb fixes

2018-11-28 Thread Sean Young
estley (1): media: dvb-usb-v2: Fix incorrect use of transfer_flags URB_FREE_BUFFER Neil Armstrong (3): media: cxd2880-spi: fix probe when dvb_attach fails media: cxd2880-spi: Add optional vcc regulator media: sony-cxd2880: add optional vcc regulator to bindings Sean Young (1

Re: [PATCH dvb v1 4/4] media: dvb_frontend: remove __func__ from dev_dbg()

2018-11-27 Thread Sean Young
On Tue, Oct 30, 2018 at 05:14:51PM +0100, Victor Toso wrote: > From: Victor Toso > > As dynamic debug can be instructed to add the function name to the > debug output using +f switch, we can remove __func__ from all > dev_dbg() calls. If not, a user that sets +f in dynamic debug would > get

Re: [PATCH dvb v1 3/4] media: dvb-usb-v2: remove __func__ from dev_dbg()

2018-11-27 Thread Sean Young
On Tue, Oct 30, 2018 at 05:14:50PM +0100, Victor Toso wrote: > From: Victor Toso > > As dynamic debug can be instructed to add the function name to the > debug output using +f switch, we can remove __func__ from all > dev_dbg() calls. If not, a user that sets +f in dynamic debug would > get

[PATCH] media: saa7134: rc-core maintains users count, no need to duplicate

2018-11-25 Thread Sean Young
This simplifies the code a little. Tested with suspend and resume. Signed-off-by: Sean Young --- drivers/media/pci/saa7134/saa7134-core.c | 8 +-- drivers/media/pci/saa7134/saa7134-input.c | 68 --- drivers/media/pci/saa7134/saa7134.h | 9 ++- 3 files changed, 18

[PATCH v4l-utils] keytable: do not install bpf protocols decoders with execute permission

2018-11-23 Thread Sean Young
/rpm/pull/604 Signed-off-by: Sean Young --- utils/keytable/bpf_protocols/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utils/keytable/bpf_protocols/Makefile.am b/utils/keytable/bpf_protocols/Makefile.am index 1b90411b..d1f04cb4 100644 --- a/utils/keytable

[PATCH v4l-utils] keytable: match every entry in rc_maps.cfg, not just the first

2018-11-16 Thread Sean Young
Signed-off-by: Sean Young --- utils/keytable/keytable.c | 71 --- 1 file changed, 36 insertions(+), 35 deletions(-) diff --git a/utils/keytable/keytable.c b/utils/keytable/keytable.c index e15440de..df9cfc49 100644 --- a/utils/keytable/keytable.c +++ b/utils

Re: TechnoTrend CT2-4500 remote not working

2018-11-14 Thread Sean Young
Martin, On Wed, Nov 14, 2018 at 09:51:38PM +0100, martin.kono...@mknetz.de wrote: > > It would be interesting to see what the device is sending. Please can you > > turn > > on dynamic debug for ir-kbd-i2c.c: > > > > echo "file ir-kbd-i2.c +p" > /sys/kernel/debug/dynamic_debug/control > > > >

Re: TechnoTrend CT2-4500 remote not working

2018-11-11 Thread Sean Young
On Sat, Nov 10, 2018 at 10:35:29PM +0100, martin.kono...@mknetz.de wrote: > Hi all, > > the remote on my TechnoTrend CT2-4500 is not working with kernel 4.18. > The TV-card itself works fine: > > cx25840 6-0044: loaded v4l-cx23885-avcore-01.fw firmware (16382 bytes) > cx23885:

Re: [PATCH v4l-utils] Add missing linux/bpf_common.h

2018-11-09 Thread Sean Young
Hi Peter, On Thu, Nov 08, 2018 at 10:13:38PM +0100, Peter Seiderer wrote: > Thanks, works for the buildroot use case (disabling > bpf support unconditionally)... > > The reason to provide copies of the linux kernel headers in v4l-utils > is to be independent of old(-er) headers provided by

[PATCH] keytable: fix BPF protocol compilation on mips

2018-11-07 Thread Sean Young
a Linux +compiler or give up. > #error Use a Linux compiler or give up. This requires __linux__ to be defined. Signed-off-by: Sean Young --- utils/keytable/bpf_protocols/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utils/keytable/bpf_protocols/Makefile

Re: [PATCH v4l-utils] Add missing linux/bpf_common.h

2018-11-07 Thread Sean Young
Hi Peter, On Tue, Nov 06, 2018 at 10:43:58PM +0100, Peter Seiderer wrote: > On Tue, 6 Nov 2018 10:38:56 +0000, Sean Young wrote: > > > On Mon, Nov 05, 2018 at 09:30:47PM +0100, Peter Seiderer wrote: > > > Copy from [1], needed by bpf.h. > > > > > > [1

[PATCH v4l-utils] keytable: fix compilation warning

2018-11-07 Thread Sean Young
keytable.c: In function ‘parse_opt’: keytable.c:835:7: warning: ‘param’ may be used uninitialized in this function [-Wuninitialized] Signed-off-by: Sean Young --- utils/keytable/keytable.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utils/keytable/keytable.c b/utils

[PATCH v2 v4l-utils] configure: build without BPF support in ir-keytable

2018-11-07 Thread Sean Young
It currently does not build on mips and some platforms do not have BPF support yet (risc-v, for example). Signed-off-by: Sean Young --- configure.ac | 17 + utils/keytable/Makefile.am | 7 --- utils/keytable/keytable.c | 5 - 3 files changed, 21

[GIT PULL FOR v4.21] rc changes

2018-11-06 Thread Sean Young
000) Benjamin Valentin (1): media: rc: add driver for Xbox DVD Movie Playback Kit Brad Love (1): mceusb: Include three Hauppauge USB dvb device with IR rx Mauro Carvalho Chehab (1): media: rc: imon: replace strcpy() by strscpy() Sean Young (6): media: rc: XBox

Re: [PATCH v4l-utils] Add missing linux/bpf_common.h

2018-11-06 Thread Sean Young
On Mon, Nov 05, 2018 at 09:30:47PM +0100, Peter Seiderer wrote: > Copy from [1], needed by bpf.h. > > [1] > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/plain/include/uapi/linux/bpf_common.h?h=v4.19 So bpf.h does include this file, but we don't use anything from it in

[PATCH] configure: build without BPF support in ir-keytable

2018-11-06 Thread Sean Young
It currently does not build on mips and some platforms do not have BPF support yet (risc-v, for example). Signed-off-by: Sean Young --- configure.ac | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 387f8539..4100db06 100644

Re: [PATCH v2] Input: Add missing event codes for common IR remote buttons

2018-11-05 Thread Sean Young
accordingly where applicable. > > v2 changes: > Renamed KEY_SYSTEM to KEY_SYSTEM_MENU to avoid conflict with powerpc > KEY_SYSTEM define. > > Signed-off-by: Derek Kelly Reviewed-by: Sean Young There are many remotes with these buttons, this is a very useful addition. Thanks

[PATCH] media: rc: ensure close() is called on rc_unregister_device

2018-11-05 Thread Sean Young
If userspace has an open file descriptor on the rc input device or lirc device when rc_unregister_device() is called, then the rc close() is never called. This ensures that the receiver is turned off on the nuvoton-cir driver during shutdown. Signed-off-by: Sean Young --- drivers/media/rc/rc

Re: [RFC] [PATCH] media: rc: Improve responsiveness of Xbox DVD Remote

2018-11-04 Thread Sean Young
On Sun, Nov 04, 2018 at 09:57:46PM +0100, Benjamin Valentin wrote: > The Xbox DVD Remote feels somewhat sluggish, pressing a button > repeatedly is sometimes interpreted as it being kept pressed down. > > It seems like the RC subsystem is doing some incorrect heuristics when > in fact the data

Re: [PATCH] media: rc: self test for IR encoders and decoders

2018-11-01 Thread Sean Young
Hi Shuah, On Thu, Nov 01, 2018 at 08:59:39AM -0600, Shuah Khan wrote: > On 10/16/2018 08:09 AM, Sean Young wrote: > > ir-loopback can transmit IR on one rc device and check the correct > > scancode and protocol is decoded on a different rc device. This can be > > used to

Re: VIVID/VIMC and media fuzzing

2018-10-31 Thread Sean Young
On Wed, Oct 31, 2018 at 11:05:10AM +0100, Hans Verkuil wrote: > CC-ing Sean Young: please see question at the end. > > On 10/31/2018 10:46 AM, Hans Verkuil wrote: > > On 10/30/2018 03:02 PM, Dmitry Vyukov wrote: > >> Hello Helen and linux-media, > >> > >&g

Re: [PATCH] lirc.4: remove ioctls and feature bits which were never implemented

2018-10-29 Thread Sean Young
Hi Michael, On Thu, Jul 12, 2018 at 02:21:18PM +0100, Sean Young wrote: > On Thu, Jul 12, 2018 at 09:33:32AM -0300, Mauro Carvalho Chehab wrote: > > Hi Michael/Alec, > > > > Em Fri, 18 May 2018 16:25:29 +0100 > > Sean Young escreveu: > > > > > On Sun,

[PATCH] media: saa7134: hvr1110 can decode rc6

2018-10-28 Thread Sean Young
The function get_key_hvr1110 can only decode rc5, however this is a standard hauppauge z8f0811 which can decode rc6 as well. Use get_key_haup_xvr() instead. Test on a HVR 1110. Signed-off-by: Sean Young --- drivers/media/pci/saa7134/saa7134-input.c | 43 +++ 1 file changed

[PATCH] media: saa7134: rc device does not need 'saa7134 IR (' prefix

2018-10-27 Thread Sean Young
Before this patch, the rc name is truncated to: saa7134 IR (Hauppauge WinTV-HVR Now it is: Hauppauge WinTV-HVR1150 ATSC/QAM-Hybrid Signed-off-by: Sean Young --- drivers/media/pci/saa7134/saa7134-input.c | 4 +--- drivers/media/pci/saa7134/saa7134.h | 1 - 2 files

[PATCH] media: v4l uapi docs: few minor corrections and typos

2018-10-26 Thread Sean Young
Signed-off-by: Sean Young --- Documentation/media/uapi/v4l/app-pri.rst | 2 +- Documentation/media/uapi/v4l/audio.rst| 2 +- Documentation/media/uapi/v4l/dev-capture.rst | 2 +- Documentation/media/uapi/v4l/dev-teletext.rst | 2 +- Documentation/media/uapi/v4l/format.rst

Re: [PATCH] media: rc: cec devices do not have a lirc chardev

2018-10-22 Thread Sean Young
On Mon, Oct 22, 2018 at 01:28:42PM +0100, Sean Young wrote: > On Mon, Oct 22, 2018 at 12:30:29PM +0100, Hans Verkuil wrote: > > On 10/22/2018 11:14 AM, Sean Young wrote: > > > Would you be able to test the following patch please? > > > > Sean, > > &g

Re: [PATCH] media: rc: cec devices do not have a lirc chardev

2018-10-22 Thread Sean Young
On Mon, Oct 22, 2018 at 12:30:29PM +0100, Hans Verkuil wrote: > On 10/22/2018 11:14 AM, Sean Young wrote: > > On Mon, Oct 22, 2018 at 11:44:22AM +0200, Torbjorn Jansson wrote: > >> On 2018-10-22 10:59, Sean Young wrote: > >>> On Sat, Oct 20, 2018 at 11:12:16PM +0200,

[PATCH] media: rc: cec devices do not have a lirc chardev

2018-10-22 Thread Sean Young
On Mon, Oct 22, 2018 at 11:44:22AM +0200, Torbjorn Jansson wrote: > On 2018-10-22 10:59, Sean Young wrote: > > On Sat, Oct 20, 2018 at 11:12:16PM +0200, Hans Verkuil wrote: > > > Hi Sean, > > > > > > Can you take a look at this, it appears to be an RC

Re: cec kernel oops with pulse8 usb cec adapter

2018-10-22 Thread Sean Young
On Sat, Oct 20, 2018 at 11:12:16PM +0200, Hans Verkuil wrote: > Hi Sean, > > Can you take a look at this, it appears to be an RC issue, see my analysis > below. > > On 10/20/2018 03:26 PM, Torbjorn Jansson wrote: > > Hello > > > > i'm using the pulse8 usb cec adapter to control my tv. > > i

[PATCH] media: rc: imon_raw: use fls rather than loop per bit

2018-10-18 Thread Sean Young
Previously, the code would loop for each of the 40 bits. Now it will branch for each edge in the IR, which will be much less. Signed-off-by: Sean Young --- drivers/media/rc/imon_raw.c | 47 ++--- 1 file changed, 23 insertions(+), 24 deletions(-) diff --git

[PATCH] media: rc: XBox DVD Remote uses 12 bits scancodes

2018-10-18 Thread Sean Young
The xbox dvd remote sends 24 bits, the first 12 bits are repeated and inverted so only 12 bits are used. The upper 4 bits can be read at offset 3. Ensure we pass this to rc-core and update the keymap accordingly. Signed-off-by: Sean Young --- drivers/media/rc/keymaps/rc-xbox-dvd.c | 58

[PATCH v4l-utils] keytable: bpf decoder and keymap for XBox DVD Remote

2018-10-18 Thread Sean Young
This uses a modified nec protocol, where 24 bits are sent and the first 12 bits are inverted. Signed-off-by: Sean Young --- utils/keytable/bpf_protocols/Makefile.am | 2 +- utils/keytable/bpf_protocols/xbox.c | 129 ++ .../rc_keymaps_userspace/xbox_dvd.toml

[PATCH] media: rc: self test for IR encoders and decoders

2018-10-16 Thread Sean Young
for this test. Signed-off-by: Sean Young Cc: Shuah Khan --- tools/testing/selftests/Makefile | 1 + tools/testing/selftests/ir/.gitignore | 1 + tools/testing/selftests/ir/Makefile | 5 + tools/testing/selftests/ir/ir_loopback.c | 199 ++ tools/testing

Re: [PATCHv2] media: rc: add driver for Xbox DVD Movie Playback Kit

2018-10-08 Thread Sean Young
Hi Benjamin, Thanks for your driver, I have some comments below. On Thu, Oct 04, 2018 at 01:52:54PM +0200, Benjamin Valentin wrote: > The Xbox DVD Movie Playback Kit is a USB dongle with an IR remote for the > Original Xbox. > > Historically it has been supported by the out-of-tree lirc_xbox

Re: [PATCH] media: cec: name for RC passthrough device does not need 'RC for'

2018-10-05 Thread Sean Young
On Fri, Oct 05, 2018 at 09:37:11AM +0200, Hans Verkuil wrote: > On 10/05/2018 12:21 AM, Sean Young wrote: > > An RC device is does not need to be called 'RC for'. Simply the name > > will suffice. > > > > Signed-off-by: Sean Young > > Reviewed-by: Hans Verkuil

Re: [PATCH 2/2] media: rc: self test for IR encoders and decoders

2018-10-04 Thread Sean Young
. Thank you for your review -- I agree with all your points and thanks for the helpful tips as well. I will fix for v2. Thanks again, Sean > > On 07/17/2018 03:33 PM, Sean Young (by way of Mauro Carvalho Chehab > ) wrote: > > ir-loopback can transmit IR on one rc device and che

[PATCH] media: cec: name for RC passthrough device does not need 'RC for'

2018-10-04 Thread Sean Young
An RC device is does not need to be called 'RC for'. Simply the name will suffice. Signed-off-by: Sean Young --- drivers/media/cec/cec-core.c | 6 ++ include/media/cec.h | 2 -- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/media/cec/cec-core.c b/drivers

[GIT PULL FOR v4.20] Additional RC fixes

2018-10-04 Thread Sean Young
/syoung/media_tree.git for-v4.20b for you to fetch changes up to a810925a2795daa204f1ff2e659e026acc4459b5: media: rc: mce_kbd: input events via rc-core's input device (2018-10-04 15:05:37 +0100) Sean Young (3): media: rc: some

[RFP] Media Summit: rc-core status update

2018-09-24 Thread Sean Young
A 10 minute status update on rc-core, present and future. I'll give a brief presentation and leave some time for discussion. Thanks Sean

[PATCH 1/4] media: rc: some events are dropped by userspace

2018-09-18 Thread Sean Young
libevdev (which is used by libinput) gets a list of keycodes from the input device on creation. Any events with keycodes which are not in this list are silently dropped. So, set all keycodes on device creation since we do not know which will be used if the keymap changes. Signed-off-by: Sean

[PATCH 3/4] media: rc: mce_kbd: input events via rc-core's input device

2018-09-18 Thread Sean Young
There is no need to create another input device. Signed-off-by: Sean Young --- drivers/media/rc/ir-mce_kbd-decoder.c | 77 +-- drivers/media/rc/rc-core-priv.h | 3 -- 2 files changed, 14 insertions(+), 66 deletions(-) diff --git a/drivers/media/rc/ir-mce_kbd

[PATCH 2/4] media: rc: imon: report mouse events using rc-core's input device

2018-09-18 Thread Sean Young
There is no need to create another input device. Signed-off-by: Sean Young --- drivers/media/rc/ir-imon-decoder.c | 62 ++ drivers/media/rc/rc-core-priv.h| 2 - drivers/media/rc/rc-main.c | 6 +++ 3 files changed, 10 insertions(+), 60 deletions(-) diff

[PATCH v4l-utils 1/2] keytable: keymap for Network Dish

2018-09-15 Thread Sean Young
BPF keymap, see: https://www.mythtv.org/wiki/DISHNetworkLIRCConfiguration Cc: VDR User Signed-off-by: Sean Young --- .../rc_keymaps_userspace/dish_network.toml| 62 +++ 1 file changed, 62 insertions(+) create mode 100644 utils/keytable/rc_keymaps_userspace

[PATCH v4l-utils 2/2] keytable: keymap for Windows Remote Keyboard for MCE

2018-09-15 Thread Sean Young
This keymap differs from rc6_mce in that it also enables the mce_kbd protocol. Signed-off-by: Sean Young --- .../rc_keymaps_userspace/mce_keyboard.toml| 75 +++ 1 file changed, 75 insertions(+) create mode 100644 utils/keytable/rc_keymaps_userspace/mce_keyboard.toml diff

Re: [PATCH v3 1/2] media: dt-bindings: bind nokia,n900-ir to generic pwm-ir-tx driver

2018-09-10 Thread Sean Young
On Fri, Aug 31, 2018 at 11:07:23AM +0300, Sakari Ailus wrote: > Hi Sean, > > On Fri, Jul 13, 2018 at 01:22:29PM +0100, Sean Young wrote: > > The generic pwm-ir-tx driver should work for the Nokia n900. > > > > Compile tested only. > > > > Cc: Rob Herring

[GIT PULL FOR v4.20] RC changes

2018-08-29 Thread Sean Young
(2018-08-28 23:27:55 +0100) Matthias Reichl (1): media: rc: ir-rc6-decoder: enable toggle bit for Kathrein RCU-676 remote Sean Young (5): media: dt-bindings: bind nokia, n900-ir to generic pwm-ir-tx driver media

[PATCH] media: rc: Remove init_ir_raw_event and DEFINE_IR_RAW_EVENT macros

2018-08-27 Thread Sean Young
o 4.6"), this is the case. Signed-off-by: Sean Young --- drivers/hid/hid-picolcd_cir.c | 3 +-- drivers/media/common/siano/smsir.c | 8 drivers/media/i2c/cx25840/cx25840-ir.c | 6 ++ drivers/media/pci/cx23885/cx23888-ir.c | 6 ++ drivers/media/pci/cx88/cx

[PATCH 1/2] Remove unnecessary if

2018-08-15 Thread Sean Young
Signed-off-by: Sean Young --- utils/ir-ctl/ir-ctl.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/utils/ir-ctl/ir-ctl.c b/utils/ir-ctl/ir-ctl.c index 59555a13..ddd93068 100644 --- a/utils/ir-ctl/ir-ctl.c +++ b/utils/ir-ctl/ir-ctl.c @@ -175,19 +175,17

[PATCH 2/2] ir-ctl: different drivers have different default timeouts

2018-08-15 Thread Sean Young
A driver might not support setting the timeout either, in addition, if a device does not support measuring the carrier, or has no wideband receiver, this command will also produce an error. Signed-off-by: Sean Young --- utils/ir-ctl/ir-ctl.1.in | 4 1 file changed, 4 deletions(-) diff

Re: [PATCH v3 2/2] media: rc: remove ir-rx51 in favour of generic pwm-ir-tx

2018-08-13 Thread Sean Young
On Fri, Jul 13, 2018 at 05:38:25PM +0300, Ivaylo Dimitrov wrote: > Hi, > > On 13.07.2018 15:22, Sean Young wrote: > > The ir-rx51 is a pwm-based TX driver specific to the N900. This can be > > handled entirely by the generic pwm-ir-tx driver. > > > > Note tha

[PATCH v4 2/6] keytable: add bpf protocols

2018-08-07 Thread Sean Young
Add a few BPF protocols and infrastructure for building them. Signed-off-by: Sean Young --- configure.ac | 4 + utils/keytable/Makefile.am| 4 + utils/keytable/bpf_protocols/Makefile.am | 21 ++ utils/keytable/bpf_protocols

[PATCH v4 0/6] Add BPF decoders to ir-keytable

2018-08-07 Thread Sean Young
. Changes since v4: - Various improvments to ir-keytable man page - Fixed bug in manchester BPF decoder - Fixed bug in lircd2toml wrt toggle_bit Sean Young (6): keytable: add support for BPF based protocols keytable: add bpf protocols keytable: add toml keymap reader keytable: convert

[PATCH v4 5/6] ir-keytable: add tool to aid migration from lircd

2018-08-07 Thread Sean Young
This python script is written to help users translate their lircd.conf remote definition to ir-keytable toml format. The tool does not cover every possible lircd.conf, but the majority should work. ./lircd2toml.py PD-202.lircd.conf -o PD-202.toml Signed-off-by: Sean Young --- contrib

[PATCH v4 6/6] keytable: improve man page wording

2018-08-07 Thread Sean Young
ir should be replaced with rc. Signed-off-by: Sean Young --- utils/keytable/ir-keytable.1.in | 86 ++--- 1 file changed, 47 insertions(+), 39 deletions(-) diff --git a/utils/keytable/ir-keytable.1.in b/utils/keytable/ir-keytable.1.in index 60f9dfe9..ffd2d705

[PATCH v4 3/6] keytable: add toml keymap reader

2018-08-07 Thread Sean Young
her the existing 32 bit scancode -> keycode. In order to make this possible, we want the scancodes to be specified for their protocol, in case multiple protocols are selected. Signed-off-by: Sean Young --- utils/keytable/Makefile.am |2 +- utils/keytable/bpf_load.c | 21 +- utils/ke

Re: [PATCH] media: rc: read out of bounds if bpf reports high protocol number

2018-07-31 Thread Sean Young
Hi Hias, On Mon, Jul 30, 2018 at 09:20:18PM +0200, Matthias Reichl wrote: > On Sat, Jul 28, 2018 at 10:11:15AM +0100, Sean Young wrote: > > The repeat period is read from a static array. If a keydown event is > > reported from bpf with a high protocol number, we rea

[GIT FIXES FOR v4.18] out of bounds memory read

2018-07-29 Thread Sean Young
/media_tree.git for-v4.18g for you to fetch changes up to 0922465cba37c45c1db0786b7fa1ea822bd647a5: media: rc: read out of bounds if bpf reports high protocol number (2018-07-29 16:31:45 +0100) Sean Young (1): media: rc

Re: [PATCH v3 0/5] Add BPF decoders to ir-keytable

2018-07-28 Thread Sean Young
Hi Hias, On Sat, Jul 21, 2018 at 08:13:27PM +0200, Matthias Reichl wrote: > Hi Sean, > > thanks a lot, this is a really nice new feature! Thank you for testing it and finding all those issues, it has become much better from your testing. > On Fri, Jul 13, 2018 at 03:30:06PM +0100

[PATCH] media: rc: read out of bounds if bpf reports high protocol number

2018-07-28 Thread Sean Young
The repeat period is read from a static array. If a keydown event is reported from bpf with a high protocol number, we read out of bounds. This is unlikely to end up with a reasonable repeat period at the best of times, in which case no timely key up event is generated. Signed-off-by: Sean Young

Re: Logspam with "two consecutive events of type space" on gpio-ir-recv and meson-ir

2018-07-25 Thread Sean Young
Hi Hias, On Sat, Jul 21, 2018 at 09:04:21PM +0200, Matthias Reichl wrote: > Hi Sean, > > I noticed that on 4.18-rc5 I get dmesg logspam with > "rc rc0: two consecutive events of type space" on gpio-ir-recv > and meson-ir - mceusb seems to be fine (haven't tested with > other IR receivers yet). >

[PATCH v4l-utils] ir-ctl: make nec32 scancode encoding match kernel

2018-07-17 Thread Sean Young
For the nec32 encoding, the kernel swaps in the "inverted" and normal address and command. This might not be the most logical scheme. Signed-off-by: Sean Young --- utils/common/ir-encode.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/utils/common/ir-

[PATCH 2/2] media: rc: self test for IR encoders and decoders

2018-07-17 Thread Sean Young
ir-loopback can transmit IR on one rc device and check the correct scancode and protocol is decoded on a different rc device. This can be used to check IR transmission between two rc devices. Using rc-loopback, we use it to check the IR encoders and decoders themselves. Signed-off-by: Sean Young

[PATCH 1/2] media: rc: nec keymaps should specify the nec variant they use

2018-07-17 Thread Sean Young
The rc_proto field should list the exact variant used by the remote. This does not change the decoder used, but helps with using keymaps for transmit purposes. Signed-off-by: Sean Young --- drivers/media/rc/keymaps/rc-behold.c | 2 +- drivers/media/rc/keymaps/rc-delock-61959.c

[PATCH v3 5/5] ir-keytable: add tool to aid migration from lircd

2018-07-13 Thread Sean Young
This python script is written to help users translate their lircd.conf remote definition to ir-keytable toml format. The tool does not cover every possible lircd.conf, but the majority should work. ./lircd2toml.py PD-202.lircd.conf -o PD-202.toml Signed-off-by: Sean Young --- contrib

[PATCH v3 2/5] keytable: add bpf protocols

2018-07-13 Thread Sean Young
Add a few BPF protocols and infrastructure for building them. Signed-off-by: Sean Young --- configure.ac | 4 + utils/keytable/Makefile.am| 4 + utils/keytable/bpf_protocols/Makefile.am | 21 ++ utils/keytable/bpf_protocols

[PATCH v3 0/5] Add BPF decoders to ir-keytable

2018-07-13 Thread Sean Young
. Changes since v3: - lots of fixes - Wrote python script to convert lircd.conf to toml file Changes since v2: - bpf parameters can be specified on the command line - bpf decoders can be loaded by path without keymap Sean Young (5): keytable: add support for BPF based protocols keytable: add

[PATCH v3 4/5] keytable: convert keymaps to new toml format

2018-07-13 Thread Sean Young
Convert all the existing keymaps to toml, so that only one format is used. Include the protocol variant as well. This will be useful in the future if we want to use rc keymaps for transmitting IR. Signed-off-by: Sean Young --- utils/keytable/gen_keytables.pl | 33 ++- utils

[PATCH v3 3/5] keytable: add toml keymap reader

2018-07-13 Thread Sean Young
her the existing 32 bit scancode -> keycode. In order to make this possible, we want the scancodes to be specified for their protocol, in case multiple protocols are selected. Signed-off-by: Sean Young --- utils/keytable/Makefile.am |2 +- utils/keytable/bpf_load.c | 21 +- utils/ke

Re: [PATCH v2 1/2] media: dt-bindings: bind nokia,n900-ir to generic pwm-ir-tx driver

2018-07-13 Thread Sean Young
On Fri, Jul 13, 2018 at 01:13:20PM +0200, Pavel Machek wrote: > Hi! > > > Signed-off-by: Sean Young > > --- > > .../devicetree/bindings/media/nokia,n900-ir | 20 --- > > arch/arm/boot/dts/omap3-n900.dts | 2 +- >

[PATCH v3 1/2] media: dt-bindings: bind nokia,n900-ir to generic pwm-ir-tx driver

2018-07-13 Thread Sean Young
The generic pwm-ir-tx driver should work for the Nokia n900. Compile tested only. Cc: Rob Herring Cc: Ivaylo Dimitrov Cc: Pali Rohár Cc: Pavel Machek Cc: Timo Kokkonen Cc: Tony Lindgren Signed-off-by: Sean Young --- arch/arm/boot/dts/omap3-n900.dts | 2 +- drivers/media/rc/pwm-ir-tx.c

[PATCH v3 2/2] media: rc: remove ir-rx51 in favour of generic pwm-ir-tx

2018-07-13 Thread Sean Young
the transmit completes. Compile tested only. Cc: Ivaylo Dimitrov Cc: Pali Rohár Cc: Pavel Machek Cc: Timo Kokkonen Cc: Tony Lindgren Signed-off-by: Sean Young --- arch/arm/configs/omap2plus_defconfig | 1 - drivers/media/rc/Kconfig | 10 - drivers/media/rc/Makefile| 1

[PATCH v2 1/2] media: dt-bindings: bind nokia,n900-ir to generic pwm-ir-tx driver

2018-07-13 Thread Sean Young
The generic pwm-ir-tx driver should work for the Nokia n900. Compile tested only. Cc: Rob Herring Cc: Ivaylo Dimitrov Cc: Pali Rohár Cc: Pavel Machek Cc: Timo Kokkonen Cc: Tony Lindgren Signed-off-by: Sean Young --- .../devicetree/bindings/media/nokia,n900-ir | 20

[PATCH v2 2/2] media: rc: remove ir-rx51 in favour of generic pwm-ir-tx

2018-07-13 Thread Sean Young
the transmit completes. Compile tested only. Cc: Ivaylo Dimitrov Cc: Pali Rohár Cc: Pavel Machek Cc: Timo Kokkonen Cc: Tony Lindgren Signed-off-by: Sean Young --- arch/arm/configs/omap2plus_defconfig | 1 - drivers/media/rc/Kconfig | 10 - drivers/media/rc/Makefile

Re: [PATCH] lirc.4: remove ioctls and feature bits which were never implemented

2018-07-12 Thread Sean Young
On Thu, Jul 12, 2018 at 09:33:32AM -0300, Mauro Carvalho Chehab wrote: > Hi Michael/Alec, > > Em Fri, 18 May 2018 16:25:29 +0100 > Sean Young escreveu: > > > On Sun, May 06, 2018 at 12:34:53PM +0200, Michael Kerrisk (man-opages) > > wrote: > > >

[GIT FIXES FOR v4.18] leaking bpf programs after detach

2018-07-04 Thread Sean Young
8:29 +0100) ---- Sean Young (1): media: bpf: ensure bpf program is freed on detach drivers/media/rc/bpf-lirc.c | 1 + 1 file changed, 1 insertion(+)

[PATCH] media: bpf: ensure bpf program is freed on detach

2018-07-04 Thread Sean Young
Currently we are leaking bpf programs when they are detached from the lirc device; the refcount never reaches zero. Signed-off-by: Sean Young --- drivers/media/rc/bpf-lirc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/rc/bpf-lirc.c b/drivers/media/rc/bpf-lirc.c index

[GIT FIXES FOR v4.18] meson-ir produces too many warnings

2018-06-27 Thread Sean Young
in the Git repository at: git://linuxtv.org/syoung/media_tree.git for-v4.18e for you to fetch changes up to 97983eed9c07ffd94429527a5e41facde4811fbc: media: rc: be less noisy when driver misbehaves (2018-06-27 10:51:42 +0100) Sean

Re: [1/3] media: rc: drivers should produce alternate pulse and space timing events

2018-06-26 Thread Sean Young
On Tue, Jun 26, 2018 at 04:39:51PM +0200, Jerome Brunet wrote: > On Tue, 2018-06-26 at 15:37 +0100, Sean Young wrote: > > On Tue, Jun 19, 2018 at 04:09:20PM +0200, Jerome Brunet wrote: > > > On Tue, 2018-06-19 at 13:57 +0100, Sean Young wrote: > > > > On Tue, Ju

Re: [1/3] media: rc: drivers should produce alternate pulse and space timing events

2018-06-26 Thread Sean Young
On Tue, Jun 19, 2018 at 04:09:20PM +0200, Jerome Brunet wrote: > On Tue, 2018-06-19 at 13:57 +0100, Sean Young wrote: > > On Tue, Jun 19, 2018 at 02:08:12PM +0200, Jerome Brunet wrote: > > > On Sat, 2018-05-12 at 11:55 +0100, Sean Young wrote: > > > > Report an error

[RFC PATCH v2 1/4] keytable: add toml keymap reader

2018-06-24 Thread Sean Young
32 bit scancode -> keycode. In order to make this possible, we want the scancodes to be specified for their protocol, in case multiple protocols are selected. Signed-off-by: Sean Young --- utils/keytable/Makefile.am |2 +- utils/keytable/keytable.c | 174 +++- utils/keytable/toml.c

[RFC PATCH v2 2/4] keytable: convert keymaps to new toml format

2018-06-24 Thread Sean Young
We will be added new BPF based keymaps which require the toml format. Convert all the existing keymaps to toml, so that only one format is used. Include the protocol variant as well. This will be useful in the future if we want to use rc keymaps for transmitting IR. Signed-off-by: Sean Young

[RFC PATCH v2 4/4] keytable: add bpf protocols

2018-06-24 Thread Sean Young
Add grundig decoder and infrastructure for build bpf protocols. Signed-off-by: Sean Young --- configure.ac | 4 + utils/keytable/Makefile.am| 4 + utils/keytable/bpf_protocols/Makefile.am | 21 ++ utils/keytable/bpf_protocols

[RFC PATCH v2 0/4] Add BPF decoders to ir-keytable

2018-06-24 Thread Sean Young
/perl?) Changes since v2: - bpf parameters can be specified on the command line - bpf decoders can be loaded by path without keymap Sean Young (4): keytable: add toml keymap reader keytable: convert keymaps to new toml format keytable: add support for BPF based decoders keytable: add bpf

Re: [1/3] media: rc: drivers should produce alternate pulse and space timing events

2018-06-19 Thread Sean Young
On Tue, Jun 19, 2018 at 02:08:12PM +0200, Jerome Brunet wrote: > On Sat, 2018-05-12 at 11:55 +0100, Sean Young wrote: > > Report an error if this is not the case or any problem with the generated > > raw events. > > Hi, > > Since the inclusion of this patch, e

Re: [PATCH] lirc.4: remove ioctls and feature bits which were never implemented

2018-06-06 Thread Sean Young
Hi Alec, On Sat, May 19, 2018 at 08:38:11AM +0200, Alec Leamas wrote: > On 18/05/18 17:25, Sean Young wrote: > > On Sun, May 06, 2018 at 12:34:53PM +0200, Michael Kerrisk (man-opages) > > wrote: > >> [CCing original author of this page] > >> > >> >

Re: [RFC PATCH v1 0/4] Add BPF decoders to ir-keytable

2018-06-02 Thread Sean Young
On Sat, Jun 02, 2018 at 01:37:54PM +0100, Sean Young wrote: > This is not ready for merging yet, however while I finish this work I would > like some feedback and ideas. > > The idea is that IR decoders can be written in C, compiled to BPF relocatable > object file. Any globa

[RFC PATCH v1 0/4] Add BPF decoders to ir-keytable

2018-06-02 Thread Sean Young
to complete this work: - Write more IR decoders - More rc_keymaps - More testing - lircd.conf to toml converter script (python/perl?) Sean Young (4): keytable: add toml keymap reader keytable: convert keymaps to new toml format keytable: add support for BPF based decoders keytable: add bpf

[RFC PATCH v1 3/4] keytable: add support for BPF based decoders

2018-06-02 Thread Sean Young
We use a modified version of samples/bpf/bpf_load.c from linux kernel tree to load elf based BPF decoders, clear them on '-c' and show the program ids when no commands are given. Any global int variables can be overrided from toml. They are patched to be immediate loads. Signed-off-by: Sean

[RFC PATCH v1 4/4] keytable: add bpf protocols

2018-06-02 Thread Sean Young
Add grundig decoder and infrastructure for build bpf protocols. Signed-off-by: Sean Young --- configure.ac| 5 + utils/keytable/Makefile.am | 4 + utils/keytable/bpf_protocols/Makefile.am| 14 + utils/keytable/bpf_protocols/bpf_helpers.h

[RFC PATCH v1 1/4] keytable: add toml keymap reader

2018-06-02 Thread Sean Young
32 bit scancode -> keycode. In order to make this possible, we want the scancodes to be specified for their protocol, in case multiple protocols are selected. Signed-off-by: Sean Young --- utils/keytable/Makefile.am |2 +- utils/keytable/keytable.c | 174 +++- utils/keytable/toml.c

[PATCH v5 1/3] bpf: bpf_prog_array_copy() should return -ENOENT if exclude_prog not found

2018-05-27 Thread Sean Young
This makes is it possible for bpf prog detach to return -ENOENT. Acked-by: Yonghong Song <y...@fb.com> Signed-off-by: Sean Young <s...@mess.org> --- kernel/bpf/core.c| 11 +-- kernel/trace/bpf_trace.c | 2 ++ 2 files changed, 11 insertions(+), 2 deletions(-) diff --

[PATCH v5 0/3] IR decoding using BPF

2018-05-27 Thread Sean Young
ally every remote without having to write a decoder for each. It might also be possible to support non-button devices such as analog directional pads or air conditioning remote controls and decode the target temperature in bpf, and pass that to an input device. Thanks, Sean Young [1] http:

  1   2   3   4   5   6   7   8   9   10   >