Re: [RFC 0/6] iommu: generic api migration and grouping

2011-06-07 Thread Roedel, Joerg
On Mon, Jun 06, 2011 at 04:09:33PM -0400, Ohad Ben-Cohen wrote: On Mon, Jun 6, 2011 at 10:20 PM, Roedel, Joerg joerg.roe...@amd.com wrote: Well, it certainly makes sense to have a single implementation for this. But I want to hide this complexity to the user of the IOMMU-API. The best

Re: [RFC 0/6] iommu: generic api migration and grouping

2011-06-07 Thread Ohad Ben-Cohen
On Tue, Jun 7, 2011 at 10:52 AM, Roedel, Joerg joerg.roe...@amd.com wrote: Yup. Btw, is there any IOMMU hardware which supports non-natural alignment? In this case we need to expose these requirements somehow. Not sure there are. Let's start with natural alignment, and extend it only if someone

Re: [RFC 0/6] iommu: generic api migration and grouping

2011-06-07 Thread Roedel, Joerg
On Tue, Jun 07, 2011 at 05:22:11AM -0400, Ohad Ben-Cohen wrote: On Tue, Jun 7, 2011 at 10:52 AM, Roedel, Joerg joerg.roe...@amd.com wrote: Yup. Btw, is there any IOMMU hardware which supports non-natural alignment? In this case we need to expose these requirements somehow. Not sure there

Re: [RFC 0/6] iommu: generic api migration and grouping

2011-06-07 Thread Ohad Ben-Cohen
On Tue, Jun 7, 2011 at 12:58 PM, Roedel, Joerg joerg.roe...@amd.com wrote: Btw, mind to split out your changes which move the iommu-api into drivers/iommu? I can merge them meanwhile into my iommu tree and start working on a proposal for the generic large page-size support. Sure, that will be

Re: [RFC 0/6] iommu: generic api migration and grouping

2011-06-06 Thread Arnd Bergmann
On Sunday 05 June 2011, Ohad Ben-Cohen wrote: As far as I can tell, once we have that in place, we you can migrate omap3isp from iovmm to dma-mapping and remove iovmm. Sounds like a plan. I'd still prefer us to take small steps here, and not gate the omap iommu cleanups with Marek's

Re: [RFC 0/6] iommu: generic api migration and grouping

2011-06-06 Thread Roedel, Joerg
Hi, On Thu, Jun 02, 2011 at 06:27:37PM -0400, Ohad Ben-Cohen wrote: First stab at iommu consolidation: - Migrate OMAP's iommu driver to the generic iommu API. With this in hand, users can now start using the generic iommu layer instead of calling omap-specific iommu API. New code

Re: [RFC 0/6] iommu: generic api migration and grouping

2011-06-06 Thread Ohad Ben-Cohen
Hi Joerg, On Mon, Jun 6, 2011 at 1:09 PM, Roedel, Joerg joerg.roe...@amd.com wrote: The IOMMU-API already supports multiple page-sizes. See the 'order'-parameter of the map/unmap functions. This is insufficient; users need somehow to tell what page sizes are supported by the underlying

Re: [RFC 0/6] iommu: generic api migration and grouping

2011-06-06 Thread Ohad Ben-Cohen
On Mon, Jun 6, 2011 at 12:10 PM, Arnd Bergmann a...@arndb.de wrote: I'd still prefer us to take small steps here, and not gate the omap iommu cleanups with Marek's generic dma_map_ops work though. Let's go forward and migrate omap's iommu to the generic iommu API, so new code will be able to

Re: [RFC 0/6] iommu: generic api migration and grouping

2011-06-06 Thread Roedel, Joerg
On Mon, Jun 06, 2011 at 11:15:30AM -0400, Ohad Ben-Cohen wrote: This is insufficient; users need somehow to tell what page sizes are supported by the underlying hardware (we can't assume host page-sizes, and we want to use bigger pages whenever possible, to relax the TLB pressure). / What

Re: [RFC 0/6] iommu: generic api migration and grouping

2011-06-06 Thread Ohad Ben-Cohen
On Mon, Jun 6, 2011 at 10:20 PM, Roedel, Joerg joerg.roe...@amd.com wrote: Well, it certainly makes sense to have a single implementation for this. But I want to hide this complexity to the user of the IOMMU-API. The best choice is to put this into the layer between the IOMMU-API and the

Re: [RFC 0/6] iommu: generic api migration and grouping

2011-06-05 Thread Ohad Ben-Cohen
Hi Arnd, On Fri, Jun 3, 2011 at 6:53 PM, Arnd Bergmann a...@arndb.de wrote: I think the future of iovmm is looking not so good. Marek Szyprowski is working on a generic version of the dma-mapping API (dma_map_ops) based on the iommu API. Nice! I missed Marek's work somehow. As far as I can

Re: [RFC 0/6] iommu: generic api migration and grouping

2011-06-05 Thread Ohad Ben-Cohen
Hi Kyungmin, On Fri, Jun 3, 2011 at 2:57 AM, Kyungmin Park kmp...@infradead.org wrote: Please see the RFC patch, ARM: DMA-mapping IOMMU integration http://www.spinics.net/lists/linux-mm/msg19856.html Marek's work somehow escaped me, thanks for the pointers ! Ohad. -- To unsubscribe from this

Re: [RFC 0/6] iommu: generic api migration and grouping

2011-06-03 Thread Arnd Bergmann
On Friday 03 June 2011, Ohad Ben-Cohen wrote: First stab at iommu consolidation: Hi Ohad, Great to see your progress here! - Migrate OMAP's iommu driver to the generic iommu API. With this in hand, users can now start using the generic iommu layer instead of calling omap-specific iommu

[RFC 0/6] iommu: generic api migration and grouping

2011-06-02 Thread Ohad Ben-Cohen
First stab at iommu consolidation: - Migrate OMAP's iommu driver to the generic iommu API. With this in hand, users can now start using the generic iommu layer instead of calling omap-specific iommu API. New code that requires functionality missing from the generic iommu api, will add

Re: [RFC 0/6] iommu: generic api migration and grouping

2011-06-02 Thread Kyungmin Park
Hi, Good approach. CC'ed the Samsung IOMMU developer. Marek. BTW, Russell wants to use the DMA based IOMMU? Please see the RFC patch, ARM: DMA-mapping IOMMU integration http://www.spinics.net/lists/linux-mm/msg19856.html Thank you, Kyungmin Park On Fri, Jun 3, 2011 at 7:27 AM, Ohad Ben-Cohen