RE: [PATCH v0 1/2] V4L - vpfe capture - convert ccdc drivers to platform drivers

2009-12-04 Thread Karicheri, Muralidharan
Sekhar, + status = -EBUSY; [Hiremath, Vaibhav] Is -EBUSY right return value, I think it should be - ENXIO or -ENOMEM. I see -ENXIO -ENOMEM being used by drivers. -ENXIO stands for No such device or address. ENOMEM stands for Out of memory . Since we are trying to map the address

RE: [PATCH v0 1/2] V4L - vpfe capture - convert ccdc drivers to platform drivers

2009-12-03 Thread Karicheri, Muralidharan
+#include mach/mux.h [Hiremath, Vaibhav] This should not be here, this should get handled in board file. The driver should be generic. See my comments against the platform part of this patch. #include media/davinci/dm355_ccdc.h #include media/davinci/vpss.h #include dm355_ccdc_regs.h @@

RE: [PATCH v0 1/2] V4L - vpfe capture - convert ccdc drivers to platform drivers

2009-12-03 Thread Nori, Sekhar
On Fri, Dec 04, 2009 at 01:21:43, Karicheri, Muralidharan wrote: [...] + if (!res) { + status = -EBUSY; + goto fail_nores; + } + + ccdc_base_addr = ioremap_nocache(res-start, res_len); + if (!ccdc_base_addr) { + status = -EBUSY; [Hiremath,

RE: [PATCH v0 1/2] V4L - vpfe capture - convert ccdc drivers to platform drivers

2009-12-01 Thread Hiremath, Vaibhav
-Original Message- From: Karicheri, Muralidharan Sent: Tuesday, December 01, 2009 11:46 PM To: linux-media@vger.kernel.org; hverk...@xs4all.nl; khil...@deeprootsystems.com Cc: davinci-linux-open-sou...@linux.davincidsp.com; Hiremath, Vaibhav; Karicheri, Muralidharan Subject: [PATCH