[PATCH 7/14] drivers/mmc: Move dereference after NULL test

2009-10-16 Thread Julia Lawall
From: Julia Lawall If the NULL test on mrq is needed, then the derefernce should be after the NULL test. A simplified version of the semantic match that detects this problem is as follows (http://coccinelle.lip6.fr/): // @match exists@ expression x, E; identifier fld; @@ * x->fld ... when !

Re: MMC_CAP_SDIO_IRQ for omap 3430

2009-10-16 Thread Dirk Behme
John Rigby wrote: It appears to never get cleared in the status register. In the OMAP status register, correct? (just to get the correct understanding) I added some printks to sdio_irq.c to print the pending interrupts in the SDIO_CCCR_INTx register for the card and there are no pending int

+ sdio-rework-cis-tuple-parsing.patch added to -mm tree

2009-10-16 Thread akpm
The patch titled sdio: rework cis tuple parsing has been added to the -mm tree. Its filename is sdio-rework-cis-tuple-parsing.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find

Re: MMC_CAP_SDIO_IRQ for omap 3430

2009-10-16 Thread John Rigby
It appears to never get cleared in the status register. I added some printks to sdio_irq.c to print the pending interrupts in the SDIO_CCCR_INTx register for the card and there are no pending interrupts so I don't think it is a card driver or card issue. It would be funny if the TRM was wrong and

RE: MMC_CAP_SDIO_IRQ for omap 3430

2009-10-16 Thread Madhusudhan
> -Original Message- > From: Dirk Behme [mailto:dirk.be...@googlemail.com] > Sent: Friday, October 16, 2009 2:28 PM > To: Madhusudhan Chikkature > Cc: linux-mmc@vger.kernel.org; John Rigby; linux-o...@vger.kernel.org; > Steve Sakoman > Subject: Re: MMC_CAP_SDIO_IRQ for omap 3430 > > Madh

Re: MMC_CAP_SDIO_IRQ for omap 3430

2009-10-16 Thread Dirk Behme
Madhusudhan Chikkature wrote: Hi Dirk, I am inlining the patch so that it helps review. ... @@ -1165,8 +1178,15 @@ static void omap_hsmmc_set_ios(struct mm break; case MMC_BUS_WIDTH_4: OMAP_HSMMC_WRITE(host->base, CON, con & ~DW8); - OMAP_H

Re: [PATCH 1/8] trivial: coding style fixes

2009-10-16 Thread Jiri Kosina
On Fri, 16 Oct 2009, Stefan Richter wrote: > Plus, I hope Jiri enhanced your changelog a bit before he committed it. > (I only looked at this patch because I was wondering what subsystem it > changed --- the patch title doesn't say it.) Yup, I have put it into header (I always do if it is not c

Re: MMC_CAP_SDIO_IRQ for omap 3430

2009-10-16 Thread Madhusudhan Chikkature
Hi Dirk, I am inlining the patch so that it helps review. Subject: [PATCH][RFC] OMAP HSMMC: Add SDIO interrupt support Form: Dirk Behme At the moment, OMAP HSMMC driver supports only SDIO polling, resulting in poor performance. Add support for SDIO interrupt handling. Signed-off-by: Dirk Beh

Re: [PATCH 1/8] trivial: coding style fixes

2009-10-16 Thread Stefan Richter
Thadeu Lima de Souza Cascardo wrote: > --- a/drivers/mmc/card/sdio_uart.c > +++ b/drivers/mmc/card/sdio_uart.c [...] > @@ -946,31 +948,31 @@ static int sdio_uart_proc_show(struct seq_file *m, void > *v) > seq_printf(m, "%d: uart:SDIO", i); > if(capable(C

Re: [PATCH 1/8] trivial: coding style fixes

2009-10-16 Thread Jiri Kosina
On Thu, 15 Oct 2009, Thadeu Lima de Souza Cascardo wrote: > Signed-off-by: Thadeu Lima de Souza Cascardo > --- > drivers/mmc/card/sdio_uart.c | 40 +--- > 1 files changed, 21 insertions(+), 19 deletions(-) Applied to trivial queue. -- Jiri Kosina SUSE Lab