Re: [PATCH v4][mmc/host]:Blackfin SD Host Controller Driver

2009-11-29 Thread Mike Frysinger
On Wed, Nov 25, 2009 at 17:43, Andrew Morton wrote: On Wed, 25 Nov 2009 17:25:20 -0500 Mike Frysinger wrote: Arguably wrong from a coding-style POV and looks weird IMO. __Adds a bit of risk that subsequent coders will think they're writing in python adn will add bugs. i dont really get

[PATCH 2.6.32-rc8 2/3] mmc: Clean up mmc_decode_scr() implementation

2009-11-29 Thread don . mullis
In mmc_decode_scr(), back out coercion of 128-bit-oriented UNSTUFF_BITS() macro to work on 64-bit raw_scr field; invoke UNSTUFF_BITS_ARRAY() instead. Tested by verifying that /sys output for scr register is unchanged. Signed-off-by: don.mul...@gmail.com --- drivers/mmc/core/sd.c | 10

[PATCH 2.6.32-rc8 3/3] mmc: Add SD_STATUS register dump to debugfs

2009-11-29 Thread don . mullis
Add a file to debugfs to read back the SD_STATUS register from an SD card. SD_STATUS contains performance-related information. Signed-off-by: don.mul...@gmail.com --- drivers/mmc/core/debugfs.c | 56 + drivers/mmc/core/sd_ops.c | 51