Re: [PATCH] sdio: add new function for RAW (Read after Write) operation

2010-05-15 Thread Grazvydas Ignotas
On Sat, May 15, 2010 at 7:25 PM, Dmitry Shmidt wrote: > Hi Grazvydas, > > You are right. > mmc_io_rw_direct() implementation doesn't check R/W flag and returns > data if "out" != NULL. > So if SDIO spec "demands" WRITE flag and wl1251 ignores it anyway, > then we should use WRITE. > You function n

[PATCH v4 5/5] OMAP4 HSMMC: Adding card detect support for MMC1 Controller

2010-05-15 Thread kishore kadiyala
Adds card detect callback function which gives the status of the card .For MMC1 Controller, Card detect interrupt is provided by twl6030 and card status is provided by MMCCTRL reg of twl6030. Signed-off-by: Kishore Kadiyala --- arch/arm/mach-omap2/board-4430sdp.c |9 +- arch/arm/mach-o

[PATCH v4 4/5] OMAP HSMMC: Adding a flag to determine the card detect type

2010-05-15 Thread kishore kadiyala
Adding a flag to determine the card detect type which can be either GPIO or NON-GPIO.MMC1 Controller of OMAP4 have NON-GPIO interrupt line from twl6030 for card detect. Signed-off-by: Kishore Kadiyala --- arch/arm/mach-omap2/board-2430sdp.c |2 ++ arch/arm/mach-omap2/board-3430sdp.c

[PATCH v4 3/5] OMAP4 HSMMC: Enable HSMMC support

2010-05-15 Thread kishore kadiyala
Enables HSMMC support for OMAP4430 defconfig Signed-off-by: Kishore Kadiyala --- arch/arm/configs/omap_4430sdp_defconfig | 19 ++- 1 files changed, 18 insertions(+), 1 deletions(-) diff --git a/arch/arm/configs/omap_4430sdp_defconfig b/arch/arm/configs/omap_4430sdp_defconfig

[PATCH v4 2/5] OMAP4 HSMMC: Adding PBIAS Configuration for MMC1 Controller

2010-05-15 Thread kishore kadiyala
In OMAP4 , MMC1 PBIAS and its associated IO is software-controlled by CONTROL_PBIAS and CONTROL_MMC1 registers. This patch adds PBIAS configuration for MMC1 Controller during power-ON and power-OFF of regulator. Signed-off-by: Kishore Kadiyala --- arch/arm/mach-omap2/hsmmc.c | 97

[PATCH v4 1/5] OMAP4 HSMMC: Adding hsmmc support to board file

2010-05-15 Thread kishore kadiyala
Adding support for MMC1 & MMC2 controllers of OMAP4430 SDP to board file. Signed-off-by: Kishore Kadiyala --- arch/arm/mach-omap2/Makefile|3 +- arch/arm/mach-omap2/board-4430sdp.c | 59 ++ 2 files changed, 54 insertions(+), 8 deletions(-) diff --gi

[PATCH v4 0/5] Adding MMC Support on OMAP4430 SDP

2010-05-15 Thread kishore kadiyala
Adding MMC1 and MMC2 controllers support for OMAP4 V4: - Rebased to "for_next" branch[LO]. - The first 3 patches [1,2,3] in the series are Minimal set of changes with which MMC1/MMC2 works [No card detect for MMC1]on OMAP4 but with dependencies on following patches [Not in "for_next" branch]

Re: [PATCH v3 2/5] OMAP4 HSMMC: Adding hsmmc support to board file

2010-05-15 Thread kishore kadiyala
Tony, On Sat, May 15, 2010 at 3:26 AM, Tony Lindgren wrote: > * kishore kadiyala [100513 13:06]: >> Support for MMC1 & MMC2 controllers is added to the board file. >> Also includes configuration of MMC1 Card detect initially. > > This patch does not seem to apply, I don't know where you're gettin

Re: [PATCH] sdio: add new function for RAW (Read after Write) operation

2010-05-15 Thread Dmitry Shmidt
Hi Grazvydas, You are right. mmc_io_rw_direct() implementation doesn't check R/W flag and returns data if "out" != NULL. So if SDIO spec "demands" WRITE flag and wl1251 ignores it anyway, then we should use WRITE. You function name is slightly confusing I would say, but I am fine with the patch.

Re: [PATCH] sdio: add new function for RAW (Read after Write) operation

2010-05-15 Thread Grazvydas Ignotas
On Sat, May 15, 2010 at 3:02 AM, Dmitry Shmidt wrote: > Hi Andrew, > > wl1251 has some HW problem for ELP register that demands to do > something like "write during read" in order > not to loose bits from this register during simple read. > Fortunately it was enough just to add low 8 bits previous

Re: Status of tmio_mmc DMA support for SDIO

2010-05-15 Thread Ian Molton
Could someone send me a copy of the patch to tmio ? -- Ian Molton Linux, Automotive, and other hacking: http://www.mnementh.co.uk/ On 14 May 2010 20:43, Charles D. Krebs wrote: >>> Just saw this - am I right in thinking someone has written SDIO >>> support for TMIO ? Im afraid I dont appear t

RE: [PATCH v3 2/5] OMAP4 HSMMC: Adding hsmmc support to board file

2010-05-15 Thread Shilimkar, Santosh
Kishore, > -Original Message- > From: linux-omap-ow...@vger.kernel.org > [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of > Shilimkar, Santosh > Sent: Saturday, May 15, 2010 11:41 AM > To: Kadiyala, Kishore > Cc: linux-mmc@vger.kernel.org; linux-o...@vger.kernel.org; Chikkature > Ra