Ben Dooks wrote:
>
> On Tue, Jun 15, 2010 at 08:27:46PM +0900, Kukjin Kim wrote:
> > From: Lee Hyuk
> >
> > This patch adds the members of platdata which are cfg_wp and get_ro.
> > The cfg_wp is the function for setting the specific GPIO for WP pin
> > and get_ro is the function for getting data
Ben Dooks wrote:
>
> On Tue, Jun 15, 2010 at 08:27:47PM +0900, Kukjin Kim wrote:
> > From: Lee Hyuk
> >
> > S5PV210 HSMMC host controller doesn't have the Write Protection pin
which
> > should be connnected with SDMMC card WP pin. So allocated a GPIO in
order
> to
> > get the data from SDMMC card
Maurus Cuelenaere wrote:
>
> Op 15-06-10 13:27, Kukjin Kim schreef:
> > From: Lee Hyuk
> >
> > S5PV210 HSMMC host controller doesn't have the Write Protection pin which
> > should be connnected with SDMMC card WP pin. So allocated a GPIO in order
> to
> > get the data from SDMMC card WP pin with
From: Hyuk Lee
This patch adds the members of platdata which is wp_gpio.
The wp_gpio is a gpio_number which is connected with WP pin of SD Slot.
Signed-off-by: Hyuk Lee
Signed-off-by: Kukjin Kim
---
arch/arm/plat-samsung/dev-hsmmc.c |2 ++
arch/arm/plat-samsung/dev-hsmmc1.c
From: Hyuk Lee
S5PV210 HSMMC host controller doesn't have the Write Protection pin which
should be connnected with SDMMC card WP pin. So send the allocated GPIO number
which is connected with WP pin of SD slot in order to implement get_ro function
in sdhci-s3c.
Signed-off-by: Hyuk Lee
Signed-of
From: Hyuk Lee
If host controller doesn't have WP pin which should be connnected with SDMMC
card WP pin, can implement get_ro function with using the allocated gpio.
In order to use this quirk wp_gpio in the platform data must be set.
Signed-off-by: Hyuk Lee
Signed-off-by: Kukjin Kim
---
driv
This patch adds support SDMMC write protection pin on SMDKV210.
Changes since v1:
Addressed comments from Ben Dooks, Maurus Cuelenaere and Kyungmin Park
- just pass gpio numbers for support WP as Ben's suggestion
- use the gpio layer for specific machine
- use s3c_sdhcix_set_platdata() in machine
Kyungmin Park wrote:
>
> On Tue, Jun 15, 2010 at 8:27 PM, Kukjin Kim wrote:
> > From: Lee Hyuk
> >
> > S5PV210 HSMMC host controller doesn't have the Write Protection pin
which
> > should be connnected with SDMMC card WP pin. So allocated a GPIO in
order
> to
> > get the data from SDMMC card WP
The patch titled
sdhci-pltfm: add support for CNS3xxx SoC devices
has been added to the -mm tree. Its filename is
sdhci-pltfm-add-support-for-cns3xxx-soc-devices.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mail
Hi Madhav,
> + host->user = 0; /*For Clock gating*/
> + host->clk_restore = 0;
Also, it's not obvious to me why two variables are necessary. What's
wrong with just setting host->clk_restore when disabling clock, and
testing whether it's non-zero instead of testing host->user?
I fixed the all issues after running checkpatch.pl and resending it.
From 1fae693a2eef37d878066b09c89f95f57f945f64 Mon Sep 17 00:00:00 2001
From: Madhav Singh
Date: Fri, 2 Jul 2010 19:33:19 +0530
Subject: [PATCH] sdhci-clk-gating-support
This patch implements clock gating support in sdhci layer.
Hi Madhav,
The patch is extremely whitespace-damaged, and your code is also
formatted incorrectly.
Some general points:
* have you measured whether there's a performance impact from
bringing the clock up and down for every request?
* I'd expect this to be implemented as an MMC capability, s
From 1917452ca1fcbb6ba52916b7535f453d86d55a1c Mon Sep 17 00:00:00 2001
From: Madhav Singh ,Nitish
Ambastha
Date: Fri, 2 Jul 2010 17:28:57 +0530
Subject: [PATCH] sdhci-clk-gating-support
This patch implements clock gating support in sdhci layer.It will enable the
clock when
host controller start
13 matches
Mail list logo
