Re: [PATCH v2 03/20] mmc: support embedded data field in mmc_host

2010-08-06 Thread Nicolas Pitre
On Fri, 6 Aug 2010, Russell King - ARM Linux wrote: > On Fri, Aug 06, 2010 at 01:02:24PM +0300, Ohad Ben-Cohen wrote: > > We have Russell's suggestion which is nice and simple, but it has the > > 1 device limitation. > > You could make it generic by doing something like this: > > #define set_dev

Re: [PATCH v2 03/20] mmc: support embedded data field in mmc_host

2010-08-06 Thread Russell King - ARM Linux
On Fri, Aug 06, 2010 at 01:02:24PM +0300, Ohad Ben-Cohen wrote: > We have Russell's suggestion which is nice and simple, but it has the > 1 device limitation. You could make it generic by doing something like this: #define set_device_data(name, type, index, data)\ ({

Re: [PATCH v2 03/20] mmc: support embedded data field in mmc_host

2010-08-06 Thread Ohad Ben-Cohen
On Fri, Aug 6, 2010 at 10:07 AM, Linus Walleij wrote: > 2010/8/4 Ohad Ben-Cohen : >> On Wed, Aug 4, 2010 at 2:41 PM, Russell King - ARM Linux >>> >>> Why not arrange for a small piece of code to be built into the kernel >>> when this driver is selected as a module or built-in, which handles >>> th

Re: [PATCH v2 03/20] mmc: support embedded data field in mmc_host

2010-08-06 Thread Linus Walleij
2010/8/4 Ohad Ben-Cohen : > On Wed, Aug 4, 2010 at 2:41 PM, Russell King - ARM Linux >> >> Why not arrange for a small piece of code to be built into the kernel >> when this driver is selected as a module or built-in, which handles >> the passing of platform data to the driver? > > It's interesting