Hi Ohad,
On 08/11/2010 01:12 AM, ext Ohad Ben-Cohen wrote:
Prepare for mmc3 regulator power control by splitting the power
control functions of mmc2 and mmc3, and expecting mmc3 to have
a single, dedicated, regulator support.
Signed-off-by: Ohad Ben-Coheno...@wizery.com
---
On 08/11/2010 01:12 AM, ext Ohad Ben-Cohen wrote:
Add MMC3 support on ZOOM, which has the wl1271 device hardwired to.
The wl1271 is a 4-wire, 1.8V, embedded SDIO WLAN device with an
external IRQ line, and power-controlled by a GPIO-based fixed regulator.
Signed-off-by: Ohad
On 08/11/2010 11:37 AM, Roger Quadros wrote:
On 08/11/2010 01:12 AM, ext Ohad Ben-Cohen wrote:
Add MMC3 support on ZOOM, which has the wl1271 device hardwired to.
The wl1271 is a 4-wire, 1.8V, embedded SDIO WLAN device with an
external IRQ line, and power-controlled by a GPIO-based fixed
Ohad Ben-Cohen wrote:
Make this go away:
drivers/mmc/host/omap_hsmmc.c: In function 'omap_hsmmc_suspend':
drivers/mmc/host/omap_hsmmc.c:2328: warning: unused variable 'state'
Was done a while ago.
See 1a13f8fa76c880be41d6b1e6a2b44404bcbfdf9e in linus' tree.
Signed-off-by: Ohad Ben-Cohen
Ohad Ben-Cohen wrote:
Prepare for mmc3 regulator power control by splitting the power
control functions of mmc2 and mmc3, and expecting mmc3 to have
a single, dedicated, regulator support.
Why? Can't the controller be connected to an eMMC with 2 power
supplies? At a glance, it is not obvious
On Wed, Aug 11, 2010 at 12:55 PM, Adrian Hunter adrian.hun...@nokia.com wrote:
Ohad Ben-Cohen wrote:
Make this go away:
drivers/mmc/host/omap_hsmmc.c: In function 'omap_hsmmc_suspend':
drivers/mmc/host/omap_hsmmc.c:2328: warning: unused variable 'state'
Was done a while ago.
Are you sure
Ohad Ben-Cohen wrote:
On Wed, Aug 11, 2010 at 12:55 PM, Adrian Hunter adrian.hun...@nokia.com wrote:
Ohad Ben-Cohen wrote:
Make this go away:
drivers/mmc/host/omap_hsmmc.c: In function 'omap_hsmmc_suspend':
drivers/mmc/host/omap_hsmmc.c:2328: warning: unused variable 'state'
Was done a while
On 08/11/2010 01:05 PM, Hunter Adrian (Nokia-MS/Helsinki) wrote:
Ohad Ben-Cohen wrote:
Prepare for mmc3 regulator power control by splitting the power
control functions of mmc2 and mmc3, and expecting mmc3 to have
a single, dedicated, regulator support.
Why? Can't the controller be connected
On Wed, Aug 11, 2010 at 1:52 PM, Roger Quadros roger.quad...@nokia.com wrote:
On 08/11/2010 01:05 PM, Hunter Adrian (Nokia-MS/Helsinki) wrote:
Ohad Ben-Cohen wrote:
Prepare for mmc3 regulator power control by splitting the power
control functions of mmc2 and mmc3, and expecting mmc3 to have
SDIO function drivers should be able to power down/up
their cards (e.g. a WLAN SDIO driver might want to
power down its card whenever wlan0 is down).
In the past few weeks we've been discussing how this
could be achieved, and I'd like to present a new approach,
which is based on runtime pm API.
On resume, let mmc_sdio_init_card go all the way, instead
of skipping the reconfiguration of the card's speed and width.
This is needed to ensure cards wake up with their clock
reconfigured (otherwise it's kept low).
This patch also removes the explicit bus width reconfiguration
on resume, since
Add a power_restore handler to the SDIO bus ops,
in order to support waking up SDIO cards that
were powered off by runtime pm.
Note: this approach would also require changing
the power_restore/save bus handlers to support
a return value.
Signed-off-by: Ohad Ben-Cohen o...@wizery.com
---
Add Runtime PM handlers to mmc, which calls mmc_power_save_host
and mmc_power_restore_host in respond to runtime_suspend and
runtime_resume events.
Runtime PM is still disabled by default, so this patch alone
has no immediate effect.
Signed-off-by: Ohad Ben-Cohen o...@wizery.com
---
Add generic Runtime PM handlers to sdio.
When a runtime pm event kicks in, those handlers call the
runtime pm handlers of the relevant SDIO function drivers.
Runtime PM is still disabled by default, so this patch alone
has no immediate effect.
Signed-off-by: Ohad Ben-Cohen o...@wizery.com
---
Before adding SDIO functions, indicate to the runtime pm core
the card is active, and enable runtime pm.
The power will be released automatically if the card
will be idle.
Signed-off-by: Ohad Ben-Cohen o...@wizery.com
---
drivers/mmc/core/sdio.c |4
1 files changed, 4 insertions(+), 0
Enable runtime pm for the wl1271 SDIO device.
We request power whenever the WLAN interface is brought up,
and release it after the WLAN interface is taken down.
As a result, power is released immediately after probe returns,
since at that point power has not been explicitly requested yet
(i.e.
On Wed, Aug 11, 2010 at 12:01 PM, Roger Quadros roger.quad...@nokia.com wrote:
Also shouldn't .nonremovable be set to true? as this is a non-removable card
slot.
This doesn't seem to have any effect on SDIO, but it can't hurt.
Thanks!
regards,
-roger
--
To unsubscribe from this list:
On Wed, Aug 11, 2010 at 11:37 AM, Roger Quadros roger.quad...@nokia.com wrote:
+ .ocr_mask = MMC_VDD_165_195,
Do we really need to specify ocr_mask here?
Removed, thanks!
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body of a message to
On Wed, Aug 11, 2010 at 1:05 PM, Adrian Hunter adrian.hun...@nokia.com wrote:
Ohad Ben-Cohen wrote:
Prepare for mmc3 regulator power control by splitting the power
control functions of mmc2 and mmc3, and expecting mmc3 to have
a single, dedicated, regulator support.
Why? Can't the
2010/8/11 a...@linux-foundation.org:
From: Grazvydas Ignotas nota...@gmail.com
There are some chips (like TI WL12xx series) that can be interfaced over
SDIO but don't support the SDIO specification, meaning that they are
missing CIA (Common I/O Area) with all it's registers. Current Linux
This patch series adds native support for wl1271 on ZOOM.
Changes since v3:
- slot is marked nonremovable
- no explicit slot ocr mask
- dont split hsmmc mmc23 power control
Patches are based on linux-next (as of Aug 7th), and tested
on ZOOM2.
Please note that I am going to have a very limited
Dynamically create and register a platform driver, that will
be used to to receive board-specific information like irq and
reference clock numbers.
The driver is created dynamically in order to avoid the 1-device
limitation of a fixed platform driver name.
Signed-off-by: Ohad Ben-Cohen
Move wl12xx.h outside of the spi-specific location,
so it can be shared with both spi and sdio solutions.
Signed-off-by: Ohad Ben-Cohen o...@wizery.com
---
drivers/net/wireless/wl12xx/wl1251_sdio.c |2 +-
drivers/net/wireless/wl12xx/wl1251_spi.c |2 +-
Make it possible for the set power method to indicate a
success/failure return value. This is needed to support
more complex power on/off operations such as bringing up
(and down) sdio functions.
Signed-off-by: Ohad Ben-Cohen o...@wizery.com
---
drivers/net/wireless/wl12xx/wl1271.h |2
Remove the hard coded irq information, and instead take
the irq information from the board's platform data.
Signed-off-by: Ohad Ben-Cohen o...@wizery.com
---
drivers/net/wireless/wl12xx/wl1271_sdio.c | 18 +-
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git
The wl1271 device is using a reference clock that may change
between board to board.
Make the ref_clock parameter configurable by the board
files that set up the device, instead of having a hard coded
value in the driver source itself.
Signed-off-by: Ohad Ben-Cohen o...@wizery.com
---
Add a fixed regulator vmmc device to enable power control
of the wl1271 wlan device.
Signed-off-by: Ohad Ben-Cohen o...@wizery.com
---
arch/arm/mach-omap2/board-zoom-peripherals.c | 35 ++
1 files changed, 35 insertions(+), 0 deletions(-)
diff --git
Add MMC3 support on ZOOM, which has the wl1271 device hardwired to.
The wl1271 is a 4-wire, 1.8V, embedded SDIO WLAN device with an
external IRQ line, and power-controlled by a GPIO-based fixed regulator.
Signed-off-by: Ohad Ben-Cohen o...@wizery.com
---
Ohad,
-Original Message-
From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-
ow...@vger.kernel.org] On Behalf Of Ohad Ben-Cohen
Sent: Wednesday, August 11, 2010 11:52 PM
To: linux-wirel...@vger.kernel.org; linux-mmc@vger.kernel.org; linux-
o...@vger.kernel.org
Cc: Ido Yariv;
-Original Message-
From: Felipe Balbi [mailto:felipe.ba...@nokia.com]
Sent: Thursday, August 12, 2010 12:18 AM
To: DebBarma, Tarun Kanti
Cc: Ohad Ben-Cohen; linux-wirel...@vger.kernel.org; linux-
m...@vger.kernel.org; linux-o...@vger.kernel.org; Ido Yariv; Mark Brown;
Hi,
On Wed, Aug 11, 2010 at 08:52:54PM +0200, ext DebBarma, Tarun Kanti wrote:
True; however if we go by that argument than we can also assume pdata
is valid, so that we would not need the below check.
of course not. You can have devices that just play well with default
values or devices
Ohad,
On Wed, Aug 11, 2010 at 9:08 PM, Ohad Ben-Cohen o...@wizery.com wrote:
On Wed, Aug 11, 2010 at 11:37 AM, Roger Quadros roger.quad...@nokia.com
wrote:
+ .ocr_mask = MMC_VDD_165_195,
Do we really need to specify ocr_mask here?
Since you specified the voltage source
From: Adrian Hunter adrian.hun...@nokia.com
Enable MMC to service discard requests. In the case of SD and MMC cards
that do not support trim, discards become erases. In the case of cards
(MMC) that only allow erases in multiples of erase group size, round to
the nearest completely discarded
From: Adrian Hunter adrian.hun...@nokia.com
SD/MMC cards tend to support an erase operation. In addition, eMMC v4.4
cards can support secure erase, trim and secure trim operations that are
all variants of the basic erase command.
SD/MMC device attributes erase_size and preferred_erase_size have
On Thu, Aug 12, 2010 at 12:22:54AM +0530, DebBarma, Tarun Kanti wrote:
True; however if we go by that argument than we can also assume pdata
is valid, so that we would not need the below check.
If pdev was ever NULL in a probe function, the kernel deserves to OOPS
so that you have a backtrace
Hi Ohad,
On Wed, Aug 11, 2010 at 10:10 PM, Ohad Ben-Cohen o...@wizery.com wrote:
Think of several wl1271 devices, each of which is represented by two
devices; an SDIO function, and a platform device. The SDIO function
stands for a specific MMC controller the device is hardwired to, and
the
Hi Vitaly,
On Thu, Aug 12, 2010 at 12:34 AM, Vitaly Wool vitalyw...@gmail.com wrote:
On Wed, Aug 11, 2010 at 10:10 PM, Ohad Ben-Cohen o...@wizery.com wrote:
Think of several wl1271 devices, each of which is represented by two
devices; an SDIO function, and a platform device. The SDIO function
On Wed, Aug 11, 2010 at 9:35 PM, DebBarma, Tarun Kanti
tarun.ka...@ti.com wrote:
- wl-if_ops-power(wl, true);
- set_bit(WL1271_FLAG_GPIO_POWER, wl-flags);
+ int ret = wl-if_ops-power(wl, true);
Just a minor comment, need a blank line here?
Can't hurt, thanks.
+ if (ret ==
Hi,
On Wed, Aug 11, 2010 at 10:10:38PM +0200, ext Ohad Ben-Cohen wrote:
Think of several wl1271 devices, each of which is represented by two
devices; an SDIO function, and a platform device. The SDIO function
stands for a specific MMC controller the device is hardwired to, and
the platform
39 matches
Mail list logo
