Re: my custom SDIO card can be detected in 2.6.30 but not in 2.6.18

2010-09-05 Thread hong zhang
Because 2.6.14 is the latest in PXA320 package. Do you know what command can display version of SDIO wifi device? --- On Sat, 9/4/10, Nicolas Pitre wrote: > From: Nicolas Pitre > Subject: Re: my custom SDIO card can be detected in 2.6.30 but not in 2.6.18 > To: "hong zhang" > Cc: linux-mmc@vge

[PATCH v5] mmc: Make ID freq configurable

2010-09-05 Thread Hein_Tibosch
Matt, Chris, Thanks both for reviewing. I never noticed that the host wasn't released because my f_min was low enough so that all frequencies would be tried. But yes, you're both right. Before somebody else makes the remark: "unsigned freqs[]" can be declared as const. Below, I changed the orde

Re: [PATCH 3/3] MMC/SD: add callback function to detect card

2010-09-05 Thread Matt Fleming
On Tue, Aug 31, 2010 at 10:57:25PM +0300, Adrian Hunter wrote: > > But now I think it should be in the mmc_rescan() function > because that is where the main other use of .get_cd() > is, and also the only call of .detect(). That's a very good point. Aren't we duplicating the code in mmc_rescan()

Re: [PATCH v4] mmc: Make ID freq configurable

2010-09-05 Thread Matt Fleming
On Sun, Sep 05, 2010 at 09:43:36PM +0100, Chris Ball wrote: > > Actually, mmc_attach_{sd,mmc}() both do release the host as part of > their failure case, so I don't think there's a problem with these two. Ah, yep you're right, I missed that. -- To unsubscribe from this list: send the line "unsubs

Re: [PATCH v4] mmc: Make ID freq configurable

2010-09-05 Thread Chris Ball
Hi Matt, On Sun, Sep 05, 2010 at 09:14:48PM +0100, Matt Fleming wrote: > On Fri, Sep 03, 2010 at 05:34:53AM +0800, Hein_Tibosch wrote: > > In the latest releases of the mmc driver, the freq during initialization > > is set to a fixed 400 Khz. This was reportedly too fast for several > > users. As

Re: + arm-samsung-mmc-fix-build-error-when-both-dma-and-pio-mode-selected.patch added to -mm tree

2010-09-05 Thread Matt Fleming
On Fri, Aug 27, 2010 at 09:23:47PM +0100, Matt Fleming wrote: > Best get Ben's opinion on this (now Cc'd). OK, it's been over a week and Ben hasn't replied. This fixes a build error so shouldn't wait any longer. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of

Re: [PATCH v4] mmc: Make ID freq configurable

2010-09-05 Thread Matt Fleming
On Fri, Sep 03, 2010 at 05:34:53AM +0800, Hein_Tibosch wrote: > In the latest releases of the mmc driver, the freq during initialization > is set to a fixed 400 Khz. This was reportedly too fast for several > users. As there doesn't seem to be an ideal frequency which-works-for-all, > Pierre sugges

Re: [PATCH v2] tmio_mmc: Allow 2 byte requests in 4-bit mode

2010-09-05 Thread Matt Fleming
On Mon, Aug 30, 2010 at 11:50:19AM +0100, Matt Fleming wrote: > From: Yusuke Goda > > Adjust the tmio_mmc block size check to accept 2-byte requests in 4-bit > mode if the hardware supports it. > > Tested with the SDHI hardware block included in sh7724. Ian, have you had a chance to test this y

Re: [PATCH] MMC: move regulator handling closer to core v2

2010-09-05 Thread Linus Walleij
2010/9/4 Adrian Hunter : > One of our contractors had a look at the patch and had this comment: > > One comment/question: > /host/mmci.c in function > "static int __devexit mmci_remove(struct amba_device *dev)" there is code: >        if (regulator_is_enabled(host->vcc)) >            regulator_dis

[PATCH] MMC: move regulator handling closer to core v3

2010-09-05 Thread Linus Walleij
After discovering a problem in regulator reference counting I took Mark Brown's advice to move the reference count into the MMC core by making the regulator status a member of struct mmc_host. I took this opportunity to also implement NULL versions of the regulator functions so as to rid the drive

Re: [PATCH] MMC: move regulator handling closer to core v2

2010-09-05 Thread Mark Brown
On Fri, Sep 03, 2010 at 09:38:45PM +0200, Linus Walleij wrote: > This has an Reveiwed-by from the regulator maintainer and > seems to address all comments, noone is objection so Andrew > can you pick it up? Just to clarify, I'm only one of the regulator maintainers - Liam also maintains the regul