Re: [PATCH] sdhci: allow for eMMC 74 clock generation by controller

2010-09-21 Thread Adrian Hunter
On 21/09/10 08:43, ext Philip Rakity wrote: Wolfram, I generated the patch for eMMC 74 clocks. I do not know if you want to incorporate into your submission or let it stand on its own. Wouldn't it be better to fix it in MMC core rather than duplicate it in every driver? regards,

Re: [PATCH] sdhci: allow for eMMC 74 clock generation by controller

2010-09-21 Thread Wolfram Sang
Hi Philip, I generated the patch for eMMC 74 clocks. I do not know if you want to incorporate into your submission or let it stand on its own. I won't pick it up as I am missing the technical details for this issue. I only jumped in because adding quirk bits should be handled very carefully

Re: [PATCH v2 3/4] omap4 hsmmc: Register offset handling

2010-09-21 Thread kishore kadiyala
Hi Benoit, On Tue, Sep 21, 2010 at 2:26 AM, Cousson, Benoit b-cous...@ti.com wrote: Hi Kishore On 9/18/2010 6:34 PM, Kadiyala, Kishore wrote: The offset handling implementation of omap4 mmc registers which was already present can't be reused once hwmod modifications are done for mmc

Re: [PATCH] add support PXA168/PXA910/MMP2 SD Host Controller

2010-09-21 Thread zhangfei gao
On Mon, Sep 20, 2010 at 9:10 AM, Wolfram Sang w.s...@pengutronix.de wrote: On Mon, Sep 20, 2010 at 08:09:26AM -0400, zhangfei gao wrote: On Mon, Sep 20, 2010 at 5:50 AM, Wolfram Sang w.s...@pengutronix.de wrote: On Mon, Sep 20, 2010 at 05:46:02PM +0800, zhangfei gao wrote: diff --git

Re: [PATCH] mmc: add SDHCI driver for STM platforms (V2)

2010-09-21 Thread Peppe CAVALLARO
On 09/20/2010 10:38 AM, Wolfram Sang wrote: On Mon, Sep 20, 2010 at 10:20:17AM +0200, Giuseppe CAVALLARO wrote: This patch adds the Arasan MMC/SD/SDIO driver for the STM ST40 platforms. It is based on the SDHCI driver. It has been tested on the STx7106/STx7108/STx5289 platforms.

Re: [PATCH] add support PXA168/PXA910/MMP2 SD Host Controller

2010-09-21 Thread claud yu
Hi , I had worked with MMP2 platform several weeks. The mmc/sdio interface have constraint about transfer size. The transfer size must be 8-byte alignment. If any transfer size is 4 byte alignment and not 8-byte alignment. This peripheral ip can't support(miss dma end interrupt or bad

Re: [PATCH] mmc: add SDHCI driver for STM platforms (V2)

2010-09-21 Thread Wolfram Sang
On Tue, Sep 21, 2010 at 11:21:48AM +0200, Peppe CAVALLARO wrote: On 09/20/2010 10:38 AM, Wolfram Sang wrote: On Mon, Sep 20, 2010 at 10:20:17AM +0200, Giuseppe CAVALLARO wrote: This patch adds the Arasan MMC/SD/SDIO driver for the STM ST40 platforms. It is based on the SDHCI driver. It

Re: [PATCH] add support PXA168/PXA910/MMP2 SD Host Controller

2010-09-21 Thread Wolfram Sang
diff --git a/drivers/mmc/host/sdhci-pxa.c b/drivers/mmc/host/sdhci-pxa.c new file mode 100644 index 000..3e091c1 --- /dev/null +++ b/drivers/mmc/host/sdhci-pxa.c @@ -0,0 +1,253 @@ +/* linux/drivers/mmc/host/sdhci-pxa.c + * + * Copyright 2010 Marvell + *      

Re: [RFC] Mobile Storage Host support

2010-09-21 Thread Kyungmin Park
Are there anyone who interest in Mobile Storage Host? On Fri, Sep 17, 2010 at 1:45 PM, Kyungmin Park kmp...@infradead.org wrote: Hi, Now we implemented the mobile storage and want to posting it to mmc. But during code review I know that it's almost similar with sdhci core except register

[PATCH 1/4] mmc: sdhci-pltfm: Add structure for host-specific data

2010-09-21 Thread Wolfram Sang
We need to carry some information per host, e.g. the clock. Add a structure for it and initialize it in the generic part. Signed-off-by: Wolfram Sang w.s...@pengutronix.de --- drivers/mmc/host/sdhci-pltfm.c |7 +-- drivers/mmc/host/sdhci-pltfm.h |5 + 2 files changed, 10

[PATCH 2/4] mmc: sdhci-pltfm: move .h-file into apropriate subdir

2010-09-21 Thread Wolfram Sang
Make use of the mmc-directory. Signed-off-by: Wolfram Sang w.s...@pengutronix.de --- drivers/mmc/host/sdhci-cns3xxx.c |2 +- drivers/mmc/host/sdhci-pltfm.c |2 +- drivers/mmc/host/sdhci-pltfm.h |2 +- include/linux/mmc/sdhci-pltfm.h | 35 +++

[PATCH 4/4] mmc: sdhci-pltfm: add pltfm-driver for imx35/51

2010-09-21 Thread Wolfram Sang
This driver adds basic support for the esdhc-core found on e.g. imx35/51. It adds up to the pltfm-core. Signed-off-by: Wolfram Sang w.s...@pengutronix.de --- drivers/mmc/host/Kconfig |9 +++ drivers/mmc/host/Makefile |1 + drivers/mmc/host/sdhci-esdhc.c | 141

[RFC] sdhci_pltfm: pass platform_data on custom init-call

2010-09-21 Thread Wolfram Sang
The custom init call may need more data to perform its job, so we pass it a pointer to the platform_data, too. Now, for drivers extending sdhci-pltfm (like sdhci-cns3xxx), a fixed platform_data is used according to the platform device id. Because that one does not contain board specific

Re: [PATCH 2/4] mmc: sdhci-pltfm: move .h-file into apropriate subdir

2010-09-21 Thread Anton Vorontsov
On Tue, Sep 21, 2010 at 02:30:08PM +0200, Wolfram Sang wrote: Make use of the mmc-directory. Signed-off-by: Wolfram Sang w.s...@pengutronix.de Acked-by: Anton Vorontsov cbouatmai...@gmail.com -- Anton Vorontsov email: cbouatmai...@gmail.com irc://irc.freenode.net/bd2 -- To unsubscribe from

Re: [PATCH 4/4] mmc: sdhci-pltfm: add pltfm-driver for imx35/51

2010-09-21 Thread Anton Vorontsov
On Tue, Sep 21, 2010 at 02:30:10PM +0200, Wolfram Sang wrote: This driver adds basic support for the esdhc-core found on e.g. imx35/51. It adds up to the pltfm-core. Signed-off-by: Wolfram Sang w.s...@pengutronix.de --- drivers/mmc/host/Kconfig |9 +++ drivers/mmc/host/Makefile

Re: [PATCH 1/4] mmc: sdhci-pltfm: Add structure for host-specific data

2010-09-21 Thread Anton Vorontsov
On Tue, Sep 21, 2010 at 02:30:07PM +0200, Wolfram Sang wrote: We need to carry some information per host, e.g. the clock. Add a structure for it and initialize it in the generic part. Signed-off-by: Wolfram Sang w.s...@pengutronix.de --- [...] diff --git a/drivers/mmc/host/sdhci-pltfm.h

Re: [PATCH] OMAP4: HSMMC cmd line reset change

2010-09-21 Thread Tony Lindgren
* Madhusudhan madhu...@ti.com [100920 09:06]: Please don't use cpu_is_omap tests in the drivers, drivers should be generic. Instead, just pass a feature flag in the platform_data for this feature like HSMMC_REVERSE_RESET_LOGIC or similar. This is not a feature. It is like

Re: [PATCH] add support PXA168/PXA910/MMP2 SD Host Controller

2010-09-21 Thread Chris Ball
Hi Wolfram, On Tue, Sep 21, 2010 at 12:11:16PM +0200, Wolfram Sang wrote: I guess to fully understand all constraints, one must really working with your platform, what I don't do. I agree that a nicely working driver is better than no driver; however, I fear once a driver hit the mainline

Re: [PATCH] sdhci: allow for eMMC 74 clock generation by controller

2010-09-21 Thread Wolfram Sang
On Tue, Sep 21, 2010 at 08:06:20AM -0700, Philip Rakity wrote: Our hardware needs to be programmed to handle this case. The host-ops option is only needed from h/w that does not handle this. If you can suggest a way to do this in the mmc layer I would welcome implementing it. I

Re: [PATCH] add support PXA168/PXA910/MMP2 SD Host Controller

2010-09-21 Thread Chris Ball
Hi, On Mon, Sep 20, 2010 at 11:16:18PM -0400, zhangfei gao wrote: We have considered using the same driver with dove once saeed push the driver, but at last we decide to use seperate driver to easy maintaince and further extension. There are different IP developed by different group between