Re: [RFC] sdhci_pltfm: pass platform_data on custom init-call

2010-09-27 Thread Peppe CAVALLARO
On 09/27/2010 04:47 AM, zhangfei gao wrote: On Tue, Sep 21, 2010 at 8:56 PM, Wolfram Sang w.s...@pengutronix.de wrote: The custom init call may need more data to perform its job, so we pass it a pointer to the platform_data, too. Now, for drivers extending sdhci-pltfm (like

RE: [PATCH] sdhci-s3c: fix NULL ptr access in sdhci_s3c_remove

2010-09-27 Thread Marek Szyprowski
Hello, On Sunday, September 26, 2010 12:53 AM Chris Ball wrote: On Thu, Sep 23, 2010 at 12:08:03PM -0700, Andrew Morton wrote: The patch applies OK to 2.6.35. Is the bug present there as well? If so, should we fix it in earlier kernels? If so then the way in which we indicate this is

Re: [PATCH v4 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-09-27 Thread kishore kadiyala
Hi Tony, On Sat, Sep 25, 2010 at 6:08 AM, Tony Lindgren t...@atomide.com wrote: * kishore kadiyala kishore.kadiy...@ti.com [100924 10:05]: Adding card detect callback function and card detect configuration function for MMC1 Controller on OMAP4. Card detect configuration function does initial

Re: [PATCH v4 1/4] omap4 hsmmc: Adding card detect support for MMC1

2010-09-27 Thread kishore kadiyala
Cc: Samuel Ortiz sa...@linux.intel.com On Fri, Sep 24, 2010 at 10:43 PM, kishore kadiyala kishore.kadiy...@ti.com wrote: Adding card detect callback function and card detect configuration function for MMC1 Controller on OMAP4. Card detect configuration function does initial configuration of

[PATCH V2 0/2] MMC removable helper function

2010-09-27 Thread Matt Fleming
Chris, I've rebased this mmc_assume_removable patch series against mmc-next and fixed up the compilation breakage with allmodconfig. Note, I've left your Signed-off-by on Jaehoon's patch because you modified the patch slightly (and because it's going through your tree anyway). I hope that's OK.

[PATCH V2 2/2] mmc: sdhci: disable MMC_CAP_NEEDS_POLL in nonremovable case

2010-09-27 Thread Matt Fleming
From: Jaehoon Chung jh80.ch...@samsung.com When a controller requires SDHCI_QUIRK_BROKEN_CARD_DETECTION, we poll for card insertion/removal, and that creates interrupts. There's no need to be doing this if we have a non-removable card. This patch requires cards to be removable before we're

[PATCH V2 1/2] mmc: Add helper function to check if a card is removable

2010-09-27 Thread Matt Fleming
There are two checks that need to be made when determining whether a card is removable. A host controller may set MMC_CAP_NONREMOVABLE if the controller does not support removing cards (e.g. eMMC), in which case the card is physically non-removable. Also the 'mmc_assume_removable' module parameter

Re: [PATCH 2/2] sdhci: disable MMC_CAP_NEEDS_POLL in nonremovable case

2010-09-27 Thread Matt Fleming
On Sun, Sep 26, 2010 at 03:31:22PM +0800, zhangfei gao wrote: On Thu, Sep 16, 2010 at 5:02 PM, Matt Fleming m...@console-pimps.org wrote: On Thu, Sep 16, 2010 at 03:20:08AM +0100, Chris Ball wrote: Hi Matt, On Wed, Sep 15, 2010 at 09:38:55PM +0100, Chris Ball wrote: On Wed, Sep 15,

Re: [PATCH V2 1/2] mmc: Add helper function to check if a card is removable

2010-09-27 Thread Wolfram Sang
On Mon, Sep 27, 2010 at 09:42:19AM +0100, Matt Fleming wrote: There are two checks that need to be made when determining whether a card is removable. A host controller may set MMC_CAP_NONREMOVABLE if the controller does not support removing cards (e.g. eMMC), in which case the card is

Re: [PATCH V2 2/2] mmc: sdhci: disable MMC_CAP_NEEDS_POLL in nonremovable case

2010-09-27 Thread Wolfram Sang
On Mon, Sep 27, 2010 at 09:42:20AM +0100, Matt Fleming wrote: From: Jaehoon Chung jh80.ch...@samsung.com When a controller requires SDHCI_QUIRK_BROKEN_CARD_DETECTION, we poll for card insertion/removal, and that creates interrupts. There's no need to be doing this if we have a non-removable

Re: [PATCH (mmc-next) 1/3] mmc: add suspend/resume in the sdhci-pltfm driver

2010-09-27 Thread Wolfram Sang
On Thu, Sep 23, 2010 at 11:14:24AM +0200, Giuseppe CAVALLARO wrote: Signed-off-by: Giuseppe Cavallaro peppe.cavall...@st.com I'd prefer it the way sdhci-mv.c is doing it (just one #if-block and returning the code from the sdhci_*-functions). Then it should be fine. ---

Re: [PATCH (mmc-next) 2/3] mmc: split the sdhci.h to help platforms that uses shdci-pltfm d.d.

2010-09-27 Thread Wolfram Sang
On Thu, Sep 23, 2010 at 11:14:25AM +0200, Giuseppe CAVALLARO wrote: Some platforms based on the shdci-pltfm device driver need to set own quirks (that currently are in drivers/mmc/host/sdhci.h). This patch splits this header file in two parts: o drivers/mmc/host/sdhci.h it includes

Re: [PATCH (mmc-next) 3/3] mmc: fix a warning when compile the sdhci d.d.

2010-09-27 Thread Wolfram Sang
On Thu, Sep 23, 2010 at 11:14:26AM +0200, Giuseppe CAVALLARO wrote: This patch fixes a warning when compile the sdhci: pwr may be used uninitialized in sdhci_set_power Also removes some include files that live in sdhci.h header file. Signed-off-by: Giuseppe Cavallaro

Re: [PATCH (mmc-next) 3/3] mmc: fix a warning when compile the sdhci d.d.

2010-09-27 Thread Peppe CAVALLARO
Hi Wolfram, On 09/27/2010 12:54 PM, Wolfram Sang wrote: On Thu, Sep 23, 2010 at 11:14:26AM +0200, Giuseppe CAVALLARO wrote: This patch fixes a warning when compile the sdhci: pwr may be used uninitialized in sdhci_set_power Also removes some include files that live in sdhci.h header file.

Re: [PATCH (mmc-next) 2/3] mmc: split the sdhci.h to help platforms that uses shdci-pltfm d.d.

2010-09-27 Thread Peppe CAVALLARO
Hi Wolfram, On 09/27/2010 12:43 PM, Wolfram Sang wrote: On Thu, Sep 23, 2010 at 11:14:25AM +0200, Giuseppe CAVALLARO wrote: Some platforms based on the shdci-pltfm device driver need to set own quirks (that currently are in drivers/mmc/host/sdhci.h). This patch splits this header file in two

Re: [PATCH (mmc-next) 1/3] mmc: add suspend/resume in the sdhci-pltfm driver

2010-09-27 Thread Peppe CAVALLARO
On 09/27/2010 12:37 PM, Wolfram Sang wrote: On Thu, Sep 23, 2010 at 11:14:24AM +0200, Giuseppe CAVALLARO wrote: Signed-off-by: Giuseppe Cavallaro peppe.cavall...@st.com I'd prefer it the way sdhci-mv.c is doing it (just one #if-block and returning the code from the sdhci_*-functions). Then

Re: [PATCH (mmc-next) 1/3] mmc: add suspend/resume in the sdhci-pltfm driver

2010-09-27 Thread Peppe CAVALLARO
On 09/27/2010 02:57 PM, Peppe CAVALLARO wrote: On 09/27/2010 12:37 PM, Wolfram Sang wrote: On Thu, Sep 23, 2010 at 11:14:24AM +0200, Giuseppe CAVALLARO wrote: Signed-off-by: Giuseppe Cavallaro peppe.cavall...@st.com I'd prefer it the way sdhci-mv.c is doing it (just one #if-block and

Re: [PATCH (mmc-next) 2/3] mmc: split the sdhci.h to help platforms that uses shdci-pltfm d.d.

2010-09-27 Thread Wolfram Sang
On Mon, Sep 27, 2010 at 02:57:50PM +0200, Peppe CAVALLARO wrote: Hi Wolfram, On 09/27/2010 12:43 PM, Wolfram Sang wrote: On Thu, Sep 23, 2010 at 11:14:25AM +0200, Giuseppe CAVALLARO wrote: Some platforms based on the shdci-pltfm device driver need to set own quirks (that currently are in

Re: [PATCH (mmc-next) 1/3] mmc: add suspend/resume in the sdhci-pltfm driver

2010-09-27 Thread Wolfram Sang
On Mon, Sep 27, 2010 at 03:24:02PM +0200, Peppe CAVALLARO wrote: On 09/27/2010 02:57 PM, Peppe CAVALLARO wrote: On 09/27/2010 12:37 PM, Wolfram Sang wrote: On Thu, Sep 23, 2010 at 11:14:24AM +0200, Giuseppe CAVALLARO wrote: Signed-off-by: Giuseppe Cavallaro peppe.cavall...@st.com

Re: [PATCH (mmc-next) 3/3] mmc: fix a warning when compile the sdhci d.d.

2010-09-27 Thread Wolfram Sang
should detect that BUG never returns). The include-removal could be in a seperate patch, not sure if it is worth, though. It can include in a separate patch. It makes sense if apply the previous patch to split the header file because we remove duplicated include files. I understand, but

Re: [PATCH (mmc-next) 2/3] mmc: split the sdhci.h to help platforms that uses shdci-pltfm d.d.

2010-09-27 Thread Peppe CAVALLARO
On 09/27/2010 04:13 PM, Wolfram Sang wrote: On Mon, Sep 27, 2010 at 02:57:50PM +0200, Peppe CAVALLARO wrote: OK for the host-struct. What about the io-accessors? Do we really need them? Hi Wolfram. Hmm, it's not necessary to move them, indeed. They can stay in the original header if you

Re: [PATCH (mmc-next) 2/3] mmc: split the sdhci.h to help platforms that uses shdci-pltfm d.d.

2010-09-27 Thread Wolfram Sang
Hmm, it's not necessary to move them, indeed. They can stay in the original header if you prefer. No issues on my side at all. Let me know so I'll rework the patch and send it again. You should know that yourself by now ;) -- Pengutronix e.K. | Wolfram Sang

Re: [PATCH V2 1/2] mmc: Add helper function to check if a card is removable

2010-09-27 Thread Chris Ball
Hi Matt, On Mon, Sep 27, 2010 at 09:42:19AM +0100, Matt Fleming wrote: There are two checks that need to be made when determining whether a card is removable. A host controller may set MMC_CAP_NONREMOVABLE if the controller does not support removing cards (e.g. eMMC), in which case the card

Re: [patch] sdhci: correct f_min in sd 3.0

2010-09-27 Thread Chris Ball
Hi Zhangfei, On Sat, Sep 25, 2010 at 12:23:33AM -0400, zhangfei gao wrote: From: Zhangfei Gao zhangfei@marvell.com Date: Mon, 20 Sep 2010 15:15:18 -0400 Subject: [PATCH] sdhci: correct f_min in sd 3.0 Signed-off-by: Zhangfei Gao zhangfei@marvell.com --- drivers/mmc/host/sdhci.c |

RE: [PATCH v2 2/2] sdhci-s3c: Add support no internal clock divider in host controller

2010-09-27 Thread Jeongbae Seo
Ben Dooks worte: On 17/09/10 10:45, Kukjin Kim wrote: From: Hyuk Lee hyuk1@samsung.com This patch adds to support no internal clock divider in SDHCI. The external clock divider can be used to make a proper clock because SDHCI doesn't support internal clock divider by itself.

Re: [patch] mmc: fix init f_min

2010-09-27 Thread Hein_Tibosch
On 28-9-2010 11:34, zhangfei gao wrote: Just curious how to get 40, which is slowest speed for initializaion, is this OK for all card? Hi Zhangfei, It looks as if you missed another thread about f_min recently? See: https://patchwork.kernel.org/patch/177932/ This was in response to

RE: [PATCH v2 2/2] sdhci-s3c: Add support no internal clock divider in host controller

2010-09-27 Thread Kukjin Kim
Jeongbae Seo wrote: Ben Dooks worte: On 17/09/10 10:45, Kukjin Kim wrote: From: Hyuk Lee hyuk1@samsung.com This patch adds to support no internal clock divider in SDHCI. The external clock divider can be used to make a proper clock because SDHCI doesn't support internal

Re: [RFC RESEND] sdhci-s3c: support clock enable/disable (clock-gating)

2010-09-27 Thread Jaehoon Chung
Jae hoon Chung wrote: 2010/9/17 Matt Fleming m...@console-pimps.org: On Thu, Sep 16, 2010 at 03:46:50PM +0900, Jaehoon Chung wrote: Hi all, This is a RFC patch that support clock-gating for saving power consumption. I found mmc_host_enable/mmc_host_disable function in core.c (using

Re: [PATCH] sdhci-s3c: support non-standard clock setting for c210

2010-09-27 Thread Kyungmin Park
To Ben, Maybe you missing this patch. It's the jaehoon's approach. Thank you, Kyungmin Park 2010/8/31 Jaehoon Chung jh80.ch...@samsung.com: This is sdhci-s3c patch for c210. c210 didn't use divider of host controller. Host Controller need other clock setting methods. So I add the callback