Re: [PATCH] mmc_rescan: reduce verbosity

2010-10-11 Thread Wolfram Sang
On Mon, Oct 11, 2010 at 11:00:30PM -0400, Nicolas Pitre wrote: > On Tue, 12 Oct 2010, Chris Ball wrote: > > > Hi, > > > > On Mon, Oct 11, 2010 at 09:50:46PM -0400, Nicolas Pitre wrote: > > > On Mon, 11 Oct 2010, Eric Bénard wrote: > > > > since commit 820f2bcfdc32cd90061224c930cf670f961e12d1 mmc_

RE: [PATCH v5 2/2] sdhci-s3c: Add support no internal clock divider in host controller

2010-10-11 Thread Kukjin Kim
Chris Ball wrote: > > Hi Kyungmin, > > On Tue, Oct 12, 2010 at 11:53:35AM +0900, Kyungmin Park wrote: > > Hi Chris, > > > > we make a conclusion use this patch. Can you merge it for 2.6.37? > > > > Acked-by: Kyungmin Park > > I don't feel that I can, because Ben Dooks is listed as the maintaine

Re: [PATCH] mmc_rescan: reduce verbosity

2010-10-11 Thread Nicolas Pitre
On Tue, 12 Oct 2010, Chris Ball wrote: > Hi, > > On Mon, Oct 11, 2010 at 09:50:46PM -0400, Nicolas Pitre wrote: > > On Mon, 11 Oct 2010, Eric Bénard wrote: > > > since commit 820f2bcfdc32cd90061224c930cf670f961e12d1 mmc_rescan > > > includes a pr_info which prints 4 lines each second for hosts co

Re: [PATCH v5 2/2] sdhci-s3c: Add support no internal clock divider in host controller

2010-10-11 Thread Chris Ball
Hi Kyungmin, On Tue, Oct 12, 2010 at 11:53:35AM +0900, Kyungmin Park wrote: > Hi Chris, > > we make a conclusion use this patch. Can you merge it for 2.6.37? > > Acked-by: Kyungmin Park I don't feel that I can, because Ben Dooks is listed as the maintainer for this driver and the patch does no

Re: [PATCH v5 2/2] sdhci-s3c: Add support no internal clock divider in host controller

2010-10-11 Thread Kyungmin Park
Hi Chris, we make a conclusion use this patch. Can you merge it for 2.6.37? Acked-by: Kyungmin Park On Mon, Oct 11, 2010 at 4:50 PM, Kukjin Kim wrote: > From: Jeongbae Seo > > This patch adds to support no internal clock divider in SDHCI. > The external clock divider can be used to make a pro

Re: [PATCH] mmc_rescan: reduce verbosity

2010-10-11 Thread Chris Ball
Hi, On Mon, Oct 11, 2010 at 09:50:46PM -0400, Nicolas Pitre wrote: > On Mon, 11 Oct 2010, Eric Bénard wrote: > > since commit 820f2bcfdc32cd90061224c930cf670f961e12d1 mmc_rescan > > includes a pr_info which prints 4 lines each second for hosts configured > > with MMC_CAP_NEEDS_POLL. Tested on i.MX

Re: [PATCH] mmc_rescan: reduce verbosity

2010-10-11 Thread Nicolas Pitre
On Mon, 11 Oct 2010, Eric Bénard wrote: > since commit 820f2bcfdc32cd90061224c930cf670f961e12d1 mmc_rescan > includes a pr_info which prints 4 lines each second for hosts configured > with MMC_CAP_NEEDS_POLL. Tested on i.MX51's sdhci-esdhc. > This patch increase log level to debug (but maybe the r

Re: [PATCH] mmc: Add "ignore mmc pm notify" functionality

2010-10-11 Thread Nicolas Pitre
On Mon, 11 Oct 2010, Dmitry Shmidt wrote: > Hi Nicolas, > > Because for example some sdio device (like wlan) can be powered after > suspend (we are not talking about desktop or laptop) > and be a source of wakeup. And we don't want to remove it every time we are > going to suspend. See MMC_PM_KE

Re: [PATCH] mmc: Add "ignore mmc pm notify" functionality

2010-10-11 Thread Nicolas Pitre
On Mon, 11 Oct 2010, Dmitry Shmidt wrote: > Hi, > > While working with "permanent" mmc/sdio devices we may want to skip new > suspend/resume functionality. Why ?? > > commit 4c40080bb1d4f68000b7a4c397c1bc8a623668fa > Author: Dmitry Shmidt > Date: Mon Oct 11 11:28:54 2010 -0700 > > m

[PATCH] mmc_rescan: reduce verbosity

2010-10-11 Thread Eric Bénard
since commit 820f2bcfdc32cd90061224c930cf670f961e12d1 mmc_rescan includes a pr_info which prints 4 lines each second for hosts configured with MMC_CAP_NEEDS_POLL. Tested on i.MX51's sdhci-esdhc. This patch increase log level to debug (but maybe the right solution would be to remove this log). Sign

[PATCH] mmc: Add "ignore mmc pm notify" functionality

2010-10-11 Thread Dmitry Shmidt
Hi, While working with "permanent" mmc/sdio devices we may want to skip new suspend/resume functionality. commit 4c40080bb1d4f68000b7a4c397c1bc8a623668fa Author: Dmitry Shmidt Date: Mon Oct 11 11:28:54 2010 -0700 mmc: Add "ignore mmc pm notify" functionality Signed-off-by: Dmitr

Re: [PATCH v2 5/6] mmc: sdhci-of-esdhc: factor out common stuff

2010-10-11 Thread Chris Ball
Hi Wolfram, On Mon, Oct 11, 2010 at 07:10:32PM +0200, Wolfram Sang wrote: > +static inline void esdhc_set_clock(struct sdhci_host *host, unsigned int > clock) > +{ > + int pre_div = 2; > + int div = 1; > + u32 temp; > + > + temp = sdhci_readl(host, ESDHC_SYSTEM_CONTROL); > + t

[PATCH v2 5/6] mmc: sdhci-of-esdhc: factor out common stuff

2010-10-11 Thread Wolfram Sang
Put everything which can be shared between the OF and platform version of this driver into a local .h-file. Signed-off-by: Wolfram Sang Tested-by : Eric Bénard --- 80 char/line fixed. Untested as of now, can only test tomorrow again. Should be safe changes, though (famous last words again ;)))

Re: [PATCH 0/6] SD/MMC driver for MX25/35/51

2010-10-11 Thread Chris Ball
Hi Wolfram, On Mon, Oct 11, 2010 at 06:44:59PM +0200, Wolfram Sang wrote: > > Mind fixing up the >80 char lines in the last two patches? It's just: > > Sigh, I don't think it will help the readability of the code, but if it can't > be helped... Okay. Perhaps as a compromise, just reflow the tw

Re: [PATCH 0/6] SD/MMC driver for MX25/35/51

2010-10-11 Thread Wolfram Sang
> > Wolfram Sang (6): > > mmc: sdhci-pltfm: Add structure for host-specific data > > mmc: sdhci-pltfm: move .h-file into apropriate subdir > > mmc: sdhci: introduce private get_ro > > mmc: sdhci_pltfm: pass more data on custom init-call > > mmc: sdhci-of-esdhc: factor out common stuff >

Re: [PATCH 0/6] SD/MMC driver for MX25/35/51

2010-10-11 Thread Chris Ball
Hi Wolfram, On Mon, Oct 11, 2010 at 04:21:00PM +0200, Wolfram Sang wrote: > Wolfram Sang (6): > mmc: sdhci-pltfm: Add structure for host-specific data > mmc: sdhci-pltfm: move .h-file into apropriate subdir > mmc: sdhci: introduce private get_ro > mmc: sdhci_pltfm: pass more data on custom

[PATCH 4/6] mmc: sdhci_pltfm: pass more data on custom init-call

2010-10-11 Thread Wolfram Sang
The custom init call may need more data to perform its job, so we pass it a pointer to pdata, too. Also, always use the platform_id specific data even if platform_data is present. Doing that, platform_data can additionally be parsed by init() for board-specific information (via sdhci->mmc->parent).

[PATCH 5/6] mmc: sdhci-of-esdhc: factor out common stuff

2010-10-11 Thread Wolfram Sang
Put everything which can be shared between the OF and platform version of this driver into a local .h-file. Signed-off-by: Wolfram Sang Tested-by : Eric Bénard --- drivers/mmc/host/sdhci-esdhc.h| 81 + drivers/mmc/host/sdhci-of-esdhc.c | 70 --

[PATCH 6/6] mmc: sdhci-pltfm: add pltfm-driver for imx35/51

2010-10-11 Thread Wolfram Sang
This driver adds basic support for the esdhc-core found on e.g. imx35/51. It adds up to the pltfm-core. Signed-off-by: Wolfram Sang Acked-by: Anton Vorontsov Tested-by : Eric Bénard --- Changes since last version: * use PTR_ERR if clk_get failed drivers/mmc/host/Kconfig | 10 +++

[PATCH 1/6] mmc: sdhci-pltfm: Add structure for host-specific data

2010-10-11 Thread Wolfram Sang
We need to carry some information per host, e.g. the clock. Add a structure for it and initialize it in the generic part. Also improve the check for a parent. Signed-off-by: Wolfram Sang Cc: Richard Röjfors --- Changes since last version: * Improved detection of a "real" parent device driver

[PATCH 2/6] mmc: sdhci-pltfm: move .h-file into apropriate subdir

2010-10-11 Thread Wolfram Sang
Make use of the mmc-directory. Signed-off-by: Wolfram Sang Acked-by: Anton Vorontsov Tested-by : Eric Bénard --- drivers/mmc/host/sdhci-cns3xxx.c |2 +- drivers/mmc/host/sdhci-pltfm.c |2 +- drivers/mmc/host/sdhci-pltfm.h |2 +- include/linux/mmc/sdhci-pltfm.h | 35 +

[PATCH 3/6] mmc: sdhci: introduce private get_ro

2010-10-11 Thread Wolfram Sang
Some controllers handle their write-protection differently. Introduce a callback to be able to handle it, ensuring the same locking takes place for it. Signed-off-by: Wolfram Sang Tested-by : Eric Bénard --- drivers/mmc/host/sdhci.c | 11 +++ drivers/mmc/host/sdhci.h |1 + 2 files

[PATCH 0/6] SD/MMC driver for MX25/35/51

2010-10-11 Thread Wolfram Sang
Here is the hopefully final (famous last words) version of my patch series. The first four are still updates/improvements for sdhci and sdhci-pltfm and are of generic interest, too. Thanks to Eric for the tests on MX25/35. Looking forward to comments/applied-to-mmc-next-messages ;) The series is b

Re: [PATCH 4/6] mmc: sdhci_pltfm: pass more data on custom init-call

2010-10-11 Thread Wolfram Sang
On Thu, Sep 30, 2010 at 01:42:02PM +0400, Anton Vorontsov wrote: > On Thu, Sep 30, 2010 at 10:31:58AM +0200, Lothar Waßmann wrote: > > > The custom init call may need more data to perform its job, so we pass > > > it a pointer to pdata, too. Also, always use the platform_id specific > > > data even

[PATCH 0/1] MMC DDR support

2010-10-11 Thread Adrian Hunter
Hi Here is a tweak to MMC DDR support. It applies to the mmc-next branch of Chris Ball's mmc tree at: git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc.git Adrian Hunter (1): mmc: refine DDR support drivers/mmc/core/core.c |7 --- drivers/mmc/core/core.h |3 ++-

[PATCH 1/1] mmc: refine DDR support

2010-10-11 Thread Adrian Hunter
>From f92528a3ebbff6e3f73fc2cb0d197ece9180324e Mon Sep 17 00:00:00 2001 From: Adrian Hunter Date: Mon, 11 Oct 2010 12:30:25 +0300 Subject: [PATCH] mmc: refine DDR support One flaw with DDR support is that MMC core does not inform the driver which DDR mode it has selected. This patch expands the

Re: 2.6.35.6 fails to suspend (pxa2xx-mci.0)

2010-10-11 Thread Sven Neumann
On Mon, 2010-10-11 at 10:45 +0200, Ohad Ben-Cohen wrote: > On Mon, Oct 11, 2010 at 10:31 AM, Sven Neumann wrote: > > On Sat, 2010-10-09 at 03:07 +0200, Ohad Ben-Cohen wrote: > >> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c > >> index c94565d..515ff39 100644 > >> --- a/drivers/mm

Re: 2.6.35.6 fails to suspend (pxa2xx-mci.0)

2010-10-11 Thread Ohad Ben-Cohen
On Mon, Oct 11, 2010 at 10:31 AM, Sven Neumann wrote: > On Sat, 2010-10-09 at 03:07 +0200, Ohad Ben-Cohen wrote: >> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c >> index c94565d..515ff39 100644 >> --- a/drivers/mmc/core/core.c >> +++ b/drivers/mmc/core/core.c >> @@ -1682,6 +1682,

Re: 2.6.35.6 fails to suspend (pxa2xx-mci.0)

2010-10-11 Thread Sven Neumann
On Sat, 2010-10-09 at 03:07 +0200, Ohad Ben-Cohen wrote: > On Fri, Oct 8, 2010 at 10:08 PM, Rafael J. Wysocki wrote: > > There is a problem with the pxa2xx-mci.0 suspend that has been introduced > > some time after 2.6.34, but it is not related to commit 152e1d5920. > > Sven, what type of card do

Re: 2.6.35.6 fails to suspend (pxa2xx-mci.0)

2010-10-11 Thread Sven Neumann
On Fri, 2010-10-08 at 22:08 +0200, Rafael J. Wysocki wrote: > On Friday, October 08, 2010, Sven Neumann wrote: > > On Thu, 2010-10-07 at 23:23 +0200, Rafael J. Wysocki wrote: > > > > > > > I wonder what happens if you echo 0 to /sys/power/pm_async ? > > > > > > > > Nothing happens. The problem pe

[PATCH v5 2/2] sdhci-s3c: Add support no internal clock divider in host controller

2010-10-11 Thread Kukjin Kim
From: Jeongbae Seo This patch adds to support no internal clock divider in SDHCI. The external clock divider can be used to make a proper clock because SDHCI doesn't support internal clock divider by itself. If external clock divider type is selected, some functions related with clock control wi