[PATCH] SDHCI: Properly enable SDIO IRQ wakeups

2010-11-04 Thread Daniel Drake
A little more work was needed for SDIO IRQ wakeups to be functional. Wake-on-WLAN on the SD WiFi adapter in the XO-1.5 laptop is now working. Signed-off-by: Daniel Drake --- drivers/mmc/host/sdhci-pci.c | 11 +-- drivers/mmc/host/sdhci.c | 10 ++ drivers/mmc/host/sdhci.h

Re: [PATCH] mmc: agressive clocking framework v9

2010-11-04 Thread Ohad Ben-Cohen
On Thu, Nov 4, 2010 at 10:25 AM, Linus Walleij wrote: > Since the runtime_pm_get/put calls are balanced for the host > enable/disable case and the clock gating is orthogonal, > I need to create an orthogonal instance of hooks, maybe it's > easiest to just spawn a second dummy device like mmc0_clk

Re: [PATCH] mmc: agressive clocking framework v9

2010-11-04 Thread Nicolas Pitre
On Thu, 4 Nov 2010, Linus Walleij wrote: > David Vrabel wrote: > > Linus Walleij wrote: > >> @@ -148,14 +148,19 @@ static int mmc_runtime_suspend(struct device *dev) > >> { > >>struct mmc_card *card = mmc_dev_to_card(dev); > >> > >> + mmc_gate_clock(card->host); > >>return mmc_power_sa

Re: [PATCH] mmc: agressive clocking framework v9

2010-11-04 Thread Linus Walleij
David Vrabel wrote: > Linus Walleij wrote: >> @@ -148,14 +148,19 @@ static int mmc_runtime_suspend(struct device *dev) >> { >> struct mmc_card *card = mmc_dev_to_card(dev); >> >> +mmc_gate_clock(card->host); >> return mmc_power_save_host(card->host); >> } > > Haven't you tied the

Re: [PATCH] mmc: agressive clocking framework v9

2010-11-04 Thread David Vrabel
Linus Walleij wrote: > > Switch to grouping this with the runtime PM stuff as Alan > suggested. Is this looking better? > [...] > diff --git a/drivers/mmc/core/bus.c b/drivers/mmc/core/bus.c > index af8dc6a..9064def 100644 > --- a/drivers/mmc/core/bus.c > +++ b/drivers/mmc/core/bus.c > @@ -148,14

[PATCH] mmc: agressive clocking framework v9

2010-11-04 Thread Linus Walleij
This patch modifies the MMC core code to optionally call the set_ios() operation on the driver with the clock frequency set to 0 (gate) after a grace period of at least 8 MCLK cycles, then restore it (ungate) before any new request. This gives the driver the option to shut down the MCI clock to the

Re: [PATCH] mmc: Return proper error code for ushc_probe()

2010-11-04 Thread David Vrabel
On 04/11/2010 05:59, Axel Lin wrote: > Signed-off-by: Axel Lin Thanks. Acked-by: David Vrabel Chris, queue this one up for 2.6.37 please. David -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: commit 'mmc: sdhci: add MMC_CAP_8_BIT_DATA in the host capabilities' breaks ricoh mmc device

2010-11-04 Thread Kyungmin Park
Hi, I got the same problem. diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 782c0ee..a0991ad 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -1849,7 +1849,7 @@ int sdhci_add_host(struct sdhci_host *host) mmc->caps |= MMC_CAP_SDIO_IRQ;