Re: [PATCH 0/5 v2] MMC: DMA for SH MMCIF

2010-11-24 Thread Paul Mundt
On Wed, Nov 24, 2010 at 11:05:08AM +0100, Guennadi Liakhovetski wrote: > This patch series slightly cleans up the sh_mmcif MMC driver and adds a > DMA capability to it. One of the patches is not directly related, but is > required for a proper DMA functionality. V2 limits the number of request >

RE: [PATCH] sdhci: Kconfig: MMC_SDHCI_PXA: CPU_MMP2 no need IO_ACCESSORS

2010-11-24 Thread Philip Rakity
Need io accressors for pxa168 otherwise need to touch sdhci.c for returning certain register values. From: zhangfei gao [zhangfei@gmail.com] Sent: Wednesday, November 24, 2010 9:31 PM To: Philip Rakity Cc: linux-mmc; Mark Brown Subject: Re: [PATCH] sdh

[GIT PULL] MMC fixes for 2.6.37-rc4

2010-11-24 Thread Chris Ball
Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc.git for-linus to fix two regressions in -rc1 (SDIO devices and <8-bit MMC cards), two longstanding bugs (rmmod race, enable SDIO IRQ wakeups), and some small device support bugs. These have been tested in linux-nex

Re: [PATCH] sdhci: Kconfig: MMC_SDHCI_PXA: CPU_MMP2 no need IO_ACCESSORS

2010-11-24 Thread zhangfei gao
On Wed, Nov 24, 2010 at 4:30 PM, Philip Rakity wrote: > Resend as plain text > > From 5ffe0546fb3d70dd97af178e474fbcdfa64ea4e8 Mon Sep 17 00:00:00 2001 > From: Philip Rakity > Date: Wed, 24 Nov 2010 13:25:47 -0800 > Subject: [PATCH] sdhci: Kconfig: MMC_SDHCI_PXA: CPU_MMP2 no need IO_ACCESSORS > >

Re: [PATCH 1/2] mmc: Add support for JMicron 388 SD/MMC controller

2010-11-24 Thread Wolfram Sang
On Wed, Nov 24, 2010 at 12:29:57PM +0100, Takashi Iwai wrote: > At Wed, 24 Nov 2010 10:59:35 +0100, > Wolfram Sang wrote: > > > > On Wed, Nov 24, 2010 at 07:21:13AM +0100, Takashi Iwai wrote: > > > > > +/* Controller doesn't support VDD 180 for MMC (for SD/MMC combo chips) */ > > > +#define SDHCI

[PATCH] sdhci: Kconfig: MMC_SDHCI_PXA: CPU_MMP2 no need IO_ACCESSORS

2010-11-24 Thread Philip Rakity
Resend as plain text >From 5ffe0546fb3d70dd97af178e474fbcdfa64ea4e8 Mon Sep 17 00:00:00 2001 From: Philip Rakity Date: Wed, 24 Nov 2010 13:25:47 -0800 Subject: [PATCH] sdhci: Kconfig: MMC_SDHCI_PXA: CPU_MMP2 no need IO_ACCESSORS read and write to MMP2 controller in sdhci-pxa does not use IO_ACCE

[PATCH] sdhci: Kconfig: MMC_SDHCI_PXA: CPU_MMP2 no need IO_ACCESSORS

2010-11-24 Thread Philip Rakity
>From 5ffe0546fb3d70dd97af178e474fbcdfa64ea4e8 Mon Sep 17 00:00:00 2001 From: Philip Rakity Date: Wed, 24 Nov 2010 13:25:47 -0800 Subject: [PATCH] sdhci: Kconfig: MMC_SDHCI_PXA: CPU_MMP2 no need IO_ACCESSORS read and write to MMP2 controller in sdhci-pxa does not use IO_ACCESSORS. MMP2 hardware

Re: [RFC] sdhci: 8 bit bus width changes

2010-11-24 Thread Chris Ball
Hi Philip, On Sun, Nov 21, 2010 at 11:17:09AM -0800, Philip Rakity wrote: > a) QUIRK removed for 8 bit support since platform issue - not quirk > b) platform Flag defined for sdhci-pxa.c and plat-pxa > c) comments added to sdhci.c on usage Thanks very much, I'll plan on sending this to Linus tomo

Re: [PATCH 1/2] mmc: agressive clocking framework v8

2010-11-24 Thread Chris Ball
On Wed, Nov 24, 2010 at 02:15:57PM +0100, Linus Walleij wrote: > > [   10.136067] mmc0: frequency set to 0 in disable function, this means the > > clock is already disabled. > > It didn't use to be like that back when I first wrote the patch, but > it seems to be like > that nowadays. So yes. Hm

Re: [PATCH 1/2] mmc: agressive clocking framework v8

2010-11-24 Thread Linus Walleij
2010/11/23 Chris Ball : > [   10.136067] mmc0: frequency set to 0 in disable function, this means the > clock is already disabled. > [   10.164089] mmc0: frequency set to 0 in disable function, this means the > clock is already disabled. > [   10.192076] mmc0: frequency set to 0 in disable funct

Re: [PATCH 1/2] mmc: Add support for JMicron 388 SD/MMC controller

2010-11-24 Thread Takashi Iwai
At Wed, 24 Nov 2010 10:59:35 +0100, Wolfram Sang wrote: > > On Wed, Nov 24, 2010 at 07:21:13AM +0100, Takashi Iwai wrote: > > > +/* Controller doesn't support VDD 180 for MMC (for SD/MMC combo chips) */ > > +#define SDHCI_QUIRK_MMC_VDD_180(1<<30) > > Can't we handle t

[PATCH 5/5 v2] ARM: mach-shmobile: enable MMCIF DMA on ap4evb

2010-11-24 Thread Guennadi Liakhovetski
Have to add DMA slave configuration to enable DMA for the sh7372 MMCIF controller. Signed-off-by: Guennadi Liakhovetski --- v2: no change arch/arm/mach-shmobile/board-ap4evb.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-shmobile/board-ap4evb

[PATCH 3/5 v2] mmc: sh_mmcif: cosmetic clean up

2010-11-24 Thread Guennadi Liakhovetski
Replace pr_* with respective dev_*, sort headers alphabetically, remove an unused struct member, superfluous variable initialisations and type-casts. Signed-off-by: Guennadi Liakhovetski --- v2: no change drivers/mmc/host/sh_mmcif.c | 63 -- 1 files ch

[PATCH 1/5 v2] mmc: sh_mmcif: switch to completion, fix flags

2010-11-24 Thread Guennadi Liakhovetski
In sh_mmcif.c an event is used as a completion, switch over. When a wait_for_completion*_timeout() returns, it suffices to check the remaining time, setting an additional flag before waking up the waiting task only reduces the race window, but does not eliminate it. This patch switches the driver t

[PATCH 4/5 v2] mmc: sh_mmcif: add DMA support

2010-11-24 Thread Guennadi Liakhovetski
The MMCIF controller on sh-mobile platforms can use the DMA controller for data transfers. Interface to the SH dmaengine driver to enable DMA. We also have to lower the maximum number of segments to match with the number od DMA descriptors on SuperH, this doesn't significantly affect driver's PIO p

[PATCH 0/5 v2] MMC: DMA for SH MMCIF

2010-11-24 Thread Guennadi Liakhovetski
This patch series slightly cleans up the sh_mmcif MMC driver and adds a DMA capability to it. One of the patches is not directly related, but is required for a proper DMA functionality. V2 limits the number of request segments, instead of raising the number of DMA descriptors in shdma.c. This d

[PATCH 2/5 v2] ARM: mach-shmobile: add DMA defines for MMCIF on sh7372

2010-11-24 Thread Guennadi Liakhovetski
Add DMA slave IDs and slave definitions for MMCIF on sh7372. Signed-off-by: Guennadi Liakhovetski --- v2: no change arch/arm/mach-shmobile/include/mach/sh7372.h |2 ++ arch/arm/mach-shmobile/setup-sh7372.c| 10 ++ 2 files changed, 12 insertions(+), 0 deletions(-) diff --

Re: [PATCH 1/2] mmc: Add support for JMicron 388 SD/MMC controller

2010-11-24 Thread Wolfram Sang
On Wed, Nov 24, 2010 at 07:21:13AM +0100, Takashi Iwai wrote: > +/* Controller doesn't support VDD 180 for MMC (for SD/MMC combo chips) */ > +#define SDHCI_QUIRK_MMC_VDD_180 (1<<30) Can't we handle this more generic? Like setting ocr_avail_* from sdhci-pci.c somehow (

Re: [RFC] sdhc-pxa : mmp2 : Send 74 clocks when device powers up

2010-11-24 Thread zhangfei gao
On Wed, Nov 24, 2010 at 9:02 AM, Philip Rakity wrote: > Resent -- now plain text > > MMC spec calls for the host to send 74 clocks to the card > during initialization, right after voltage stabilization. > the mmp2 controller does not start the clock when the clock > is enabled but does provide a w

RE: [PATCH v1 0/4]mmc: enable eMMC4.41 new feature background operations and HPI

2010-11-24 Thread Dong, Chuanxiao
> > Basic question. Do you have any performance gain or improvement? > In my test environment. no performance gain. Yes I know it's not for > performance improvement. My understanding: If BKOPS feature is not enabled, the background operations will be started when card handles some read or write

Re: [PATCH v1 0/4]mmc: enable eMMC4.41 new feature background operations and HPI

2010-11-24 Thread Kyungmin Park
Hi, Basic question. Do you have any performance gain or improvement? In my test environment. no performance gain. Yes I know it's not for performance improvement. How to measure or check it has some improvement? Any ideas? Thank you, Kyungmin Park On Tue, Nov 23, 2010 at 5:43 PM, Chuanxiao Dong