Re: [PATCH 2/2] mmc: Test bus-width for old MMC devices

2010-12-04 Thread Chris Ball
Hi Takashi, Philip, On Wed, Nov 24, 2010 at 07:21:14AM +0100, Takashi Iwai wrote: > From: Aries Lee > > Some old MMC devices fail with the 4/8 bits the driver tries to use > exclusively. This patch adds a test for the given bus setup and falls > back to the lower bit mode (until 1-bit mode) whe

Re: [PATCH 11/44] drivers/mmc: Remove unnecessary semicolons

2010-12-04 Thread Chris Ball
Hi Joe, On Sun, Nov 14, 2010 at 07:04:30PM -0800, Joe Perches wrote: > Signed-off-by: Joe Perches > --- > drivers/mmc/host/davinci_mmc.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c > index e15547c

Re: [PATCH v2 1/1]sdhci-pxa: support tune_timming for various cards

2010-12-04 Thread Chris Ball
Hi Zhangfei, On Thu, Nov 11, 2010 at 08:19:12AM -0500, zhangfei gao wrote: > Hi, Chirs & Eric > > Thanks for review, here is updated version. > 1. After clk_gating is enabled, set_clock will transfer clock=0, so > clk_disable will be called, currently set_clock will never transfer > clock=0. > La

Re: [PATCH 1/1]sdhci-pxa: add MMC_CAP_NONREMOVABLE for on-chip device

2010-12-04 Thread Chris Ball
Hi, On Thu, Oct 28, 2010 at 02:00:10AM -0400, zhangfei gao wrote: > Thanks for your suggestion, here is updated version. > > >From 470140b629e3f044a0951368db8e3dc98ebd8ab3 Mon Sep 17 00:00:00 2001 > From: Zhangfei Gao > Date: Thu, 28 Oct 2010 10:44:15 -0400 > Subject: [PATCH] sdhci-pxa: add MMC_

Re: [PATCH 4/4] [ARM] mxcmmc: remove a unnecessary release_resource() call

2010-12-04 Thread Chris Ball
Hi, On Thu, Nov 25, 2010 at 10:03:11AM +0100, Sascha Hauer wrote: > On Mon, Nov 22, 2010 at 04:47:51PM +0800, Axel Lin wrote: > > Remove release_resource() after release_mem_region(). > > > > Signed-off-by: Axel Lin > > Acked-by: Sascha Hauer > > > --- > > drivers/mmc/host/mxcmmc.c |1 -

Re: working around a Marvell wifi SDIO bug

2010-12-04 Thread Nicolas Pitre
On Sat, 4 Dec 2010, Daniel Drake wrote: > "According to a confidential Marvell AN, we should be asserting RESET > externally after powering up the WLAN card. The Linux driver should > assert WLAN_RESETn low for between 1 and 20 uS, about 1 mS after > turning on power to the card" > > While other

Re: [PATCH v3 2/3]set timeout control reg for such SDHCI host

2010-12-04 Thread Wolfram Sang
On Fri, Dec 03, 2010 at 10:38:59AM +0800, Dong, Chuanxiao wrote: > > > > On Thu, Dec 02, 2010 at 07:26:13PM +0800, Chuanxiao Dong wrote: > > > > > + if (host->quirks & SDHCI_QUIRK_FORCE_ERASE_SINGLE) { > > > + /* Set the timeout to be the maximum value */ > > > + if (cmd->erase_t

Re: [PATCH 1/3 ] mmc: add support for h/w clock gating of sd controller

2010-12-04 Thread Wolfram Sang
Hi, minor comments in addition to Nicolas: On Fri, Dec 03, 2010 at 11:26:50AM -0800, Philip Rakity wrote: > hardware clock gating is enabled by setting the mmc quirk It's not a quirk, it's a capability :) > MMC_CAP_CLOCK_GATING_HW Why not MMC_CAP_HW_CLOCK_GATING? Might be a mileage, though...

working around a Marvell wifi SDIO bug

2010-12-04 Thread Daniel Drake
Hi, The XO-1.5 laptop ships with an internal wifi adapter connected to the SDIO bus (on a sdhci-pci host). We were experiencing a problem where initialization of this card sometimes failed (on low-level SD stuff, like setting voltage or reading CCCR). Also, when runtime PM was enabled, the card c

Re: [PATCH] mmci: handle clock frequency 0 properly

2010-12-04 Thread Russell King - ARM Linux
On Tue, Nov 16, 2010 at 06:17:49PM +0100, Linus Walleij wrote: > This removes the default clocking for the MMCI controller so that > the external MCI card clock does not activate until the first > .set_ios() call is issued. It will further handle the transitions > from a clock != 0 to 0 and vice ve