Re: [PATCH] mmc/sdhci: Enable bus-width test for JMicron controllers

2010-12-16 Thread Chris Ball
Hi Takashi, On Thu, Dec 16, 2010 at 05:54:14PM +0100, Takashi Iwai wrote: > > Signed-off-by: Takashi Iwai > --- > > This is a patch to be applied after > "mmc: Test bus-width for old MMC devices (v2)" > > and a replacement for the previous "mmc: Enable bus-width tests on > SDHCI host" patch.

Re: [PATCH] mmc: Test bus-width for old MMC devices (v2)

2010-12-16 Thread Chris Ball
Hi Philip, On Thu, Dec 16, 2010 at 06:33:49PM -0800, Philip Rakity wrote: > It is not possible for bus_width to be not initialized. This would imply > ARRAY_SIZE(bus_widths) is 1. Certainly not true. Right, I agree. We should fix the warning anyway. > We could just initialize by changing > +

[patch] workaround of 1-bit mmc card in case cmd19 & cmd 14 not supported

2010-12-16 Thread zhangfei gao
If controller does not support cmd19 & cmd14, here is workaround we using. Send just in case somebody require. >From b95c5e8d1c5b42a149a521c4992dfd8fc8d61143 Mon Sep 17 00:00:00 2001 From: Zhangfei Gao Date: Thu, 16 Dec 2010 22:28:40 -0500 Subject: [PATCH] mmc: workaround of 1-bit mmc card

Re: [PATCH] mmc: Test bus-width for old MMC devices (v2)

2010-12-16 Thread Philip Rakity
Chris, It is not possible for bus_width to be not initialized. This would imply ARRAY_SIZE(bus_widths) is 1. Certainly not true. We could just initialize by changing + unsigned idx, bus_width; to + unsigned idx, bus_width = 0; I wonder what compiler are you using s

Re: [PATCH v4] mmc: Make ID freq configurable

2010-12-16 Thread Chris Ball
Hi MichaƂ, Sahitya, On Thu, Dec 02, 2010 at 11:38:12PM +0100, Michal Miroslaw wrote: > mmc: fix detection of memory part of SD-combo card with broken SDIO > > In case of failure, mmc_attach_sdio() will power off the SD bus. > Power it up and reinitialize before trying SD memory detection. > > Re

Re: [PATCH 3/3] mmc: sdio: don't power up cards on system suspend

2010-12-16 Thread Chris Ball
Hi Ohad, On Sun, Nov 28, 2010 at 07:21:30AM +0200, Ohad Ben-Cohen wrote: > Initial SDIO runtime PM implementation took a conservative approach > of powering up cards (and fully reinitializing them) on system suspend, > just before the suspend handlers of the relevant drivers were executed. > > To

Re: [PATCH 2/3] mmc: sdio: don't reinitialize nonremovable powered-resumed cards

2010-12-16 Thread Chris Ball
Hi Ohad, On Sun, Nov 28, 2010 at 07:21:29AM +0200, Ohad Ben-Cohen wrote: > Upon system resume, SDIO core must reinitialize cards that were > powered off during suspend. > > If the card had its power kept during suspend (and thus it > is 'powered-resumed'), SDIO core performs only a limited reinit

Re: [PATCH 1/3] mmc: skip detection of nonremovable cards on rescan

2010-12-16 Thread Chris Ball
Hi Ohad, On Sun, Nov 28, 2010 at 07:21:28AM +0200, Ohad Ben-Cohen wrote: > mmc_rescan checks whether registered cards are still present before > skipping them, by calling the bus-specific ->detect() handler. > > With buses that support runtime PM, the card may be powered off at > this point, so t

Re: [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver

2010-12-16 Thread Chris Ball
Hi Tony, On Tue, Nov 30, 2010 at 12:23:06PM +, David Vrabel wrote: > > Any interest in reviewing this USB-SD driver? I'm especially curious > > about whether you think there are worthwhile possibilities to share > > code with USHC. > > A quick look suggests that there is unlikely to be any

Re: [PATCH] mmc: Fix a typo in ocr_avail mask check for MMC

2010-12-16 Thread Chris Ball
Hi Takashi, On Wed, Dec 15, 2010 at 02:19:22PM +0100, Takashi Iwai wrote: > In the patch "mmc: Add support for JMicron 388 SD/MMC controller", > I changed a wrong field for MMC during rewrite. Fixed now. > > Signed-off-by: Takashi Iwai > --- > drivers/mmc/host/sdhci.c |2 +- > 1 files chan

Re: [PATCH] mmc: Test bus-width for old MMC devices (v2)

2010-12-16 Thread Chris Ball
Hi Takashi, On Wed, Dec 15, 2010 at 08:14:24AM +0100, Takashi Iwai wrote: > From: Aries Lee > > Some old MMC devices fail with the 4/8 bits the driver tries to use > exclusively. This patch adds a test for the given bus setup and falls > back to the lower bit mode (until 1-bit mode) when the te

[PATCH] mmc/sdhci: Enable bus-width test for JMicron controllers

2010-12-16 Thread Takashi Iwai
Signed-off-by: Takashi Iwai --- This is a patch to be applied after "mmc: Test bus-width for old MMC devices (v2)" and a replacement for the previous "mmc: Enable bus-width tests on SDHCI host" patch. Instead of enabling all for sdhci, this one turns on the feature only for JMicron, just to