Re: [PATCH] mmc: add MMC_QUIRK_BROKEN_CLK_GATING

2011-01-04 Thread Ohad Ben-Cohen
On Wed, Jan 5, 2011 at 1:52 AM, Linus Walleij wrote: > Do you have a candidate function driver to do this ...? wl1271. We don't use SDIO interrupts at all (the wl1271 has an external irq line), so we will surely use this. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in

Re: outstanding TMIO MMC patches

2011-01-04 Thread Paul Mundt
On Wed, Jan 05, 2011 at 11:10:18AM +0900, Magnus Damm wrote: > mmc: tmio_mmc: allow multi-element scatter-gather lists > mmc: tmio_mmc: fix PIO fallback on DMA descriptor allocation failure > [1/3] mmc: tmio: merge the private header into the driver > [2/3] mmc: tmio: implement a bounce buffer for

Re: mmc_test mmc0:0001: Can't create file. Perhaps debugfs is disabled

2011-01-04 Thread Chris Ball
Hi Viresh, On Wed, Jan 05, 2011 at 09:07:07AM +0530, viresh kumar wrote: > Actually i am bit new to LKML and i don't know if i should send the patch > again > with signed-off or simply send a signed-off: in a similar way as we send > Acked-by:. Please tell me if i need to resend patch. No need t

[PATCH] ARM: tegra: harmony: add sdhci devices

2011-01-04 Thread Olof Johansson
Add platform devices for SDIO{1,2,4} on harmony, which goes to wifi and the two card connectors on the board. SDIO4 (the non-bayonet connector) is wired for 8-bit cards, SDIO2 is not. Originally from: Signed-off-by: Colin Cross SDIO1 pieces from: Signed-off-by: Gary King Cleanup, move of GPIO

Re: mmc_test mmc0:0001: Can't create file. Perhaps debugfs is disabled

2011-01-04 Thread viresh kumar
On 01/04/2011 11:31 PM, Chris Ball wrote: > Thanks, I've reproduced this now. It's a bug. The reason I hadn't seen > it before is that my workflow is always to insert a card, then rmmod > mmc_block && modprobe mmc_test -- this works because the debugfs dir is > created late on the initial inserti

Re: eMMC sector/byte access mode validation

2011-01-04 Thread Philip Rakity
The patch was submitted because we did see the issue. On Jan 4, 2011, at 5:43 PM, Ethan Du wrote: > Hi: > > I have not seen case (1) and (2) across >20 types of micro SD > cards, and >10 types of Sandisk/Toshiba eMMC chips, so I believe the > 2GB condition is ok. > Probing of the OCR bit to

[PATCH] mmc: Support Mobile Storage controller Interface

2011-01-04 Thread Jaehoon Chung
This patch is Mobile Storage Controller interface. This controller is similar to SDHCI.(This patch is based on sdhci.c) I tried to use mobile storage with sdhci-controller, but bit controlling is too many different So need Mobile Storage controller. I tested only 8-bit buswidth. It's working well

Re: outstanding TMIO MMC patches

2011-01-04 Thread Magnus Damm
On Wed, Dec 29, 2010 at 8:32 AM, Guennadi Liakhovetski wrote: > Hi Ian > > There are a number of outstanding tmio-mmc patches from Arnd Hannemann and > myself, many of them posted weeks ago. We really would like to have them > in 2.6.38. Would you have time to process them? Otherwise, could someon

Re: [PATCH] mmc: sh_mmcif: make DMA support by the driver unconditional

2011-01-04 Thread Magnus Damm
On Wed, Dec 29, 2010 at 4:59 PM, Guennadi Liakhovetski wrote: > Simplify the driver by removing the possibility to build it without the DMA > support and remove the respective Kconfig parameter. > > Signed-off-by: Guennadi Liakhovetski Excellent, this helps against bitrot and makes kernel config

Re: eMMC sector/byte access mode validation

2011-01-04 Thread Ethan Du
Hi: I have not seen case (1) and (2) across >20 types of micro SD cards, and >10 types of Sandisk/Toshiba eMMC chips, so I believe the 2GB condition is ok. Probing of the OCR bit to chose between byte and sector mode will also work, which I have tried in a large scope. Regards, -Ethan On W

[PATCH] mmc: fix division by zero in MMC core

2011-01-04 Thread Linus Walleij
The card is not always clocked and the clock frequency zero is perfectly legal, thus this code in mmc_set_data_timeout() may cause a division by zero. It will be triggered more often if you're using software clock gating but can be triggered under other conditions too. Reported-by: Pierre Tardy S

Re: [PATCH] mmc: add MMC_QUIRK_BROKEN_CLK_GATING

2011-01-04 Thread Linus Walleij
2011/1/2 Pierre Tardy : > Some sdio card are not following sdio standard, and does not work > when the sdio bus's clock is gated Seem to me like it's pretty straight-forward and will work... Acked-by: Linus Walleij > diff --git a/drivers/mmc/core/sdio.c b/drivers/mmc/core/sdio.c > index 82f4b90

Re: [PATCH 4/4] mmc: add MMC_QUIRK_NONSTD_FUNC_IF

2011-01-04 Thread Ohad Ben-Cohen
On Wed, Jan 5, 2011 at 1:25 AM, Pierre Tardy wrote: > There is no such platform data in intel_mid platforms.. Sound like > another platform hack will be needed for wl1271 to be integrated. :-( John (cc'ed) ported this to your platform and can share the solution with you; IIRC the idea was the sam

Re: [PATCH 4/4] mmc: add MMC_QUIRK_NONSTD_FUNC_IF

2011-01-04 Thread Pierre Tardy
>  static struct omap2_hsmmc_info mmc[] __initdata = { >        { >                .name           = "external", > @@ -221,6 +233,7 @@ static struct omap2_hsmmc_info mmc[] __initdata = { >                .gpio_wp        = -EINVAL, >                .gpio_cd        = -EINVAL, >                .nonrem

Re: [PATCH 3/4] mmc: add MMC_QUIRK_DISABLE_CD

2011-01-04 Thread Ohad Ben-Cohen
On Wed, Jan 5, 2011 at 1:04 AM, David Vrabel wrote: > Could we unconditionally disable the card's internal pull-up? Good question. Empirically, I can say that we have done this with many types of boards and never encountered any issue. -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH 4/4] mmc: add MMC_QUIRK_NONSTD_FUNC_IF

2011-01-04 Thread Ohad Ben-Cohen
Hi Pierre, On Wed, Jan 5, 2011 at 12:48 AM, Pierre Tardy wrote: > This sounds good, and may solve this problem we have with wl1271. > Then, how do you tell the mmc stack the wl1271 has the quirk > MMC_QUIRK_NONSTD_FUNC_IF? Something like this: diff --git a/arch/arm/mach-omap2/board-zoom-periphe

Re: [PATCH 3/4] mmc: add MMC_QUIRK_DISABLE_CD

2011-01-04 Thread David Vrabel
On 04/01/2011 22:27, Ohad Ben-Cohen wrote: > On Wed, Jan 5, 2011 at 12:13 AM, Ohad Ben-Cohen wrote: >>> Whether this pull up should be >>> enabled or disabled is determined by the board (not the card). The >>> pull-up should be disabled if the board has a pull-up external to the >>> card, otherwi

Re: [PATCH 4/4] mmc: add MMC_QUIRK_NONSTD_FUNC_IF

2011-01-04 Thread Pierre Tardy
On Tue, Jan 4, 2011 at 10:10 PM, Ohad Ben-Cohen wrote: > Use MMC_QUIRK_NONSTD_FUNC_IF to ignore the "SDIO Standard Function interface > code" as indicated by the card's FBR, and instead treat all functions as > non-standard interfaces. Hi Ohad, This sounds good, and may solve this problem we have

Re: [PATCH 3/4] mmc: add MMC_QUIRK_DISABLE_CD

2011-01-04 Thread Ohad Ben-Cohen
On Wed, Jan 5, 2011 at 12:13 AM, Ohad Ben-Cohen wrote: >> Whether this pull up should be >> enabled or disabled is determined by the board (not the card).  The >> pull-up should be disabled if the board has a pull-up external to the >> card, otherwise it must remain enabled. > > Agree. It might m

Re: [PATCH 3/4] mmc: add MMC_QUIRK_DISABLE_CD

2011-01-04 Thread Ohad Ben-Cohen
On Wed, Jan 5, 2011 at 12:09 AM, David Vrabel wrote: > How are you intending to use this? diff --git a/arch/arm/mach-omap2/board-zoom-peripherals.c b/arch/arm/mach-omap2/board-zoom-peripherals.c index 9db9203..ae69ba9 100644 --- a/arch/arm/mach-omap2/board-zoom-peripherals.c +++ b/arch/arm/mach-o

Re: [PATCH 3/4] mmc: add MMC_QUIRK_DISABLE_CD

2011-01-04 Thread David Vrabel
On 04/01/2011 21:10, Ohad Ben-Cohen wrote: > 006ebd5d introduced sdio_disable_cd(), which disconnects the pull-up > resistor on CD/DAT[3] (pin 1) of the card. > > Make it possible to start using sdio_disable_cd() by introducing > MMC_QUIRK_DISABLE_CD. How are you intending to use this? Whether t

[PATCH 3/4] mmc: add MMC_QUIRK_DISABLE_CD

2011-01-04 Thread Ohad Ben-Cohen
006ebd5d introduced sdio_disable_cd(), which disconnects the pull-up resistor on CD/DAT[3] (pin 1) of the card. Make it possible to start using sdio_disable_cd() by introducing MMC_QUIRK_DISABLE_CD. Signed-off-by: Ohad Ben-Cohen --- drivers/mmc/core/sdio.c |2 +- include/linux/mmc/card.h |

[PATCH 4/4] mmc: add MMC_QUIRK_NONSTD_FUNC_IF

2011-01-04 Thread Ohad Ben-Cohen
Use MMC_QUIRK_NONSTD_FUNC_IF to ignore the "SDIO Standard Function interface code" as indicated by the card's FBR, and instead treat all functions as non-standard interfaces. This is required to prevent standard drivers (e.g. btsdio) from facing errors when trying to communicate with SDIO cards th

[PATCH 1/4] mmc: mmc_card_keep_power cleanups

2011-01-04 Thread Ohad Ben-Cohen
mmc_card_is_powered_resumed is a mouthful; instead, simply use mmc_card_keep_power, which also better reflects the meaning of the predicate. Employ mmc_card_keep_power() where possible. Signed-off-by: Ohad Ben-Cohen --- drivers/mmc/core/core.c |4 ++-- drivers/mmc/core/sdio.c | 10 +

[PATCH 2/4] mmc: do not switch to 1-bit mode if not required

2011-01-04 Thread Ohad Ben-Cohen
6b5eda36 followed SDIO spec part E1 section 8, which states that in case SDIO interrupts are being used to wake up a suspended host, then it is required to switch to 1-bit mode before stopping the clock. Before switching to 1-bit mode (or back to 4-bit mode on resume), make sure that SDIO interrup

Re: [PATCH] mmc: MMC_BLOCK_MINORS should depend on MMC_BLOCK.

2011-01-04 Thread Olof Johansson
On Tue, Jan 4, 2011 at 10:02 AM, Chris Ball wrote: > Signed-off-by: Chris Ball Acked-by: Olof Johansson -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-

[PATCH] mmc: MMC_BLOCK_MINORS should depend on MMC_BLOCK.

2011-01-04 Thread Chris Ball
Signed-off-by: Chris Ball --- drivers/mmc/card/Kconfig |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/mmc/card/Kconfig b/drivers/mmc/card/Kconfig index 57e4416..2a876c4 100644 --- a/drivers/mmc/card/Kconfig +++ b/drivers/mmc/card/Kconfig @@ -16,6 +16,7 @@ config

Re: mmc_test mmc0:0001: Can't create file. Perhaps debugfs is disabled

2011-01-04 Thread Chris Ball
Hi Viresh, On Wed, Dec 22, 2010 at 05:29:47PM +0530, viresh kumar wrote: > I am using mmc_test.c driver present in drivers/mmc/test.c > > Whenever i insert my card after booting linux i get this error: > "mmc_test mmc0:0001: Can't create file. Perhaps debugfs is disabled" > > I debugged a bit an

Re: [PATCH] Fix sd/sdio/mmc initialization frequency retries

2011-01-04 Thread Chris Ball
Hi, On Tue, Jan 04, 2011 at 01:29:02AM +, Chris Ball wrote: > Thanks! Pushed to mmc-next for .38, after adding Reviewed-by: tags and > removing the mmc_bus_{put,get}() comment, since I'll take care of that > separately. And here's the comment patch: From: Chris Ball Date: Tue, 4 Jan 2011 1

Re: eMMC sector/byte access mode validation

2011-01-04 Thread Sujit Reddy
Hi, Any comments on below mentioned query? Thanks Sujit On Thu, Dec 23, 2010 at 1:35 PM, Sujit Reddy wrote: > Hi, > > According to eMMC spec v4.3, Section 6.1 says that greater than 2GB > density cards are sector addressable and less than 2GB are byte addressable. > But Section 7.3.3 says that

Re: [PATCH 2/2] mmc: add sdhci-tegra driver for Tegra SoCs

2011-01-04 Thread Wolfram Sang
On Sat, Jan 01, 2011 at 04:28:46PM -0800, Olof Johansson wrote: > On Thu, Dec 23, 2010 at 3:23 AM, Wolfram Sang wrote: > > > >> Changes since v2: > >>       * Whitespace fixes > >>       * Changed order of test in get_ro > > > > What benefit has the reordering? (And just to make sure: You still >

Re: [PATCH 1/2] sdhci: add quirk for max len ADMA descriptors

2011-01-04 Thread Wolfram Sang
Hi Olof, happy new 2011, first of all. On Thu, Dec 23, 2010 at 10:26:16AM -0800, Olof Johansson wrote: > > I tend to NACK it (but I am not the maintainer). I'd prefer to see a > > draft of your idea of a sdhci_add_host_fixup()-function :) > > See, I tend to get annoyed when I get asked to clean

RE: [RFC] sdhci: use ios->clock to know when sdhci is idle

2011-01-04 Thread Dong, Chuanxiao
Hi Pierre, I have some concerns about this RFC. I agree with you that even if the Wifi interface is up, user might not use the network and host controller should be power gated. That also is the purport of runtime PM framework! But I think Wifi card driver can know whether user is using the netw