[PATCH 13/16] MMC: jz4740: don't treat NULL clk as an error

2011-01-11 Thread Jamie Iles
clk_get() returns a struct clk cookie to the driver and some platforms may return NULL if they only support a single clock. clk_get() has only failed if it returns a ERR_PTR() encoded pointer. Cc: linux-mmc@vger.kernel.org Signed-off-by: Jamie Iles ja...@jamieiles.com ---

[PATCH] MMCI: don't read command response when invalid

2011-01-11 Thread Russell King - ARM Linux
Don't read the command response from the registers when either the command timed out (because there was no response from the card) or the checksum on the response was invalid. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk --- drivers/mmc/host/mmci.c | 10 +- 1 file changed, 5

Re: [PATCH] MMCI: don't read command response when invalid

2011-01-11 Thread Chris Ball
Hi, On Tue, Jan 11, 2011 at 04:35:56PM +, Russell King - ARM Linux wrote: Don't read the command response from the registers when either the command timed out (because there was no response from the card) or the checksum on the response was invalid. Signed-off-by: Russell King

Re: [PATCH 13/16] MMC: jz4740: don't treat NULL clk as an error

2011-01-11 Thread Chris Ball
Hi Jamie, On Tue, Jan 11, 2011 at 12:43:50PM +, Jamie Iles wrote: clk_get() returns a struct clk cookie to the driver and some platforms may return NULL if they only support a single clock. clk_get() has only failed if it returns a ERR_PTR() encoded pointer. Cc:

[PATCH] sdhci-s3c: add platform_8bit_width()

2011-01-11 Thread Jaehoon Chung
This patch is added platform_8bit_width() function in sdhci-s3c. We has 8-bit width support but is not a v3 controller. So we need platform_8bit_width() to support 8-bit buswidth. Also we need MMC_CAP_8_BIT_DATA, so we added them in platdata. Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com

Re: [PATCH] sdhci-s3c: add platform_8bit_width()

2011-01-11 Thread Chris Ball
Hi Jaehoon, Looks fine, just style corrections: On Wed, Jan 12, 2011 at 09:30:41AM +0900, Jaehoon Chung wrote: This patch is added platform_8bit_width() function in sdhci-s3c. ^ adds We has 8-bit width support but is not a v3 controller. ^ have So we need

Re: [PATCH] sdhci-s3c: add platform_8bit_width()

2011-01-11 Thread Jaehoon Chung
Hi Chris. Thanks for your comments. So i fixed them, and resend the patch. We have 8-bit width support bu is not a v3 controller. So we need platform_8bit_width() to support 8-bit buswidth. Also we need MMC_CAP_8_BIT_DATA, so we add it in platdata. Signed-off-by: Jaehoon Chung

Re: [PATCH] sdhci-s3c: add platform_8bit_width()

2011-01-11 Thread Chris Ball
Hi Jaehoon, On Wed, Jan 12, 2011 at 11:59:12AM +0900, Jaehoon Chung wrote: Hi Chris. Thanks for your comments. So i fixed them, and resend the patch. Thanks! I've pushed it to mmc-next. We have 8-bit width support bu is not a v3 controller. So we need platform_8bit_width() to support

[PATCH] mmc: bfin_sdh: fix alloc size for private data

2011-01-11 Thread Mike Frysinger
From: Sonic Zhang sonic.zh...@analog.com The bfin_sdh driver allocates the wrong size for the private data in the mmc_host. The first parameter of mmc_alloc_host should be the size of the local driver struct rather than the common mmc_host. Signed-off-by: Sonic Zhang sonic.zh...@analog.com

Re: [PATCH] sdhci-s3c: add platform_8bit_width()

2011-01-11 Thread Kyungmin Park
On Wed, Jan 12, 2011 at 12:27 PM, Chris Ball c...@laptop.org wrote: Hi Jaehoon, On Wed, Jan 12, 2011 at 11:59:12AM +0900, Jaehoon Chung wrote: Hi Chris. Thanks for your comments. So i fixed them, and resend the patch. Thanks!  I've pushed it to mmc-next. We have 8-bit width support bu

Re: [PATCH] sdhci-s3c: add platform_8bit_width()

2011-01-11 Thread Chris Ball
On Wed, Jan 12, 2011 at 12:54:07PM +0900, Kyungmin Park wrote: Umm I think it's kind of bug fix since we used 8-bit buswidth previous code but recent change don't make it working So re-support the 8-bit buswidth. Can you merge it at 38.rc period? Okay, that should be fine. As always, though,