Re: [PATCH] mmc: clear all interrupt in suspend before free_irq

2011-01-23 Thread zhangfei gao
On Sun, Jan 23, 2011 at 9:17 PM, Philip Rakity wrote: > > I am confused.  Your patch modifiies > > sdhci_suspend_host () to +     sdhci_clear_set_irqs(host, SDHCI_INT_ALL_MASK, 0); >>> > > > > #define SDHCI_INT_ALL_MASK      ((unsigned int)-1) > > static void sdhci_clear_set_irqs(struct sdhci

Re: [PATCH] mmc: clear all interrupt in suspend before free_irq

2011-01-23 Thread Philip Rakity
I am confused. Your patch modifiies sdhci_suspend_host () to >>> + sdhci_clear_set_irqs(host, SDHCI_INT_ALL_MASK, 0); >> #define SDHCI_INT_ALL_MASK ((unsigned int)-1) static void sdhci_clear_set_irqs(struct sdhci_host *host, u32 clear, u32 set) { u32 ier; ier = s

Re: [PATCH] mmc: clear all interrupt in suspend before free_irq

2011-01-23 Thread zhangfei gao
On Fri, Jan 21, 2011 at 2:33 PM, Nicolas Pitre wrote: > On Fri, 21 Jan 2011, zhangfei gao wrote: > >> >From b7be39e0bbac3950057078ac66900ebc0871f77e Mon Sep 17 00:00:00 2001 >> From: Zhangfei Gao >> Date: Fri, 21 Jan 2011 18:02:47 -0500 >> Subject: [PATCH] mmc: clear all interrupt in suspend befo

Re: [PATCH v1 1/3]mmc: implemented runtime pm for mmc host

2011-01-23 Thread Ohad Ben-Cohen
On Sun, Jan 23, 2011 at 7:20 AM, Nicolas Pitre wrote: > First case:  you want to stop the clock _to_ the _card_ when not talking > to it.  That has nothing to do with power saving performed within the > host controller.  This is for reducing power consumption by the _card_ > (and possibly by the c

RE: [PATCH v1 1/3]mmc: implemented runtime pm for mmc host

2011-01-23 Thread Tardy, Pierre
> > First case: you want to stop the clock _to_ the _card_ when not talking > to it. That has nothing to do with power saving performed within the > host controller. This is for reducing power consumption by the _card_ > (and possibly by the clock generator). The runtime PM stuff has no > busi

Re: [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver Resubmission

2011-01-23 Thread Nicolas Pitre
On Sun, 23 Jan 2011, Wolfram Sang wrote: > On Sat, Jan 22, 2011 at 02:07:21PM -0500, Nicolas Pitre wrote: > > On Sat, 22 Jan 2011, Wolfram Sang wrote: > > > > > On Fri, Jan 21, 2011 at 04:14:46PM -0500, Nicolas Pitre wrote: > > > > On Fri, 21 Jan 2011, Tony Olech wrote: > > > > > > > > > Add a d

Re: [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver Resubmission

2011-01-23 Thread Wolfram Sang
On Sat, Jan 22, 2011 at 02:07:21PM -0500, Nicolas Pitre wrote: > On Sat, 22 Jan 2011, Wolfram Sang wrote: > > > On Fri, Jan 21, 2011 at 04:14:46PM -0500, Nicolas Pitre wrote: > > > On Fri, 21 Jan 2011, Tony Olech wrote: > > > > > > > Add a driver for Elan Digital System's VUB300 chip > > > > whic