Re: [PATCH 1/2] dw_mmc: Run card detect tasklet during slot initialisation.

2011-02-04 Thread Matt Fleming
On Fri, 4 Feb 2011 11:17:54 + Will Newton wrote: > We need to run the card detect tasklet at the end of slot > initialisation as it is possible that a card has been inserted prior > to boot, so we miss the insertion interrupt and now the card is > sitting there inserted but with no power to i

Re: [BUG] CMD52 sent as first command not CMD0

2011-02-04 Thread Philip Rakity
Debugging shows CMD52 is sent from sdio_reset call in mmc_rescan_try_fteq. card does not exist at this time. I can make this a formal patch once others are happy that this is the answer. Philip diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c index 6625c05..39e8da0 100644 --- a/

[BUG] CMD52 sent as first command not CMD0

2011-02-04 Thread Philip Rakity
using mmc-next -- NO changes -- last checkin was from linux Jan 26 [1.881003] mmc0: clock 0Hz busmode 1 powermode 1 cs 0 Vdd 21 width 0 timing 0 [1.902580] NET: Registered protocol family 17 [1.916121] Registering the dns_resolver key type [1.930357] VFP support v0.3: [1.9390

[PATCH] [patch v3] tmio_mmc: Improve readability of the output of pr_debug_status()

2011-02-04 Thread Simon Horman
Cc: Guennadi Liakhovetski Signed-off-by: Simon Horman --- v2: As suggested by Guennadi Liakhovetski * Pass status and i as parameters to STATUS_TO_TEXT * Pad "|" with spaces to further improve readability v3: Actually include the v2 changes * My git-foo bites again --- drivers/mmc/host/tmio_m

[PATCH] [patch v2] tmio_mmc: Improve readability of the output of pr_debug_status()

2011-02-04 Thread Simon Horman
Cc: Guennadi Liakhovetski Signed-off-by: Simon Horman --- v2: As suggested by Guennadi Liakhovetski * Pass status and i as parameters to STATUS_TO_TEXT * Pad "|" with spaces to further improve readability --- drivers/mmc/host/tmio_mmc.h |6 +- 1 files changed, 5 insertions(+), 1 deleti

Re: [PATCH] tmio_mmc: Improve readability of the output of pr_debug_status()

2011-02-04 Thread Simon Horman
On Fri, Feb 04, 2011 at 08:34:54PM +0100, Guennadi Liakhovetski wrote: > On Fri, 4 Feb 2011, Simon Horman wrote: > > > Signed-off-by: Simon Horman > > --- > > drivers/mmc/host/tmio_mmc.h |6 +- > > 1 files changed, 5 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/mmc/host/tm

Re: [PATCH 1/7] mmc: mxs-mmc: add mmc host driver for i.MX23/28

2011-02-04 Thread Arnd Bergmann
On Saturday 05 February 2011 03:18:41 Shawn Guo wrote: > This adds the mmc host driver for Freescale MXS-based SoC i.MX23/28. > The driver calls into mxs-dma via generic dmaengine api for both pio > and data transfer. Hi Shawn, The driver looks good coding-style wise, but it's my impression that

Re: [PATCH] tmio_mmc: Improve readability of the output of pr_debug_status()

2011-02-04 Thread Guennadi Liakhovetski
On Fri, 4 Feb 2011, Simon Horman wrote: > Signed-off-by: Simon Horman > --- > drivers/mmc/host/tmio_mmc.h |6 +- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/drivers/mmc/host/tmio_mmc.h b/drivers/mmc/host/tmio_mmc.h > index 6f724de..811427d 100644 > --- a/drivers/

[PATCH 7/7] ARM: mxs/mx28evk: add mmc device

2011-02-04 Thread Shawn Guo
Signed-off-by: Shawn Guo --- arch/arm/mach-mxs/Kconfig|1 + arch/arm/mach-mxs/mach-mx28evk.c | 102 +- 2 files changed, 101 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-mxs/Kconfig b/arch/arm/mach-mxs/Kconfig index 3f400cb..b00dd2a 100

[PATCH 1/7] mmc: mxs-mmc: add mmc host driver for i.MX23/28

2011-02-04 Thread Shawn Guo
This adds the mmc host driver for Freescale MXS-based SoC i.MX23/28. The driver calls into mxs-dma via generic dmaengine api for both pio and data transfer. Signed-off-by: Shawn Guo --- arch/arm/mach-mxs/include/mach/mmc.h | 15 + drivers/mmc/host/Kconfig |9 + drivers/mmc/host

[PATCH 5/7] ARM: mxs: fix typo "GPO" in iomux-mx23.h

2011-02-04 Thread Shawn Guo
Signed-off-by: Shawn Guo --- arch/arm/mach-mxs/include/mach/iomux-mx23.h | 190 +- 1 files changed, 95 insertions(+), 95 deletions(-) diff --git a/arch/arm/mach-mxs/include/mach/iomux-mx23.h b/arch/arm/mach-mxs/include/mach/iomux-mx23.h index 94e5dd8..b0190a4 100644 ---

[PATCH 6/7] ARM: mxs/mx23evk: add mmc device

2011-02-04 Thread Shawn Guo
Signed-off-by: Shawn Guo --- arch/arm/mach-mxs/Kconfig|1 + arch/arm/mach-mxs/mach-mx23evk.c | 58 ++ 2 files changed, 59 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-mxs/Kconfig b/arch/arm/mach-mxs/Kconfig index c9ac415..3f400cb 1006

[PATCH 4/7] ARM: mxs: dynamically allocate mmc device

2011-02-04 Thread Shawn Guo
Signed-off-by: Shawn Guo --- arch/arm/mach-mxs/clock-mx23.c | 16 + arch/arm/mach-mxs/clock-mx28.c | 18 + arch/arm/mach-mxs/devices-mx23.h|4 + arch/arm/mach-mxs/devices-mx28.h|4 + arch/arm/mach-mxs/devices/Kc

[PATCH 2/7] ARM: mxs/clock: fix base address missing in name##_set_parent

2011-02-04 Thread Shawn Guo
Signed-off-by: Shawn Guo --- arch/arm/mach-mxs/clock-mx23.c |2 +- arch/arm/mach-mxs/clock-mx28.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-mxs/clock-mx23.c b/arch/arm/mach-mxs/clock-mx23.c index 350b28c..c19b69a 100644 --- a/arch/arm/mach-mxs/clo

[PATCH 3/7] ARM: mxs: make ssp error irq definition consistent

2011-02-04 Thread Shawn Guo
Signed-off-by: Shawn Guo --- arch/arm/mach-mxs/include/mach/mx23.h |2 +- arch/arm/mach-mxs/include/mach/mx28.h |8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm/mach-mxs/include/mach/mx23.h b/arch/arm/mach-mxs/include/mach/mx23.h index 1730c9c..e858692

[PATCH 0/7] Add mmc driver for i.MX23/28

2011-02-04 Thread Shawn Guo
This patch set is to add mmc host driver for i.MX23/28. It was tested on both mx23evk and mx28evk boards against Sascha's imx-for-2.6.39 tree plus the mxs-dma patch set. Thanks for review. Regards, Shawn Shawn Guo (7) [PATCH 1/7] mmc: mxs-mmc: add mmc host driver for i.MX23/28 [PATCH 2/7] ARM

[PATCH 2/2] dw_mmc: Enable low-power mode for the card clock.

2011-02-04 Thread Will Newton
Setting this bit in the clock enable register will stop the clock when the card is in the IDLE state. Signed-off-by: Will Newton --- drivers/mmc/host/dw_mmc.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c index 0b

[PATCH 1/2] dw_mmc: Run card detect tasklet during slot initialisation.

2011-02-04 Thread Will Newton
We need to run the card detect tasklet at the end of slot initialisation as it is possible that a card has been inserted prior to boot, so we miss the insertion interrupt and now the card is sitting there inserted but with no power to it. Signed-off-by: Neil Jones Signed-off-by: Will Newton ---

[PATCH] tmio_mmc: Improve readability of the output of pr_debug_status()

2011-02-04 Thread Simon Horman
Signed-off-by: Simon Horman --- drivers/mmc/host/tmio_mmc.h |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/host/tmio_mmc.h b/drivers/mmc/host/tmio_mmc.h index 6f724de..811427d 100644 --- a/drivers/mmc/host/tmio_mmc.h +++ b/drivers/mmc/host/tmio_mmc.h @@