[PATCH 2/2] mmc: sdhci: Replace SDHCI_QUIRK_NO_MULTIBLOCK with a platform hook.

2011-02-05 Thread Chris Ball
Part of a quirk cleanup run. This quirk was only used by sdhci-esdhc. This patch is untested. Signed-off-by: Chris Ball Cc: Anton Vorontsov Cc: Wolfram Sang --- drivers/mmc/host/sdhci-esdhc-imx.c | 12 drivers/mmc/host/sdhci.c |5 - drivers/mmc/host/sdhci.h

[PATCH 1/2] mmc: sdhci: Replace SDHCI_QUIRK_FORCE_BLK_SZ_2048 with a pklatform hook.

2011-02-05 Thread Chris Ball
Part of a quirk cleanup run. This quirk was only used by sdhci-esdhc. This patch is untested. Signed-off-by: Chris Ball Cc: Anton Vorontsov Cc: Wolfram Sang --- drivers/mmc/host/sdhci-esdhc-imx.c |8 drivers/mmc/host/sdhci-esdhc.h |3 +-- drivers/mmc/host/sdhci-of-esdhc.c

Re: [PATCH] mmc: sdhci-s3c: Auto CMD12 support

2011-02-05 Thread Chris Ball
Hi Kyungmin, On Sat, Oct 30, 2010 at 12:58:56PM +0900, Kyungmin Park wrote: > From: Kyungmin Park > > Samsung SDHCI host controller supports the Auto CMD12. > > Signed-off-by: Kyungmin Park > --- > diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c > index aacb862..e2d79e

Re: [BUG] CMD52 sent as first command not CMD0

2011-02-05 Thread Chris Ball
Hi, On Sat, Feb 05, 2011 at 05:35:46PM -0800, Philip Rakity wrote: > > proposed solution: I cannot verify this fix until Monday. > = > > CMD52 is a reset for SDIO cards. CMD0 is not sufficient when > the card is being re-initialized. Only send CMD52 if > a) doing a reinitialize > b) card

Re: [BUG] CMD52 sent as first command not CMD0

2011-02-05 Thread Philip Rakity
proposed solution: I cannot verify this fix until Monday. = CMD52 is a reset for SDIO cards. CMD0 is not sufficient when the card is being re-initialized. Only send CMD52 if a) doing a reinitialize b) card is SDIO or SDIO_COMBO Signed-off-by: Philip Rakity --- drivers/mmc/core/core.c |

Re: [BUG] CMD52 sent as first command not CMD0

2011-02-05 Thread Chris Ball
On Sat, Feb 05, 2011 at 04:52:12PM -0800, Philip Rakity wrote: > nothing negative but reset is meant to reinit the card. This is the power up > sequence for the 1st time a card is detected. > There is no reason to do this if no card has yet enumerated. If a sdio card > was there I completely ag

Re: [BUG] CMD52 sent as first command not CMD0

2011-02-05 Thread Philip Rakity
The CMD52 was sent to a eMMC card. Not SDIO. Figure 6.2 in SDIO spec 2.0 -- clearly shows that the card needs to exist before cmd52 (reset) is legal. Probably need to extend the proposed change to check card type to ensure only done for sdio. On Feb 5, 2011, at 4:52 PM, Philip Rakity wrote:

Re: [BUG] CMD52 sent as first command not CMD0

2011-02-05 Thread Philip Rakity
nothing negative but reset is meant to reinit the card. This is the power up sequence for the 1st time a card is detected. There is no reason to do this if no card has yet enumerated. If a sdio card was there I completely agree with the mod since we need to reset the card. CMD0 should be th

Re: [BUG] CMD52 sent as first command not CMD0

2011-02-05 Thread Chris Ball
Hi Philip, On Fri, Feb 04, 2011 at 02:53:59PM -0800, Philip Rakity wrote: > using mmc-next -- NO changes -- last checkin was from linux Jan 26 [..] > [2.034998] mmc0: starting CMD52 arg 0c00 flags 0195 > [2.052704] Waiting 15sec before mounting root device... > [2.068948] sdhci

Re: [PATCH 0/5] mmc: add double buffering for mmc block requests

2011-02-05 Thread Russell King - ARM Linux
On Sat, Feb 05, 2011 at 05:02:55PM +, Russell King - ARM Linux wrote: > On Wed, Jan 12, 2011 at 07:13:58PM +0100, Per Forlin wrote: > > Add support to prepare one MMC request while another is active on > > the host. This is done by making the issue_rw_rq() asynchronous. > > The increase in thro

Re: [PATCH 0/5] mmc: add double buffering for mmc block requests

2011-02-05 Thread Russell King - ARM Linux
On Wed, Jan 12, 2011 at 07:13:58PM +0100, Per Forlin wrote: > Add support to prepare one MMC request while another is active on > the host. This is done by making the issue_rw_rq() asynchronous. > The increase in throughput is proportional to the time it takes to > prepare a request and how fast th