Re: [BUG] CMD52 sent as first command not CMD0

2011-02-06 Thread Albert Herranz
Hi, On 02/06/2011 02:35 AM, Philip Rakity wrote: proposed solution: I cannot verify this fix until Monday. = CMD52 is a reset for SDIO cards. CMD0 is not sufficient when the card is being re-initialized. Only send CMD52 if a) doing a reinitialize b) card is SDIO or SDIO_COMBO

RE: [BUG] CMD52 sent as first command not CMD0

2011-02-06 Thread Tardy, Pierre
nothing negative but reset is meant to reinit the card. This is the power up sequence for the 1st time a card is detected. There is no reason to do this if no card has yet enumerated. If a sdio card was there I completely agree with the mod since we need to reset the card. What

[PATCH v2 0/3] sdhci runtime_pm implementation using mmc clock gating fw

2011-02-06 Thread Pierre Tardy
Please find a simple sdhci runtime_pm implementation that uses clock gating fw as a tip to know when our chip is idle. Previous version was RFC and untested, This version has been tested on intel medfield platform. Pierre Tardy (2): mmc: put the led blinking code after clock ungating

[PATCH v2 1/3] mmc: put the led blinking code after clock ungating

2011-02-06 Thread Pierre Tardy
as mmc clock gating can also be used as a power gating tip, this is better to put the led blinking after having ungate the clock Signed-off-by: Pierre Tardy pierre.ta...@intel.com --- drivers/mmc/core/core.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git

[PATCH v2 2/3] sdhci-pci : Enable runtime PM support

2011-02-06 Thread Pierre Tardy
From: Yunpeng Gao yunpeng@intel.com Follow the kernel runtime PM framework, enable runtime PM support of the sdhci host controller with pci interface. Note that this patch implements runtime_pm but now actually detects activity. It relies on higher level (childrens) to do actual waking up

[PATCH v2 3/3] sdhci:v2:use ios-clock to know when sdhci is idle

2011-02-06 Thread Pierre Tardy
From: Pierre Tardy tar...@gmail.com This allows sdhci to detect its own activity and to autosuspend when not used inspired from mmci: handle clock frequency 0 properly From Linus Walleij linus.wall...@stericsson.com author of mmc aggressive clock gating fw. The idea of using mmc clock gating

[PATCH v2 1/3] mmc: add per device quirk placeholder

2011-02-06 Thread Pierre Tardy
Some cards have quirks valid for every platforms using current platform quirk hooks leads to a lot of code and debug duplication. So we inspire a bit from what exists in PCI subsystem and do out own per vendorid/deviceid quirk We still drop the complexity of the pci quirk system (with special

[PATCH v2 2/3] mmc: add MMC_QUIRK_BROKEN_CLK_GATING

2011-02-06 Thread Pierre Tardy
From: Pierre Tardy tar...@gmail.com Some sdio card are not following sdio standard, and does not work when the sdio bus's clock is gated To keep functionnality for all legacy driver, we turn this quirk on for every sdio card. Drivers needs to disable the quirk manually when someone verified that

[PATCH v2 3/3] mmc: remove BROCKEN_CLK_GATING quirk for wl1271

2011-02-06 Thread Pierre Tardy
This sdio card is supporting having its sdio clock shutdown It is also not using the SDIO IRQ, but rather uses a side gpio irq. Signed-off-by: Pierre Tardy tar...@gmail.com --- drivers/mmc/core/quirks.c | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git

Re: [PATCH v2 0/3] sdhci runtime_pm implementation using mmc clock gating fw

2011-02-06 Thread Linus Walleij
2011/2/6 Pierre Tardy pierre.ta...@intel.com: Please find a simple sdhci runtime_pm implementation that uses clock gating fw as a tip to know when our chip is idle. I like this approach, the gated clock hints to rpm that it's time to idle the device. Great work. Acked-by: Linus Walleij

Re: [PATCH] mmc_test: Don't warn about not waiting for busy if controller can't do this

2011-02-06 Thread Matt Fleming
On Mon, 17 Jan 2011 17:00:31 + Pawel Moll pawel.m...@arm.com wrote: If the MMC host controller does not support waiting for card signaling busy state (MMC_CAP_WAIT_WHILE_BUSY cap), there is no point in prining the relevant warning message. Signed-off-by: Pawel Moll pawel.m...@arm.com

Re: [PATCH] mmc_test: Don't warn about not waiting for busy if controller can't do this

2011-02-06 Thread Chris Ball
Hi, On Sun, Feb 06, 2011 at 07:53:59PM +, Matt Fleming wrote: On Mon, 17 Jan 2011 17:00:31 + Pawel Moll pawel.m...@arm.com wrote: If the MMC host controller does not support waiting for card signaling busy state (MMC_CAP_WAIT_WHILE_BUSY cap), there is no point in prining the

Re: [PATCH v2 0/3] sdhci runtime_pm implementation using mmc clock gating fw

2011-02-06 Thread Chris Ball
Hi Pierre, On Sun, Feb 06, 2011 at 07:02:47PM +0100, Pierre Tardy wrote: Please find a simple sdhci runtime_pm implementation that uses clock gating fw as a tip to know when our chip is idle. Previous version was RFC and untested, This version has been tested on intel medfield platform.

Re: [PATCH v2 0/3] introduce mmc per device quirks

2011-02-06 Thread Chris Ball
On Sun, Feb 06, 2011 at 07:03:45PM +0100, Pierre Tardy wrote: This patchset is the resend and cleanup of the mmc per device quirks patchset. User of the quirks is attached, which allows clock gating framework to be used for specific sdio card that are known to work. Pierre Tardy (3):

Re: [BUG] CMD52 sent as first command not CMD0

2011-02-06 Thread Philip Rakity
On Feb 6, 2011, at 3:13 AM, Albert Herranz wrote: Hi, On 02/06/2011 02:35 AM, Philip Rakity wrote: proposed solution: I cannot verify this fix until Monday. = CMD52 is a reset for SDIO cards. CMD0 is not sufficient when the card is being re-initialized. Only send CMD52 if a)

Re: [BUG] CMD52 sent as first command not CMD0

2011-02-06 Thread Nicolas Pitre
On Sun, 6 Feb 2011, Philip Rakity wrote: On Feb 6, 2011, at 3:13 AM, Albert Herranz wrote: Hi, On 02/06/2011 02:35 AM, Philip Rakity wrote: proposed solution: I cannot verify this fix until Monday. = CMD52 is a reset for SDIO cards. CMD0 is not sufficient when the