Re: MMC quirks relating to performance/lifetime.

2011-02-18 Thread Andrei Warkentin
2011/2/18 Andrei Warkentin : > On Fri, Feb 18, 2011 at 1:47 PM, Andrei Warkentin > wrote: >> On Fri, Feb 18, 2011 at 7:44 AM, Arnd Bergmann wrote: >>> I'm curious. Neither the manfid nor the oemid fields of either card >>> match what I have seen on SD cards, I would expect them to be >>> >>> San

Re: MMC quirks relating to performance/lifetime.

2011-02-18 Thread Andrei Warkentin
On Fri, Feb 18, 2011 at 1:47 PM, Andrei Warkentin wrote: > On Fri, Feb 18, 2011 at 7:44 AM, Arnd Bergmann wrote: >> I'm curious. Neither the manfid nor the oemid fields of either card >> match what I have seen on SD cards, I would expect them to be >> >> Sandisk: manfid 0x03, oemid 0x5344 >>

Re: MMC quirks relating to performance/lifetime.

2011-02-18 Thread Andrei Warkentin
On Fri, Feb 18, 2011 at 7:44 AM, Arnd Bergmann wrote: > I'm curious. Neither the manfid nor the oemid fields of either card > match what I have seen on SD cards, I would expect them to be > > Sandisk: manfid 0x03, oemid 0x5344 > Toshiba: manfid 0x02, oemid 0x544d > > I have not actually se

Re: [PATCH 01/12] mmc: sdhci: add support for SD Host Controller 3.0

2011-02-18 Thread Philip Rakity
Thanks Nico Anindam, Lets follow Nico advise -- please ignore my last post on moving it into the host driver. Philip On Feb 18, 2011, at 10:55 AM, Nicolas Pitre wrote: > On Fri, 18 Feb 2011, Nath, Arindam wrote: > >> Hi Philip, >> >> >>> -Original Message- >>> From: Philip Rakity

Re: [PATCH 01/12] mmc: sdhci: add support for SD Host Controller 3.0

2011-02-18 Thread Philip Rakity
On Feb 18, 2011, at 9:17 AM, Nath, Arindam wrote: > Hi Philip, > > >> -Original Message- >> From: Philip Rakity [mailto:prak...@marvell.com] >> Sent: Friday, February 18, 2011 9:19 PM >> To: Nath, Arindam >> Cc: Zhangfei Gao; Chris Ball; linux-mmc@vger.kernel.org; Su, Henry; Lu, >> Aaro

RE: [PATCH 01/12] mmc: sdhci: add support for SD Host Controller 3.0

2011-02-18 Thread Nicolas Pitre
On Fri, 18 Feb 2011, Nath, Arindam wrote: > Hi Philip, > > > > -Original Message- > > From: Philip Rakity [mailto:prak...@marvell.com] > > Sent: Friday, February 18, 2011 9:19 PM > > To: Nath, Arindam > > Cc: Zhangfei Gao; Chris Ball; linux-mmc@vger.kernel.org; Su, Henry; Lu, > > Aaron;

RE: [PATCH 01/12] mmc: sdhci: add support for SD Host Controller 3.0

2011-02-18 Thread Nath, Arindam
Hi Philip, > -Original Message- > From: Philip Rakity [mailto:prak...@marvell.com] > Sent: Friday, February 18, 2011 9:19 PM > To: Nath, Arindam > Cc: Zhangfei Gao; Chris Ball; linux-mmc@vger.kernel.org; Su, Henry; Lu, > Aaron; anath@gmail.com; Nicolas Pitre > Subject: [PATCH 01/12] m

Fwd: [PATCH 00/12] add support for sd host controller v3.00

2011-02-18 Thread Philip Rakity
Begin forwarded message: > From: "Nath, Arindam" > Date: February 16, 2011 10:52:50 PM PST > To: Philip Rakity > Cc: "Su, Henry" , "Lu, Aaron" > Subject: RE: [PATCH 00/12] add support for sd host controller v3.00 > > Good catch Philip. Thanks for the review. I will fix it. BTW, you can put

Re: [RFC] MMC: error handling improvements

2011-02-18 Thread Brian Swetland
On Fri, Feb 18, 2011 at 5:03 AM, Linus Walleij wrote: > 2011/2/17 Brian Swetland : >> On Wed, Feb 16, 2011 at 1:01 PM, Linus Walleij >> wrote: >>> 2011/2/16 David Brown : > The SDCC block is shared between the modem processor and the processor running Linux.  If the driver doesn't

[PATCH 01/12] mmc: sdhci: add support for SD Host Controller 3.0

2011-02-18 Thread Philip Rakity
Arindam, Could you look at making (Tuning) CMD19 part of the sdhc.ci driver? It flow is part of the Host Controller and Physical layer specs. I am not sure that it belongs in core/ as it is transparent to the other functions and is unclear why it needs to be exposed adding Nico for comment

Re: [PATCH 01/12] mmc: sdhci: add support for auto CMD23

2011-02-18 Thread Arnd Bergmann
On Friday 18 February 2011, Nath, Arindam wrote: > Auto CMD23 is a feature that automatically issues a CMD23 before > a CMD18 or CMD25 is sent. Objective of this function is to avoid > performance deterioration during memory access by removing interrupt > service of CMD23. I feel a bit stupid now,

Re: MMC quirks relating to performance/lifetime.

2011-02-18 Thread Arnd Bergmann
On Friday 18 February 2011, Andrei Warkentin wrote: > On Fri, Feb 11, 2011 at 4:33 PM, Andrei Warkentin > wrote: > > Arnd, > > > > Yes, this is a Toshiba card. I've sent the patch as a reply to Linus' email. > > > > cid - 02010053454d3332479070cc51451d00 > > csd - d00f00320f5903ff92404000

Re: [PATCH v2] mxcmmc: use dmaengine API

2011-02-18 Thread Arnd Bergmann
On Friday 18 February 2011, Sascha Hauer wrote: > This switches the mxcmmc driver to use the dmaengine API. Unlike > the old one this one is always present in the tree, even if no DMA > is implemented, hence we can remove all the #ifdefs in from the driver. > The driver automatically switches to PI

RE: [PATCH 01/12] mmc: sdhci: add support for auto CMD23

2011-02-18 Thread Nath, Arindam
Hi Arnd, > -Original Message- > From: Arnd Bergmann [mailto:a...@arndb.de] > Sent: Friday, February 18, 2011 6:39 PM > To: Nath, Arindam > Cc: zhangfei gao; c...@laptop.org; linux-mmc@vger.kernel.org; Su, Henry; > Lu, Aaron; anath@gmail.com > Subject: Re: [PATCH 01/12] mmc: sdhci: add

Re: [PATCH 01/12] mmc: sdhci: add support for auto CMD23

2011-02-18 Thread Arnd Bergmann
On Friday 18 February 2011, Nath, Arindam wrote: > > AFAICT, whether CMD23 can be used or not is primarily a decision based > > on > > the card, and the block driver might want issue it for a longer range > > if it needs to split a block request into multiple MMC requests. > > Thanks for the comme

Re: [RFC] MMC: error handling improvements

2011-02-18 Thread Linus Walleij
2011/2/17 Brian Swetland : > On Wed, Feb 16, 2011 at 1:01 PM, Linus Walleij > wrote: >> 2011/2/16 David Brown : >>> The SDCC block is shared between >>> the modem processor and the processor running Linux.  If the driver >>> doesn't go through the DMA engine, which coordinates this, the register

RE: [PATCH 01/12] mmc: sdhci: add support for auto CMD23

2011-02-18 Thread Nath, Arindam
Hi Arnd, > -Original Message- > From: Arnd Bergmann [mailto:a...@arndb.de] > Sent: Friday, February 18, 2011 4:21 PM > To: zhangfei gao > Cc: Nath, Arindam; c...@laptop.org; linux-mmc@vger.kernel.org; Su, > Henry; Lu, Aaron; anath@gmail.com > Subject: Re: [PATCH 01/12] mmc: sdhci: add

RE: [PATCH 01/12] mmc: sdhci: add support for auto CMD23

2011-02-18 Thread Nath, Arindam
Hi Zhangfei, > -Original Message- > From: zhangfei gao [mailto:zhangfei@gmail.com] > Sent: Friday, February 18, 2011 4:15 PM > To: Nath, Arindam > Cc: c...@laptop.org; linux-mmc@vger.kernel.org; Su, Henry; Lu, Aaron; > anath@gmail.com > Subject: Re: [PATCH 01/12] mmc: sdhci: add su

RE: [PATCH 09/12] mmc: sd: add support for tuning during uhs initialization

2011-02-18 Thread Nath, Arindam
Hi Zhangfei, > -Original Message- > From: zhangfei gao [mailto:zhangfei@gmail.com] > Sent: Friday, February 18, 2011 4:20 PM > To: Nath, Arindam > Cc: c...@laptop.org; linux-mmc@vger.kernel.org; Su, Henry; Lu, Aaron; > anath@gmail.com > Subject: Re: [PATCH 09/12] mmc: sd: add suppo

Re: [PATCH 01/12] mmc: sdhci: add support for auto CMD23

2011-02-18 Thread Arnd Bergmann
On Friday 18 February 2011 11:45:27 zhangfei gao wrote: > On Tue, Feb 15, 2011 at 4:34 AM, Arindam Nath wrote: > > Host Controller v3.00 and later support Auto CMD23 in the Transfer > > Mode register. Since Auto CMD23 can be used with or without DMA, > > and if used with DMA, it should only be ADM

Re: [PATCH 09/12] mmc: sd: add support for tuning during uhs initialization

2011-02-18 Thread zhangfei gao
On Tue, Feb 15, 2011 at 4:35 AM, Arindam Nath wrote: > Host Controller needs tuning during initialization to operate SDR50 > and SDR104 UHS-I cards. Whether SDR50 mode actually needs tuning is > indicated by bit 45 of the Host Controller Capabilities register. > A new command CMD19 has been define

Re: [PATCH 01/12] mmc: sdhci: add support for auto CMD23

2011-02-18 Thread zhangfei gao
On Tue, Feb 15, 2011 at 4:34 AM, Arindam Nath wrote: > Host Controller v3.00 and later support Auto CMD23 in the Transfer > Mode register. Since Auto CMD23 can be used with or without DMA, > and if used with DMA, it should _only_ be ADMA, we check against > SDHCI_USE_SDMA not being set. This flag

[PATCH v2] mxcmmc: use dmaengine API

2011-02-18 Thread Sascha Hauer
This switches the mxcmmc driver to use the dmaengine API. Unlike the old one this one is always present in the tree, even if no DMA is implemented, hence we can remove all the #ifdefs in from the driver. The driver automatically switches to PIO mode if no DMA support or no suitable channel is avai