Re: MMC quirks relating to performance/lifetime.

2011-02-21 Thread Andrei Warkentin
On Sun, Feb 20, 2011 at 8:39 AM, Arnd Bergmann wrote: > [adding linux-fsdevel to Cc, see http://lwn.net/Articles/428941/ and > http://comments.gmane.org/gmane.linux.ports.arm.kernel/105607 for more > on this discussion.] > > > I think it's good to discuss all the options, but my feeling is that >

Re: MMC quirks relating to performance/lifetime.

2011-02-21 Thread Andrei Warkentin
On Sun, Feb 20, 2011 at 9:23 AM, Arnd Bergmann wrote: > The description of the test case is probably suboptimal. What this does > is 32 KB accesses, with 32 KB alignment in the pre and post case, but 16 KB > alignment in the "on" case. The idea here is that it should never do > any access with les

RE: [PATCH 5/5] mmc: sdhci: add quirk SDHCI_QUIRK_FIX_NO_INT_IN_MULTI_BLK_IO

2011-02-21 Thread Zhu Richard-R65037
Hi WolfSang: I mis-understand your meaning of the IO-Accessors. It maybe work when the IO-Accessors are used. Wait a minute, I would resend the patches use he IO-Accessors methods. Best Regards Richard Zhu > -Original Message- > From: Zhu Richard-R65037 > Sent: Tuesday, February 22, 2011

RE: [PATCH 5/5] mmc: sdhci: add quirk SDHCI_QUIRK_FIX_NO_INT_IN_MULTI_BLK_IO

2011-02-21 Thread Zhu Richard-R65037
Hi Russell King: Thanks for your comments firstly. Best Regards Richard Zhu > -Original Message- > From: Russell King - ARM Linux [mailto:li...@arm.linux.org.uk] > Sent: Monday, February 21, 2011 7:09 PM > To: Wolfram Sang > Cc: Zhu Richard-R65037; Zhao Richard-B20223; c...@laptop.org; >

RE: [PATCH 5/5] mmc: sdhci: add quirk SDHCI_QUIRK_FIX_NO_INT_IN_MULTI_BLK_IO

2011-02-21 Thread Zhu Richard-R65037
Hi Wolfsang: Maybe I don't describe my thoughts clearly and exactly. I feel it's not easy to add the the IO-accessors in every cmd execution procedure, to make a double check why a IO-accessor is needed or not. Best Regards Richard Zhu > -Original Message- > From: Wolfram Sang [mailto:w

Re: [PATCH] dw_mmc: set the debounce value and remove duplicated offset

2011-02-21 Thread Jaehoon Chung
Will Newton wrote: > On Mon, Feb 21, 2011 at 8:57 AM, Jaehoon Chung wrote: >> This patch is set the debouce value.. >> This value do not need to be changed with every command. >> So we set the value in probe function. >> >> And DATA register offset is duplicated.. >> >> Signed-off-by: Jaehoon Chun

Re: [PATCH 2/5] ARM: imx51/53: add sdhc3/4 clock

2011-02-21 Thread Richard Zhao
Hi Sascha, On Mon, Feb 21, 2011 at 05:21:54PM +0100, Sascha Hauer wrote: > On Mon, Feb 21, 2011 at 05:54:52PM +0800, Richard Zhao wrote: > > Signed-off-by: Richard Zhao > > > > diff --git a/arch/arm/mach-mx5/clock-mx51-mx53.c > > b/arch/arm/mach-mx5/clock-mx51-mx53.c > > index 8164b1d..8ac61d5 1

Re: [PATCH] mmc: sdhci-tegra: free irq on error and remove

2011-02-21 Thread Chris Ball
Hi, On Mon, Feb 21, 2011 at 01:35:36PM -0800, Olof Johansson wrote: > >> Found the leak while working on the esdhc-imx driver. Not even compile > >> tested, > >> please check. > > > > Olof, do you have a minute for this one? > > Yeah, my bad -- I thought I had already acked it. > > Acked-by: Ol

Re: [PATCH] mmc: sdhci-tegra: free irq on error and remove

2011-02-21 Thread Olof Johansson
On Sun, Feb 20, 2011 at 11:21 PM, Wolfram Sang wrote: > On Thu, Feb 10, 2011 at 06:07:30PM +0100, Wolfram Sang wrote: >> Signed-off-by: Wolfram Sang >> Cc: Olof Johansson >> Cc: Chris Ball >> --- >> >> Found the leak while working on the esdhc-imx driver. Not even compile >> tested, >> please

[PATCH] sdhci: work around broken dma boundary behaviour

2011-02-21 Thread Mikko Vinni
Some SD host controllers (noticed on an integrated JMicron SD reader on an HP Pavilion dv5-1250eo laptop) don't update the dma address register before signalling a dma interrupt due to a dma boundary. Detect this and update the register to the next 512KB boundary, at which the transfer presumably s

Re: [RFC] MMC: error handling improvements

2011-02-21 Thread Linus Walleij
Out of sheer curiosity, Qualcomm/CodeAurora guys: if you dump out the registers at offset 0xfe0-0xfff on the SDCC, does it contain a valid PrimeCell ID? Anyone who can make a hexdump of it? It is possible to hardcode an AMBA ID to use this driver even if this area is just 0x... but I'm just c

Re: [PATCH v2 2/3] sdhci-pci : Enable runtime PM support

2011-02-21 Thread Chris Ball
Hi Pierre, On Sun, Feb 13, 2011 at 11:42:01AM +0100, Pierre Tardy wrote: > > [   10.892280] sdhci-pci :17:00.0: Unbalanced pm_runtime_enable! > > I never have seen this before. I'm not testing those patches on > mmc-next, as our platform is not totally upstream yet, and do not boot > on 2.6.3

Re: [PATCH v3] mmc: mxs-mmc: add mmc host driver for i.MX23/28

2011-02-21 Thread Wolfram Sang
Shawn, On Mon, Feb 21, 2011 at 06:35:28PM +0800, Shawn Guo wrote: > This adds the mmc host driver for Freescale MXS-based SoC i.MX23/28. > The driver calls into mxs-dma via generic dmaengine api for both pio > and data transfer. > > Thanks Chris Ball for the indentation patch. > > Signed-off-by:

Re: [PATCH 2/5] ARM: imx51/53: add sdhc3/4 clock

2011-02-21 Thread Sascha Hauer
On Mon, Feb 21, 2011 at 05:54:52PM +0800, Richard Zhao wrote: > Signed-off-by: Richard Zhao > > diff --git a/arch/arm/mach-mx5/clock-mx51-mx53.c > b/arch/arm/mach-mx5/clock-mx51-mx53.c > index 8164b1d..8ac61d5 100644 > --- a/arch/arm/mach-mx5/clock-mx51-mx53.c > +++ b/arch/arm/mach-mx5/clock-mx5

Re: [PATCH] omap: hsmmc: fix ocr mask usage

2011-02-21 Thread Kishore Kadiyala
On Mon, Feb 21, 2011 at 11:37 AM, Anand Gadiyar wrote: > The OMAP HSMMC driver uses an ocr_mask to determine the > list of voltages supported by the card. It populates this > mask based on the list of voltages supported by the > regulator that supplies the voltage. > > Commit 64be97822b (omap4 hsm

Re: [PATCH v2] mxcmmc: use dmaengine API

2011-02-21 Thread Sascha Hauer
On Fri, Feb 18, 2011 at 02:37:02PM +0100, Arnd Bergmann wrote: > On Friday 18 February 2011, Sascha Hauer wrote: > > This switches the mxcmmc driver to use the dmaengine API. Unlike > > the old one this one is always present in the tree, even if no DMA > > is implemented, hence we can remove all th

Re: [PATCH 5/5] mmc: sdhci: add quirk SDHCI_QUIRK_FIX_NO_INT_IN_MULTI_BLK_IO

2011-02-21 Thread Richard Zhao
On Mon, Feb 21, 2011 at 11:06:24AM +, Russell King - ARM Linux wrote: > On Mon, Feb 21, 2011 at 05:54:55PM +0800, Richard Zhao wrote: > > + if (host->quirks & SDHCI_QUIRK_FIX_NO_INT_IN_MULTI_BLK_IO) { > > + if (readl(host->ioaddr + SDHCI_VENDOR_SPEC) & 0x2) > > + w

Re: [PATCH 5/5] mmc: sdhci: add quirk SDHCI_QUIRK_FIX_NO_INT_IN_MULTI_BLK_IO

2011-02-21 Thread Wolfram Sang
On Mon, Feb 21, 2011 at 11:09:05AM +, Russell King - ARM Linux wrote: > On Mon, Feb 21, 2011 at 11:46:08AM +0100, Wolfram Sang wrote: > > > > > - if (cpu_is_mx35() || cpu_is_mx51()) > > > > > + if (cpu_is_mx53()) > > > > > + host->quirks |= SDHCI_QUIRK_FIX_NO_INT_IN_MULTI_BLK_IO;

Re: [PATCH 5/5] mmc: sdhci: add quirk SDHCI_QUIRK_FIX_NO_INT_IN_MULTI_BLK_IO

2011-02-21 Thread Russell King - ARM Linux
On Mon, Feb 21, 2011 at 11:46:08AM +0100, Wolfram Sang wrote: > > > > - if (cpu_is_mx35() || cpu_is_mx51()) > > > > + if (cpu_is_mx53()) > > > > + host->quirks |= SDHCI_QUIRK_FIX_NO_INT_IN_MULTI_BLK_IO; > > > > > > Have you tried it doing it via IO-accessors? > > Richard Zhu: This qui

Re: [PATCH 5/5] mmc: sdhci: add quirk SDHCI_QUIRK_FIX_NO_INT_IN_MULTI_BLK_IO

2011-02-21 Thread Russell King - ARM Linux
On Mon, Feb 21, 2011 at 05:54:55PM +0800, Richard Zhao wrote: > + if (host->quirks & SDHCI_QUIRK_FIX_NO_INT_IN_MULTI_BLK_IO) { > + if (readl(host->ioaddr + SDHCI_VENDOR_SPEC) & 0x2) > + writel(readl(host->ioaddr + SDHCI_VENDOR_SPEC) & ~0x2, > +

Re: [PATCH 5/5] mmc: sdhci: add quirk SDHCI_QUIRK_FIX_NO_INT_IN_MULTI_BLK_IO

2011-02-21 Thread Wolfram Sang
> > > - if (cpu_is_mx35() || cpu_is_mx51()) > > > + if (cpu_is_mx53()) > > > + host->quirks |= SDHCI_QUIRK_FIX_NO_INT_IN_MULTI_BLK_IO; > > > > Have you tried it doing it via IO-accessors? > Richard Zhu: This quirk is used to fix a mechanism problem in the MMC CMDs > execution procedu

[PATCH v3] mmc: mxs-mmc: add mmc host driver for i.MX23/28

2011-02-21 Thread Shawn Guo
This adds the mmc host driver for Freescale MXS-based SoC i.MX23/28. The driver calls into mxs-dma via generic dmaengine api for both pio and data transfer. Thanks Chris Ball for the indentation patch. Signed-off-by: Shawn Guo Reviewed-by: Arnd Bergmann --- arch/arm/mach-mxs/include/mach/mmc.h

Re: [PATCH] dw_mmc: set the debounce value and remove duplicated offset

2011-02-21 Thread Will Newton
On Mon, Feb 21, 2011 at 8:57 AM, Jaehoon Chung wrote: > This patch is set the debouce value.. > This value do not need to be changed with every command. > So we set the value in probe function. > > And DATA register offset is duplicated.. > > Signed-off-by: Jaehoon Chung > Signed-off-by: kyungmin

RE: [PATCH 5/5] mmc: sdhci: add quirk SDHCI_QUIRK_FIX_NO_INT_IN_MULTI_BLK_IO

2011-02-21 Thread Zhu Richard-R65037
Hi Wolfsang: See my comments marked by Richard Zhu below. Best Regards Richard Zhu > -Original Message- > From: Wolfram Sang [mailto:w.s...@pengutronix.de] > Sent: Monday, February 21, 2011 6:05 PM > To: Zhao Richard-B20223 > Cc: linux-arm-ker...@lists.infradead.org; ker...@pengutronix.de

Re: [PATCH 5/5] mmc: sdhci: add quirk SDHCI_QUIRK_FIX_NO_INT_IN_MULTI_BLK_IO

2011-02-21 Thread Wolfram Sang
On Mon, Feb 21, 2011 at 05:54:55PM +0800, Richard Zhao wrote: > Fix no INT in MULTI-BLK IO. > > Signed-off-by: Richard Zhu > > diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c > b/drivers/mmc/host/sdhci-esdhc-imx.c > index 9b82910..2eeb03e 100644 > --- a/drivers/mmc/host/sdhci-esdhc-imx.c > +++

Re: [PATCH 4/5] mm: sdhci-esdhc: remove SDHCI_QUIRK_NO_CARD_NO_RESET from ESDHC_DEFAULT_QUIRKS

2011-02-21 Thread Wolfram Sang
On Mon, Feb 21, 2011 at 05:54:54PM +0800, Richard Zhao wrote: > sdhci-esdhc-imx does not need SDHCI_QUIRK_NO_CARD_NO_RESET. > Make it OF-specific. Just to make sure, because all the other patches are for mx53: Do you have tested it on mx25/35/51 also? Regards, Wolfram -- Pengutronix e.K.

[PATCH 2/5] ARM: imx51/53: add sdhc3/4 clock

2011-02-21 Thread Richard Zhao
Signed-off-by: Richard Zhao diff --git a/arch/arm/mach-mx5/clock-mx51-mx53.c b/arch/arm/mach-mx5/clock-mx51-mx53.c index 8164b1d..8ac61d5 100644 --- a/arch/arm/mach-mx5/clock-mx51-mx53.c +++ b/arch/arm/mach-mx5/clock-mx51-mx53.c @@ -42,6 +42,7 @@ static struct clk usboh3_clk; static struct clk

[PATCH 3/5] ARM: imx53_loco: add esdhc device support

2011-02-21 Thread Richard Zhao
Signed-off-by: Richard Zhao diff --git a/arch/arm/mach-mx5/Kconfig b/arch/arm/mach-mx5/Kconfig index f065a0d..a72c833 100644 --- a/arch/arm/mach-mx5/Kconfig +++ b/arch/arm/mach-mx5/Kconfig @@ -162,6 +162,7 @@ config MACH_MX53_LOCO select IMX_HAVE_PLATFORM_IMX2_WDT select IMX_HAVE_

[PATCH 4/5] mm: sdhci-esdhc: remove SDHCI_QUIRK_NO_CARD_NO_RESET from ESDHC_DEFAULT_QUIRKS

2011-02-21 Thread Richard Zhao
sdhci-esdhc-imx does not need SDHCI_QUIRK_NO_CARD_NO_RESET. Make it OF-specific. Signed-off-by: Richard Zhu diff --git a/drivers/mmc/host/sdhci-esdhc.h b/drivers/mmc/host/sdhci-esdhc.h index afaf1bc..303cde0 100644 --- a/drivers/mmc/host/sdhci-esdhc.h +++ b/drivers/mmc/host/sdhci-esdhc.h @@ -24,

[PATCH 1/5] ARM: imx53: add sdhc pad settings

2011-02-21 Thread Richard Zhao
Signed-off-by: Richard Zhao diff --git a/arch/arm/plat-mxc/include/mach/iomux-mx53.h b/arch/arm/plat-mxc/include/mach/iomux-mx53.h index bae7fd0..e95d9cb 100644 --- a/arch/arm/plat-mxc/include/mach/iomux-mx53.h +++ b/arch/arm/plat-mxc/include/mach/iomux-mx53.h @@ -27,6 +27,9 @@ #define MX53_U

[PATCH 5/5] mmc: sdhci: add quirk SDHCI_QUIRK_FIX_NO_INT_IN_MULTI_BLK_IO

2011-02-21 Thread Richard Zhao
Fix no INT in MULTI-BLK IO. Signed-off-by: Richard Zhu diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c index 9b82910..2eeb03e 100644 --- a/drivers/mmc/host/sdhci-esdhc-imx.c +++ b/drivers/mmc/host/sdhci-esdhc-imx.c @@ -113,7 +113,10 @@ static int esdhc_pltfm

[PATCH] dw_mmc: set the debounce value and remove duplicated offset

2011-02-21 Thread Jaehoon Chung
This patch is set the debouce value.. This value do not need to be changed with every command. So we set the value in probe function. And DATA register offset is duplicated.. Signed-off-by: Jaehoon Chung Signed-off-by: kyungmin Park --- drivers/mmc/host/dw_mmc.c |3 +++ drivers/mmc/host/dw