On Friday 25 February 2011, Andrei Warkentin wrote:
Yup. I understand :-). That's the strategy I'm going to follow. For
page_size-alignment/splitting I'm looking at the block layer now. Is
that the right approach or should I still submit a (cleaned up) patch
to mmc/card/block.c for that
snip
- if (cpu_is_omap44xx())
- mmc-reg_offset = OMAP4_MMC_REG_OFFSET;
- else
- mmc-reg_offset = 0;
+static struct omap_mmc_platform_data *mmc __initdata;
can you pass this *mmc as another argument to
Hi Kishore,
On 2/24/2011 8:26 PM, Kadiyala, Kishore wrote:
Adding hwmod data for hsmmc device on OMAP2430/OMAP3/OMAP4.
Adapting the omap_hsmmc driver to hwmod framework.
The patch series is based on omap-for-linus and tested on
OMAP2430, OMAP3430SDP OMAP4430SDP.
Also boot tested on
Hi Benoit,
On Fri, Feb 25, 2011 at 6:24 PM, Cousson, Benoit b-cous...@ti.com wrote:
Hi Kishore,
On 2/24/2011 8:26 PM, Kadiyala, Kishore wrote:
Adding hwmod data for hsmmc device on OMAP2430/OMAP3/OMAP4.
Adapting the omap_hsmmc driver to hwmod framework.
The patch series is based on
On 2/25/2011 2:06 PM, Kadiyala, Kishore wrote:
Hi Benoit,
On Fri, Feb 25, 2011 at 6:24 PM, Cousson, Benoitb-cous...@ti.com wrote:
Hi Kishore,
On 2/24/2011 8:26 PM, Kadiyala, Kishore wrote:
Adding hwmod data for hsmmc device on OMAP2430/OMAP3/OMAP4.
Adapting the omap_hsmmc driver to hwmod
Hi Kishore,
On 2/24/2011 8:26 PM, Kadiyala, Kishore wrote:
Add a device attribute to hwmod data of omap2430, omap3, omap4.
Currently the device attribute holds information regarding dual volt MMC card
support by the controller which will be later passed to the host driver via
platform data.
On Fri, Feb 25, 2011 at 6:20 PM, Krishnamoorthy, Balaji T
balaj...@ti.com wrote:
snip
- if (cpu_is_omap44xx())
- mmc-reg_offset = OMAP4_MMC_REG_OFFSET;
- else
- mmc-reg_offset = 0;
+static struct omap_mmc_platform_data
On Fri, Feb 25, 2011 at 07:33:12AM +, Tardy, Pierre wrote:
My understanding is the pci driver is not supposed to do any
set_power_state/pci_save_state/wake_enable.
Everything is supposed to be generically handle by pci frameworks's
runtime_pm impl.
Need confirmation from Rafael.
The
To support MMC aggressive clock gating the driver has to stop the interface
clock, when the .set_ios() method is called with .clock == 0.
Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de
---
Tested on ap4evb and ecovec
drivers/mmc/host/sh_mmcif.c | 10 +-
1 files changed, 5
Adding hwmod data for hsmmc device on OMAP2430/OMAP3/OMAP4.
Adapting the omap_hsmmc driver to hwmod framework.
Omap2420 platform consists of mmc block as in omap1 and not the
hsmmc block as present in omap2430, omap3, omap4 platforms.
The series takes care spliting out the mmc device init for
From: Anand Gadiyar gadi...@ti.com
The MMC controller on the OMAP2420 is different from those
on the OMAP2430, OMAP3 and OMAP4 families - all of the latter
are identical. The one on the OMAP2420 is closer to that
on OMAP1 chips.
Currently, the n8x0 is the only OMAP2420 platform supported
in
Modifying the device driver name from mmci-omap-hs to
omap_hsmmc.
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
Acked-by: Benoit Coussonb-cous...@ti.com
---
arch/arm/mach-omap2/board-2430sdp.c |2 +-
arch/arm/mach-omap2/board-3430sdp.c |6 +++---
From: Anand Gadiyar gadi...@ti.com
Enabling hsmmc hwmod for OMAP4
Signed-off-by: Anand Gadiyar gadi...@ti.com
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
Acked-by: Benoit Coussonb-cous...@ti.com
---
arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 10 +-
1 files changed, 5
Moving the definition of mux setting API from devices.c to hsmmc.c
and renaming it from omap2_mmc_mux to omap_hsmmc_mux.
Also calling omap_hsmmc_mux from omap2_hsmmc_init.
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
Cc: Chris Ball c...@laptop.org
Cc: Tony Lindgren t...@atomide.com
---
Changes involves:
1) Remove controller reset in devices.c which is taken care of
by hwmod framework.
2) Omap2420 platform consists of mmc block as in omap1 and not the
hsmmc block as present in omap2430, omap3, omap4 platforms.
Removing all base address macro defines except keeping one
From: Paul Walmsley p...@pwsan.com
Update the omap2430 hwmod data with the HSMMC info.
Signed-off-by: Paul Walmsley p...@pwsan.com
Signed-off-by: Kevin Hilman khil...@deeprootsystems.com
Signed-off-by: Rajendra Nayak rna...@ti.com
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
Cc:
From: Paul Walmsley p...@pwsan.com
Update the omap3 hwmod data with the HSMMC info.
Signed-off-by: Paul Walmsley p...@pwsan.com
Signed-off-by: Kevin Hilman khil...@deeprootsystems.com
Signed-off-by: Rajendra Nayak rna...@ti.com
Signed-off-by: Kishore Kadiyala kishore.kadiy...@ti.com
Cc: Benoit
Hi Guennadi,
On Fri, Feb 25, 2011 at 04:58:38PM +0100, Guennadi Liakhovetski wrote:
To support MMC aggressive clock gating the driver has to stop the interface
clock, when the .set_ios() method is called with .clock == 0.
Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de
---
On Fri, Feb 25, 2011 at 7:35 AM, Jaehoon Chung jh80.ch...@samsung.com wrote:
Hi..
I didn't understand this point..
Plz let me explain this code..
why need this function (dw_mci_queue_request(host, slot, mrq)?
I don't think there would be any problem merging those two functions.
Also I would
On Fri, Feb 25, 2011 at 2:08 AM, Jaehoon Chung jh80.ch...@samsung.com wrote:
This patch is applied the power control with regulator.
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
Signed-off-by: kyungmin Park kyungmin.p...@samsung.com
---
drivers/mmc/host/dw_mmc.c | 25
Hi Philip,
On Fri, Feb 25, 2011 at 09:54:35AM -0800, Philip Rakity wrote:
Rather then special case busy etc .. lets just use the max value.
OK.
Did not remove BROKEN_TIMEOUT QUIRK so existing code will compile
we can remove this once existing platform drivers delete usage and get
quirk
On Feb 25, 2011, at 10:02 AM, Wolfram Sang wrote:
Hi Philip,
On Fri, Feb 25, 2011 at 09:54:35AM -0800, Philip Rakity wrote:
Rather then special case busy etc .. lets just use the max value.
OK.
Did not remove BROKEN_TIMEOUT QUIRK so existing code will compile
we can remove this
- return count;
+ return 0xE;
Why don't you remove the function entirely?
better to rename it --- to set_maximum_timeout since a little clearer.
left the old name for historical reasons -- if no need I will change it
I'd suggest...
}
static void
On Wed, Feb 23, 2011 at 11:17:43PM +, Chris Ball wrote:
Fixes:
drivers/mmc/host/cb710-mmc.c: In function ‘cb710_wait_while_busy’:
drivers/mmc/host/cb710-mmc.c:182:6: warning: variable ‘err’ set but not
used [-Wunused-but-set-variable]
Signed-off-by: Chris Ball c...@laptop.org
Cc:
v2
use define for max timeout. remove subroutine call and just
set the register directly
v1
The card/host controller may sometimes return a value that is
too low and cause the h/w to timeout a transfer that would have
worked. Using the maximum value avoids this.
Signed-off-by: Philip Rakity
On Friday, February 25, 2011, Matthew Garrett wrote:
On Fri, Feb 25, 2011 at 07:33:12AM +, Tardy, Pierre wrote:
My understanding is the pci driver is not supposed to do any
set_power_state/pci_save_state/wake_enable.
Everything is supposed to be generically handle by pci frameworks's
Eric Benard e...@eukrea.com writes:
Hi Arnaud,
Salut !
On 24/02/2011 12:40, Arnaud Patard (Rtp) wrote:
Wolfram Sangw.s...@pengutronix.de writes:
Hi,
Take #3, changes:
* also intercept calls to SDHCI_SIGNAL_ENABLE (needed on mx25)
* remove unconditional BROKEN_CARD_DETECTION
On Fri, Feb 25, 2011 at 10:49:25AM -0800, Philip Rakity wrote:
v2
use define for max timeout. remove subroutine call and just
set the register directly
The generic description goes above the --- line, the incremental
history of the patch usually below.
v1
The card/host controller may
On Tue, Feb 22, 2011 at 06:13:26PM +0800, Richard Zhu wrote:
Fix the NO INT in the Multi-BLK IO in SD/MMC, and
Multi-BLK read in SDIO
This description is too short. Why does it not work before, and why does
this patch help?
Signed-off-by: Richard Zhu hong-xing@freescale.com
---
* Kishore Kadiyala kishore.kadiy...@ti.com [110225 09:00]:
+static int omap_mmc_init(struct omap_hwmod *oh, void *hsmmcinfo)
...
+ static int mmc_num;
+
+ c += mmc_num;
This does not look right..
Tony
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body
* Tony Lindgren t...@atomide.com [110225 12:42]:
* Kishore Kadiyala kishore.kadiy...@ti.com [110225 09:00]:
+static int omap_mmc_init(struct omap_hwmod *oh, void *hsmmcinfo)
...
+ static int mmc_num;
+
+ c += mmc_num;
This does not look right..
So since mmc_num is static, it
Hi,
On 25/02/2011 20:31, Arnaud Patard (Rtp) wrote:
Eric Benarde...@eukrea.com writes:
may you please test the attached patch. It may give someone with a
better knowledge of sdhci than me an idea of what is wrong.
I've tested this patch on my efikamx and this patch does solve the
issue. I
Hello Kishore,
There are several problems with this data that generate warning messages
on boot on 2430SDP.
Did you actually test this on 2430SDP? The warning messages would have
been obvious in the boot log.
Comments below:
On Fri, 25 Feb 2011, Kishore Kadiyala wrote:
From: Paul Walmsley
Hi Chris,
would you like to take this one, or should we merge it through the OMAP
tree?
- Paul
From: Paul Walmsley p...@pwsan.com
Date: Fri, 25 Feb 2011 18:22:08 -0700
Subject: [PATCH] MMC: omap_hsmmc: enable interface clock before calling
mmc_host_enable()
The code path entered via
Hi Paul,
On Fri, Feb 25, 2011 at 06:26:45PM -0700, Paul Walmsley wrote:
Hi Chris,
would you like to take this one, or should we merge it through the OMAP
tree?
Thanks for asking -- OMAP folks seem to like merging patches to host/*omap*
directly through the OMAP tree, and that's fine with
Hi Chris,
On Sat, 26 Feb 2011, Chris Ball wrote:
Thanks for asking -- OMAP folks seem to like merging patches to host/*omap*
directly through the OMAP tree, and that's fine with me; I don't want to
get in the way of a good workflow with responsive maintainers. I do like
the patches to be
Support multiple sd/eMMC interfaces. enable mmc1, 2, and 3.
mmc2 is used eMMC and slot is marked PERMANENT and 8 bit device.
mmc1 is used for Wifi and slot is marked PERMANENT
Note: eMMC (mmc2) is set to initialize first to workaround a problem
where booting in logical order requires mmc create
37 matches
Mail list logo
