Re: [PATCH] mmc/sdio: remember new card RCA when redetecting card

2011-03-02 Thread Chris Ball
Hi Nico, thanks for the quick reply, On Wed, Mar 02 2011, Nicolas Pitre wrote: > No, I have nothing better to suggest at the moment. Okay. I'll add a comment explaining what's going on. >> And, just to check we're all on the same page, this would be a >> regression introduced back at 2.6.32 whe

Re: [PATCH] mmc/sdio: remember new card RCA when redetecting card

2011-03-02 Thread Nicolas Pitre
On Wed, 2 Mar 2011, Chris Ball wrote: > Hi, > > On Tue, Mar 01 2011, Linus Walleij wrote: > > From: Stefan Nilsson XK > > > > During redetection of a SDIO card, a request for a new card RCA > > was submitted to the card, but was then overwritten by the old RCA. > > This caused the card to be des

Re: [PATCH v6 0/8] OMAP: HSMMC: hwmod adaptation

2011-03-02 Thread Tony Lindgren
* Kevin Hilman [110302 13:14]: > Kishore Kadiyala writes: > > > Adding hwmod data for hsmmc device on OMAP2430/OMAP3/OMAP4. > > Adapting the omap_hsmmc driver to hwmod framework. > > Looks OK to me. > > Reviewed-by: Kevin Hilman Sorry just missed it, got it all merged into omap-for-linus alr

Re: [RFC 2/3] MMC: Add block quirks support.

2011-03-02 Thread Andrei Warkentin
On Wed, Mar 2, 2011 at 3:04 PM, Arnd Bergmann wrote: > On Wednesday 02 March 2011 21:48:25 Andrei Warkentin wrote: > >> > >> > Instead of the dynamic registration, I'd just put all quirks into >> > one file and have an array of them: >> >> Ideally, you'd have the most important workarounds always

Re: [PATCH v6 0/8] OMAP: HSMMC: hwmod adaptation

2011-03-02 Thread Kevin Hilman
Kishore Kadiyala writes: > Adding hwmod data for hsmmc device on OMAP2430/OMAP3/OMAP4. > Adapting the omap_hsmmc driver to hwmod framework. Looks OK to me. Reviewed-by: Kevin Hilman Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to major

Re: [RFC 2/3] MMC: Add block quirks support.

2011-03-02 Thread Arnd Bergmann
On Wednesday 02 March 2011 21:48:25 Andrei Warkentin wrote: > > > > Instead of the dynamic registration, I'd just put all quirks into > > one file and have an array of them: > > Ideally, you'd have the most important workarounds always built in, to > deal with important problems like out-of-spec

Re: [RFC 2/3] MMC: Add block quirks support.

2011-03-02 Thread Andrei Warkentin
On Wed, Mar 2, 2011 at 11:19 AM, Arnd Bergmann wrote: > On Tuesday 01 March 2011, Andrei Warkentin wrote: >> Quirks are card-specific workarounds. Usually they involve >> tuning mmcblk parameters at mmc_blk_probe time, but can >> involve affecting the way mmcblk I/O requests are handled. >> The la

[PATCH] omap-mmc: Fix possible NULL pointer deref

2011-03-02 Thread Michael Buesch
Either OMAP_MMC_STAT_CARD_ERR or OMAP_MMC_STAT_END_OF_CMD might fire if there is no host->cmd pointer. Check for a valid host->cmd pointer before calling mmc_omap_cmd_done(). Signed-off-by: Michael Buesch Acked-by: Tony Lindgren --- Fixes [3.814483] Unable to handle kernel NULL pointer de

Re: [RFC 2/3] MMC: Add block quirks support.

2011-03-02 Thread Arnd Bergmann
On Tuesday 01 March 2011, Andrei Warkentin wrote: > Quirks are card-specific workarounds. Usually they involve > tuning mmcblk parameters at mmc_blk_probe time, but can > involve affecting the way mmcblk I/O requests are handled. > The later is necessary to handle Sandisk out-of-spec discard suppor

Re: [PATCH] mmc/sdio: remember new card RCA when redetecting card

2011-03-02 Thread Chris Ball
Hi, On Tue, Mar 01 2011, Linus Walleij wrote: > From: Stefan Nilsson XK > > During redetection of a SDIO card, a request for a new card RCA > was submitted to the card, but was then overwritten by the old RCA. > This caused the card to be deselected instead of selected when using > the incorrect

Re: [PATCH] mmc/sdio: remember new card RCA when redetecting card

2011-03-02 Thread Linus Walleij
2011/3/1 Linus Walleij : > From: Stefan Nilsson XK > > During redetection of a SDIO card, a request for a new card RCA > was submitted to the card, but was then overwritten by the old RCA. > This caused the card to be deselected instead of selected when using > the incorrect RCA. Chris can you l

Re: [linux-pm] [RFC,PATCHv3 0/3] sdhci runtime_pm implementation

2011-03-02 Thread Alan Stern
On Wed, 2 Mar 2011, Rafael J. Wysocki wrote: > > > How it works is, basically, that when the device signals wakeup, it either > > > causes a PME# signal to be raised (parallel PCI), or a PME Message to be > > > sent upstream (PCIe). In the first case it will cause a platform event > > > (eg. ACPI

Re: [PATCH] tmio: silence warnings introduced by mfd changes

2011-03-02 Thread Samuel Ortiz
Hi Andres, On Tue, Mar 01, 2011 at 12:32:20PM -0800, Andres Salomon wrote: > On Tue, 1 Mar 2011 10:53:22 -0800 > Andres Salomon wrote: > > > On Tue, 1 Mar 2011 15:42:30 +1100 > > Stephen Rothwell wrote: > > > > > Hi Samuel, > > > > > > After merging the mfd tree, today's linux-next build (x86

Re: MMC quirks relating to performance/lifetime.

2011-03-02 Thread Andrei Warkentin
On Tue, Mar 1, 2011 at 1:11 PM, Arnd Bergmann wrote: > On Tuesday 01 March 2011 19:48:17 Jens Axboe wrote: >> >> On 2011-02-25 07:21, Arnd Bergmann wrote: >> > On Friday 25 February 2011, Andrei Warkentin wrote: >> >> Yup. I understand :-).  That's the strategy I'm going to follow. For >> >> page_

Re: Fwd: [RFC] MMC: error handling improvements

2011-03-02 Thread Linus Walleij
Thanks for writing back Murali! 2011/3/1 Murali Krishna Palnati : > Though the bulk of the MSM SDCC controller is designed around PL180, there > are still some modifications to include flow control, SDIO support, We have these fixes in the U300/Ux500 version of MMCI as well, I suspect it's nothi

[PATCH V5 3/6] mmc: add the abort CMDTYE bits definition

2011-03-02 Thread Richard Zhu
Add the abort CMDTYPE bits definition of command register (offset 0xE) Signed-off-by: Richard Zhu --- drivers/mmc/host/sdhci.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h index 6e0969e..25e8bde 100644 --- a/drivers/

[PATCH V5 4/6] mmc: sdhci-esdhc: make the writel/readl as the general APIs

2011-03-02 Thread Richard Zhu
Add one flag to indicate the GPIO CD/WP is enabled or not on imx platforms, and reuse the writel/readl as the general APIs for imx SOCs. Signed-off-by: Richard Zhu --- drivers/mmc/host/sdhci-esdhc-imx.c | 40 ++- 1 files changed, 34 insertions(+), 6 deletions(-)

[PATCH V5 1/6] ARM: imx51/53: add sdhc3/4 clock

2011-03-02 Thread Richard Zhu
Signed-off-by: Richard Zhao --- arch/arm/mach-mx5/clock-mx51-mx53.c | 140 ++- arch/arm/mach-mx5/crm_regs.h|7 ++ 2 files changed, 146 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-mx5/clock-mx51-mx53.c b/arch/arm/mach-mx5/clock-mx51-mx53.

[PATCH V5 5/6] mmc: sdhci-esdhc: enable esdhc on imx53

2011-03-02 Thread Richard Zhu
Fix the NO INT in the Multi-BLK IO in SD/MMC, and Multi-BLK read in SDIO on imx53. The CMDTYPE of the CMD register (offset 0xE) should be set to "11" when the STOP CMD12 is issued on imx53 to abort one open ended multi-blk IO. Otherwise one the TC INT wouldn't be generated. In exact block transfe

[PATCH V5 6/6] ARM: imx53_loco: add esdhc device support

2011-03-02 Thread Richard Zhu
Signed-off-by: Richard Zhao Acked-by: Wolfram Sang --- arch/arm/mach-mx5/Kconfig |1 + arch/arm/mach-mx5/board-mx53_loco.c |2 ++ 2 files changed, 3 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-mx5/Kconfig b/arch/arm/mach-mx5/Kconfig index f065a0d..a72c833 100644 -

[PATCH V5 2/6] mmc: sdhci-esdhc: remove SDHCI_QUIRK_NO_CARD_NO_RESET from ESDHC_DEFAULT_QUIRKS

2011-03-02 Thread Richard Zhu
sdhci-esdhc-imx does not need SDHCI_QUIRK_NO_CARD_NO_RESET. Make it OF-specific. Signed-off-by: Richard Zhu Tested-by: Wolfram Sang --- drivers/mmc/host/sdhci-esdhc.h|3 +-- drivers/mmc/host/sdhci-of-esdhc.c |3 ++- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/driv

RE: [PATCH 02/12] mmc: sd: add support for signal voltage switch procedure

2011-03-02 Thread Nath, Arindam
Hi Subhash, > -Original Message- > From: subha...@codeaurora.org [mailto:subha...@codeaurora.org] > Sent: Tuesday, March 01, 2011 9:33 PM > To: Nath, Arindam; c...@laptop.org > Cc: linux-mmc@vger.kernel.org; Su, Henry; Lu, Aaron; > anath@gmail.com > Subject: RE: [PATCH 02/12] mmc: sd: