RE: [PATCH v2 06/12] mmc: sd: add support for uhs bus speed mode selection

2011-03-20 Thread Subhash Jadavani
> -Original Message- > From: Arindam Nath [mailto:anath@gmail.com] On Behalf Of Arindam > Nath > Sent: Friday, March 04, 2011 5:03 PM > To: c...@laptop.org > Cc: zhangfei@gmail.com; prak...@marvell.com; > subha...@codeaurora.org; linux-mmc@vger.kernel.org; henry...@amd.com; > aaro

[PATCH V7 2/4] mmc: add the abort CMDTYE bits definition

2011-03-20 Thread Richard Zhu
Add the abort CMDTYPE bits definition of command register (offset 0xE) Signed-off-by: Richard Zhu --- drivers/mmc/host/sdhci.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h index 6e0969e..25e8bde 100644 --- a/drivers/

[PATCH V7 0/4] mmc: one comment is missing addressed.

2011-03-20 Thread Richard Zhu
One comment is missing addressed in the previous review round, complement it into this review round. [PATCH V7 1/4] mmc: sdhci-esdhc: remove SDHCI_QUIRK_NO_CARD_NO_RESET from ESDHC_DEFAULT_QUIRKS [PATCH V7 2/4] mmc: add the abort CMDTYE bits definition [PATCH V7 3/4] m

[PATCH V7 3/4] mmc: sdhci-esdhc: make the writel/readl as the general APIs

2011-03-20 Thread Richard Zhu
Add one flag to indicate the GPIO CD/WP is enabled or not on imx platforms, and reuse the writel/readl as the general APIs for imx SOCs. Signed-off-by: Richard Zhu --- drivers/mmc/host/sdhci-esdhc-imx.c | 39 +-- drivers/mmc/host/sdhci-pltfm.h |2 +- 2 f

[PATCH V7 4/4] mmc: sdhci-esdhc: enable esdhc on imx53

2011-03-20 Thread Richard Zhu
Fix the NO INT in the Multi-BLK IO in SD/MMC, and Multi-BLK read in SDIO on imx53. The CMDTYPE of the CMD register (offset 0xE) should be set to "11" when the STOP CMD12 is issued on imx53 to abort one open ended multi-blk IO. Otherwise one the TC INT wouldn't be generated. In exact block transfe

[PATCH V7 1/4] mmc: sdhci-esdhc: remove SDHCI_QUIRK_NO_CARD_NO_RESET from ESDHC_DEFAULT_QUIRKS

2011-03-20 Thread Richard Zhu
sdhci-esdhc-imx does not need SDHCI_QUIRK_NO_CARD_NO_RESET. Make it OF-specific. Signed-off-by: Richard Zhu Tested-by: Wolfram Sang --- drivers/mmc/host/sdhci-esdhc.h|3 +-- drivers/mmc/host/sdhci-of-esdhc.c |3 ++- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/driv

[PATCH V7 4/4] mmc: sdhci-esdhc: enable esdhc on imx53

2011-03-20 Thread Richard Zhu
Fix the NO INT in the Multi-BLK IO in SD/MMC, and Multi-BLK read in SDIO on imx53. The CMDTYPE of the CMD register (offset 0xE) should be set to "11" when the STOP CMD12 is issued on imx53 to abort one open ended multi-blk IO. Otherwise one the TC INT wouldn't be generated. In exact block transfe

[PATCH V7 3/4] mmc: sdhci-esdhc: make the writel/readl as the general APIs

2011-03-20 Thread Richard Zhu
Add one flag to indicate the GPIO CD/WP is enabled or not on imx platforms, and reuse the writel/readl as the general APIs for imx SOCs. Signed-off-by: Richard Zhu --- drivers/mmc/host/sdhci-esdhc-imx.c | 42 ++-- drivers/mmc/host/sdhci-pltfm.h |2 +- 2

[PATCH V7 2/4] mmc: add the abort CMDTYE bits definition

2011-03-20 Thread Richard Zhu
Add the abort CMDTYPE bits definition of command register (offset 0xE) Signed-off-by: Richard Zhu --- drivers/mmc/host/sdhci.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h index 6e0969e..25e8bde 100644 --- a/drivers/

[PATCH V7 1/4] mmc: sdhci-esdhc: remove SDHCI_QUIRK_NO_CARD_NO_RESET from ESDHC_DEFAULT_QUIRKS

2011-03-20 Thread Richard Zhu
sdhci-esdhc-imx does not need SDHCI_QUIRK_NO_CARD_NO_RESET. Make it OF-specific. Signed-off-by: Richard Zhu Tested-by: Wolfram Sang --- drivers/mmc/host/sdhci-esdhc.h|3 +-- drivers/mmc/host/sdhci-of-esdhc.c |3 ++- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/driv

[PATCH V7 0/4] mmc: one comment is missing addressed in the previous review.

2011-03-20 Thread Richard Zhu
One comment is missing addressed in the previous review round, complement it into this review round. [PATCH V7 1/4] mmc: sdhci-esdhc: remove SDHCI_QUIRK_NO_CARD_NO_RESET from ESDHC_DEFAULT_QUIRKS [PATCH V7 2/4] mmc: add the abort CMDTYE bits definition [PATCH V7 3/4] mmc: sdhci-esdhc: make the wr