[PATCH v2] mmc: sdhci: add error checking for mmc_add_host

2011-04-03 Thread Jaehoon Chung
Sometimes we can't add the device,but we didn't check any error status. Need to check error status for mmc_add_host. Signed-off-by: Jaehoon Chung Signed-off-by: kyungmin Park --- drivers/mmc/host/sdhci.c | 14 -- 1 files changed, 12 insertions(+), 2 deletions(-) diff --git a/driv

Re: [PATCH v4 2/3]mmc: enable TRIM/ERASE caps for SDHCI host

2011-04-03 Thread Andrei Warkentin
On Sun, Apr 3, 2011 at 11:06 PM, Andrei Warkentin wrote: > On Sat, Feb 12, 2011 at 12:22 AM, Chuanxiao Dong > wrote: >> SDHCI host controller has TRIM/ERASE capability, enable these caps for >> erasing >> purpose. >> >> ERASE command needs R1B response. So for such command with busy signal, >>

Re: [PATCH] mmc: sdhci: add error checking for mmc_add_host

2011-04-03 Thread Jaehoon Chung
Wolfram Sang wrote: > On Mon, Apr 04, 2011 at 11:48:57AM +0900, Jaehoon Chung wrote: >> Sometimes we can't add the device,but we didn't check any error status. >> Need to check error status for mmc_add_host. > > Thanks, this is correct, but... > >> -mmc_add_host(mmc); >> +ret = mmc_add_ho

Re: [PATCH] mmc: power class support

2011-04-03 Thread Andrei Warkentin
On Fri, Apr 1, 2011 at 7:28 PM, Andrei Warkentin wrote: > Hi Russ, > > On Fri, Apr 1, 2011 at 10:58 AM, Russ Knize wrote: >> +                       /* >> +                        * Ignore switch errors from buggy cards that >> actually >> +                        * do switch successfully. >> +

Re: [PATCH v4 2/3]mmc: enable TRIM/ERASE caps for SDHCI host

2011-04-03 Thread Andrei Warkentin
On Sat, Feb 12, 2011 at 12:22 AM, Chuanxiao Dong wrote: > SDHCI host controller has TRIM/ERASE capability, enable these caps for erasing > purpose. > > ERASE command needs R1B response. So for such command with busy signal, before > sending command, SDHCI host driver will simply set a maximum valu

Re: [PATCH] mmc: sdhci: add error checking for mmc_add_host

2011-04-03 Thread Wolfram Sang
On Mon, Apr 04, 2011 at 11:48:57AM +0900, Jaehoon Chung wrote: > Sometimes we can't add the device,but we didn't check any error status. > Need to check error status for mmc_add_host. Thanks, this is correct, but... > - mmc_add_host(mmc); > + ret = mmc_add_host(mmc); > + if (unlikely(

[PATCH] mmc: sdhci: add error checking for mmc_add_host

2011-04-03 Thread Jaehoon Chung
Sometimes we can't add the device,but we didn't check any error status. Need to check error status for mmc_add_host. Signed-off-by: Jaehoon Chung Signed-off-by: kyungmin Park --- drivers/mmc/host/sdhci.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/

Re: [PATCH v4 2/3]mmc: enable TRIM/ERASE caps for SDHCI host

2011-04-03 Thread Sascha Silbe
Excerpts from Chuanxiao Dong's message of Sat Feb 12 07:22:20 +0100 2011: > SDHCI host controller has TRIM/ERASE capability, enable these caps for erasing > purpose. > > ERASE command needs R1B response. So for such command with busy signal, before > sending command, SDHCI host driver will simply