Re: [PATCH] sdio: optimized SDIO IRQ handling for single function

2011-05-04 Thread Per Forlin
On 4 May 2011 05:40, Nicolas Pitre nicolas.pi...@linaro.org wrote: On Tue, 3 May 2011, Per Forlin wrote: From: Stefan Nilsson XK stefan.xk.nils...@stericsson.com If there is only 1 function registered, and IRQ:s are supported and currently enabled, call the callback handler directly without

RE: Is it possible for the ext4/btrfs file system to pass some context related info to low level block driver?

2011-05-04 Thread Gao, Yunpeng
Hi Park, Thanks a lot for the response. It seems similar with TRIM. So how about to consider TRIM implementation or extend it? Yes, file system set REQ_DISCARD flag to notify block device driver to execute TRIM. And I noticed there's already a flag REQ_META used for file system meta data. But

[PATCH] mmc: add a new quirk for NONREMOVABLE_CARD useful for sdhci-pltfm

2011-05-04 Thread Giuseppe CAVALLARO
STM platforms use the sdhci-pltfm.c driver but, IMO there are some problems when use the eMMC card. --- from sdhci.c file: 1897if ((host-quirks SDHCI_QUIRK_BROKEN_CARD_DETECTION) 1898 mmc_card_is_removable(mmc)) 1899 mmc-caps |= MMC_CAP_NEEDS_POLL; [snip]

Re: [PATCH] mmc: mmc_add_card(): fix missing break in switch statement

2011-05-04 Thread Michał Mirosław
On Tue, May 03, 2011 at 05:00:03PM +0530, Prashanth Bhat wrote: To be more specific, I would think that the code change required in include/linux/mmc/card.h is: #define mmc_card_mmc(c) ((c)-type == MMC_TYPE_MMC) - #define mmc_card_sd(c) ((c)-type == MMC_TYPE_SD) - #define

RE: Is it possible for the ext4/btrfs file system to pass some context related info to low level block driver?

2011-05-04 Thread Gao, Yunpeng
Yes, I have been working on some changes that allow us to tag bios and pass the information out to storage. These patches have been on the back burner for a while due to other commitments. But I'll dig them out and post them later. We just discussed them a couple of weeks ago at the Linux Storage

Re: mmc blkqueue is empty even if there are pending reads in do_generic_file_read()

2011-05-04 Thread Arnd Bergmann
On Tuesday 03 May 2011, Per Forlin wrote: submitting small 512 byte read requests is a real problem when the underlying page size is 16 KB. If your interpretation is right, we should probably find a way to make it read larger chunks on flash media. Sorry a typo. I missed out a k :) It

Re: Is it possible for the ext4/btrfs file system to pass some context related info to low level block driver?

2011-05-04 Thread Andreas Dilger
On 2011-05-04, at 5:45 AM, Gao, Yunpeng yunpeng@intel.com wrote: Yes, I have been working on some changes that allow us to tag bios and pass the information out to storage. These patches have been on the back burner for a while due to other commitments. But I'll dig them out and post them

Re: [PATCH] sdio: optimized SDIO IRQ handling for single function

2011-05-04 Thread Nicolas Pitre
On Wed, 4 May 2011, Per Forlin wrote: On 4 May 2011 05:40, Nicolas Pitre nicolas.pi...@linaro.org wrote: On Tue, 3 May 2011, Per Forlin wrote: From: Stefan Nilsson XK stefan.xk.nils...@stericsson.com If there is only 1 function registered, and IRQ:s are supported and currently

Re: [PATCH] sdio: optimized SDIO IRQ handling for single function

2011-05-04 Thread Per Forlin
On 4 May 2011 17:20, Nicolas Pitre nicolas.pi...@linaro.org wrote: On Wed, 4 May 2011, Per Forlin wrote: On 4 May 2011 05:40, Nicolas Pitre nicolas.pi...@linaro.org wrote: On Tue, 3 May 2011, Per Forlin wrote: From: Stefan Nilsson XK stefan.xk.nils...@stericsson.com If there is only 1

[PATCH v2] sdio: optimized SDIO IRQ handling for single irq

2011-05-04 Thread Per Forlin
Optimize performance for single irq Changes since v1. * Add member to hold sdio_single_irq function in mmc_card and minimize new code in process_sdio_pending_irqs * Clarify commit message Stefan Nilsson XK (1): sdio: optimized SDIO IRQ handling for single irq drivers/mmc/core/sdio_irq.c

[PATCH v2] sdio: optimized SDIO IRQ handling for single irq

2011-05-04 Thread Per Forlin
From: Stefan Nilsson XK stefan.xk.nils...@stericsson.com If there is only 1 function registered it is possible to improve performance by directly calling the irq handler and avoiding the overhead of reading the CCCR registers. Signed-off-by: Per Forlin per.for...@linaro.org Acked-by: Ulf Hansson

Re: [PATCH v2] sdio: optimized SDIO IRQ handling for single irq

2011-05-04 Thread Michał Mirosław
2011/5/4 Per Forlin per.for...@linaro.org: From: Stefan Nilsson XK stefan.xk.nils...@stericsson.com If there is only 1 function registered it is possible to improve performance by directly calling the irq handler and avoiding the overhead of reading the CCCR registers. [...] ---

Re: [PATCH] mmc: mmc_add_card(): fix missing break in switch statement

2011-05-04 Thread Prashanth Bhat
Interesting coincidence that the value of MMC_TYPE_SD and MMC_TYPE_SDIO and MMC_TYPE_SD_COMBO have the relationship that SD_COMBO is the bitwise OR of the other two. However, this seems to be more of a coincidence than intentional. The #defines were clearly meant to be numeric values rather

Re: [PATCH] mmc: mmc_add_card(): fix missing break in switch statement

2011-05-04 Thread Michał Mirosław
On Wed, May 04, 2011 at 10:06:20PM +0530, Prashanth Bhat wrote: On Wednesday 04 May 2011 04:53 PM, Michał Mirosław wrote: On Tue, May 03, 2011 at 05:00:03PM +0530, Prashanth Bhat wrote: To be more specific, I would think that the code change required in include/linux/mmc/card.h is: #define

Re: [PATCH v2] sdio: optimized SDIO IRQ handling for single irq

2011-05-04 Thread Per Forlin
2011/5/4 Michał Mirosław mir...@gmail.com: 2011/5/4 Per Forlin per.for...@linaro.org: From: Stefan Nilsson XK stefan.xk.nils...@stericsson.com If there is only 1 function registered it is possible to improve performance by directly calling the irq handler and avoiding the overhead of reading

Re: [PATCH v2] sdio: optimized SDIO IRQ handling for single irq

2011-05-04 Thread Nicolas Pitre
On Wed, 4 May 2011, Per Forlin wrote: From: Stefan Nilsson XK stefan.xk.nils...@stericsson.com If there is only 1 function registered it is possible to improve performance by directly calling the irq handler and avoiding the overhead of reading the CCCR registers. Signed-off-by: Per

Re: [PATCH v2] sdio: optimized SDIO IRQ handling for single irq

2011-05-04 Thread Nicolas Pitre
On Wed, 4 May 2011, Per Forlin wrote: 2011/5/4 Michał Mirosław mir...@gmail.com: 2011/5/4 Per Forlin per.for...@linaro.org: From: Stefan Nilsson XK stefan.xk.nils...@stericsson.com If there is only 1 function registered it is possible to improve performance by directly calling the irq

Re: mmc blkqueue is empty even if there are pending reads in do_generic_file_read()

2011-05-04 Thread Per Forlin
On 3 May 2011 22:02, Arnd Bergmann a...@arndb.de wrote: On Tuesday 03 May 2011 20:54:43 Per Forlin wrote: page_not_up_to_date: /* Get exclusive access to the page ... */ error = lock_page_killable(page); I looked at the code in do_generic_file_read(). lock_page_killable waits until the

Re: [PATCH v2] sdio: optimized SDIO IRQ handling for single irq

2011-05-04 Thread Per Forlin
On 4 May 2011 19:34, Nicolas Pitre nicolas.pi...@linaro.org wrote: On Wed, 4 May 2011, Per Forlin wrote: From: Stefan Nilsson XK stefan.xk.nils...@stericsson.com If there is only 1 function registered it is possible to improve performance by directly calling the irq handler and avoiding the

Re: [PATCH v2] sdio: optimized SDIO IRQ handling for single irq

2011-05-04 Thread Nicolas Pitre
On Wed, 4 May 2011, Per Forlin wrote: On 4 May 2011 19:34, Nicolas Pitre nicolas.pi...@linaro.org wrote: On Wed, 4 May 2011, Per Forlin wrote: From: Stefan Nilsson XK stefan.xk.nils...@stericsson.com If there is only 1 function registered it is possible to improve performance by

Re: DRIVERS MMC card freezes at Jmicron controllers.

2011-05-04 Thread Chris Ball
Hi Alexandre, adding linux-mmc@ to CC. (EOF) On Wed, May 04 2011, Alexandre Felipe Muller de Souza wrote: Hi, all. I wrote an email minutes ago and I think it could be delivered missing half of the content for mistake using email editor. Sorry for that We have users, reporting problems with