On Fri, May 06, 2011 at 01:02:30PM +0200, Guennadi Liakhovetski wrote:
> This is just a rebase of patches from Magnus, based on earlier patches by
> Simon, on top of my PM patch from yesterday [1] with some minor
> improvements.
Now all three of us have posted versions of this series :^)
Review
On Friday, May 06, 2011, Guennadi Liakhovetski wrote:
> On Thu, 5 May 2011, Rafael J. Wysocki wrote:
>
> > On Thursday, May 05, 2011, Guennadi Liakhovetski wrote:
> > > Adding support for runtime power-management to the MMCIF driver allows
> > > it to save power as long as no card is present. To a
On Fri, 22 Apr 2011 14:43:11 +0200
Antonio Ospite wrote:
> Add support for powering up SD cards driven by regulators.
> This makes the mmc_spi driver work also with the Motorola A910 phone.
>
> Signed-off-by: Antonio Ospite
> ---
>
> Changes since v1:
> - Remove the ifdef CONFIG_REGULATOR as
Hi,
On Fri, May 6, 2011 at 14:44, Adrian Hunter wrote:
> After a warm restart, an eMMC which cannot be powered off is
> in an unknown state, so reset it to be sure it will initialize.
>
> Signed-off-by: Adrian Hunter
> ---
> drivers/mmc/host/omap_hsmmc.c | 38 +
On Fri, May 6, 2011 at 2:34 PM, Varadarajan, Charulatha wrote:
> On Fri, May 6, 2011 at 14:44, Adrian Hunter wrote:
>> From: Andy Shevchenko
>>
>
> Add patch description here.
You mean something like following:
"The code contains similarities in the error path of probe function.
Let's combine th
On Fri, May 6, 2011 at 14:44, Adrian Hunter wrote:
> From: Andy Shevchenko
>
Add patch description here.
> Signed-off-by: Andy Shevchenko
> Signed-off-by: Adrian Hunter
> ---
> drivers/mmc/host/omap_hsmmc.c | 17 ++---
> 1 files changed, 6 insertions(+), 11 deletions(-)
>
<>
-
From: Magnus Damm
Convert the SDHI code to support more than a single
interrupt source. Needed to support hardware that
uses GIC instead of INTC as interrupt controller.
Will also allow us to remove the irq forwarding
workaround from the INTC code in the future.
Signed-off-by: Simon Horman
Sig
From: Magnus Damm
Instead of printing out useless information such
as the virtual base address and one of 4 interrupts,
convert the SDHI probe() to print out physical base
address together with clock rate.
We do have a struct device so make use of dev_info().
Signed-off-by: Magnus Damm
Signed-
This is just a rebase of patches from Magnus, based on earlier patches by
Simon, on top of my PM patch from yesterday [1] with some minor
improvements.
Thanks
Guennadi
[1] http://article.gmane.org/gmane.linux.kernel.mmc/7836
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Devel
From: Magnus Damm
Modify the SDHI driver to get rid of unwanted irq flags.
IRQF_DISABLED unused, see include/linux/interrupt.h
IRQF_TRIGGER_FALLING only relevant on external IRQ pins,
but since SDHI is internal in the SoC this can go away.
Needed to support SDHI on sh73a0 that comes with a GIC
From: Magnus Damm
Move request_irq()/free_irq() from the shared code
in tmio_mmc.c into the SDHI/tmio specific portion
in sh_mobile_sdhi.c and tmio_mmc_pio.c.
This is ground work to allow us to adjust the SDHI
code with IRQ flags and number of interupt sources.
Signed-off-by: Magnus Damm
Signe
On Thu, May 5, 2011 at 2:49 AM, Arindam Nath wrote:
> This patch adds support for setting UHS-I bus speed mode during UHS-I
> initialization procedure. Since both the host and card can support
> more than one bus speed, we select the highest speed based on both of
> their capabilities. First we se
On Thu, May 5, 2011 at 2:49 AM, Arindam Nath wrote:
> Host Controller v3.00 can support retuning modes 1,2 or 3 depending on
> the bits 46-47 of the Capabilities register. Also, the timer count for
> retuning is indicated by bits 40-43 of the same register. We initialize
> timer_list for retuning
On Thu, May 5, 2011 at 2:49 AM, Arindam Nath wrote:
> Host Controller v3.00 supports programmable clock mode as an optional
> feature. The support for this mode is indicated by non-zero value in
> bits 48-55 of the Capabilities register. If supported, the actual
> value of Clock Multiplier is one
On Thu, May 5, 2011 at 2:49 AM, Arindam Nath wrote:
> According to the Host Controller spec v3.00, setting Preset Value Enable
> in the Host Control2 register lets SDCLK Frequency Select, Clock Generator
> Select and Driver Strength Select to be set automatically by the Host
> Controller based on
On Thu, May 5, 2011 at 2:49 AM, Arindam Nath wrote:
> Host Controller needs tuning during initialization to operate SDR50
> and SDR104 UHS-I cards. Whether SDR50 mode actually needs tuning is
> indicated by bit 45 of the Host Controller Capabilities register.
> A new command CMD19 has been defined
On Thu, May 5, 2011 at 2:49 AM, Arindam Nath wrote:
> Since only UHS-I cards respond with S18A set in response to ACMD41,
> we set the card as ultra-high-speed after successfull initialization.
> We need to decide whether a card is SDXC based on the C_SIZE field
> of CSDv2.0 register. According to
On Thu, May 5, 2011 at 2:49 AM, Arindam Nath wrote:
> We decide on the current limit to be set for the card based on the
> Capability of Host Controller to provide current at 1.8V signalling,
> and the maximum current limit of the card as indicated by CMD6
> mode 0. We then set the current limit f
On Thu, May 5, 2011 at 2:49 AM, Arindam Nath wrote:
> As per Host Controller spec v3.00, we reset SDCLK before setting
> High Speed Enable, and then set it back to avoid generating clock
> gliches. Before enabling SDCLK again, we make sure the clock is
> stable, so we use sdhci_set_clock().
>
> Si
On Thu, May 5, 2011 at 2:48 AM, Arindam Nath wrote:
> This patch adds support for setting driver strength during UHS-I
> initialization prcedure. Since UHS-I cards set S18A (bit 24) in
> response to ACMD41, we use this as a base for UHS-I initialization.
> We modify the parameter list of mmc_sd_ge
On Thu, May 5, 2011 at 2:48 AM, Arindam Nath wrote:
> SD cards which conform to Physical Layer Spec v3.01 can support
> additional Bus Speed Modes, Driver Strength, and Current Limit
> other than the default values. We use CMD6 mode 0 to read these
> additional card functions. The values read here
On Thu, May 5, 2011 at 2:48 AM, Arindam Nath wrote:
> Host Controller v3.00 adds another Capabilities register. Apart
> from other things, this new register indicates whether the Host
> Controller supports SDR50, SDR104, and DDR50 UHS-I modes. The spec
> doesn't mention about explicit support for
This patch added mmc_power_off after mmc_attach_sd()
i found that didn't detect the second card insert.(using SDHCI)
you can see the below log.
i want to know that somebody know this issue...
->first card inserted (correct card detect)
# mmc1: new SDHC card at address e624
mmcblk1: mmc1:e624 SU0
From: Andy Shevchenko
We should like to adjust MMC host controller clock whenever the OPP is changed.
OPP affects to L3/L4 bus frequency. Due to this we update the maximum frequency
limits before each upcoming request and when the divisor is calculated.
Signed-off-by: Andy Shevchenko
Signed-off
After a warm restart, an eMMC which cannot be powered off is
in an unknown state, so reset it to be sure it will initialize.
Signed-off-by: Adrian Hunter
---
drivers/mmc/host/omap_hsmmc.c | 38 +-
1 files changed, 37 insertions(+), 1 deletions(-)
diff --git
From: Andy Shevchenko
There are 3 new platform data methods which should help us to do a clock
switching when notification is happened or request is started.
The purpose of the patch is to avoid high frequency of MMC controller on low
OPPs due to an HW bug in OMAP 3630.
The algorithm:
- the PM
From: Andy Shevchenko
There are few places with the same functionality. This patch creates two
functions omap_hsmmc_set_bus_width() and omap_hsmmc_set_bus_mode() to do the
job.
Signed-off-by: Andy Shevchenko
Signed-off-by: Adrian Hunter
---
drivers/mmc/host/omap_hsmmc.c | 85 +++
From: Jarkko Lavinen
Allow the bootloader do all the muxing.
Signed-off-by: Jarkko Lavinen
Signed-off-by: Adrian Hunter
---
arch/arm/mach-omap2/hsmmc.c |3 ++-
arch/arm/mach-omap2/hsmmc.h |1 +
2 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/hsmmc.c
From: Andy Shevchenko
Move the min and max frequency constants to the definition block in the source
file.
Signed-off-by: Andy Shevchenko
Signed-off-by: Adrian Hunter
---
drivers/mmc/host/omap_hsmmc.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/ho
eMMC may have a hardware reset line connected to a gpio,
so pass it to the driver.
Signed-off-by: Adrian Hunter
---
arch/arm/mach-omap2/hsmmc.c |5 +
arch/arm/mach-omap2/hsmmc.h |1 +
arch/arm/plat-omap/include/plat/mmc.h |1 +
3 files changed, 7 insertions(+)
From: Sudhir Bera
In fact the no_off check here will not be hit because
'omap_hsmmc_disabled_to_sleep()' won't schedule a
deeper disable in the no_off case.
Signed-off-by: Sudhir Bera
Signed-off-by: Adrian Hunter
---
drivers/mmc/host/omap_hsmmc.c | 10 --
1 files changed, 4 insertio
CERR and BADA were in the wrong place and there are only
32 not 35.
Signed-off-by: Adrian Hunter
Reviewed-by: Venkatraman S
---
drivers/mmc/host/omap_hsmmc.c | 19 +++
1 files changed, 11 insertions(+), 8 deletions(-)
diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/h
Hi
Here is V2 of some patches for omap_hsmmc.
Changes in V2:
OMAP: sDMA: descriptor autoloading feature
- removed the feature entirely as per Tony Lindgren
mmc: omap_hsmmc: fix few bugs when set the clock divisor
- added cpu_relax() as per Grazvyd
From: Andy Shevchenko
There is similar piece of code in two functions which enables clock. Split this
code to omap_hsmmc_start_clock(). Re-use omap_hsmmc_stop_clock() in
omap_hsmmc_context_restore() as well.
Signed-off-by: Andy Shevchenko
Signed-off-by: Adrian Hunter
---
drivers/mmc/host/omap
From: Andy Shevchenko
There are two places where the same calculations are done. Let's split them to
separate function.
In addition the new function is simplified by usage DIV_ROUND_UP kernel macro.
Signed-off-by: Andy Shevchenko
Signed-off-by: Adrian Hunter
---
drivers/mmc/host/omap_hsmmc.c
From: Andy Shevchenko
There are two pieces of code which similar, but not the same. Each of them
contains a bug.
The SYSCTL register should be read before write in the
omap_hsmmc_context_restore() to remain the state of the reserved bits.
Before set the clock divisor and DTO bits the value from
In the case of an I/O error, the DMA will have been
cleaned up in the MMC interrupt and the request
structure pointer will be null.
In that case, it is essential to check if the DMA
DMA is over before dereferencing host->mrq->data.
Oops as follows:
<3>[ 2293.695281] wl1271: ERROR sdio read faile
Let the bootloader do all the pad configuration.
Signed-off-by: Adrian Hunter
---
arch/arm/mach-omap2/board-rm680.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/board-rm680.c
b/arch/arm/mach-omap2/board-rm680.c
index 42d10b1..c4e821f 100644
--- a/
Go through the driver's set_power() functions rather than
calling regulator_enable/disable() directly because otherwise
pbias configuration for MMC1 is not done.
Signed-off-by: Adrian Hunter
---
drivers/mmc/host/omap_hsmmc.c | 17 -
1 files changed, 8 insertions(+), 9 deletions
From: Andy Shevchenko
Signed-off-by: Andy Shevchenko
Signed-off-by: Adrian Hunter
---
drivers/mmc/host/omap_hsmmc.c | 17 ++---
1 files changed, 6 insertions(+), 11 deletions(-)
diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index c8aab47..3121293 100
On Thu, 5 May 2011, Rafael J. Wysocki wrote:
> On Thursday, May 05, 2011, Guennadi Liakhovetski wrote:
> > Adding support for runtime power-management to the MMCIF driver allows
> > it to save power as long as no card is present. To also allow to turn
> > off the power domain at that time, we rele
Hello Shawn,
On Thu, May 05, 2011 at 09:22:58PM +0800, Shawn Guo wrote:
> Signed-off-by: Shawn Guo
> ---
> .../plat-mxc/devices/platform-sdhci-esdhc-imx.c|1 -
> arch/arm/plat-mxc/include/mach/devices-common.h|2 +-
what about removing arch/arm/plat-mxc/include/mach/esdhc.h in thi
On Thu, May 5, 2011 at 5:21 PM, Adrian Hunter wrote:
> CERR and BADA were in the wrong place and there are only
> 32 not 35.
>
> Signed-off-by: Adrian Hunter
> ---
> drivers/mmc/host/omap_hsmmc.c | 19 +++
> 1 files changed, 11 insertions(+), 8 deletions(-)
>
> diff --git a/dri
43 matches
Mail list logo
