Re: [PATCH 2/2] sdhci-pxa: add call back interface to share sdhci-pxa

2011-05-13 Thread zhangfei gao
On Fri, May 13, 2011 at 9:47 PM, Chris Ball wrote: > Hi, > > On Thu, May 12 2011, Philip Rakity wrote: >> All other platform specific code is in the host/ directory. >> >> This moves it to arch/arm >> >> If that is the direction the group wants to go in --> then the patch >> is fine provided the m

Re: [PATCH] mmc: duplicated trial with same freq when mmc_rescan_try_freq()

2011-05-13 Thread Chris Ball
Hi Jaehoon, On Thu, May 12 2011, Jaehoon Chung wrote: > when running mmc_rescan_try_freq(), try to init two times with last frequency. > For example, assume that host->f_min is 400KHz, we can find the below message. > > mmc1: mmc_rescan_try_freq: trying to init card at 40 Hz > mmc1: mmc_rescan

Re: [PATCH] mmc: duplicated trial with same freq when mmc_rescan_try_freq()

2011-05-13 Thread Andy Ross
On 05/12/2011 07:16 PM, Jaehoon Chung wrote: > In other words, first init card with 400KHZ, > but second/third to init with 300KHz. > i think not necessary that try to initialize the two times with 300KHz. This sounds like a correct patch to me. Presumably the board I was using had a f_min that

Re: [PATCH 2/2] sdhci-pxa: add call back interface to share sdhci-pxa

2011-05-13 Thread Chris Ball
Hi, On Thu, May 12 2011, Philip Rakity wrote: > All other platform specific code is in the host/ directory. > > This moves it to arch/arm > > If that is the direction the group wants to go in --> then the patch > is fine provided the mmc group can review the patches. Otherwise they > are handled

Re: [PATCH v2 0/4] eMMC DDR support

2011-05-13 Thread Chris Ball
Hi Arindam, On Fri, May 13 2011, Arindam Nath wrote: > V2 > > [PATCH 1/4]: Fixed tabbing for comment. > [PATCH 2/4]: Use switch-case instead of if-else. > [PATCH 3/4]: Use bool type for argument *cmd11* instead of int. > > Philip Rakity (4): > [PATCH 1/4]: sdhci add hooks for UHS setting by

Re: [PATCH v4 12/15] sdhci pxa add platform specific code for UHS signaling

2011-05-13 Thread zhangfei gao
On Wed, May 11, 2011 at 5:47 AM, Philip Rakity wrote: > > On May 11, 2011, at 2:28 AM, zhangfei gao wrote: > >> On Wed, May 11, 2011 at 4:52 AM, Philip Rakity wrote: >>> >>> \ >>> On May 11, 2011, at 1:48 AM, zhangfei gao wrote: >>> On Thu, May 5, 2011 at 2:49 AM, Arindam Nath wrote: >