Re: [PATCH 2/2] mmc: sdhci: Replace SDHCI_QUIRK_NO_MULTIBLOCK with a platform hook.

2011-05-28 Thread Chris Ball
Hi, On Sun, Feb 06 2011, Chris Ball wrote: > Part of a quirk cleanup run. This quirk was only used by sdhci-esdhc. > This patch is untested. > > Signed-off-by: Chris Ball > Cc: Anton Vorontsov > Cc: Wolfram Sang I've queued this patch now, since we're out of quirk bits and didn't come up with

Re: [PATCH 1/2] mmc: sdhci: Replace SDHCI_QUIRK_FORCE_BLK_SZ_2048 with a pklatform hook.

2011-05-28 Thread Chris Ball
Hi, On Sun, Feb 06 2011, Chris Ball wrote: > Part of a quirk cleanup run. This quirk was only used by sdhci-esdhc. > This patch is untested. > > Signed-off-by: Chris Ball > Cc: Anton Vorontsov > Cc: Wolfram Sang I've queued this patch now, since we're out of quirk bits and didn't come up with

Possible bug in sdio.c?

2011-05-28 Thread Prashanth Bhat
Hi MichaƂ, In mmc/core/sdio.c, routine mmc_enable_4bit_bus(): I think: if (card->type == MMC_TYPE_SDIO) return sdio_enable_wide(card); should really be: if (card->type == MMC_TYPE_SDIO || card->type == MMC_TYPE_SD_COMBO ) return sdio_enable_wide(card); Ot

Re: [PATCH] mmc: support sdhci-mmp2

2011-05-28 Thread Arnd Bergmann
On Saturday 28 May 2011 18:25:00 Philip Rakity wrote: > On May 28, 2011, at 1:52 AM, Arnd Bergmann wrote: > > I would actually prefer in general if the Kconfig file listed only > > the strictly necessary dependencies for building the driver. > > If this driver can be built anywhere, I would list no

Re: [PATCH] mmc: support sdhci-mmp2

2011-05-28 Thread Philip Rakity
On May 28, 2011, at 1:52 AM, Arnd Bergmann wrote: > On Saturday 28 May 2011 07:00:38 Philip Rakity wrote: >> In some sense all of this is backwards. Once the SoC is known (pxa910 or >> mmp2), >> it knows that SDHCI controller it supports. It should set a config option >> like USES_MRVL_V3_SD_C

Re: [PATCH] mmc: support sdhci-mmp2

2011-05-28 Thread Arnd Bergmann
On Saturday 28 May 2011 07:00:38 Philip Rakity wrote: > In some sense all of this is backwards. Once the SoC is known (pxa910 or > mmp2), > it knows that SDHCI controller it supports. It should set a config option > like USES_MRVL_V3_SD_CONTROLLER. The Kconfig entry in mmc/host should > depend