Re: [PATCH 1/2] mmc: sdhci: Replace SDHCI_QUIRK_FORCE_BLK_SZ_2048 with a platform hook.

2011-05-31 Thread Chris Ball
Hi Wolfram, Nico, On Wed, Jun 01 2011, Wolfram Sang wrote: > :( I still like the io-accessor-method a lot better. That's okay -- nothing's final yet, I just wanted to get things moving again since we're out of quirk space now. I'm still happy to take a patch from you instead if we decide it's th

Re: [PATCH 1/2] mmc: sdhci: Replace SDHCI_QUIRK_FORCE_BLK_SZ_2048 with a pklatform hook.

2011-05-31 Thread Wolfram Sang
On Sat, May 28, 2011 at 10:27:41PM -0400, Chris Ball wrote: > Hi, > > On Sun, Feb 06 2011, Chris Ball wrote: > > Part of a quirk cleanup run. This quirk was only used by sdhci-esdhc. > > This patch is untested. > > > > Signed-off-by: Chris Ball > > Cc: Anton Vorontsov > > Cc: Wolfram Sang > >

Re: [PATCH 0/2] sdio: make sdio_single_irq optional due to suprious IRQ

2011-05-31 Thread Daniel Drake
On 31 May 2011 21:33, Per Forlin wrote: > Daniel Drake reported an issue in the libertas sdio client that was > triggered by the sdio_single_irq functionality. His SDIO device seems to > raise an interrupt even though there are no bits set in the CCCR_INTx > register. This behaviour is not support

[PATCH 2/2] sdio: report error if pending IRQ but none function bits

2011-05-31 Thread Per Forlin
Return error in case of pending IRQ but none functions bits in CCCR_INTx is set. Signed-off-by: Per Forlin --- drivers/mmc/core/sdio_irq.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/mmc/core/sdio_irq.c b/drivers/mmc/core/sdio_irq.c index 2f81ddc..8184b6e

[PATCH 1/2] sdio: add function to enable and disable sdio_single_irq optimization

2011-05-31 Thread Per Forlin
Make sdio single irq run time configurable, default is disable. This is due to an issue in libertas where the SDIO device seems to raise interrupt even if there are none function bits in CCCR_INTx set. This behaviour is not defined by the SDIO spec. Signed-off-by: Per Forlin --- drivers/mmc/core

[PATCH 0/2] sdio: make sdio_single_irq optional due to suprious IRQ

2011-05-31 Thread Per Forlin
Daniel Drake reported an issue in the libertas sdio client that was triggered by the sdio_single_irq functionality. His SDIO device seems to raise an interrupt even though there are no bits set in the CCCR_INTx register. This behaviour is not supported by the sdio_single_irq feature nor the SDIO sp

Re: [PATCH V2] mmc: eMMC bus width may not work on all platforms

2011-05-31 Thread Philip Rakity
Chris, Just tested the mod on brownstone. Works. Philip On May 24, 2011, at 6:14 PM, Philip Rakity wrote: > > resend > > Note: I cannot test test for a few days. Following Chris > suggestion posting to list. > > version 2 > --- > return -EINVAL when compare of ext_csd_fails > combine tw

Re: [PATCH] mmc: support sdhci-mmp2

2011-05-31 Thread Philip Rakity
Hi Zhangfei, It is probably better to NOT name the file sdhci-mmp2.c but something like sdchi-pxaV3.c since other SoC's may use this controller. >>> fine >> >> The same renaming change is needed for the pxa9xx patch. > Do you mean use sdhci-pxa9xx.c to replace sdhci-pxa910.c, px

Re: [PATCH] mmc: Enable MMC card reader for RICOH [1180:e823]

2011-05-31 Thread Chris Ball
Hi, On Tue, May 31 2011, Manoj Iyer wrote: >> Do you not need a corresponding entry in drivers/mmc/host/sdhci-pci.c's >> pci_device_id struct? > > I believe there is an entry there already, introduced by this patch: > https://lkml.org/lkml/2011/2/11/309 I see, thanks; patch is queued for 3.0 with

Re: SDIO single IRQ optimization breaks libertas

2011-05-31 Thread Per Forlin
On 30 May 2011 16:38, Nicolas Pitre wrote: > On Mon, 30 May 2011, Per Forlin wrote: > >> Hi Daniel, >> >> > >> > On 29 May 2011 15:26, Daniel Drake laptop.org> wrote: >> > > Hi, >> > > >> > > The following commit in 2.6.39 causes instant death for libertas_sdio >> > > when it receives its first i

Re: [PATCH] mmc: Enable MMC card reader for RICOH [1180:e823]

2011-05-31 Thread Manoj Iyer
On Thu, 26 May 2011, Chris Ball wrote: Hi Manoj, On Thu, May 26 2011, Manoj Iyer wrote: Signed-off-by: Manoj Iyer --- drivers/pci/quirks.c|2 ++ include/linux/pci_ids.h |1 + 2 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks

Re: [PATCH 2/2] ARM: OMAP4: MMC: no regulator off during probe for eMMC

2011-05-31 Thread Kishore Kadiyala
On Mon, May 30, 2011 at 7:55 PM, Balaji T K wrote: > eMMC does not handle power off when not in sleep state, > Skip regulator disable during probe when eMMC is > not in known state - state left by bootloader. > > Resolves eMMC failure on OMAP4 > mmc0: error -110 whilst initialising MMC card > > Si

Re: [PATCH 1/2] ARM: OMAP4: MMC: increase delay for pbias

2011-05-31 Thread Kishore Kadiyala
On Mon, May 30, 2011 at 7:55 PM, Balaji T K wrote: > 4 micro seconds is not enough for PBIAS if MMC regulator is > enabled from MMC regulator OFF. > Increase the delay for PBIAS to stabilize. > Wait for PBIAS and timeout if not. > > Resolves MMC/SD failure on OMAP4 > "Pbias Voltage is not same as

Re: [PATCH 2/2] ARM: OMAP4: MMC: no regulator off during probe for eMMC

2011-05-31 Thread Tony Lindgren
* T Krishnamoorthy, Balaji [110531 06:28]: > On Tue, May 31, 2011 at 6:56 PM, Tony Lindgren wrote: > > * Balaji T K [110530 07:23]: > >> eMMC does not handle power off when not in sleep state, > >> Skip regulator disable during probe when eMMC is > >> not in known state - state left by bootloade

Re: [PATCH 2/2] ARM: OMAP4: MMC: no regulator off during probe for eMMC

2011-05-31 Thread T Krishnamoorthy, Balaji
On Tue, May 31, 2011 at 6:56 PM, Tony Lindgren wrote: > * Balaji T K [110530 07:23]: >> eMMC does not handle power off when not in sleep state, >> Skip regulator disable during probe when eMMC is >> not in known state - state left by bootloader. >> >> Resolves eMMC failure on OMAP4 >> mmc0: error

Re: [PATCH 1/2] ARM: OMAP4: MMC: increase delay for pbias

2011-05-31 Thread Tony Lindgren
* Balaji T K [110530 07:23]: > 4 micro seconds is not enough for PBIAS if MMC regulator is > enabled from MMC regulator OFF. > Increase the delay for PBIAS to stabilize. > Wait for PBIAS and timeout if not. > > Resolves MMC/SD failure on OMAP4 > "Pbias Voltage is not same as LDO" Thanks will que

Re: [PATCH 2/2] ARM: OMAP4: MMC: no regulator off during probe for eMMC

2011-05-31 Thread Tony Lindgren
* Balaji T K [110530 07:23]: > eMMC does not handle power off when not in sleep state, > Skip regulator disable during probe when eMMC is > not in known state - state left by bootloader. > > Resolves eMMC failure on OMAP4 > mmc0: error -110 whilst initialising MMC card > > --- a/arch/arm/mach-om

Re: [PATCH] mmc: support sdhci-mmp2

2011-05-31 Thread zhangfei gao
On Tue, May 31, 2011 at 4:47 AM, Philip Rakity wrote: > > On May 30, 2011, at 6:15 AM, zhangfei gao wrote: > >> On Sat, May 28, 2011 at 1:00 AM, Philip Rakity wrote: >>> >>> Hi Zhangfei, >>> >>> >>> comments below. (based on V1 patch but change to V2 affect (3<<1) typo. >>> >>> Philip and Mark. >

Re: [PATCH v3] mmc_spi.c: add support for the regulator framework

2011-05-31 Thread Mark Brown
On Mon, May 30, 2011 at 12:57:57PM +0200, Antonio Ospite wrote: > It is cleaner and more uniform indeed, but it does not solve the problem > I am seeing, the issue is still there when pdata is NULL, we are at the > same point as before (the current code checks for (pdata && > pdata->field)), and w