Re: [PATCH v4 0/4] Extend sdhci-esdhc-imx card_detect and write_protect support for mx5

2011-06-26 Thread Shawn Guo
On Sun, Jun 26, 2011 at 11:47:57PM -0400, Chris Ball wrote: > Hi Shawn, > > On Sun, Jun 26 2011, Shawn Guo wrote: > >> arch/arm/mach-imx/eukrea_mbimxsd25-baseboard.c |3 +- > >> arch/arm/mach-imx/eukrea_mbimxsd35-baseboard.c |3 +- > >> arch/arm/mach-imx/mach-mx25_3ds.c

Re: [PATCH v4 0/4] Extend sdhci-esdhc-imx card_detect and write_protect support for mx5

2011-06-26 Thread Chris Ball
Hi Shawn, On Sun, Jun 26 2011, Shawn Guo wrote: >> arch/arm/mach-imx/eukrea_mbimxsd25-baseboard.c |3 +- >> arch/arm/mach-imx/eukrea_mbimxsd35-baseboard.c |3 +- >> arch/arm/mach-imx/mach-mx25_3ds.c |2 + >> arch/arm/mach-imx/mach-pcm043.c

Re: [PATCH v4 0/4] Extend sdhci-esdhc-imx card_detect and write_protect support for mx5

2011-06-26 Thread Shawn Guo
Hi Chris, On Tue, Jun 21, 2011 at 10:41:47PM +0800, Shawn Guo wrote: > The card-present polling for sdhci based driver is very expensive > in terms of the impact to system performance. We observe a few > system performance issues from Freescale and Linaro on mx5 platforms, > which have been prove

Re: [PATCH] mmc: sdio: reset card during power_restore

2011-06-26 Thread Chris Ball
Hi, On Sat, Jun 25 2011, Daniel Drake wrote: > mmc_sdio_power_restore() skips some steps that are performed in other > power-related codepaths which are necessary to fully reset the card. > Without this, runtime PM fails for SD8686 SDIO wifi on OLPC XO-1.5. > > Signed-off-by: Daniel Drake Thanks

Re: [PATCH] mmc: sdio: fix runtime PM path during driver removal

2011-06-26 Thread Chris Ball
Hi Ohad, On Sun, Jun 26 2011, Ohad Ben-Cohen wrote: > On Fri, Jun 10, 2011 at 2:40 AM, Ohad Ben-Cohen wrote: >> After commit e1866b3 "PM / Runtime: Rework runtime PM handling >> during driver removal" was introduced, the driver core stopped >> incrementing the runtime PM usage counter of the devi

Re: [PATCH] mmc: sdio: reset card during power_restore

2011-06-26 Thread Ohad Ben-Cohen
On Sat, Jun 25, 2011 at 9:20 PM, Daniel Drake wrote: > mmc_sdio_power_restore() skips some steps that are performed in other > power-related codepaths which are necessary to fully reset the card. > Without this, runtime PM fails for SD8686 SDIO wifi on OLPC XO-1.5. > > Signed-off-by: Daniel Drake

Re: [PATCH] mmc: sdio: fix runtime PM path during driver removal

2011-06-26 Thread Ohad Ben-Cohen
Hi Chris, On Fri, Jun 10, 2011 at 2:40 AM, Ohad Ben-Cohen wrote: > After commit e1866b3 "PM / Runtime: Rework runtime PM handling > during driver removal" was introduced, the driver core stopped > incrementing the runtime PM usage counter of the device during > the invocation of the ->remove() ca