Re: mmc_test Correct xfer_size at write

2011-06-29 Thread James Hogan
On 06/28/2011 05:50 PM, Pierre Ossman wrote: On Tue, 28 Jun 2011 11:37:25 +0100 James Hogan james.ho...@imgtec.com wrote: Hi, I'm trying to figure out why the broken write transfer tests in mmc_test require the result to be -ETIMEDOUT, so that I can make dw_mmc pass these tests. Perhaps

[PATCH 1/4] mmc: dw_mmc: fix stop when fallen back to PIO

2011-06-29 Thread James Hogan
There are several situations when dw_mci_submit_data_dma() decides to fall back to PIO mode instead of using DMA, due to a short (to avoid overhead) or complex (e.g. with unaligned buffers) transaction, even though host-use_dma is set. However dw_mci_stop_dma() decides whether to stop DMA or set

[PATCH 2/4] mmc: dw_mmc: remove unnecessary error messages

2011-06-29 Thread James Hogan
Remove error messages for timeout and CRC failure, since the error code already indicates the problem. Signed-off-by: James Hogan james.ho...@imgtec.com --- drivers/mmc/host/dw_mmc.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/dw_mmc.c

[PATCH 3/4] mmc: dw_mmc: handle no CRC status error

2011-06-29 Thread James Hogan
When a data write isn't acknowledged by the card (so no CRC status token is detected after the data), the error -EIO is returned instead of the -ETIMEDOUT expected by mmc_test 15 - Correct xfer_size at write (start failure) and 17 Correct xfer_size at write (midway failure). In PIO mode the

[PATCH 4/4] mmc: dw_mmc: reset FIFO after an error

2011-06-29 Thread James Hogan
If an error occurs mid way through a transaction (such as a missing CRC status response after the 2nd block written out of 3), then the FIFO may still contain data which will interfere with the next transaction. Therefore after an error has been detected, reset the fifo using the CTRL register.

Re: [PATCH] mmc: sdio: reset card during power_restore

2011-06-29 Thread zhangfei gao
So wlan probe function should be called for re-downloading, is it be achieved by calling pm_runtime_get_sync and mmc_power_restore_host? Not really; I assume you refer to libertas_sdio, which AFAICT, is built to power on the device (and configure it) on -probe(), and then power it off on

Re: [PATCH] mmc: sdio: reset card during power_restore

2011-06-29 Thread Daniel Drake
On 28 June 2011 10:13, zhangfei gao zhangfei@gmail.com wrote: Hi, Ohad One question :( Under pm_runtime mechanism, how to dynamically open/close wlan. If the wlan chip really power off, the firmware should be reloaded, since the firmware is download to ram and disappear after power

Re: [PATCH] mmc: sdio: reset card during power_restore

2011-06-29 Thread Ohad Ben-Cohen
On Wed, Jun 29, 2011 at 11:43 AM, zhangfei gao zhangfei@gmail.com wrote: However still not fully understand how to call -remove to power off wlan, using suspend system looks to me is only test method, which counting on bus_ops-suspend returns -ENOSYS. Please take a look at mac80211 and

Re: [PATCH 0/4] mmc: dw_mmc: mmc_test related fixes

2011-06-29 Thread Will Newton
On Wed, Jun 29, 2011 at 9:27 AM, James Hogan james.ho...@imgtec.com wrote: More improvements and fixes for the Synopsys DesignWare MCI driver so that it passes the mmc_test suite: [PATCH 1/4] mmc: dw_mmc: fix stop when fallen back to PIO        Fixes a hang after an error/timeout in PIO mode.

[PATCH 0/2] mmc: sdhci-pci: add 8-bit bus width support for Medfield eMMCs

2011-06-29 Thread Adrian Hunter
Hi Just setting some MMC_CAP_8_BIT_DATA bits. Adrian Hunter (1): mmc: sdhci-pci: allow 8-bit bus width for Intel Medfield eMMCs Major Lee (1): mmc: sdhci-pci: add 8-bit bus width support for mrst hc0 drivers/mmc/host/sdhci-pci.c | 54 ++

[PATCH 1/2] mmc: sdhci-pci: add 8-bit bus width support for mrst hc0

2011-06-29 Thread Adrian Hunter
From: Major Lee major_...@wistron.com And hook platform_8bit_width to support 8-bit bus width. Signed-off-by: Major Lee major_...@wistron.com Signed-off-by: Alan Cox a...@linux.intel.com Signed-off-by: Dirk Brandewie dirk.brande...@gmail.com --- drivers/mmc/host/sdhci-pci.c | 33

[PATCH 2/2] mmc: sdhci-pci: allow 8-bit bus width for Intel Medfield eMMCs

2011-06-29 Thread Adrian Hunter
Unless MMC_CAP_8_BIT_DATA is set, the bus width defaults to 4. Signed-off-by: Adrian Hunter adrian.hun...@intel.com --- drivers/mmc/host/sdhci-pci.c | 21 - 1 files changed, 16 insertions(+), 5 deletions(-) diff --git a/drivers/mmc/host/sdhci-pci.c

Re: [PATCH 2/3] MMC: OMAP: HSMMC: add runtime pm support

2011-06-29 Thread T Krishnamoorthy, Balaji
On Wed, Jun 29, 2011 at 12:11 AM, Paul Walmsley p...@pwsan.com wrote: On Tue, 28 Jun 2011, T Krishnamoorthy, Balaji wrote: On Tue, Jun 28, 2011 at 10:52 PM, Paul Walmsley p...@pwsan.com wrote: On Wed, 22 Jun 2011, Balaji T K wrote: Use runtime autosuspend APIs to enable auto suspend

Re: [PATCH 2/3] MMC: OMAP: HSMMC: add runtime pm support

2011-06-29 Thread Paul Walmsley
On Wed, 29 Jun 2011, T Krishnamoorthy, Balaji wrote: On Wed, Jun 29, 2011 at 12:11 AM, Paul Walmsley p...@pwsan.com wrote: On Tue, 28 Jun 2011, T Krishnamoorthy, Balaji wrote: On Tue, Jun 28, 2011 at 10:52 PM, Paul Walmsley p...@pwsan.com wrote: On Wed, 22 Jun 2011, Balaji T K wrote:

Re: [PATCH] mmc: sdio: reset card during power_restore

2011-06-29 Thread Ohad Ben-Cohen
On Wed, Jun 29, 2011 at 12:19 PM, zhangfei gao zhangfei@gmail.com wrote: Enable wlan: # ifconfig up mlan0 - power up the chip via runtime PM - wlan_probe download the firmware Disable wlan: # ifconfig down mlan0 - power down the chip via runtime PM - wlan_remove ? Sounds all good, besides

Re: [PATCH 2/3] MMC: OMAP: HSMMC: add runtime pm support

2011-06-29 Thread Paul Walmsley
On Wed, 29 Jun 2011, T Krishnamoorthy, Balaji wrote: There have been some experiments on our customer programs to reduce this value to a few ms and infrequent crashes were observed (stress testing for several hours) while trying to access the controller registers. By the way, could you send

[PATCH 1/2] MMC: PM: add suspend/resume in atmel-mci

2011-06-29 Thread Nicolas Ferre
Take care of slots while going to suspend state. Signed-off-by: Nicolas Ferre nicolas.fe...@atmel.com Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de --- drivers/mmc/host/atmel-mci.c | 51 ++ 1 files changed, 51 insertions(+), 0

Re: [PATCH 1/2] MMC: PM: add suspend/resume in atmel-mci

2011-06-29 Thread Felipe Balbi
Hi, On Wed, Jun 29, 2011 at 06:54:19PM +0200, Nicolas Ferre wrote: Take care of slots while going to suspend state. Signed-off-by: Nicolas Ferre nicolas.fe...@atmel.com Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de --- drivers/mmc/host/atmel-mci.c | 51

Re: [PATCH 2/3] MMC: OMAP: HSMMC: add runtime pm support

2011-06-29 Thread T Krishnamoorthy, Balaji
On Wed, Jun 29, 2011 at 8:12 PM, Paul Walmsley p...@pwsan.com wrote: On Wed, 29 Jun 2011, T Krishnamoorthy, Balaji wrote: On Wed, Jun 29, 2011 at 12:11 AM, Paul Walmsley p...@pwsan.com wrote: On Tue, 28 Jun 2011, T Krishnamoorthy, Balaji wrote: On Tue, Jun 28, 2011 at 10:52 PM, Paul

Re: [PATCH 2/3] MMC: OMAP: HSMMC: add runtime pm support

2011-06-29 Thread S, Venkatraman
On Wed, Jun 29, 2011 at 9:08 PM, Paul Walmsley p...@pwsan.com wrote: On Wed, 29 Jun 2011, T Krishnamoorthy, Balaji wrote: There have been some experiments on our customer programs to reduce this value to a few ms and infrequent crashes were observed (stress testing for several hours) while

Re: [PATCH 2/3] MMC: OMAP: HSMMC: add runtime pm support

2011-06-29 Thread Kevin Hilman
T Krishnamoorthy, Balaji balaj...@ti.com writes: On Wed, Jun 29, 2011 at 2:00 AM, Kevin Hilman khil...@ti.com wrote: T Krishnamoorthy, Balaji balaj...@ti.com writes: On Tue, Jun 28, 2011 at 10:52 PM, Paul Walmsley p...@pwsan.com wrote: (cc'ing Adrian also) Hi Balaji On Wed, 22 Jun 2011,

Re: [PATCHv2 2/3] MMC: OMAP: HSMMC: add runtime pm support

2011-06-29 Thread Kevin Hilman
T Krishnamoorthy, Balaji balaj...@ti.com writes: On Wed, Jun 29, 2011 at 5:02 AM, Kevin Hilman khil...@ti.com wrote: +Rajendra Balaji T K balaj...@ti.com writes: add runtime pm support to HSMMC host controller Use runtime pm API to enable/disable HSMMC clock Use runtime autosuspend APIs

Re: [PATCH 2/3] MMC: OMAP: HSMMC: add runtime pm support

2011-06-29 Thread Paul Walmsley
+ Venkat Hi Balaji, Venkat, On Wed, 29 Jun 2011, T Krishnamoorthy, Balaji wrote: OOPS pointed to omap_hsmmc_prepare_data / set_data_timeout Use case was MMC + SDIO +GPS activity, on kernel 2.6.35 though. Unhandled fault: imprecise external abort (0x1406) at 0x4073102c

Re: [PATCH 2/3] MMC: OMAP: HSMMC: add runtime pm support

2011-06-29 Thread Paul Walmsley
cc'ing lakml Hi Venkat, Balaji, On Wed, 29 Jun 2011, S, Venkatraman wrote: On Wed, Jun 29, 2011 at 9:08 PM, Paul Walmsley p...@pwsan.com wrote: On Wed, 29 Jun 2011, T Krishnamoorthy, Balaji wrote: There have been some experiments on our customer programs to reduce this value to a few

Re: [PATCH 1/2] MMC: PM: add suspend/resume in atmel-mci

2011-06-29 Thread Rafael J. Wysocki
On Wednesday, June 29, 2011, Felipe Balbi wrote: Hi, On Wed, Jun 29, 2011 at 06:54:19PM +0200, Nicolas Ferre wrote: Take care of slots while going to suspend state. Signed-off-by: Nicolas Ferre nicolas.fe...@atmel.com Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de

Re: [RFC] How working MMC_BUS_WIDTH_TEST??

2011-06-29 Thread Jaehoon Chung
Hi Philip.. If i didn't set MMC_CAP_BUS_WIDTH_TEST, entered mmc_compare_ext_csds(). right? i understand that mmc_compare_ext_csds() compared with previously ext_csd. But in source code, always previously ext_csd is NULL. I didn't find where assigned ext_csd.. I think that need to assign

[PATCH] mmc: dw_mmc: Supply clocks for both host and card.

2011-06-29 Thread Seungwon Jeon
Add enabling clocks for both host controller and card. Signed-off-by: Seungwon Jeon tgih@samsung.com --- drivers/mmc/host/dw_mmc.c | 33 - include/linux/mmc/dw_mmc.h |7 +++ 2 files changed, 39 insertions(+), 1 deletions(-) diff --git

Re: [PATCHv2 2/3] MMC: OMAP: HSMMC: add runtime pm support

2011-06-29 Thread T Krishnamoorthy, Balaji
On Wed, Jun 29, 2011 at 11:26 PM, Kevin Hilman khil...@ti.com wrote: T Krishnamoorthy, Balaji balaj...@ti.com writes: On Wed, Jun 29, 2011 at 5:02 AM, Kevin Hilman khil...@ti.com wrote: +Rajendra Balaji T K balaj...@ti.com writes: add runtime pm support to HSMMC host controller Use

[PATCH] mmc: tmio: fix build error if CONFIG_MMC_SDHI is not configured

2011-06-29 Thread Axel Lin
Fix below build error: CC drivers/mmc/host/tmio_mmc_dma.o drivers/mmc/host/tmio_mmc_dma.c:192: error: redefinition of 'tmio_mmc_start_dma' drivers/mmc/host/tmio_mmc.h:111: error: previous definition of 'tmio_mmc_start_dma' was here drivers/mmc/host/tmio_mmc_dma.c:257: error: redefinition

Re: [PATCH 2/3] MMC: OMAP: HSMMC: add runtime pm support

2011-06-29 Thread S, Venkatraman
On Thu, Jun 30, 2011 at 1:37 AM, Paul Walmsley p...@pwsan.com wrote: cc'ing lakml Hi Venkat, Balaji, On Wed, 29 Jun 2011, S, Venkatraman wrote: On Wed, Jun 29, 2011 at 9:08 PM, Paul Walmsley p...@pwsan.com wrote: On Wed, 29 Jun 2011, T Krishnamoorthy, Balaji wrote: There have been

Re: [PATCH 2/3] MMC: OMAP: HSMMC: add runtime pm support

2011-06-29 Thread S, Venkatraman
On Thu, Jun 30, 2011 at 6:10 AM, Paul Walmsley p...@pwsan.com wrote: + Venkat Hi Balaji On Wed, 29 Jun 2011, T Krishnamoorthy, Balaji wrote: On Wed, Jun 29, 2011 at 2:00 AM, Kevin Hilman khil...@ti.com wrote: T Krishnamoorthy, Balaji balaj...@ti.com writes: I have seen some

Re: [PATCH 0/4] mmc: dw_mmc: mmc_test related fixes

2011-06-29 Thread Jaehoon Chung
Tested-by: Jaehoon Chung jh80.ch...@samsung.com Will Newton wrote: On Wed, Jun 29, 2011 at 9:27 AM, James Hogan james.ho...@imgtec.com wrote: More improvements and fixes for the Synopsys DesignWare MCI driver so that it passes the mmc_test suite: [PATCH 1/4] mmc: dw_mmc: fix stop when fallen