[PATCH v5] mmc: documentation of mmc non-blocking request usage and design.

2011-07-06 Thread Per Forlin
Documentation about the background and the design of mmc non-blocking. Host driver guidelines to minimize request preparation overhead. Signed-off-by: Per Forlin per.for...@linaro.org Acked-by: Randy Dunlap rdun...@xenotime.net --- ChangeLog: v2: - Minor updates after proofreading comments from

Re: [PATCH v3] arm: mach-mmp: brownstone.c support multiple sd slots

2011-07-06 Thread zhangfei gao
On Wed, Jul 6, 2011 at 4:20 AM, Philip Rakity prak...@marvell.com wrote: Subject: [PATCH V3] arm: mach-mmp: brownstone.c support multiple sd slots V3 == Change since V2 -- delete mmc3 since it was committed to linux next. enable mmc1 used for wifi (8688) and marked PERMANENT. Wifi

[PATCH V4] MMC: PM: add suspend/resume in atmel-mci

2011-07-06 Thread Nicolas Ferre
Take care of slots while going to suspend state. Signed-off-by: Nicolas Ferre nicolas.fe...@atmel.com --- V4: make CONFIG_PM logic work even if not selected V3: take care of each slot SUSPENDED state (adding a status bit in the slot flags) V2: move to pm_ops drivers/mmc/host/atmel-mci.c |

Re: [PATCH V4] MMC: PM: add suspend/resume in atmel-mci

2011-07-06 Thread Felipe Balbi
Hi, On Wed, Jul 06, 2011 at 11:31:36AM +0200, Nicolas Ferre wrote: Take care of slots while going to suspend state. Signed-off-by: Nicolas Ferre nicolas.fe...@atmel.com FWIW: Reviewed-by: Felipe Balbi ba...@ti.com @@ -1878,10 +1879,72 @@ static int __exit atmci_remove(struct

[PATCH] ARM i.MX dma: Fix burstsize settings

2011-07-06 Thread Sascha Hauer
dmaengine expects the maxburst parameter in words, not bytes. The imxdma driver and its users do this wrong. Fix this. As a side note the imx-pcm-dma-mx2 driver was 'fixed' to work with imx-dma. This broke the driver with imx-sdma support which correctly takes the maxburst parameter in words.

Re: [PATCH] mxs-mmc: fix clock rate setting

2011-07-06 Thread Wolfram Sang
About the patch itself: I didn't verify the formulas, but it does solve one special problem here. Thanks a lot! So: Does it solve any other special problem except for the wrong clock rate setting? Nope, but that it does :) -- Pengutronix e.K. | Wolfram Sang

[PATCH v2 0/4] mmc: dw_mmc: mmc_test related fixes

2011-07-06 Thread James Hogan
No changes since v1 except acked-by and tested-by More improvements and fixes for the Synopsys DesignWare MCI driver so that it passes the mmc_test suite: [PATCH 1/4] mmc: dw_mmc: fix stop when fallen back to PIO Fixes a hang after an error/timeout in PIO mode. [PATCH 2/4] mmc: dw_mmc:

[PATCH v2 1/4] mmc: dw_mmc: fix stop when fallen back to PIO

2011-07-06 Thread James Hogan
There are several situations when dw_mci_submit_data_dma() decides to fall back to PIO mode instead of using DMA, due to a short (to avoid overhead) or complex (e.g. with unaligned buffers) transaction, even though host-use_dma is set. However dw_mci_stop_dma() decides whether to stop DMA or set

[PATCH 2/4] mmc: dw_mmc: remove unnecessary error messages

2011-07-06 Thread James Hogan
Remove error messages for timeout and CRC failure, since the error code already indicates the problem. Signed-off-by: James Hogan james.ho...@imgtec.com Acked-by: Will Newton will.new...@imgtec.com Tested-by: Jaehoon Chung jh80.ch...@samsung.com --- drivers/mmc/host/dw_mmc.c |4 1 files

Re: [PATCH] mxs-mmc: fix clock rate setting

2011-07-06 Thread Wolfram Sang
On Mon, Jul 04, 2011 at 12:59:29PM +0200, Koen Beel wrote: On Mon, Jul 4, 2011 at 12:34 PM, Wolfram Sang w.s...@pengutronix.de wrote: Well, maybe not. My colleague complained and I think he is right that we are mapping div2 from the range 0 to 256 (inclusive!) to an 8-bit range.

[PATCH v2 3/4] mmc: dw_mmc: handle no CRC status error

2011-07-06 Thread James Hogan
When a data write isn't acknowledged by the card (so no CRC status token is detected after the data), the error -EIO is returned instead of the -ETIMEDOUT expected by mmc_test 15 - Correct xfer_size at write (start failure) and 17 Correct xfer_size at write (midway failure). In PIO mode the

[PATCH v2 4/4] mmc: dw_mmc: reset FIFO after an error

2011-07-06 Thread James Hogan
If an error occurs mid way through a transaction (such as a missing CRC status response after the 2nd block written out of 3), then the FIFO may still contain data which will interfere with the next transaction. Therefore after an error has been detected, reset the fifo using the CTRL register.

Re: [PATCH] mxs-mmc: fix clock rate setting

2011-07-06 Thread Koen Beel
On Wed, Jul 6, 2011 at 11:38 AM, Wolfram Sang w.s...@pengutronix.de wrote: On Mon, Jul 04, 2011 at 12:59:29PM +0200, Koen Beel wrote: On Mon, Jul 4, 2011 at 12:34 PM, Wolfram Sang w.s...@pengutronix.de wrote: Well, maybe not. My colleague complained and I think he is right that we

Re: [PATCH] mxs-mmc: fix clock rate setting

2011-07-06 Thread Wolfram Sang
I think I misunderstood this suggestion previously. Using DIV_ROUND_UP would do the rounding in the correct direction. This should result in: the actual clock is as high as possible without being higher then the requested clock. Yes, that should be done in V2. And if you could also put the

Lavagna luminosa a LED con telecomando e lampada per ombrelloni

2011-07-06 Thread Led Technology Srl
Led Technology srl vi presenta questo fantastico prodotto per presentare il vostro Menù in un modo più tecnologico, oppure la lampada a led per illuminare i vostri tavoli sotto gli ombrelloni. Vedi la brochure della lavagna cliccando su questo link:

Re: [PATCH] mmc: enable background operations for emmc4.41 with HPI support

2011-07-06 Thread Sebastian RASMUSSEN
Hi! HPI is a feature to handle a higher or urgent request then pre-ongoing request and it's only possible when some conditions are met. Agreed, as I read the spec this would writes, erases and BKOPS (eMMC spec 4.41 7.6.20 (table 20) and the 3rd paragraph in 7.6.19). BKOPS is a feature to

Re: [PATCH] ARM i.MX dma: Fix burstsize settings

2011-07-06 Thread Mark Brown
On Wed, Jul 06, 2011 at 11:18:33AM +0200, Sascha Hauer wrote: dmaengine expects the maxburst parameter in words, not bytes. The imxdma driver and its users do this wrong. Fix this. As a side note the imx-pcm-dma-mx2 driver was 'fixed' to work with imx-dma. This broke the driver with imx-sdma

Re: [PATCH] mmc: enable background operations for emmc4.41 with HPI support

2011-07-06 Thread Kyungmin Park
On Wed, Jul 6, 2011 at 11:40 PM, Sebastian RASMUSSEN sebastian.rasmus...@stericsson.com wrote: Hi! HPI is a feature to handle a higher or urgent request then pre-ongoing request and it's only possible when some conditions are met. Agreed, as I read the spec this would writes, erases and

Re: [PATCH v3] arm: mach-mmp: brownstone.c support multiple sd slots

2011-07-06 Thread Philip Rakity
On Jul 6, 2011, at 12:19 AM, zhangfei gao wrote: On Wed, Jul 6, 2011 at 4:20 AM, Philip Rakity prak...@marvell.com wrote: Subject: [PATCH V3] arm: mach-mmp: brownstone.c support multiple sd slots V3 == Change since V2 -- delete mmc3 since it was committed to linux next. enable mmc1

Re: [PATCH v2 3/3] mmc: sdhci-esdhc-imx: add device tree probe support

2011-07-06 Thread Shawn Guo
On Tue, Jul 05, 2011 at 11:54:34AM -0600, Grant Likely wrote: On Tue, Jul 5, 2011 at 9:26 AM, Shawn Guo shawn@linaro.org wrote: The patch adds device tree probe support for sdhci-esdhc-imx driver. Signed-off-by: Shawn Guo shawn@linaro.org Cc: Wolfram Sang w.s...@pengutronix.de

Re: [PATCH v2 3/3] mmc: sdhci-esdhc-imx: add device tree probe support

2011-07-06 Thread Grant Likely
On Wed, Jul 06, 2011 at 11:43:15PM +0800, Shawn Guo wrote: On Tue, Jul 05, 2011 at 11:54:34AM -0600, Grant Likely wrote: On Tue, Jul 5, 2011 at 9:26 AM, Shawn Guo shawn@linaro.org wrote: The patch adds device tree probe support for sdhci-esdhc-imx driver. Signed-off-by: Shawn Guo

[PATCH V2] mmc: sd.c Set Non Default Drive Strength via platform

2011-07-06 Thread Philip Rakity
V2 -- Include host.h change for callback to select_drive_strength V1 -- Non default Drive Strength cannot be set automatically. It is a function of the board design and only if there is a specific platform handler can it be set. The platform handler needs to take into account the board design.

Re: -ENOSYS suspend-powerdown regression

2011-07-06 Thread Daniel Drake
the simplistic test of booting, and then suspending (without loading the libertas driver), things go wrong: http://dev.laptop.org/~dsd/20110706/dmesg.txt I added printk's in mmc_power_save_host and mmc_power_restore_host. The strange thing is that it tries to resume mmc1 even though it is powered

[PATCH v4] arm: mach-mmp: brownstone.c support multiple sd slots

2011-07-06 Thread Philip Rakity
Eric, Not sure what to suggest. If it makes more sense to take V3 which powers on the wifi card but does not do power handling per new spec take that. At least wifi card works and then wait for power code. New code could delete power code as part of the mod. If it makes more sense to wait

Re: [PATCH v4] arm: mach-mmp: brownstone.c support multiple sd slots

2011-07-06 Thread Eric Miao
On Thu, Jul 7, 2011 at 12:08 AM, Philip Rakity prak...@marvell.com wrote: Eric, Not sure what to suggest. If it makes more sense to take V3 which powers on the wifi card but does not do power handling per new spec take that.  At least wifi card works and then wait for power code.   New

RE: [PATCH] mmc: enable background operations for emmc4.41 with HPI support

2011-07-06 Thread Sebastian RASMUSSEN
Hi! 1. I wonder BKOPS is really required to perform frequently? Yes I know it's helpful to use but no need to call it frequently. I believe that the patch properly checks for R1_URGENT_BKOPS, which seems correct..? Right, it checks the R1_URGENT_BKOPS, I mean it called every user

[PATCH v3 1/4] mmc: sdhci-esdhc-imx: do not reference platform data after probe

2011-07-06 Thread Shawn Guo
The patch copies platform data into pltfm_imx_data and reference the data there than platform data after probe. This work is inspired by Grant Likely and Troy Kisky. Signed-off-by: Shawn Guo shawn@linaro.org Cc: Troy Kisky troy.ki...@boundarydevices.com Cc: Grant Likely

[PATCH v3 2/4] mmc: sdhci-esdhc-imx: get rid of the uses of cpu_is_mx()

2011-07-06 Thread Shawn Guo
The patch removes all the uses of cpu_is_mx(). Instead, it utilizes platform_device_id to distinguish the esdhc differences among SoCs. Signed-off-by: Shawn Guo shawn@linaro.org Cc: Wolfram Sang w.s...@pengutronix.de Cc: Chris Ball c...@laptop.org Acked-by: Grant Likely

[PATCH v3 3/4] mmc: sdhci-pltfm: dt device does not pass parent to sdhci_alloc_host

2011-07-06 Thread Shawn Guo
Neither platform based nor dt based device needs to pass the parent to sdhci_alloc_host. There is no difference between platform and dt on this point. The patch makes the change to pass device itself than its parent to sdhci_alloc_host for dt case too. Otherwise the probe function of sdhci

[PATCH v3 0/4] Add device tree probe for sdhci-esdhc-imx

2011-07-06 Thread Shawn Guo
The first patch copies platform data into driver private data, and do not reference platform data after probe. The second one removes the uses of cpu_is_mx(). The third one makes a dt related fix on sdhci-pltfm.c, and the last one adds actual device tree probe for sdhci-esdhc-imx driver.

[PATCH v3 4/4] mmc: sdhci-esdhc-imx: add device tree probe support

2011-07-06 Thread Shawn Guo
The patch adds device tree probe support for sdhci-esdhc-imx driver. Signed-off-by: Shawn Guo shawn@linaro.org Cc: Wolfram Sang w.s...@pengutronix.de Cc: Chris Ball c...@laptop.org Cc: Grant Likely grant.lik...@secretlab.ca --- .../devicetree/bindings/mmc/fsl-imx-esdhc.txt | 34

RE: [PATCH V2] mmc: sd.c Set Non Default Drive Strength via platform

2011-07-06 Thread Nath, Arindam
Hi Philip, -Original Message- From: Philip Rakity [mailto:prak...@marvell.com] Sent: Wednesday, July 06, 2011 9:22 PM To: linux-mmc@vger.kernel.org Cc: Nath, Arindam Subject: [PATCH V2] mmc: sd.c Set Non Default Drive Strength via platform V2 -- Include host.h change for

Re: [PATCH] mmc: enable background operations for emmc4.41 with HPI support

2011-07-06 Thread S, Venkatraman
On Tue, Jul 5, 2011 at 5:57 PM, Hanumath Prasad hanumath.pra...@stericsson.com wrote: Background operations is an optional feature defined in eMMC4.41 spec. The need for BKOPS will be checked after servicing each user request in R1 response. If need for BKOPS flag is set, then start BKOPS when

Re: [PATCH 1/4] mmci: use StartBitErr to detect bad connections

2011-07-06 Thread Russell King - ARM Linux
On Tue, Jul 05, 2011 at 12:16:11PM +0100, Russell King - ARM Linux wrote: On Tue, Jun 28, 2011 at 09:57:25AM +0200, Linus Walleij wrote: Stresstesting insert/remove of SD-cards can trigger a StartBitErr. This made the driver to hang in forever waiting for a non ocurring data timeout.

Re: [PATCH v3 1/4] mmc: sdhci-esdhc-imx: do not reference platform data after probe

2011-07-06 Thread Grant Likely
On Thu, Jul 07, 2011 at 12:47:47AM +0800, Shawn Guo wrote: The patch copies platform data into pltfm_imx_data and reference the data there than platform data after probe. This work is inspired by Grant Likely and Troy Kisky. Signed-off-by: Shawn Guo shawn@linaro.org Cc: Troy Kisky

Re: [PATCH v3 4/4] mmc: sdhci-esdhc-imx: add device tree probe support

2011-07-06 Thread Grant Likely
On Thu, Jul 07, 2011 at 12:47:50AM +0800, Shawn Guo wrote: The patch adds device tree probe support for sdhci-esdhc-imx driver. Signed-off-by: Shawn Guo shawn@linaro.org Cc: Wolfram Sang w.s...@pengutronix.de Cc: Chris Ball c...@laptop.org Cc: Grant Likely grant.lik...@secretlab.ca

Re: [PATCH] ARM i.MX dma: Fix burstsize settings

2011-07-06 Thread Vinod Koul
On Wed, 2011-07-06 at 08:03 -0700, Mark Brown wrote: On Wed, Jul 06, 2011 at 11:18:33AM +0200, Sascha Hauer wrote: dmaengine expects the maxburst parameter in words, not bytes. The imxdma driver and its users do this wrong. Fix this. As a side note the imx-pcm-dma-mx2 driver was 'fixed'