Re: [PATCH] mmc: sdhci-esdhc-imx: add missing inclusion of linux/module.h

2011-08-14 Thread Stephen Rothwell
Hi Shawn, On Mon, 15 Aug 2011 14:05:49 +0800 Shawn Guo wrote: > > My .config is attached. It's used to build i.mx53 image. Thanks. > Before you start building it, you need to cherry-pick the following > commit from Linus' tree to fix another error. > > commit d9c927833a42b4eaae4addd031f780f45

Re: [PATCH] mmc: sdhci-esdhc-imx: add missing inclusion of linux/module.h

2011-08-14 Thread Chris Ball
Hi Stephen, On Mon, Aug 15 2011, Stephen Rothwell wrote: > It could well be an interaction with the module.h split up, in which case > it will only appear in linux-next. That said, I don;t get that error in > my manual builds, so the config (or at least ARCH) could be useful. Ah, yes, I was bui

[PATCH 4/4] mmc: sdhi: Make use of per-source irq handlers

2011-08-14 Thread Simon Horman
Make use of per-source irq handles if the platform (data) has multiple irq sources. Cc: Guennadi Liakhovetski Cc: Magnus Damm Signed-off-by: Simon Horman --- drivers/mmc/host/sh_mobile_sdhi.c | 24 drivers/mmc/host/tmio_mmc_pio.c |2 +- 2 files changed, 21 inse

[PATCH 1/4] mmc: tmio, sdhi: Split tmio_mmc_irq() based on registers

2011-08-14 Thread Simon Horman
This splits tmio_mmc_irq() in two based on the registers used to handle the interrupts. This involves two key changes to the logic: 1. Do not assume that only one interrupt has occurred. In particular because tmio_mmc_irq() handles interrupts from three sources. Also, because this allows

[PATCH 3/4] mmc: tmio, sdhi: Provide separate interrupt hadnlers

2011-08-14 Thread Simon Horman
Provide separate interrupt handlers which may be used by platforms where SDHI has three interrupt sources. Cc: Guennadi Liakhovetski Cc: Magnus Damm Signed-off-by: Simon Horman --- drivers/mmc/host/tmio_mmc.h |3 +++ drivers/mmc/host/tmio_mmc_pio.c | 35 ++

[PATCH 2/4] mmc: tmio, sdhi: Split card interrupts based on source

2011-08-14 Thread Simon Horman
SDHI hardware allows for two different card interrupt sources; one for access and one for detect. As preparation for wiring the sources up to separate interrupt handlers this patch splits the card interrupt handler in two. Cc: Guennadi Liakhovetski Cc: Magnus Damm Signed-off-by: Simon Horman -

[RFC 0/4] mmc: tmio, sdhi: provide multiple irq handlers

2011-08-14 Thread Simon Horman
The SDHI driver already supports making use of up to three interrupt sources. This series breaks up the existing interrupt handler into three handlers, one for card access, one for card detect interrupts, and one for SDIO interrupts. A cover-all handler, which makes use of these new broken-out ha

Re: [PATCH] mmc: sdhci-esdhc-imx: add missing inclusion of linux/module.h

2011-08-14 Thread Shawn Guo
On 15 August 2011 13:35, Shawn Guo wrote: > Hi Chris, > > On 15 August 2011 11:54, Chris Ball wrote: >> Hi Shawn, >> >> On Sun, Aug 14 2011, Shawn Guo wrote: >>> There are following warning and error when compiling the driver. >>> The patch adds the missing inclusion of linux/module.h to fix them

Re: [PATCH] mmc: sdhci-esdhc-imx: add missing inclusion of linux/module.h

2011-08-14 Thread Stephen Rothwell
Hi, On Mon, 15 Aug 2011 13:35:58 +0800 Shawn Guo wrote: > > On 15 August 2011 11:54, Chris Ball wrote: > > > > On Sun, Aug 14 2011, Shawn Guo wrote: > >> There are following warning and error when compiling the driver. > >> The patch adds the missing inclusion of linux/module.h to fix them. > >>

Re: [PATCH] mmc: sdhci-esdhc-imx: add missing inclusion of linux/module.h

2011-08-14 Thread Shawn Guo
Hi Chris, On 15 August 2011 11:54, Chris Ball wrote: > Hi Shawn, > > On Sun, Aug 14 2011, Shawn Guo wrote: >> There are following warning and error when compiling the driver. >> The patch adds the missing inclusion of linux/module.h to fix them. >> >> drivers/mmc/host/sdhci-esdhc-imx.c:87:1: warn

RE: [PATCH 2/2 v2] eSDHC: Fix errors when booting kernel with fsl esdhc

2011-08-14 Thread Zang Roy-R61911
> -Original Message- > From: Anton Vorontsov [mailto:cbouatmai...@gmail.com] > Sent: Friday, August 12, 2011 18:05 PM > To: Zang Roy-R61911 > Cc: linux-mmc@vger.kernel.org; linuxppc-...@lists.ozlabs.org; akpm@linux- > foundation.org; Xu Lei-B33228; Kumar Gala; Wood Scott-B07421 > Subject:

Re: [PATCH] mmc: sdhci-esdhc-imx: add missing inclusion of linux/module.h

2011-08-14 Thread Chris Ball
Hi Shawn, On Sun, Aug 14 2011, Shawn Guo wrote: > There are following warning and error when compiling the driver. > The patch adds the missing inclusion of linux/module.h to fix them. > > drivers/mmc/host/sdhci-esdhc-imx.c:87:1: warning: data definition has > no type or storage class Pushed to m

[PATCH] mmc: sdhci-esdhc-imx: add missing inclusion of linux/module.h

2011-08-14 Thread Shawn Guo
There are following warning and error when compiling the driver. The patch adds the missing inclusion of linux/module.h to fix them. drivers/mmc/host/sdhci-esdhc-imx.c:87:1: warning: data definition has no type or storage class drivers/mmc/host/sdhci-esdhc-imx.c:87:1: warning: type defaults to ‘i

[GIT PULL] MMC fixes for 3.1-rc2

2011-08-14 Thread Chris Ball
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc.git for-linus for a small set of MMC fixes and cleanups. There are currently no merge conflicts, and the patches have been tested in linux-next. Thanks. The following changes since commit 322a8b034003c0d46d39